Skip to contentSkip to conversation

ARM: dts: omap5.dtsi: add DSS RFBI node

PATCH New Tomi Valkeinen 3 participants 3 messages Sep 4, 2014 – Sep 9, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: omap5.dtsi: add DSS RFBI node

The RFBI node for OMAP DSS was left out when adding the rest of the DSS nodes, because it was not clear how to set up the clocks for the RFBI.

However, it seems that if there is a HWMOD for a device, we also need a DT node for it. Otherwise, at boot, we get:

WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2542 _init+0x464/0x4e0()

omap_hwmod: dss_rfbi: doesn't have mpu register target base

Now that v3.17-rc3 contains a fix (8fd46439e1f5a7f86d76a08733459b74debd9468) for the L3 ICLK required by the RFBI, let's add the RFBI node to get rid of the warning.

---
 arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/omap5.dtsi +9 -0
index fc8df1739f39..1e6ff61a7f12 100644
@@ -945,6 +945,15 @@
 				clock-names = "fck";
 			};
 
+			rfbi: encoder at 58002000  {
+				compatible = "ti,omap5-rfbi";
+				reg = <0x58002000 0x100>;
+				status = "disabled";
+				ti,hwmods = "dss_rfbi";
+				clocks = <&dss_dss_clk>, <&l3_iclk_div>;
+				clock-names = "fck", "ick";
+			};
+
 			dsi1: encoder at 58004000 {
 				compatible = "ti,omap5-dsi";
 				reg = <0x58004000 0x200>,
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: omap5.dtsi: add DSS RFBI node

$subject: ARM: dts: OMAP5: Add DSS RFBI node

Quoted 6 lines · Tomi Valkeinen

The RFBI node for OMAP DSS was left out when adding the rest of the DSS nodes, because it was not clear how to set up the clocks for the RFBI.

However, it seems that if there is a HWMOD for a device, we also need a DT node for it. Otherwise, at boot, we get:

Quoted 6 lines
WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2542 _init+0x464/0x4e0()

omap_hwmod: dss_rfbi: doesn't have mpu register target base

Now that v3.17-rc3 contains a fix (8fd46439e1f5a7f86d76a08733459b74debd9468) for the L3 ICLK required by the RFBI, let's add the RFBI node to get rid of the warning.

The usual style is to use the following style:
Commit 8fd46439e1f5 ("ARM: dts: omap54xx-clocks: Fix the l3 and l4 clock rates")

Quoted 17 lines
---
 arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/omap5.dtsi +2 -0
index fc8df1739f39..1e6ff61a7f12 100644
@@ -945,6 +945,15 @@
 				clock-names = "fck";
 			};
 
+			rfbi: encoder at 58002000  {
+				compatible = "ti,omap5-rfbi";

arch/arm/boot/dts/omap5.dtsi line 959

Quoted 10 lines
arch/arm/boot/dts/omap5.dtsi +7 -0
+				reg = <0x58002000 0x100>;
+				status = "disabled";
+				ti,hwmods = "dss_rfbi";
+				clocks = <&dss_dss_clk>, <&l3_iclk_div>;
+				clock-names = "fck", "ick";
+			};
+
 			dsi1: encoder at 58004000 {
 				compatible = "ti,omap5-dsi";
 				reg = <0x58004000 0x200>,

before-omap5-evm: http://paste.ubuntu.org.cn/1477659

after-omap5-evm: http://paste.ubuntu.org.cn/1477658

So, yep, no more warning.

Signature · 2 lines
Regards,
Nishanth Menon
#2 lore raw

PATCH 1/1 ARM: dts: omap5.dtsi: add DSS RFBI node

Quoted 12 lines · Nishanth Menon

$subject: ARM: dts: OMAP5: Add DSS RFBI node

Quoted 9 lines · Tomi Valkeinen

The RFBI node for OMAP DSS was left out when adding the rest of the DSS nodes, because it was not clear how to set up the clocks for the RFBI.

However, it seems that if there is a HWMOD for a device, we also need a DT node for it. Otherwise, at boot, we get:

WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2542 _init+0x464/0x4e0()

omap_hwmod: dss_rfbi: doesn't have mpu register target base

Quoted 6 lines
Quoted 3 lines

Now that v3.17-rc3 contains a fix (8fd46439e1f5a7f86d76a08733459b74debd9468) for the L3 ICLK required by the RFBI, let's add the RFBI node to get rid of the warning.

The usual style is to use the following style:
Commit 8fd46439e1f5 ("ARM: dts: omap54xx-clocks: Fix the l3 and l4 clock rates")

Applying into omap-for-v3.18/dt with the above part of the changelog updated.

Regards,

Tony

Quoted 37 lines
Quoted 16 lines
---
 arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/omap5.dtsi +2 -0
index fc8df1739f39..1e6ff61a7f12 100644
@@ -945,6 +945,15 @@
 				clock-names = "fck";
 			};
 
+			rfbi: encoder at 58002000  {
+				compatible = "ti,omap5-rfbi";

arch/arm/boot/dts/omap5.dtsi line 959

Quoted 10 lines
arch/arm/boot/dts/omap5.dtsi +7 -0
+				reg = <0x58002000 0x100>;
+				status = "disabled";
+				ti,hwmods = "dss_rfbi";
+				clocks = <&dss_dss_clk>, <&l3_iclk_div>;
+				clock-names = "fck", "ick";
+			};
+
 			dsi1: encoder at 58004000 {
 				compatible = "ti,omap5-dsi";
 				reg = <0x58004000 0x200>,

before-omap5-evm: http://paste.ubuntu.org.cn/1477659

after-omap5-evm: http://paste.ubuntu.org.cn/1477658

So, yep, no more warning.

Signature · 2 lines
Regards,
Nishanth Menon