Skip to contentSkip to conversation

peach_pit: Add support for FIMD, DP and parade chip

PATCH Superseded Ajay Kumar 4 participants 16 messages Jul 30, 2014 – Sep 5, 2014

Subsystems (4)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Ajay Kumar

author
#0 lore raw

v4 cover peach_pit: Add support for FIMD, DP and parade chip

Patchset V1:
https://www.mail-archive.com/u-boot at lists.denx.de/msg140596.html

Patchset V2:
https://www.mail-archive.com/u-boot at lists.denx.de/msg141203.html

Patchset V3:
http://lists.denx.de/pipermail/u-boot/2014-July/183096.html

Changes from V1:
[PATCH V2 3/10] : Don't mix cpu_is and proid_is as per Minkyu's suggestion.
Also, incorporate Simon's suggestion of not using else.
[PATCH V2 4/10] : For FIMD SYSMMU DT, use same compatible string as kernel. [TEST_ONLY V2 6/10]: Make this patch TEST_ONLY

Changes from V2:
[PATCH V3 5/9] : Use SPDX tags to define the license for the file: parade.c Removed TEST_ONLY patches.

Changes from V3:
[PATCH V4 1/9] : Fix comment style.
[PATCH V4 3/9] : Use 'else if' clause instead of 'if'.

Ajay Kumar (8):
[PATCH V4 1/9] exynos_fb: Remove usage of static defines
[PATCH V4 2/9] arm: exynos: Add RPLL for Exynos5420
[PATCH V4 3/9] arm: exynos: Add get_lcd_clk and set_lcd_clk callbacks for Exynos5420 [PATCH V4 4/9] video: exynos_fimd: Add framework to disable FIMD sysmmu [PATCH V4 6/9] ARM: exynos: Add missing declaration for gpio_direction_input [PATCH V4 7/9] exynos5420: add callbacks needed for exynos_fb driver [PATCH V4 8/9] ARM: exynos: peach_pit: Add DT nodes for fimd and parade bridge chip [PATCH V4 9/9] CONFIGS: peach-pit: Enable display for peach_pit board

Vadim Bendebury (1):
[PATCH V4 5/9] video: Add driver for Parade PS8625 dP to LVDS bridge

 arch/arm/cpu/armv7/exynos/clock.c              |   83 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |    3 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c |   13 ++
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      |    2 +-
 arch/arm/dts/exynos5420-peach-pit.dts          |   30 ++++
 arch/arm/dts/exynos54xx.dtsi                   |   10 ++
 arch/arm/include/asm/arch-exynos/clk.h         |    1 +
 arch/arm/include/asm/arch-exynos/gpio.h        |    1 +
 arch/arm/include/asm/arch-exynos/system.h      |    4 +
 board/samsung/common/board.c                   |   15 ++
 board/samsung/smdk5420/smdk5420.c              |  129 +++++---------
 doc/device-tree-bindings/video/exynos-fb.txt   |    6 +
 drivers/video/Makefile                         |    1 +
 drivers/video/exynos_fb.c                      |   17 +-
 drivers/video/exynos_fimd.c                    |   43 +++++
 drivers/video/parade.c                         |  220 ++++++++++++++++++++++++
 include/configs/exynos5250-dt.h                |    2 -
 include/configs/peach-pit.h                    |   10 ++
 include/configs/s5pc210_universal.h            |    3 -
 include/configs/trats.h                        |    3 -
 include/configs/trats2.h                       |    3 -
 include/fdtdec.h                               |    2 +
 lib/fdtdec.c                                   |    2 +
 23 files changed, 492 insertions(+), 111 deletions(-)
 create mode 100644 drivers/video/parade.c
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH v4 1/9 exynos_fb: Remove usage of static defines

Previously, we used to statically assign values for vl_col, vl_row and vl_bpix using #defines like LCD_XRES, LCD_YRES and LCD_COLOR16.

Introducing the function exynos_lcd_early_init() would take care of this assignment on the fly by parsing FIMD DT properties, thereby allowing us to remove LCD_XRES and LCD_YRES from the main config file.

---
 arch/arm/include/asm/arch-exynos/system.h |    1 +
 board/samsung/common/board.c              |   15 +++++++++++++++
 drivers/video/exynos_fb.c                 |   17 +++++------------
 include/configs/exynos5250-dt.h           |    2 --
 include/configs/s5pc210_universal.h       |    3 ---
 include/configs/trats.h                   |    3 ---
 include/configs/trats2.h                  |    3 ---
 7 files changed, 21 insertions(+), 23 deletions(-)
arch/arm/include/asm/arch-exynos/system.h +1 -0
index 7e2057c..4968d3d 100644
@@ -39,5 +39,6 @@ struct exynos5_sysreg {
 
 void set_usbhost_mode(unsigned int mode);
 void set_system_display_ctrl(void);
+int exynos_lcd_early_init(const void *blob);
 
 #endif	/* _EXYNOS4_SYSTEM_H */
board/samsung/common/board.c +15 -0
index 9dc7c83..1f6f0a0 100644
@@ -20,6 +20,7 @@
 #include <asm/arch/mmc.h>
 #include <asm/arch/pinmux.h>
 #include <asm/arch/power.h>
+#include <asm/arch/system.h>
 #include <power/pmic.h>
 #include <asm/arch/sromc.h>
 #include <lcd.h>
@@ -148,6 +149,20 @@ int board_early_init_f(void)
 	board_i2c_init(gd->fdt_blob);
 #endif
 
+#if defined(CONFIG_OF_CONTROL) && defined(CONFIG_EXYNOS_FB)
+/*
+ * board_init_f(arch/arm/lib/board.c) calls lcd_setmem() which needs
+ * panel_info.vl_col, panel_info.vl_row and panel_info.vl_bpix, to reserve
+ * FB memory at a very early stage. So, we need to fill panel_info.vl_col,
+ * panel_info.vl_row and panel_info.vl_bpix before lcd_setmem() is called.
+ */
+	err = exynos_lcd_early_init(gd->fdt_blob);
+	if (err) {
+		debug("LCD early init failed\n");
+		return err;
+	}
+#endif
+
 	return exynos_early_init_f();
 }
 #endif
drivers/video/exynos_fb.c +6 -12
index e1e0d80..bc478a9 100644
@@ -27,17 +27,13 @@ DECLARE_GLOBAL_DATA_PTR;
 
 static unsigned int panel_width, panel_height;
 
-/*
- * board_init_f(arch/arm/lib/board.c) calls lcd_setmem() which needs
- * panel_info.vl_col, panel_info.vl_row and panel_info.vl_bpix to reserve
- * FB memory at a very early stage, i.e even before exynos_fimd_parse_dt()
- * is called. So, we are forced to statically assign it.
- */
 #ifdef CONFIG_OF_CONTROL
 vidinfo_t panel_info  = {
-	.vl_col = LCD_XRES,
-	.vl_row = LCD_YRES,
-	.vl_bpix = LCD_COLOR16,
+	/*
+	 * Insert a value here so that we don't end up in the BSS
+	 * Reference: drivers/video/tegra.c
+	 */
+	.vl_col = -1,
 };
 #endif
 
@@ -141,7 +136,7 @@ static void lcd_panel_on(vidinfo_t *vid)
 }
 
 #ifdef CONFIG_OF_CONTROL
-int exynos_fimd_parse_dt(const void *blob)
+int exynos_lcd_early_init(const void *blob)
 {
 	unsigned int node;
 	node = fdtdec_next_compatible(blob, 0, COMPAT_SAMSUNG_EXYNOS_FIMD);
@@ -286,8 +281,6 @@ void lcd_ctrl_init(void *lcdbase)
 	set_lcd_clk();
 
 #ifdef CONFIG_OF_CONTROL
-	if (exynos_fimd_parse_dt(gd->fdt_blob))
-		debug("Can't get proper panel info\n");
 #ifdef CONFIG_EXYNOS_MIPI_DSIM
 	exynos_init_dsim_platform_data(&panel_info);
 #endif
include/configs/exynos5250-dt.h +0 -2
index 74e72a5..c24984b 100644
@@ -61,8 +61,6 @@
 #ifdef CONFIG_LCD
 #define CONFIG_EXYNOS_FB
 #define CONFIG_EXYNOS_DP
-#define LCD_XRES			2560
-#define LCD_YRES			1600
 #define LCD_BPP			LCD_COLOR16
 #endif
 
include/configs/s5pc210_universal.h +0 -3
index eb046cd..20985da 100644
@@ -247,7 +247,4 @@ int universal_spi_read(void);
 #define CONFIG_VIDEO_BMP_GZIP
 #define CONFIG_SYS_VIDEO_LOGO_MAX_SIZE ((500 * 160 * 4) + 54)
 
-#define LCD_XRES	480
-#define LCD_YRES	800
-
 #endif	/* __CONFIG_H */
include/configs/trats.h +0 -3
index 90f1962..35c1feb 100644
@@ -261,7 +261,4 @@
 #define CONFIG_VIDEO_BMP_GZIP
 #define CONFIG_SYS_VIDEO_LOGO_MAX_SIZE  ((500 * 160 * 4) + 54)
 
-#define LCD_XRES	720
-#define LCD_YRES	1280
-
 #endif	/* __CONFIG_H */
include/configs/trats2.h +0 -3
index 206975b..94c8a9f 100644
@@ -241,7 +241,4 @@ int get_soft_i2c_sda_pin(void);
 #define CONFIG_VIDEO_BMP_GZIP
 #define CONFIG_SYS_VIDEO_LOGO_MAX_SIZE ((500 * 160 * 4) + 54)
 
-#define LCD_XRES	720
-#define LCD_YRES	1280
-
 #endif	/* __CONFIG_H */
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH v4 2/9 arm: exynos: Add RPLL for Exynos5420

In reply to Ajay Kumar

RPLL is needed to drive the LCD panel on Exynos5420 based boards.

---
 arch/arm/cpu/armv7/exynos/clock_init.h         |    3 +++
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c |   13 +++++++++++++
 2 files changed, 16 insertions(+)
arch/arm/cpu/armv7/exynos/clock_init.h +3 -0
index a875d0b..fce502f 100644
@@ -75,6 +75,9 @@ struct mem_timings {
 	unsigned spll_mdiv;
 	unsigned spll_pdiv;
 	unsigned spll_sdiv;
+	unsigned rpll_mdiv;
+	unsigned rpll_pdiv;
+	unsigned rpll_sdiv;
 	unsigned pclk_cdrex_ratio;
 	unsigned direct_cmd_msr[MEM_TIMINGS_MSR_COUNT];
 
arch/arm/cpu/armv7/exynos/clock_init_exynos5.c +13 -0
index 1d6977f..b6a9bc1 100644
@@ -179,6 +179,10 @@ struct mem_timings mem_timings[] = {
 		.spll_mdiv = 0xc8,
 		.spll_pdiv = 0x3,
 		.spll_sdiv = 0x2,
+		/* RPLL @70.5Mhz */
+		.rpll_mdiv = 0x5E,
+		.rpll_pdiv = 0x2,
+		.rpll_sdiv = 0x4,
 
 		.direct_cmd_msr = {
 			0x00020018, 0x00030000, 0x00010046, 0x00000d70,
@@ -800,6 +804,7 @@ static void exynos5420_system_clock_init(void)
 	writel(mem->ipll_pdiv * PLL_LOCK_FACTOR, &clk->ipll_lock);
 	writel(mem->spll_pdiv * PLL_LOCK_FACTOR, &clk->spll_lock);
 	writel(mem->kpll_pdiv * PLL_LOCK_FACTOR, &clk->kpll_lock);
+	writel(mem->rpll_pdiv * PLL_X_LOCK_FACTOR, &clk->rpll_lock);
 
 	setbits_le32(&clk->src_cpu, MUX_HPM_SEL_MASK);
 
@@ -898,6 +903,14 @@ static void exynos5420_system_clock_init(void)
 	while ((readl(&clk->spll_con0) & PLL_LOCKED) == 0)
 		;
 
+	/* Set RPLL */
+	writel(RPLL_CON2_VAL, &clk->rpll_con2);
+	writel(RPLL_CON1_VAL, &clk->rpll_con1);
+	val = set_pll(mem->rpll_mdiv, mem->rpll_pdiv, mem->rpll_sdiv);
+	writel(val, &clk->rpll_con0);
+	while ((readl(&clk->rpll_con0) & PLL_LOCKED) == 0)
+		;
+
 	writel(CLK_DIV_CDREX0_VAL, &clk->div_cdrex0);
 	writel(CLK_DIV_CDREX1_VAL, &clk->div_cdrex1);
 
Signature · 1 line
1.7.9.5
author
#3 lore raw

PATCH v4 3/9 arm: exynos: Add get_lcd_clk and set_lcd_clk callbacks for Exynos5420

In reply to Ajay Kumar

Add get_lcd_clk and set_lcd_clk callbacks for Exynos5420 needed by exynos video driver.
Also, configure ACLK_400_DISP1 as the parent for MUX_ACLK_400_DISP1_SUB_SEL.

---
 arch/arm/cpu/armv7/exynos/clock.c         |   83 +++++++++++++++++++++++++++--
 arch/arm/cpu/armv7/exynos/exynos5_setup.h |    2 +-
 arch/arm/include/asm/arch-exynos/clk.h    |    1 +
 3 files changed, 80 insertions(+), 6 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +78 -5
index 400d134..c8be39b 100644
@@ -82,7 +82,8 @@ static int exynos_get_pll_clk(int pllreg, unsigned int r, unsigned int k)
 	 * VPLL_CON: MIDV [24:16]
 	 * BPLL_CON: MIDV [25:16]: Exynos5
 	 */
-	if (pllreg == APLL || pllreg == MPLL || pllreg == BPLL)
+	if (pllreg == APLL || pllreg == MPLL || pllreg == BPLL ||
+	    pllreg == SPLL)
 		mask = 0x3ff;
 	else
 		mask = 0x1ff;
@@ -391,6 +392,9 @@ static unsigned long exynos5420_get_pll_clk(int pllreg)
 		r = readl(&clk->rpll_con0);
 		k = readl(&clk->rpll_con1);
 		break;
+	case SPLL:
+		r = readl(&clk->spll_con0);
+		break;
 	default:
 		printf("Unsupported PLL (%d)\n", pllreg);
 		return 0;
@@ -1027,6 +1031,40 @@ static unsigned long exynos5_get_lcd_clk(void)
 	return pclk;
 }
 
+static unsigned long exynos5420_get_lcd_clk(void)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	unsigned long pclk, sclk;
+	unsigned int sel;
+	unsigned int ratio;
+
+	/*
+	 * CLK_SRC_DISP10
+	 * FIMD1_SEL [4]
+	 * 0: SCLK_RPLL
+	 * 1: SCLK_SPLL
+	 */
+	sel = readl(&clk->src_disp10);
+	sel &= (1 << 4);
+
+	if (sel)
+		sclk = get_pll_clk(SPLL);
+	else
+		sclk = get_pll_clk(RPLL);
+
+	/*
+	 * CLK_DIV_DISP10
+	 * FIMD1_RATIO [3:0]
+	 */
+	ratio = readl(&clk->div_disp10);
+	ratio = ratio & 0xf;
+
+	pclk = sclk / (ratio + 1);
+
+	return pclk;
+}
+
 void exynos4_set_lcd_clk(void)
 {
 	struct exynos4_clock *clk =
@@ -1131,6 +1169,33 @@ void exynos5_set_lcd_clk(void)
 	clrsetbits_le32(&clk->div_disp1_0, 0xf, 0x0);
 }
 
+void exynos5420_set_lcd_clk(void)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	unsigned int cfg;
+
+	/*
+	 * CLK_SRC_DISP10
+	 * FIMD1_SEL [4]
+	 * 0: SCLK_RPLL
+	 * 1: SCLK_SPLL
+	 */
+	cfg = readl(&clk->src_disp10);
+	cfg &= ~(0x1 << 4);
+	cfg |= (0 << 4);
+	writel(cfg, &clk->src_disp10);
+
+	/*
+	 * CLK_DIV_DISP10
+	 * FIMD1_RATIO		[3:0]
+	 */
+	cfg = readl(&clk->div_disp10);
+	cfg &= ~(0xf << 0);
+	cfg |= (0 << 0);
+	writel(cfg, &clk->div_disp10);
+}
+
 void exynos4_set_mipi_clk(void)
 {
 	struct exynos4_clock *clk =
@@ -1602,16 +1667,24 @@ unsigned long get_lcd_clk(void)
 {
 	if (cpu_is_exynos4())
 		return exynos4_get_lcd_clk();
-	else
-		return exynos5_get_lcd_clk();
+	else {
+		if (proid_is_exynos5420())
+			return exynos5420_get_lcd_clk();
+		else
+			return exynos5_get_lcd_clk();
+	}
 }
 
 void set_lcd_clk(void)
 {
 	if (cpu_is_exynos4())
 		exynos4_set_lcd_clk();
-	else
-		exynos5_set_lcd_clk();
+	else {
+		if (proid_is_exynos5250())
+			exynos5_set_lcd_clk();
+		else if (proid_is_exynos5420())
+			exynos5420_set_lcd_clk();
+	}
 }
 
 void set_mipi_clk(void)
arch/arm/cpu/armv7/exynos/exynos5_setup.h +1 -1
index 3242093..2eea48a 100644
@@ -783,7 +783,7 @@
 #define CLK_SRC_TOP2_VAL	0x11101000
 #define CLK_SRC_TOP3_VAL	0x11111111
 #define CLK_SRC_TOP4_VAL	0x11110111
-#define CLK_SRC_TOP5_VAL	0x11111100
+#define CLK_SRC_TOP5_VAL	0x11111101
 #define CLK_SRC_TOP6_VAL	0x11110111
 #define CLK_SRC_TOP7_VAL	0x00022200
 
arch/arm/include/asm/arch-exynos/clk.h +1 -0
index ffbc07e..db24dc0 100644
@@ -15,6 +15,7 @@
 #define VPLL	4
 #define BPLL	5
 #define RPLL	6
+#define SPLL	7
 
 #define MASK_PRE_RATIO(x)	(0xff << ((x << 4) + 8))
 #define MASK_RATIO(x)		(0xf << (x << 4))
Signature · 1 line
1.7.9.5
author
#4 lore raw

PATCH v4 4/9 video: exynos_fimd: Add framework to disable FIMD sysmmu

In reply to Ajay Kumar

On Exynos5420 and newer versions, the FIMD sysmmus are in "on state" by default.
We have to disable them in order to make FIMD DMA work. This patch adds the required framework to exynos_fimd driver, and disables FIMD sysmmu on Exynos5420.

---
 arch/arm/dts/exynos54xx.dtsi                 |   10 ++++++
 doc/device-tree-bindings/video/exynos-fb.txt |    6 ++++
 drivers/video/exynos_fimd.c                  |   43 ++++++++++++++++++++++++++
 include/fdtdec.h                             |    1 +
 lib/fdtdec.c                                 |    1 +
 5 files changed, 61 insertions(+)
arch/arm/dts/exynos54xx.dtsi +10 -0
index b9f8e0b..c21d798 100644
@@ -113,6 +113,16 @@
 		status = "disabled";
 	};
 
+	fimdm0_sysmmu at 0x14640000 {
+		compatible = "samsung,sysmmu-v3.3";
+		reg = <0x14640000 0x100>;
+	};
+
+	fimdm1_sysmmu at 0x14680000 {
+		compatible = "samsung,sysmmu-v3.3";
+		reg = <0x14680000 0x100>;
+	};
+
 	fimd at 14400000 {
 		/* sysmmu is not used in U-Boot */
 		samsung,disable-sysmmu;
doc/device-tree-bindings/video/exynos-fb.txt +6 -0
index bb7441c..dc4e44f 100644
@@ -55,6 +55,12 @@ Board(panel specific):
 	samsung,pclk-name: parent clock identifier: 1(MPLL), 2(EPLL), 3(VPLL)
 	samsung,sclk-div: parent_clock/source_clock ratio
 	samsung,dual-lcd-enabled: 1 if you support two LCD, else 0
+	samsung,disable-sysmmu: Define this if you want to disable FIMD sysmmu.
+				(needed for Exynos5420 and newer versions)
+				Add the required FIMD sysmmu nodes to be
+				disabled with compatible string
+				"samsung,sysmmu-v3.3", with a "reg" property
+				holding the register address of FIMD sysmmu.
 
 Example:
 SOC specific part:
drivers/video/exynos_fimd.c +43 -0

55 lines not on this page · raw message

include/fdtdec.h +1 -0
index a7e6ee7..a583d68 100644
@@ -94,6 +94,7 @@ enum fdt_compat_id {
 	COMPAT_SANDBOX_LCD_SDL,		/* Sandbox LCD emulation with SDL */
 	COMPAT_TI_TPS65090,		/* Texas Instrument TPS65090 */
 	COMPAT_NXP_PTN3460,		/* NXP PTN3460 DP/LVDS bridge */
+	COMPAT_SAMSUNG_EXYNOS_SYSMMU,	/* Exynos sysmmu */
 
 	COMPAT_COUNT,
 };
lib/fdtdec.c +1 -0
index aaa6620..64d2398 100644
@@ -68,6 +68,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
 	COMPAT(SANDBOX_LCD_SDL, "sandbox,lcd-sdl"),
 	COMPAT(TI_TPS65090, "ti,tps65090"),
 	COMPAT(COMPAT_NXP_PTN3460, "nxp,ptn3460"),
+	COMPAT(SAMSUNG_EXYNOS_SYSMMU, "samsung,sysmmu-v3.3"),
 };
 
 const char *fdtdec_get_compatible(enum fdt_compat_id id)
Signature · 1 line
1.7.9.5
author
#5 lore raw

PATCH v4 5/9 video: Add driver for Parade PS8625 dP to LVDS bridge

In reply to Ajay Kumar

From: Vadim Bendebury <[email protected]>

The initialization table comes from the "Illustration of I2C command for initialing PS8625" document supplied by Parade.

---
 drivers/video/Makefile |    1 +
 drivers/video/parade.c |  220 ++++++++++++++++++++++++++++++++++++++++++++++++
 include/fdtdec.h       |    1 +
 lib/fdtdec.c           |    1 +
 4 files changed, 223 insertions(+)
 create mode 100644 drivers/video/parade.c
drivers/video/Makefile +1 -0
index 945f35d..8618590 100644
@@ -41,3 +41,4 @@ obj-$(CONFIG_VIDEO_SMI_LYNXEM) += smiLynxEM.o videomodes.o
 obj-$(CONFIG_VIDEO_TEGRA) += tegra.o
 obj-$(CONFIG_VIDEO_VCXK) += bus_vcxk.o
 obj-$(CONFIG_FORMIKE) += formike.o
+obj-$(CONFIG_VIDEO_PARADE) += parade.o
drivers/video/parade.c new file +220 -0

220 lines not on this page · raw message

include/fdtdec.h +1 -0
index a583d68..d4284bb 100644
@@ -95,6 +95,7 @@ enum fdt_compat_id {
 	COMPAT_TI_TPS65090,		/* Texas Instrument TPS65090 */
 	COMPAT_NXP_PTN3460,		/* NXP PTN3460 DP/LVDS bridge */
 	COMPAT_SAMSUNG_EXYNOS_SYSMMU,	/* Exynos sysmmu */
+	COMPAT_PARADE_PS8625,		/* Parade PS8622 EDP->LVDS bridge */
 
 	COMPAT_COUNT,
 };
lib/fdtdec.c +1 -0
index 64d2398..17d7969 100644
@@ -69,6 +69,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
 	COMPAT(TI_TPS65090, "ti,tps65090"),
 	COMPAT(COMPAT_NXP_PTN3460, "nxp,ptn3460"),
 	COMPAT(SAMSUNG_EXYNOS_SYSMMU, "samsung,sysmmu-v3.3"),
+	COMPAT(PARADE_PS8625, "parade,ps8625"),
 };
 
 const char *fdtdec_get_compatible(enum fdt_compat_id id)
Signature · 1 line
1.7.9.5
author
#6 lore raw

PATCH v4 6/9 ARM: exynos: Add missing declaration for gpio_direction_input

In reply to Ajay Kumar

This patch adds missing declaration for gpio_direction_input function, thereby helps in resolving compilation warnings.

---
 arch/arm/include/asm/arch-exynos/gpio.h |    1 +
 1 file changed, 1 insertion(+)
arch/arm/include/asm/arch-exynos/gpio.h +1 -0
index be5113f..8fb5c23 100644
@@ -1504,6 +1504,7 @@ static const struct gpio_name_num_table exynos5420_gpio_table[] = {
 void gpio_cfg_pin(int gpio, int cfg);
 void gpio_set_pull(int gpio, int mode);
 void gpio_set_drv(int gpio, int mode);
+int gpio_direction_input(unsigned gpio);
 int gpio_direction_output(unsigned gpio, int value);
 int gpio_set_value(unsigned gpio, int value);
 int gpio_get_value(unsigned gpio);
Signature · 1 line
1.7.9.5
author
#7 lore raw

PATCH v4 7/9 exynos5420: add callbacks needed for exynos_fb driver

In reply to Ajay Kumar

Add initialization code for peach_pit panel, parade bridge chip, and backlight.

---
 arch/arm/include/asm/arch-exynos/system.h |    3 +
 board/samsung/smdk5420/smdk5420.c         |  129 +++++++++++------------------
 2 files changed, 50 insertions(+), 82 deletions(-)
arch/arm/include/asm/arch-exynos/system.h +3 -0
index 4968d3d..320763f 100644
@@ -41,4 +41,7 @@ void set_usbhost_mode(unsigned int mode);
 void set_system_display_ctrl(void);
 int exynos_lcd_early_init(const void *blob);
 
+/* Initialize the Parade dP<->LVDS bridge if present */
+int parade_init(const void *blob);
+
 #endif	/* _EXYNOS4_SYSTEM_H */
board/samsung/smdk5420/smdk5420.c +47 -82

153 lines not on this page · raw message

Signature · 1 line
1.7.9.5
author
#8 lore raw

PATCH v4 8/9 ARM: exynos: peach_pit: Add DT nodes for fimd and parade bridge chip

In reply to Ajay Kumar

This patch adds DT properties for fimd and the parade bridge chip present on peach_pit. The panel supports 1366x768 resolution.

---
 arch/arm/dts/exynos5420-peach-pit.dts |   30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm/dts/exynos5420-peach-pit.dts +30 -0
index 8d148af..3ed70a8 100644
@@ -63,6 +63,11 @@
 	              reg = <0x20>;
 	              compatible = "maxim,max98090-codec";
 	       };
+
+	        edp-lvds-bridge at 48 {
+	                compatible = "parade,ps8625";
+	                reg = <0x48>;
+	        };
 	};
 
         sound at 3830000 {
@@ -124,4 +129,29 @@
 	xhci at 12400000 {
 		samsung,vbus-gpio = <&gpio 0x41 0>; /* H01 */
 	};
+
+	fimd at 14400000 {
+		samsung,vl-freq = <60>;
+		samsung,vl-col = <1366>;
+		samsung,vl-row = <768>;
+		samsung,vl-width = <1366>;
+		samsung,vl-height = <768>;
+
+		samsung,vl-clkp;
+		samsung,vl-dp;
+		samsung,vl-bpix = <4>;
+
+		samsung,vl-hspw = <32>;
+		samsung,vl-hbpd = <40>;
+		samsung,vl-hfpd = <40>;
+		samsung,vl-vspw = <6>;
+		samsung,vl-vbpd = <10>;
+		samsung,vl-vfpd = <12>;
+		samsung,vl-cmd-allow-len = <0xf>;
+
+		samsung,winid = <3>;
+		samsung,interface-mode = <1>;
+		samsung,dp-enabled = <1>;
+		samsung,dual-lcd-enabled = <0>;
+	};
 };
Signature · 1 line
1.7.9.5
author
#9 lore raw

PATCH v4 9/9 CONFIGS: peach-pit: Enable display for peach_pit board

In reply to Ajay Kumar

Enable drivers for FIMD, DP and parade bridge chip.

---
 include/configs/peach-pit.h |   10 ++++++++++
 1 file changed, 10 insertions(+)
include/configs/peach-pit.h +10 -0
index 76b8d7a..88c093f 100644
@@ -22,4 +22,14 @@
 #define CONFIG_SYS_PROMPT	"Peach # "
 #define CONFIG_IDENT_STRING	" for Peach"
 
+#define CONFIG_VIDEO_PARADE
+
+/* Display */
+#define CONFIG_LCD
+#ifdef CONFIG_LCD
+#define CONFIG_EXYNOS_FB
+#define CONFIG_EXYNOS_DP
+#define LCD_BPP			LCD_COLOR16
+#endif
+
 #endif	/* __CONFIG_PEACH_PIT_H */
Signature · 1 line
1.7.9.5
#10 lore raw

v4 cover peach_pit: Add support for FIMD, DP and parade chip

In reply to Ajay Kumar

Hi,

Quoted 15 lines · Ajay Kumar

Patchset V1:
https://www.mail-archive.com/u-boot at lists.denx.de/msg140596.html

Patchset V2:
https://www.mail-archive.com/u-boot at lists.denx.de/msg141203.html

Patchset V3:
http://lists.denx.de/pipermail/u-boot/2014-July/183096.html

Changes from V1:
[PATCH V2 3/10] : Don't mix cpu_is and proid_is as per Minkyu's suggestion.
Also, incorporate Simon's suggestion of not using else.
[PATCH V2 4/10] : For FIMD SYSMMU DT, use same compatible string as kernel. [TEST_ONLY V2 6/10]: Make this patch TEST_ONLY

Quoted 7 lines

Changes from V2:
[PATCH V3 5/9] : Use SPDX tags to define the license for the file: parade.c Removed TEST_ONLY patches.

Changes from V3:
[PATCH V4 1/9] : Fix comment style.
[PATCH V4 3/9] : Use 'else if' clause instead of 'if'.

Is this series ready to be merged? I have several series dependent on it.

Regards,
Simon

#11 lore raw

v4 cover peach_pit: Add support for FIMD, DP and parade chip

+Minkyu

Quoted 22 lines · Simon Glass

Hi,

Quoted 19 lines · Ajay Kumar

Patchset V1:
https://www.mail-archive.com/u-boot at lists.denx.de/msg140596.html

Patchset V2:
https://www.mail-archive.com/u-boot at lists.denx.de/msg141203.html

Patchset V3:
http://lists.denx.de/pipermail/u-boot/2014-July/183096.html

Changes from V1:
[PATCH V2 3/10] : Don't mix cpu_is and proid_is as per Minkyu's suggestion.
Also, incorporate Simon's suggestion of not using else.
[PATCH V2 4/10] : For FIMD SYSMMU DT, use same compatible string as kernel. [TEST_ONLY V2 6/10]: Make this patch TEST_ONLY

Changes from V2:
[PATCH V3 5/9] : Use SPDX tags to define the license for the file: parade.c Removed TEST_ONLY patches.

Quoted 5 lines
Quoted 3 lines

Changes from V3:
[PATCH V4 1/9] : Fix comment style.
[PATCH V4 3/9] : Use 'else if' clause instead of 'if'.

Is this series ready to be merged? I have several series dependent on it.

I have addressed all the comments from Minkyu.
Hopefully, it should get in this time!

Ajay

#12 lore raw

v4 cover peach_pit: Add support for FIMD, DP and parade chip

Hi Minkyu,

Quoted 25 lines · Ajay kumar

+Minkyu

Quoted 22 lines · Simon Glass

Hi,

Quoted 19 lines · Ajay Kumar

Patchset V1:
https://www.mail-archive.com/u-boot at lists.denx.de/msg140596.html

Patchset V2:
https://www.mail-archive.com/u-boot at lists.denx.de/msg141203.html

Patchset V3:
http://lists.denx.de/pipermail/u-boot/2014-July/183096.html

Changes from V1:
[PATCH V2 3/10] : Don't mix cpu_is and proid_is as per Minkyu's suggestion.
Also, incorporate Simon's suggestion of not using else.
[PATCH V2 4/10] : For FIMD SYSMMU DT, use same compatible string as kernel. [TEST_ONLY V2 6/10]: Make this patch TEST_ONLY

Changes from V2:
[PATCH V3 5/9] : Use SPDX tags to define the license for the file: parade.c Removed TEST_ONLY patches.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Changes from V3:
[PATCH V4 1/9] : Fix comment style.
[PATCH V4 3/9] : Use 'else if' clause instead of 'if'.

Is this series ready to be merged? I have several series dependent on it.

I have addressed all the comments from Minkyu.
Hopefully, it should get in this time!

Can this series be applied please?

Regards,
Simon

#13 lore raw

v4 cover peach_pit: Add support for FIMD, DP and parade chip

Hi,

Quoted 32 lines · Simon Glass

Hi Minkyu,

Quoted 29 lines · Ajay kumar

+Minkyu

Quoted 26 lines · Simon Glass

Hi,

Quoted 22 lines · Ajay Kumar

Patchset V1:
https://www.mail-archive.com/u-boot at lists.denx.de/msg140596.html

Patchset V2:
https://www.mail-archive.com/u-boot at lists.denx.de/msg141203.html

Patchset V3:
http://lists.denx.de/pipermail/u-boot/2014-July/183096.html

Changes from V1:
[PATCH V2 3/10] : Don't mix cpu_is and proid_is as per Minkyu's suggestion.
Also, incorporate Simon's suggestion of not using else.
[PATCH V2 4/10] : For FIMD SYSMMU DT, use same compatible string as kernel. [TEST_ONLY V2 6/10]: Make this patch TEST_ONLY

Changes from V2:
[PATCH V3 5/9] : Use SPDX tags to define the license for the file: parade.c Removed TEST_ONLY patches.

Changes from V3:
[PATCH V4 1/9] : Fix comment style.
[PATCH V4 3/9] : Use 'else if' clause instead of 'if'.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Is this series ready to be merged? I have several series dependent on it.

I have addressed all the comments from Minkyu.
Hopefully, it should get in this time!

Can this series be applied please?

Will check soon.

Thanks,
Minkyu Kang.

#14 lore raw

v4 cover peach_pit: Add support for FIMD, DP and parade chip

In reply to Ajay kumar
Quoted 29 lines · Ajay kumar

+Minkyu

Quoted 26 lines · Simon Glass

Hi,

Quoted 22 lines · Ajay Kumar

Patchset V1:
https://www.mail-archive.com/u-boot at lists.denx.de/msg140596.html

Patchset V2:
https://www.mail-archive.com/u-boot at lists.denx.de/msg141203.html

Patchset V3:
http://lists.denx.de/pipermail/u-boot/2014-July/183096.html

Changes from V1:
[PATCH V2 3/10] : Don't mix cpu_is and proid_is as per Minkyu's suggestion.
Also, incorporate Simon's suggestion of not using else.
[PATCH V2 4/10] : For FIMD SYSMMU DT, use same compatible string as kernel. [TEST_ONLY V2 6/10]: Make this patch TEST_ONLY

Changes from V2:
[PATCH V3 5/9] : Use SPDX tags to define the license for the file: parade.c Removed TEST_ONLY patches.

Changes from V3:
[PATCH V4 1/9] : Fix comment style.
[PATCH V4 3/9] : Use 'else if' clause instead of 'if'.

Quoted 6 lines
Quoted 1 line

Is this series ready to be merged? I have several series dependent on it.

I have addressed all the comments from Minkyu.
Hopefully, it should get in this time!

Ajay

Could you please rebase & resend this patch?

Thanks,
Minkyu Kang.

#15 lore raw

v4 cover peach_pit: Add support for FIMD, DP and parade chip

Hi Minkyu,

Quoted 30 lines · Minkyu Kang
Quoted 29 lines · Ajay kumar

+Minkyu

Quoted 26 lines · Simon Glass

Hi,

Quoted 22 lines · Ajay Kumar

Patchset V1:
https://www.mail-archive.com/u-boot at lists.denx.de/msg140596.html

Patchset V2:
https://www.mail-archive.com/u-boot at lists.denx.de/msg141203.html

Patchset V3:
http://lists.denx.de/pipermail/u-boot/2014-July/183096.html

Changes from V1:
[PATCH V2 3/10] : Don't mix cpu_is and proid_is as per Minkyu's suggestion.
Also, incorporate Simon's suggestion of not using else.
[PATCH V2 4/10] : For FIMD SYSMMU DT, use same compatible string as kernel. [TEST_ONLY V2 6/10]: Make this patch TEST_ONLY

Changes from V2:
[PATCH V3 5/9] : Use SPDX tags to define the license for the file: parade.c Removed TEST_ONLY patches.

Changes from V3:
[PATCH V4 1/9] : Fix comment style.
[PATCH V4 3/9] : Use 'else if' clause instead of 'if'.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Is this series ready to be merged? I have several series dependent on it.

I have addressed all the comments from Minkyu.
Hopefully, it should get in this time!

Ajay

Could you please rebase & resend this patch?

I have sent
"[PATCH V5 0/9] peach_pit: Add support for FIMD, DP and parade chip" after rebasing and testing.

Thanks,
Ajay