drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

PATCH In review Chen Gang 5 participants 7 messages Sep 3, 2014 – Sep 29, 2014

Subsystems (3)

USB Arm/Zynq architecture USB ehci driver

lore

Share & tools

lore

Chen Gang

author

2014-09-03 15:50 UTC #0 lore raw

PATCH 1/1 drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

Need include it for irq_of_parse_and_map(), the related error with allmodconfig under microblaze:

drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]

    irq = irq_of_parse_and_map(dn, 0);
    ^

Signed-off-by Chen Gang <[email protected]>

---
 drivers/usb/host/ehci-xilinx-of.c | 1 +
 1 file changed, 1 insertion(+)

drivers/usb/host/ehci-xilinx-of.c +1 -0

index fe57710..a232836 100644
@@ -31,6 +31,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
+#include <linux/of_irq.h>
 
 /**
  * ehci_xilinx_port_handed_over - hand the port out if failed to enable it

Signature · 1 line

1.9.3

Michal Simek

Acked-by on v1 1/1

2014-09-08 05:20 UTC #1 lore raw

Quoted 19 lines · Chen Gang

Need include it for irq_of_parse_and_map(), the related error with allmodconfig under microblaze:
drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
    irq = irq_of_parse_and_map(dn, 0);
    ^
Signed-off-by Chen Gang <[email protected]>
---
 drivers/usb/host/ehci-xilinx-of.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-xilinx-of.c +0 -0
index fe57710..a232836 100644

drivers/usb/host/ehci-xilinx-of.c line 37

Quoted 7 lines

drivers/usb/host/ehci-xilinx-of.c +1 -0

@@ -31,6 +31,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
+#include <linux/of_irq.h>
 
 /**
  * ehci_xilinx_port_handed_over - hand the port out if failed to enable it

Acked-by Michal Simek <[email protected]>

Thanks,
Michal

Signature · 14 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140908/51d60e4e/attachment.sig>

Chen Gang

author

2014-09-20 04:19 UTC #2 lore raw

Hello Maintainers:

Please help check this patch, when you have time.

Thanks.

Quoted 33 lines · Michal Simek

Quoted 19 lines · Chen Gang
Need include it for irq_of_parse_and_map(), the related error with allmodconfig under microblaze:
drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
    irq = irq_of_parse_and_map(dn, 0);
    ^
Signed-off-by Chen Gang <[email protected]>
---
 drivers/usb/host/ehci-xilinx-of.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-xilinx-of.c +0 -0
index fe57710..a232836 100644
drivers/usb/host/ehci-xilinx-of.c line 37
Quoted 7 lines
drivers/usb/host/ehci-xilinx-of.c +1 -0
@@ -31,6 +31,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
+#include <linux/of_irq.h>
 
 /**
  * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
Acked-by Michal Simek <[email protected]>
Thanks,
Michal

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Michal Simek

2014-09-22 13:25 UTC #3 lore raw

Hi Alan and Greg,

Quoted 36 lines · Chen Gang

Hello Maintainers:
Please help check this patch, when you have time.
Thanks.
Quoted 29 lines · Michal Simek
Quoted 19 lines · Chen Gang
Need include it for irq_of_parse_and_map(), the related error with allmodconfig under microblaze:
drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
    irq = irq_of_parse_and_map(dn, 0);
    ^
Signed-off-by Chen Gang <[email protected]>
---
 drivers/usb/host/ehci-xilinx-of.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-xilinx-of.c +0 -0
index fe57710..a232836 100644
drivers/usb/host/ehci-xilinx-of.c line 37
Quoted 7 lines
drivers/usb/host/ehci-xilinx-of.c +1 -0
@@ -31,6 +31,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
+#include <linux/of_irq.h>
 
 /**
  * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
Acked-by Michal Simek <[email protected]>

Alan: Can you please add this patch to your queue?
Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?

I have also not a problem to add this patch through my microblaze tree but I think it will be much better to use any USB tree.

Thanks,
Michal

Alan Stern

maintainer

2014-09-24 15:41 UTC #4 lore raw

Quoted 40 lines · Michal Simek

Hi Alan and Greg,
Quoted 36 lines · Chen Gang
Hello Maintainers:
Please help check this patch, when you have time.
Thanks.
Quoted 29 lines · Michal Simek
Quoted 19 lines · Chen Gang
Need include it for irq_of_parse_and_map(), the related error with allmodconfig under microblaze:
drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
    irq = irq_of_parse_and_map(dn, 0);
    ^
Signed-off-by Chen Gang <[email protected]>
---
 drivers/usb/host/ehci-xilinx-of.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-xilinx-of.c +0 -0
index fe57710..a232836 100644
drivers/usb/host/ehci-xilinx-of.c line 37
Quoted 7 lines
drivers/usb/host/ehci-xilinx-of.c +1 -0
@@ -31,6 +31,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
+#include <linux/of_irq.h>
 
 /**
  * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
Acked-by Michal Simek <[email protected]>

Quoted 5 lines

Alan: Can you please add this patch to your queue?
Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
I have also not a problem to add this patch through my microblaze tree but I think it will be much better to use any USB tree.

Greg should be able to accept a trivial patch like this one directly.

Alan Stern

Greg Kroah-Hartman

maintainer

2014-09-29 01:52 UTC #5 lore raw

Quoted 42 lines · Alan Stern

Quoted 40 lines · Michal Simek
Hi Alan and Greg,
Quoted 36 lines · Chen Gang
Hello Maintainers:
Please help check this patch, when you have time.
Thanks.
Quoted 29 lines · Michal Simek
Quoted 19 lines · Chen Gang
Need include it for irq_of_parse_and_map(), the related error with allmodconfig under microblaze:
drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
    irq = irq_of_parse_and_map(dn, 0);
    ^
Signed-off-by Chen Gang <[email protected]>
---
 drivers/usb/host/ehci-xilinx-of.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-xilinx-of.c +0 -0
index fe57710..a232836 100644
drivers/usb/host/ehci-xilinx-of.c line 37
Quoted 7 lines
drivers/usb/host/ehci-xilinx-of.c +1 -0
@@ -31,6 +31,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
+#include <linux/of_irq.h>
 
 /**
  * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
Acked-by Michal Simek <[email protected]>

Quoted 7 lines

Quoted 5 lines
Alan: Can you please add this patch to your queue?
Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
I have also not a problem to add this patch through my microblaze tree but I think it will be much better to use any USB tree.
Greg should be able to accept a trivial patch like this one directly.

I can, if someone will resend it so I can apply it :)

thanks,

greg k-h

Chen Gang

author

2014-09-29 06:55 UTC #6 lore raw

Quoted 6 lines · Greg Kroah-Hartman

Quoted 5 lines · Alan Stern
Quoted 3 lines · Michal Simek
Alan: Can you please add this patch to your queue?
Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?

Quoted 7 lines

Quoted 4 lines
Quoted 2 lines
I have also not a problem to add this patch through my microblaze tree but I think it will be much better to use any USB tree.
Greg should be able to accept a trivial patch like this one directly.
I can, if someone will resend it so I can apply it :)

This patch you have already applied (applied this patch in 2014-09-24), so I need not resend it.

Thank all of you for your work.

Thanks.

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed