Skip to contentSkip to conversation

pango / ptest: clean CFLAGS for host binary

PATCH In review [email protected] 1 participant 4 messages Sep 2, 2014 – Sep 9, 2014

lore
Share & tools
lore
#0 lore raw

cover pango / ptest: clean CFLAGS for host binary

From: Wenzong Fan <[email protected]>

The binary gen-all-unicode needs to be compiled for the host architecture, the CFLAGS passed to target system could cause build issues for it.

Such as if CFLAGS includes ARM specific flag '-mapcs-frame', then it will cause build errors:

cc1: error: unrecognized command line option "-mapcs-frame"

The following changes since commit bb00d83675a1293ee8d7a3ac22cf01243fa2397b:

conf: Account for eglibc->glibc move (2014-09-01 18:03:06 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/fix-pango
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/fix-pango

Wenzong Fan (1):
pango / ptest: clean CFLAGS for host binary

 meta/recipes-graphics/pango/pango.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 pango / ptest: clean CFLAGS for host binary

From: Wenzong Fan <[email protected]>

The binary gen-all-unicode needs to be compiled for the host architecture, the CFLAGS passed to target system could cause build issues for it.

---
 meta/recipes-graphics/pango/pango.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/pango/pango.inc +1 -1
index 1ad46a3..b59d33d 100644
@@ -67,7 +67,7 @@ fi
 # This binary needs to be compiled for the host architecture.  This isn't pretty!
 do_compile_prepend () {
 	if ${@base_contains('DISTRO_FEATURES', 'ptest', 'true', 'false', d)}; then
-		make CC="${BUILD_CC}" AM_CPPFLAGS="$(pkg-config-native --cflags glib-2.0)" gen_all_unicode_LDADD="$(pkg-config-native --libs glib-2.0)" -C ${B}/tests gen-all-unicode
+		make CC="${BUILD_CC}" CFLAGS="" AM_CPPFLAGS="$(pkg-config-native --cflags glib-2.0)" gen_all_unicode_LDADD="$(pkg-config-native --libs glib-2.0)" -C ${B}/tests gen-all-unicode
 	fi
 }
 
Signature · 1 line
1.7.9.5
#2 lore raw
In reply to [email protected]

Recall this patch, it should be fixed from the dependency of swig.

Sorry for the inconvenience.

// Wenzong

Quoted 26 lines · On 09/02/2014 01:53 PM, [email protected] wrote:

From: Wenzong Fan <[email protected]>

The binary gen-all-unicode needs to be compiled for the host architecture, the CFLAGS passed to target system could cause build issues for it.

Such as if CFLAGS includes ARM specific flag '-mapcs-frame', then it will cause build errors:

cc1: error: unrecognized command line option "-mapcs-frame"

The following changes since commit bb00d83675a1293ee8d7a3ac22cf01243fa2397b:

   conf: Account for eglibc->glibc move (2014-09-01 18:03:06 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/fix-pango
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/fix-pango

Wenzong Fan (1):
pango / ptest: clean CFLAGS for host binary

  meta/recipes-graphics/pango/pango.inc |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
#3 lore raw

On 09/09/2014 05:11 PM, wenzong fan wrote:

Oops, I replied wrong mail list, this patch works and have been merged, please just ignore my nonsense below:

============================================

Quoted 6 lines

Recall this patch, it should be fixed from the dependency of swig.

Sorry for the inconvenience.

// Wenzong

============================================

Thanks
Wenzong

Quoted 31 lines · On 09/02/2014 01:53 PM, [email protected] wrote:
Quoted 28 lines

From: Wenzong Fan <[email protected]>

The binary gen-all-unicode needs to be compiled for the host architecture, the CFLAGS passed to target system could cause build issues for it.

Such as if CFLAGS includes ARM specific flag '-mapcs-frame', then it will cause build errors:

cc1: error: unrecognized command line option "-mapcs-frame"

The following changes since commit
bb00d83675a1293ee8d7a3ac22cf01243fa2397b:

   conf: Account for eglibc->glibc move (2014-09-01 18:03:06 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/fix-pango

http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/fix-pango

Wenzong Fan (1):
pango / ptest: clean CFLAGS for host binary

  meta/recipes-graphics/pango/pango.inc |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)