video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT
PATCH 1/1 video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT
Commit 7edaa761ee81b ("video: mx3fb: Add backlight control support") changed the mx3fb driver so it always selects the BACKLIGHT_CLASS_DEVICE symbol, but that is hidden behind BACKLIGHT_LCD_SUPPORT in Kconfig, so we get a Kconfig warning for multi_v5_defconfig, which doesn't have that:
Warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY && FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI && EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT)
This makes sure we always enable both symbols together for mx3fb, like we do for the other drivers that can't be built without backlight support. Note that a better solution would be to ensure the driver can work with or without backlight support.
drivers/video/fbdev/Kconfig +2 -1
@@ -2356,10 +2356,11 @@ config FB_MSM config FB_MX3 tristate "MX3 Framebuffer support" depends on FB && MX3_IPU + select BACKLIGHT_CLASS_DEVICE + select BACKLIGHT_LCD_SUPPORT select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT - select BACKLIGHT_CLASS_DEVICE default y help This is a framebuffer device for the i.MX31 LCD Controller. So
PATCH 1/1 video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT
Quoted 30 lines · Arnd Bergmann
Commit
7edaa761ee81b("video: mx3fb: Add backlight control support") changed the mx3fb driver so it always selects theBACKLIGHT_CLASS_DEVICEsymbol, but that is hidden behindBACKLIGHT_LCD_SUPPORTinKconfig, so we get aKconfigwarning formulti_v5_defconfig, which doesn't have that:Warning: (
DRM_RADEON&&DRM_NOUVEAU&&DRM_I915&&DRM_GMA500&&DRM_SHMOBILE&&DRM_TILCDC&&FB_BACKLIGHT&&FB_MX3&&USB_APPLEDISPLAY&&FB_OLPC_DCON&&ASUS_LAPTOP&&SONY_LAPTOP&&THINKPAD_ACPI&&EEEPC_LAPTOP&&ACPI_CMPC&&SAMSUNG_Q10) selectsBACKLIGHT_CLASS_DEVICEwhich has unmet direct dependencies (HAS_IOMEM&&BACKLIGHT_LCD_SUPPORT)This makes sure we always enable both symbols together for mx3fb, like we do for the other drivers that can't be built without backlight support. Note that a better solution would be to ensure the driver can work with or without backlight support.
Signed-off-by Arnd Bergmann <[email protected]>Cc Alexander Stein <[email protected]>Cc Tomi Valkeinen <[email protected]>Cc linux-fbdev at vger.kernel.orgCc Jean-Christophe Plagniol-Villard <[email protected]>drivers/video/fbdev/Kconfig +0
-0@@ -2356,10 +2356,11 @@ config FB_MSM config FB_MX3 tristate "MX3 Framebuffer support"
drivers/video/fbdev/Kconfig config FB_MSM · line 2366
Quoted 10 lines
drivers/video/fbdev/Kconfig +2
-1depends on FB && MX3_IPU + select BACKLIGHT_CLASS_DEVICE + select BACKLIGHT_LCD_SUPPORT select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT - select BACKLIGHT_CLASS_DEVICE default y help This is a framebuffer device for the i.MX31 LCD Controller. So
Thanks, queued for 3.18.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140909/14fb0c17/attachment.sig>