video: fbdev: use %*ph specifier to dump small buffers
PATCH 1/1 video: fbdev: use %*ph specifier to dump small buffers
Instead of dereference each byte let's use %*ph specifier in the printk() calls.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/video/fbdev/core/fbsysfs.c | 12 ++---------- drivers/video/fbdev/udlfb.c | 7 ++----- 2 files changed, 4 insertions(+), 15 deletions(-)
drivers/video/fbdev/core/fbsysfs.c +2 -10
@@ -485,16 +485,8 @@ static ssize_t show_bl_curve(struct device *device,mutex_lock (&fb_info->bl_curve_mutex);for (i =0 ; i <FB_BACKLIGHT_LEVELS ; i +=8 ) - len +=snprintf (&buf[len],PAGE_SIZE , -"%02x %02x %02x %02x %02x %02x %02x %02x\n" , - fb_info->bl_curve[i +0 ], - fb_info->bl_curve[i +1 ], - fb_info->bl_curve[i +2 ], - fb_info->bl_curve[i +3 ], - fb_info->bl_curve[i +4 ], - fb_info->bl_curve[i +5 ], - fb_info->bl_curve[i +6 ], - fb_info->bl_curve[i +7 ]); + len +=snprintf (&buf[len],PAGE_SIZE ,"%8ph\n" , + fb_info->bl_curve + i);mutex_unlock (&fb_info->bl_curve_mutex);return len;
drivers/video/fbdev/udlfb.c +2 -5
@@ -1528,11 +1528,8 @@ static int dlfb_parse_vendor_descriptor(struct dlfb_data *dev, }if (total_len >5 ) { -pr_info ("vendor descriptor length:%x data:%02x %02x %02x %02x" \ -"%02x %02x %02x %02x %02x %02x %02x\n" , - total_len, desc[0 ], - desc[1 ], desc[2 ], desc[3 ], desc[4 ], desc[5 ], desc[6 ], - desc[7 ], desc[8 ], desc[9 ], desc[10 ]); +pr_info ("vendor descriptor length:%x data:%11ph\n" , total_len, + desc); if ((desc[0] != total_len) || /* descriptor length */ (desc[1] != 0x5f) || /* vendor descriptor type */
Signature · 1 line
2.1.0
Quoted 9 lines · Andy Shevchenko
Instead of dereference each byte let's use %*ph specifier in the
printk()calls.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/video/fbdev/core/fbsysfs.c | 12 ++---------- drivers/video/fbdev/udlfb.c | 7 ++----- 2 files changed, 4 insertions(+), 15 deletions(-)
Thanks, queued for 3.18.
Tomi