Skip to contentSkip to conversation

Staging: octeon-hcd: removed dummy label

PATCH Superseded Nitin Kuppelur 2 participants 4 messages Sep 9, 2014 – Sep 10, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: octeon-hcd: removed dummy label

This is a patch to the octeon-hcd.c file that removes dummy label i.e. label followed by return of void function

---
 drivers/staging/octeon-usb/octeon-hcd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/octeon-usb/octeon-hcd.c +1 -4
index 8a80982..5fffef2 100644
@@ -2253,9 +2253,8 @@ static void __cvmx_usb_perform_complete(
 			/* Increment to the next location in our packet array */
 			transaction->iso_packets++;
 			transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
-			goto done;
+			return;
 		}
-	}
 
 	/* Remove the transaction from the pipe list */
 	list_del(&transaction->node);
@@ -2266,8 +2265,6 @@ static void __cvmx_usb_perform_complete(
 					 transaction->actual_bytes,
 					 transaction->urb);
 	kfree(transaction);
-done:
-	return;
 }
 
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 14 lines · Nitin Kuppelur

This is a patch to the octeon-hcd.c file that removes dummy label i.e. label followed by return of void function

---
 drivers/staging/octeon-usb/octeon-hcd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/octeon-usb/octeon-hcd.c +0 -0
index 8a80982..5fffef2 100644

drivers/staging/octeon-usb/octeon-hcd.c static void __cvmx_usb_perform_complete( · line 2258

Quoted 8 lines
drivers/staging/octeon-usb/octeon-hcd.c +1 -2
@@ -2253,9 +2253,8 @@ static void __cvmx_usb_perform_complete(
 			/* Increment to the next location in our packet array */
 			transaction->iso_packets++;
 			transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
-			goto done;
+			return;
 		}
-	}
 

Wat? Does this still compile without the curly brace?

regards,
dan carpenter

#2 lore raw

Hi Dan,

Sorry for that. While doing some last movement changes related to indentation I accidentally removed the brace and did not build it after :-(

I am sending PATCH with correction.

Regards,
Nitin

Quoted 6 lines

Wat? Does this still compile without the curly brace?

regards,
dan carpenter

#3 lore raw

PATCH v2 1/1 Staging: octeon-hcd: removed dummy label

This is a patch to the octeon-hcd.c file that fixes removes dummy label i.e. label followed by return of void function

---
 drivers/staging/octeon-usb/octeon-hcd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/octeon-usb/octeon-hcd.c +1 -3
index 8a80982..5f9db4c 100644
@@ -2253,7 +2253,7 @@ static void __cvmx_usb_perform_complete(
 			/* Increment to the next location in our packet array */
 			transaction->iso_packets++;
 			transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
-			goto done;
+			return;
 		}
 	}
 
@@ -2266,8 +2266,6 @@ static void __cvmx_usb_perform_complete(
 					 transaction->actual_bytes,
 					 transaction->urb);
 	kfree(transaction);
-done:
-	return;
 }
 
 
Signature · 1 line
1.9.1