Skip to contentSkip to conversation

ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig

PATCH New Simon Horman 3 participants 4 messages Sep 10, 2014 – Sep 11, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig

Support for the r8a7794 was recently added.
Enable it in the shmobile_defconfig to increase build coverage.

---

Based on renesas-devel-20140910v2-v3.17-rc4

 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +1 -0
index 522275a..d7346ad 100644
@@ -16,6 +16,7 @@ CONFIG_ARCH_R8A7740=y
 CONFIG_ARCH_R8A7779=y
 CONFIG_ARCH_R8A7790=y
 CONFIG_ARCH_R8A7791=y
+CONFIG_ARCH_R8A7794=y
 CONFIG_MACH_KOELSCH=y
 CONFIG_MACH_LAGER=y
 CONFIG_MACH_MARZEN=y
Signature · 1 line
2.0.1
#1 lore raw

PATCH 1/1 ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig

Quoted 4 lines · Simon Horman

Support for the r8a7794 was recently added.
Enable it in the shmobile_defconfig to increase build coverage.

I have queued this up.

Quoted 21 lines

---

Based on renesas-devel-20140910v2-v3.17-rc4

 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +1 -0
index 522275a..d7346ad 100644
@@ -16,6 +16,7 @@ CONFIG_ARCH_R8A7740=y
 CONFIG_ARCH_R8A7779=y
 CONFIG_ARCH_R8A7790=y
 CONFIG_ARCH_R8A7791=y
+CONFIG_ARCH_R8A7794=y
 CONFIG_MACH_KOELSCH=y
 CONFIG_MACH_LAGER=y
 CONFIG_MACH_MARZEN=y
Signature · 1 line
2.0.1
#2 lore raw

PATCH 1/1 ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig

In reply to Simon Horman

Hi Simon,
cc Ulrich,

Thanks for your patch.

I think it's a bit early to enable r8a7794
in shmobile_defconfig.

The accepted part of r8a7794 initial code lacked of
arch. timer initialization code for Cortex-A7 in r8a7794 SoC.
[PATCH 1/3] ARM: shmobile: rcar-gen2: Add CA7 arch_timer initialization for r8a7794
http://www.spinics.net/lists/linux-sh/msg34978.html

I guess (at least) that code should be merged (in current form or another) before r8a7794 can be enabled in shmobile_defconfig.

Quoted 2 lines · Simon Horman

Support for the r8a7794 was recently added.
Enable it in the shmobile_defconfig to increase build coverage.

IMO, the support is only enabled after the code under that config run correctly.
Please correct me if I'm wrong.

Quoted 20 lines

---

Based on renesas-devel-20140910v2-v3.17-rc4

 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +1 -0
index 522275a..d7346ad 100644
@@ -16,6 +16,7 @@ CONFIG_ARCH_R8A7740=y
 CONFIG_ARCH_R8A7779=y
 CONFIG_ARCH_R8A7790=y
 CONFIG_ARCH_R8A7791=y
+CONFIG_ARCH_R8A7794=y
 CONFIG_MACH_KOELSCH=y
 CONFIG_MACH_LAGER=y
 CONFIG_MACH_MARZEN=y
Signature · 2 lines
Best regards,
KHIEM Nguyen
#3 lore raw

PATCH 1/1 ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig

Quoted 16 lines · Khiem Nguyen

Hi Simon,
cc Ulrich,

Thanks for your patch.

I think it's a bit early to enable r8a7794
in shmobile_defconfig.

The accepted part of r8a7794 initial code lacked of
arch. timer initialization code for Cortex-A7 in r8a7794 SoC.
[PATCH 1/3] ARM: shmobile: rcar-gen2: Add CA7 arch_timer initialization for r8a7794
http://www.spinics.net/lists/linux-sh/msg34978.html

I guess (at least) that code should be merged (in current form or another) before r8a7794 can be enabled in shmobile_defconfig.

Quoted 7 lines
Quoted 2 lines · Simon Horman

Support for the r8a7794 was recently added.
Enable it in the shmobile_defconfig to increase build coverage.

IMO, the support is only enabled after the code under that config run correctly.
Please correct me if I'm wrong.

The purpose of enabling r8a7794 at this point is to increase build coverage. As the SoC support is new it doesn't create any regressions even though the support may not be in a working form yet.

Quoted 25 lines
Quoted 20 lines

---

Based on renesas-devel-20140910v2-v3.17-rc4

 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/shmobile_defconfig +1 -0
index 522275a..d7346ad 100644
@@ -16,6 +16,7 @@ CONFIG_ARCH_R8A7740=y
 CONFIG_ARCH_R8A7779=y
 CONFIG_ARCH_R8A7790=y
 CONFIG_ARCH_R8A7791=y
+CONFIG_ARCH_R8A7794=y
 CONFIG_MACH_KOELSCH=y
 CONFIG_MACH_LAGER=y
 CONFIG_MACH_MARZEN=y
Signature · 2 lines
Best regards,
KHIEM Nguyen