v4l2_fops - poll and open
Mauro/Hans,
It turns out au0828 driver does init tuner from its v4l2_fops read and poll. If an analog app comes in and does a read or poll, digital could get disrupted. Do you recommend adding token access to these??
-- Shuah
Signature · 4 lines
Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978
Quoted 6 lines · Shuah Khan
Mauro/Hans,
It turns out au0828 driver does init tuner from its
v4l2_fopsread and poll. If an analog app comes in and does a read or poll, digital could get disrupted. Do you recommend adding token access to these??
Yes. read() and poll() are effectively the same as STREAMON.
But rather than doing this for read, poll, streamon, streamoff and when the filehandle is closed you should think of integrating this in vb2 and do it in start_streaming and stop_streaming. Those are really the only two streaming-related places where you need to take and release the tuner token.
As I mentioned before, I think it is a good idea to convert au0828 to vb2. Since vb2 makes resource management so much easier than vb1 I think it will only help you.
Also, requiring vb2 support for tuner ownership to work correctly is a good incentive to keep on converting drivers to vb2.
Regards,
Hans
Quoted 3 lines
-- Shuah
Quoted 16 lines · Hans Verkuil
Quoted 6 lines · Shuah Khan
Mauro/Hans,
It turns out au0828 driver does init tuner from its
v4l2_fopsread and poll. If an analog app comes in and does a read or poll, digital could get disrupted. Do you recommend adding token access to these??Yes.
read()andpoll()are effectively the same as STREAMON.But rather than doing this for read, poll, streamon, streamoff and when the filehandle is closed you should think of integrating this in vb2 and do it in
start_streamingandstop_streaming. Those are really the only two streaming-related places where you need to take and release the tuner token.
Quoted 7 lines
As I mentioned before, I think it is a good idea to convert au0828 to vb2. Since vb2 makes resource management so much easier than vb1 I think it will only help you.
Also, requiring vb2 support for tuner ownership to work correctly is a good incentive to keep on converting drivers to vb2.
Right we discussed it a few weeks at LinuxCon. My thinking is getting the tuner ownership work done is higher priority as it benefits several drivers. Even if au0828 gets converted to vb2, the tuner work still have to deal with other drivers that aren't converted to vb2. i.e I might still end up adding acquiring tuner at open, poll etc.
Mauro! What are your thoughts on this idea?? I would like to get the media sharing work done since it will benefit PM scenarios.
-- Shuah
Signature · 4 lines
Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978