Skip to contentSkip to conversation

ARM: dts: Add DT changes for display on peach_pi

PATCH Superseded Ajay Kumar 3 participants 3 messages Aug 4, 2014 – Sep 14, 2014

Subsystems (2)
lore
Share & tools
lore

Ajay Kumar

author
#0 lore raw

PATCH v3 1/1 ARM: dts: Add DT changes for display on peach_pi

Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also, add panel phandle needed by dp to enable display on peach_pi.

---
Changes since V1:
Remove "simple-panel" compatible string and use only ""auo,b133htn01".

Changes since V2:
As suggested by Andreas,
Use GPIO_ACTIVE_HIGH for backlight enable-gpios instead of using 0. Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5800-peach-pi.dts |   27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)
arch/arm/boot/dts/exynos5800-peach-pi.dts +10 -17
index f3ee48b..f8c2e61 100644
@@ -28,11 +28,13 @@
 		i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
 	};
 
-	backlight {
+	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm 0 1000000 0>;
 		brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
 		default-brightness-level = <7>;
+		enable-gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;
+		power-supply = <&tps65090_fet1>;
 		pinctrl-0 = <&pwm0_out>;
 		pinctrl-names = "default";
 	};
@@ -98,6 +100,12 @@
 		regulator-boot-on;
 		regulator-always-on;
 	};
+
+	panel: panel {
+		compatible = "auo,b133htn01";
+		power-supply = <&tps65090_fet6>;
+		backlight = <&backlight>;
+	};
 };
 
 &dp {
@@ -111,22 +119,7 @@
 	samsung,link-rate = <0x0a>;
 	samsung,lane-count = <2>;
 	samsung,hpd-gpio = <&gpx2 6 0>;
-
-	display-timings {
-		native-mode = <&timing1>;
-
-		timing1: timing at 1 {
-			clock-frequency = <150660000>;
-			hactive = <1920>;
-			vactive = <1080>;
-			hfront-porch = <60>;
-			hback-porch = <172>;
-			hsync-len = <80>;
-			vback-porch = <25>;
-			vfront-porch = <10>;
-			vsync-len = <10>;
-		};
-	};
+	panel = <&panel>;
 };
 
 &fimd {
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v3 1/1 ARM: dts: Add DT changes for display on peach_pi

Quoted 76 lines · Ajay Kumar

Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also, add panel phandle needed by dp to enable display on peach_pi.

---
Changes since V1:
Remove "simple-panel" compatible string and use only ""auo,b133htn01".

Changes since V2:
As suggested by Andreas,
Use GPIO_ACTIVE_HIGH for backlight enable-gpios instead of using 0. Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5800-peach-pi.dts |   27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)
arch/arm/boot/dts/exynos5800-peach-pi.dts +10 -18
index f3ee48b..f8c2e61 100644
@@ -28,11 +28,13 @@
                i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
        };
 
-       backlight {
+       backlight: backlight {
                compatible = "pwm-backlight";
                pwms = <&pwm 0 1000000 0>;
                brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
                default-brightness-level = <7>;
+               enable-gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;
+               power-supply = <&tps65090_fet1>;
                pinctrl-0 = <&pwm0_out>;
                pinctrl-names = "default";
        };
@@ -98,6 +100,12 @@
                regulator-boot-on;
                regulator-always-on;
        };
+
+       panel: panel {
+               compatible = "auo,b133htn01";
+               power-supply = <&tps65090_fet6>;
+               backlight = <&backlight>;
+       };
 };
 
 &dp {
@@ -111,22 +119,7 @@
        samsung,link-rate = <0x0a>;
        samsung,lane-count = <2>;
        samsung,hpd-gpio = <&gpx2 6 0>;
-
-       display-timings {
-               native-mode = <&timing1>;
-
-               timing1: timing at 1 {
-                       clock-frequency = <150660000>;
-                       hactive = <1920>;
-                       vactive = <1080>;
-                       hfront-porch = <60>;
-                       hback-porch = <172>;
-                       hsync-len = <80>;
-                       vback-porch = <25>;
-                       vfront-porch = <10>;
-                       vsync-len = <10>;
-               };
-       };
+       panel = <&panel>;
 };
 
 &fimd {
--

1.7.9.5

Applied
#2 lore raw

PATCH v3 1/1 ARM: dts: Add DT changes for display on peach_pi

Quoted 10 lines · Ajay kumar
Quoted 9 lines · Ajay Kumar

Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also, add panel phandle needed by dp to enable display on peach_pi.

---
Changes since V1:
Remove "simple-panel" compatible string and use only ""auo,b133htn01".

Quoted 8 lines
Quoted 8 lines

Changes since V2:
As suggested by Andreas,
Use GPIO_ACTIVE_HIGH for backlight enable-gpios instead of using 0. Change panel node naming from "panel-simple" to "panel".

  arch/arm/boot/dts/exynos5800-peach-pi.dts |   27 ++++++++++-----------------
  1 file changed, 10 insertions(+), 17 deletions(-)

Applied, thanks.

- Kukjin