Skip to contentSkip to conversation

mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC

PATCH In review Boris BREZILLON 3 participants 3 messages Sep 2, 2014 – Sep 19, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC

Disable subpage write when using PMECC to prevent buggy partial page write.

This fix has been taken from linux sources (see commit 90445ff6241e2a13445310803e2efa606c61f276)

---
Hi,

Here is a link to the linux commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/nand/atmel_nand.c?id=90445ff6241e2a13445310803e2efa606c61f276

Best Regards,

Boris

 drivers/mtd/nand/atmel_nand.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/atmel_nand.c +1 -0
index e73834d..ee67662 100644
@@ -881,6 +881,7 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
 		return -ENOMEM;
 	}
 
+	nand->options |= NAND_NO_SUBPAGE_WRITE;
 	nand->ecc.read_page = atmel_nand_pmecc_read_page;
 	nand->ecc.write_page = atmel_nand_pmecc_write_page;
 	nand->ecc.strength = cap;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC

Hi, Boris

Quoted 6 lines · Boris BREZILLON

Disable subpage write when using PMECC to prevent buggy partial page write.

This fix has been taken from linux sources (see commit 90445ff6241e2a13445310803e2efa606c61f276)

Sorry for the later reply. And

Best Regards,
Josh Wu

Quoted 25 lines

---
Hi,

Here is a link to the linux commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/nand/atmel_nand.c?id=90445ff6241e2a13445310803e2efa606c61f276

Best Regards,

Boris

  drivers/mtd/nand/atmel_nand.c | 1 +
  1 file changed, 1 insertion(+)
drivers/mtd/nand/atmel_nand.c +1 -0
index e73834d..ee67662 100644
@@ -881,6 +881,7 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
  		return -ENOMEM;
  	}
 
+	nand->options |= NAND_NO_SUBPAGE_WRITE;
  	nand->ecc.read_page = atmel_nand_pmecc_read_page;
  	nand->ecc.write_page = atmel_nand_pmecc_write_page;
  	nand->ecc.strength = cap;
#2 lore raw
In reply to Boris BREZILLON

Dear Boris BREZILLON,

Quoted 13 lines · Boris BREZILLON

Disable subpage write when using PMECC to prevent buggy partial page write.

This fix has been taken from linux sources (see commit 90445ff6241e2a13445310803e2efa606c61f276)

---
Hi,

Here is a link to the linux commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/nand/atmel_nand.c?id=90445ff6241e2a13445310803e2efa606c61f276

Quoted 6 lines

Best Regards,

Boris

drivers/mtd/nand/atmel_nand.c | 1 +

1 file changed, 1 insertion(+)

applied to u-boot-atmel/master, thanks!

Best regards,
Andreas Bie?mann