Fix randconfig errros in bnx2i/bnx2fc caused by IPV6
Subsystems (5)
cover Fix randconfig errros in bnx2i/bnx2fc caused by IPV6
Just like CNIC bnx2i/bnx2fc also have their tristate dependent on IPV6, however using the same solution as CNIC can cause recursive dependecies during make.
Based on suggestions by Randy Dunlap, SCSI_NETLINK now depends on NET instead
of selecting NET. Second patch fixes the actual randconfig error.
Entire thread can be followed here : https://lkml.org/lkml/2014/9/9/500
-Anish
Anish Bhatt (2):
scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting
NET
bnx2i/bnx2fc : fix randconfig error
drivers/scsi/Kconfig | 2 +- drivers/scsi/bnx2fc/Kconfig | 1 + drivers/scsi/bnx2i/Kconfig | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.1.0
PATCH 1/2 scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET
Required for avoiding recursive dependencies in the Kconfig, brought out by fixing randconfig error for bnx2i/bnx2fc in the patch that follows. As suggested by Randy Dunlap
--- drivers/scsi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/Kconfig +1 -1
@@ -43,7 +43,7 @@ config SCSI_DMA config SCSI_NETLINK bool default n - select NET + depends on NET config SCSI_PROC_FS bool "legacy /proc/scsi/ support"
Signature · 1 line
2.1.0
PATCH 1/1 scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
From: Randy Dunlap <[email protected]>
Fix build errors when CONFIG_SCSI_NETLINK is enabled but CONFIG_NET is not enabled:
drivers/built-in.o: In function `scsi_nl_rcv_msg':
scsi_netlink.c:(.text+0x1850fa): undefined reference to netlink_ack' scsi_netlink.c:(.text+0x185105): undefined reference to skb_pull' scsi_netlink.c:(.text+0x18515d): undefined reference to netlink_capable' drivers/built-in.o: In function scsi_netlink_init':
(.text+0x185244): undefined reference to init_net' drivers/built-in.o: In function scsi_netlink_init':
(.text+0x185258): undefined reference to __netlink_kernel_create' drivers/built-in.o: In function scsi_netlink_exit':
(.text+0x185291): undefined reference to `netlink_kernel_release'
--- drivers/scsi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Based on Anish's previous SCSI_NETLINK patch.
Sorry about missing this one.
drivers/scsi/Kconfig +1 -1
@@ -257,7 +257,7 @@ config SCSI_SPI_ATTRS config SCSI_FC_ATTRS tristate "FiberChannel Transport Attributes" - depends on SCSI + depends on SCSI && NET select SCSI_NETLINK help If you wish to export transport-specific information about
RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
Quoted 22 lines
From : Randy Dunlap [[email protected]]
Sent: Monday, September 15, 2014 5:20 PM
To: Anish Bhatt; [email protected]; [email protected]; David Miller
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH 3] scsi: fix build errors,SCSI_FC_ATTRSneeds to depend on SCSI && NETFrom: Randy Dunlap <[email protected]>
Fix build errors when
CONFIG_SCSI_NETLINKis enabled butCONFIG_NETis not enabled:
drivers/built-in.o: In function `scsi_nl_rcv_msg':
scsi_netlink.c:(.text+0x1850fa): undefined reference tonetlink_ack' scsi_netlink.c:(.text+0x185105): undefined reference toskb_pull' scsi_netlink.c:(.text+0x18515d): undefined reference tonetlink_capable' drivers/built-in.o: In functionscsi_netlink_init':
(.text+0x185244): undefined reference toinit_net' drivers/built-in.o: In functionscsi_netlink_init':
(.text+0x185258): undefined reference to__netlink_kernel_create' drivers/built-in.o: In functionscsi_netlink_exit':
(.text+0x185291): undefined reference to `netlink_kernel_release'
Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>
Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is on defconfig
Quoted 18 lines
--- drivers/scsi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Based on Anish's previous
SCSI_NETLINKpatch.
Sorry about missing this one.drivers/scsi/Kconfig +1
-1@@ -257,7 +257,7 @@ config SCSI_SPI_ATTRS config SCSI_FC_ATTRS tristate "FiberChannel Transport Attributes" - depends on SCSI + depends on SCSI && NET select SCSI_NETLINK help If you wish to export transport-specific information about
Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
Quoted 4 lines · Anish Bhatt
Doesn't fix make warnings, but
SCSI_FC_ATTRScan no longer be selected without NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is on defconfig
You mean these kconfig warnings?
<quote>
After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:
warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
</quote>
I'll look into those.
Signature · 1 line
~Randy
RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
________________________________________
From: Randy Dunlap [[email protected]]
Sent: Monday, September 15, 2014 8:17 PM
To: Anish Bhatt; [email protected]; [email protected]; David Miller
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
Quoted 7 lines · Anish Bhatt
Quoted 4 lines
Doesn't fix make warnings, but
SCSI_FC_ATTRScan no longer be selected without NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is on defconfigYou mean these kconfig warnings?
[....]
Quoted 3 lines
I'll look into those.
--
~Randy
Yes, thanks
-Anish
Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
In reply to Randy DunlapFrom: Randy Dunlap <[email protected]>
Date: Mon, 15 Sep 2014 17:20:42 -0700
Quoted 4 lines
From: Randy Dunlap <[email protected]>
Fix build errors when
CONFIG_SCSI_NETLINKis enabled butCONFIG_NETis not enabled:
...
Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>
Applied, thanks a lot Randy.
PATCH 2/2 bnx2i/bnx2fc : fix randconfig error in next-20140909
In reply to Anish BhattJust like CNIC, tristate of these two modules is also dependent on IPV6. These need to be handled separately as they select CNIC, which can override tristate for CNIC from 'm' to 'y', which can cause build failures when ipv6 is
compiled as a module even if CNIC's Kconfig will only 'm' or 'n' when ipv6 is
compiled as a module.
--- drivers/scsi/bnx2fc/Kconfig | 1 + drivers/scsi/bnx2i/Kconfig | 1 + 2 files changed, 2 insertions(+)
drivers/scsi/bnx2fc/Kconfig +1 -0
@@ -1,6 +1,7 @@ config SCSI_BNX2X_FCOE tristate "QLogic NetXtreme II FCoE support" depends on PCI + depends on (IPV6 || IPV6=n) select NETDEVICES select ETHERNET select NET_VENDOR_BROADCOM
drivers/scsi/bnx2i/Kconfig +1 -0
@@ -2,6 +2,7 @@ config SCSI_BNX2_ISCSI tristate "QLogic NetXtreme II iSCSI support" depends on NET depends on PCI + depends on (IPV6 || IPV6=n) select SCSI_ISCSI_ATTRS select NETDEVICES select ETHERNET
Signature · 1 line
2.1.0
David Miller
maintainerFrom: Anish Bhatt <[email protected]>
Date: Mon, 15 Sep 2014 13:45:19 -0700
Quoted 10 lines
Just like CNIC bnx2i/bnx2fc also have their tristate dependent on IPV6, however using the same solution as CNIC can cause recursive dependecies during make.
Based on suggestions by Randy Dunlap,
SCSI_NETLINKnow depends on NET instead
of selecting NET. Second patch fixes the actual randconfig error.Entire thread can be followed here : https://lkml.org/lkml/2014/9/9/500
-AnishFixes c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
Series applied, thank you.