Skip to contentSkip to conversation

Checkpatch Patches

DISCUSSION nick 10 participants 29 messages Sep 16, 2014 3 messages not in the archive

lore
Share & tools
lore

nick

author
#0 lore raw

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.
Thanks,
Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-Add-blank-line-below-declarations-in-hfa384x.patch
Type: text/x-patch
Size: 1516 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/a07557f8/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-netlogic-Fix-checkpatch-errors-in-xlr_net.c.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/a07557f8/attachment-0001.bin

#1 lore raw

I wouldn't touch those with a ten foot pole.

Quoted 6 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
from the maintainers. Would someone please send them off for me. Thanks,
Nick

Quoted 6 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/5e47471e/attachment.html

author
#2 lore raw
Quoted 16 lines · Kristofer Hallin

I wouldn't touch those with a ten foot pole.

Quoted 12 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
from the maintainers. Would someone please send them off for me. Thanks,
Nick

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Kristofer,
I would appreciate if you look at them and see if there any good. I understand based on my other patches so assumptions but it would be nice if you only too a look for me.
Nick

#3 lore raw
In reply to nick
Quoted 54 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.
Thanks,
Nick

Quoted 1 line

From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Sat, 13 Sep 2014 11:53:24 -0400
Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations

Fixing trivial checkpatch warnings about missing line after declarations.

Signed-off-by Nicholas Krause <[email protected]>

---
Tested by compilation only.

 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/wlan-ng/hfa384x.h +3 -0
index 1f2c78c..20d146b 100644
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
 	int result = 0;
+
 	result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
 	if (result == 0)
 		*((u16 *) val) = le16_to_cpu(*((u16 *) val));

@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
 	u16 value = cpu_to_le16(val);
+
 	return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
 }

@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
 	u16 value = cpu_to_le16(val);
+
 	return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
 					    NULL, NULL);
 }

1.9.1

Quoted 1 line

From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Mon, 15 Sep 2014 17:07:24 -0400
Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c

Quoted 6 lines

This removes the checkpatch errors related to a needed line below declaration of a struct and another about a non nessary printk message about a NULL allocated skb due to the function returning NULL to the caller of the function and the printk no longer being' used or needed by any callers.

spelling mistakes

Quoted 10 lines
Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/netlogic/xlr_net.c +0 -0
index 9bf407d..28a42831 100644

drivers/staging/netlogic/xlr_net.c static inline struct sk_buff *xlr_alloc_skb(void) · line 146

Quoted 5 lines
drivers/staging/netlogic/xlr_net.c +0 -2
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
 	/* skb->data is cache aligned */
 	skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-	if (!skb) {
-		pr_err("SKB allocation failed\n");

why the error message was removed ?

Quoted 17 lines
drivers/staging/netlogic/xlr_net.c +2 -1
+	if (!skb)
 		return NULL;
-	}
 	mac_put_skb_back_ptr(skb);
 	return skb;
 }

@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
 	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
 	unregister_netdev(priv->ndev);
 	mdiobus_unregister(priv->mii_bus);
 	mdiobus_free(priv->mii_bus);
Signature · 1 line
1.9.1

ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916

why are we wasting our time for your patches , which are bound to have some problem ????

thanks
sudip

Quoted 4 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

author
#4 lore raw
Quoted 104 lines · Sudip Mukherjee
Quoted 54 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.
Thanks,
Nick

Quoted 1 line

From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Sat, 13 Sep 2014 11:53:24 -0400
Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations

Fixing trivial checkpatch warnings about missing line after declarations.

Signed-off-by Nicholas Krause <[email protected]>

---
Tested by compilation only.

 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/wlan-ng/hfa384x.h +3 -0
index 1f2c78c..20d146b 100644
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
 	int result = 0;
+
 	result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
 	if (result == 0)
 		*((u16 *) val) = le16_to_cpu(*((u16 *) val));

@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
 	u16 value = cpu_to_le16(val);
+
 	return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
 }

@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
 	u16 value = cpu_to_le16(val);
+
 	return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
 					    NULL, NULL);
 }

1.9.1

Quoted 1 line

From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Mon, 15 Sep 2014 17:07:24 -0400
Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c

Quoted 6 lines

This removes the checkpatch errors related to a needed line below declaration of a struct and another about a non nessary printk message about a NULL allocated skb due to the function returning NULL to the caller of the function and the printk no longer being' used or needed by any callers.

spelling mistakes

Quoted 10 lines
Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/netlogic/xlr_net.c +0 -0
index 9bf407d..28a42831 100644

drivers/staging/netlogic/xlr_net.c static inline struct sk_buff *xlr_alloc_skb(void) · line 146

Quoted 5 lines
drivers/staging/netlogic/xlr_net.c +0 -2
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
 	/* skb->data is cache aligned */
 	skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-	if (!skb) {
-		pr_err("SKB allocation failed\n");

why the error message was removed ?

Quoted 17 lines
drivers/staging/netlogic/xlr_net.c +2 -1
+	if (!skb)
 		return NULL;
-	}
 	mac_put_skb_back_ptr(skb);
 	return skb;
 }

@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
 	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
 	unregister_netdev(priv->ndev);
 	mdiobus_unregister(priv->mii_bus);
 	mdiobus_free(priv->mii_bus);
Signature · 1 line
1.9.1

ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916

Quoted 11 lines

why are we wasting our time for your patches , which are bound to have some problem ????

thanks
sudip

Quoted 4 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I tried these on Greg's tree of staging-next and they worked for me. Nick

#5 lore raw
Quoted 113 lines · nick
Quoted 110 lines · Sudip Mukherjee
Quoted 54 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.
Thanks,
Nick

Quoted 1 line

From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Sat, 13 Sep 2014 11:53:24 -0400
Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations

Fixing trivial checkpatch warnings about missing line after declarations.

Signed-off-by Nicholas Krause <[email protected]>

---
Tested by compilation only.

 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/wlan-ng/hfa384x.h +3 -0
index 1f2c78c..20d146b 100644
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
     int result = 0;
+
     result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
     if (result == 0)
             *((u16 *) val) = le16_to_cpu(*((u16 *) val));

@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
     u16 value = cpu_to_le16(val);
+
     return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
 }

@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
     u16 value = cpu_to_le16(val);
+
     return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
                                         NULL, NULL);
 }

1.9.1

Quoted 1 line

From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Mon, 15 Sep 2014 17:07:24 -0400
Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c

Quoted 6 lines

This removes the checkpatch errors related to a needed line below declaration of a struct and another about a non nessary printk message about a NULL allocated skb due to the function returning NULL to the caller of the function and the printk no longer being' used or needed by any callers.

spelling mistakes

Quoted 10 lines
Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/netlogic/xlr_net.c +0 -0
index 9bf407d..28a42831 100644

drivers/staging/netlogic/xlr_net.c static inline struct sk_buff *xlr_alloc_skb(void) · line 146

Quoted 5 lines
drivers/staging/netlogic/xlr_net.c +0 -2
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
     /* skb->data is cache aligned */
     skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-    if (!skb) {
-            pr_err("SKB allocation failed\n");

why the error message was removed ?

Quoted 15 lines
drivers/staging/netlogic/xlr_net.c +2 -2
+    if (!skb)
             return NULL;
-    }
     mac_put_skb_back_ptr(skb);
     return skb;
 }

@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
     struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
     unregister_netdev(priv->ndev);
     mdiobus_unregister(priv->mii_bus);
     mdiobus_free(priv->mii_bus);
--
Quoted 2 lines

1.9.1

ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916

why are we wasting our time for your patches , which are bound to have some problem ????

thanks
sudip

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I tried these on Greg's tree of staging-next and they worked for me. Nick

in drivers/staging/netlogic/xlr_net.c file of next-20140916

1) in line 142 we just have an "} else {" (doesnot match your patch)
2) in the same file , there is only one instance of "pr_err("SKB allocation failed\n");" , and that is at line 208 , and that is followed by a "return -ENOMEM;" , but your patch is showing that there is a return NULL ....

thanks
sudip

author
#6 lore raw
Quoted 124 lines · Sudip Mukherjee
Quoted 113 lines · nick
Quoted 110 lines · Sudip Mukherjee
Quoted 54 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.
Thanks,
Nick

Quoted 1 line

From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Sat, 13 Sep 2014 11:53:24 -0400
Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations

Fixing trivial checkpatch warnings about missing line after declarations.

Signed-off-by Nicholas Krause <[email protected]>

---
Tested by compilation only.

 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/wlan-ng/hfa384x.h +3 -0
index 1f2c78c..20d146b 100644
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
     int result = 0;
+
     result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
     if (result == 0)
             *((u16 *) val) = le16_to_cpu(*((u16 *) val));

@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
     u16 value = cpu_to_le16(val);
+
     return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
 }

@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
     u16 value = cpu_to_le16(val);
+
     return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
                                         NULL, NULL);
 }

1.9.1

Quoted 1 line

From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Mon, 15 Sep 2014 17:07:24 -0400
Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c

Quoted 6 lines

This removes the checkpatch errors related to a needed line below declaration of a struct and another about a non nessary printk message about a NULL allocated skb due to the function returning NULL to the caller of the function and the printk no longer being' used or needed by any callers.

spelling mistakes

Quoted 10 lines
Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/netlogic/xlr_net.c +0 -0
index 9bf407d..28a42831 100644

drivers/staging/netlogic/xlr_net.c static inline struct sk_buff *xlr_alloc_skb(void) · line 146

Quoted 5 lines
drivers/staging/netlogic/xlr_net.c +0 -2
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
     /* skb->data is cache aligned */
     skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-    if (!skb) {
-            pr_err("SKB allocation failed\n");

why the error message was removed ?

Quoted 15 lines
drivers/staging/netlogic/xlr_net.c +2 -2
+    if (!skb)
             return NULL;
-    }
     mac_put_skb_back_ptr(skb);
     return skb;
 }

@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
     struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
     unregister_netdev(priv->ndev);
     mdiobus_unregister(priv->mii_bus);
     mdiobus_free(priv->mii_bus);
--
Quoted 2 lines

1.9.1

ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916

why are we wasting our time for your patches , which are bound to have some problem ????

thanks
sudip

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I tried these on Greg's tree of staging-next and they worked for me. Nick

in drivers/staging/netlogic/xlr_net.c file of next-20140916

Quoted 9 lines

1) in line 142 we just have an "} else {" (doesnot match your patch)
2) in the same file , there is only one instance of "pr_err("SKB allocation failed\n");" , and that is at line 208 , and that is followed by a "return -ENOMEM;" , but your patch is showing that there is a return NULL ....

thanks
sudip

Thanks Sudip,
I will fix the patch later if you want. In addition is my other patch OK or do I need to fix it still? Nick

A message that is not in the archive (sent off-list or not yet received): CADVatmOZx7q636=b0pQ95CZ93_6jn_jZ2SCPKH7pHmw9P0mRuQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CADVatmP1G1pg-vDmn1z-vg9Ppn7Yhvc=hnhbaOyENbdg6WUO2A@mail.gmail.com

#10 lore raw
Quoted 148 lines · Sudip Mukherjee
Quoted 147 lines · nick
Quoted 144 lines · Sudip Mukherjee
Quoted 133 lines · nick
Quoted 130 lines · Sudip Mukherjee
Quoted 113 lines · nick
Quoted 110 lines · Sudip Mukherjee
Quoted 54 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.
Thanks,
Nick

Quoted 1 line

From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Sat, 13 Sep 2014 11:53:24 -0400
Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations

Fixing trivial checkpatch warnings about missing line after declarations.

Signed-off-by Nicholas Krause <[email protected]>

---
Tested by compilation only.

 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/wlan-ng/hfa384x.h +3 -0
index 1f2c78c..20d146b 100644
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
     int result = 0;
+
     result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
     if (result == 0)
             *((u16 *) val) = le16_to_cpu(*((u16 *) val));

@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
     u16 value = cpu_to_le16(val);
+
     return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
 }

@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
     u16 value = cpu_to_le16(val);
+
     return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
                                         NULL, NULL);
 }

1.9.1

Quoted 1 line

From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Mon, 15 Sep 2014 17:07:24 -0400
Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c

Quoted 6 lines

This removes the checkpatch errors related to a needed line below declaration of a struct and another about a non nessary printk message about a NULL allocated skb due to the function returning NULL to the caller of the function and the printk no longer being' used or needed by any callers.

spelling mistakes

Quoted 10 lines
Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/staging/netlogic/xlr_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/netlogic/xlr_net.c +0 -0
index 9bf407d..28a42831 100644

drivers/staging/netlogic/xlr_net.c static inline struct sk_buff *xlr_alloc_skb(void) · line 146

Quoted 5 lines
drivers/staging/netlogic/xlr_net.c +0 -2
@@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
 
     /* skb->data is cache aligned */
     skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
-    if (!skb) {
-            pr_err("SKB allocation failed\n");

why the error message was removed ?

Quoted 15 lines
drivers/staging/netlogic/xlr_net.c +2 -2
+    if (!skb)
             return NULL;
-    }
     mac_put_skb_back_ptr(skb);
     return skb;
 }

@@ -1104,6 +1102,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
     struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
     unregister_netdev(priv->ndev);
     mdiobus_unregister(priv->mii_bus);
     mdiobus_free(priv->mii_bus);
--
Quoted 2 lines

1.9.1

ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916

why are we wasting our time for your patches , which are bound to have some problem ????

thanks
sudip

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I tried these on Greg's tree of staging-next and they worked for me. Nick

in drivers/staging/netlogic/xlr_net.c file of next-20140916

1) in line 142 we just have an "} else {" (doesnot match your patch)
2) in the same file , there is only one instance of "pr_err("SKB allocation failed\n");" , and that is at line 208 , and that is followed by a "return -ENOMEM;" , but your patch is showing that there is a return NULL ....

Quoted 6 lines
Quoted 3 lines

thanks
sudip

Thanks Sudip,
I will fix the patch later if you want. In addition is my other patch OK or do I need to fix it still? Nick

allow me to quote from my mail : "ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916 "

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

i mentioned both ...

Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is now to make it right.
Nick

and your are screwing up even more by sending these patches.

and your are screwing up even more by sending these patches.

#11 lore raw
In reply to nick
Quoted 3 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.

hey, kids ... remember what i wrote recently about, at the very
least, having a grammatically correct subject line? well, there you go. why nick has not been banned from this list is purely a mystery at this point.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#12 lore raw
In reply to nick
Quoted 3 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.

oh, and remember how i wrote *explicitly* that the patch message
should match the properties of the patch, and that one should not claim to be fixing an "error" if what is being rectified is merely a *warning*? remember i wrote that?

take a wild guess as to what nick did in his second patch. go ahead,
guess. you'll never guess.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#13 lore raw
In reply to nick
Quoted 2 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.

"I am attaching". Fail 3 words in.

That's why you aren't getting a reply from the maintainers. They don't bother reading patches they know will probably *never* be correct.

And yes, at least one of the two patches is incorrect.

Quoted 2 lines
Quoted 2 lines

Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is now to make it right.

You don't make it right by posting more wrong patches. Now do us all a favor and *stop* being either an idiot, or a troll, or whatever your problem is. We have *zero* desire to see *any* more patches from somebody who is either unable or unwilling to post a *single* correct patch after *two months* of trying.

So please do us a favor and go piss off some other open source project.

THE KERNEL DOES NOT WANT YOUR BULLSHIT.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/14e5f1b2/attachment.bin

author
#14 lore raw
Quoted 21 lines · On Tue, Sep 16, 2014 at 10:19 AM, <[email protected]> wrote:
Quoted 2 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.

"I am attaching". Fail 3 words in.

That's why you aren't getting a reply from the maintainers. They don't bother reading patches they know will probably *never* be correct.

And yes, at least one of the two patches is incorrect.

Quoted 2 lines
Quoted 2 lines

Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is now to make it right.

You don't make it right by posting more wrong patches. Now do us all a favor and *stop* being either an idiot, or a troll, or whatever your problem is. We have *zero* desire to see *any* more patches from somebody who is either unable or unwilling to post a *single* correct patch after *two months* of trying.

Quoted 6 lines

So please do us a favor and go piss off some other open source project.

THE KERNEL DOES NOT WANT YOUR BULLSHIT.

I am going to attach it again and I understand Valdis. I am going to talk to Sudip about reading and checking
my patches first.
Nick

#15 lore raw
Quoted 24 lines · Nick Krause
Quoted 23 lines · On Tue, Sep 16, 2014 at 10:19 AM, <[email protected]> wrote:
Quoted 2 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.

"I am attaching". Fail 3 words in.

That's why you aren't getting a reply from the maintainers. They don't bother reading patches they know will probably *never* be correct.

And yes, at least one of the two patches is incorrect.

Quoted 2 lines
Quoted 2 lines

Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is now to make it right.

You don't make it right by posting more wrong patches. Now do us all a favor and *stop* being either an idiot, or a troll, or whatever your problem is. We have *zero* desire to see *any* more patches from somebody who is either unable or unwilling to post a *single* correct patch after *two months* of trying.

So please do us a favor and go piss off some other open source project.

Quoted 7 lines
Quoted 4 lines

THE KERNEL DOES NOT WANT YOUR BULLSHIT.

I am going to attach it again and I understand Valdis. I am going to talk to Sudip about reading and checking
my patches first.

Rik,
probably it's time to ban Nick also from this ml.

Signature · 1 line
Carlo Caione
#16 lore raw

Nick,

Use this guide: http://kernelnewbies.org/OPWfirstpatch

It's a tutorial that shows you how to setup and send patches.

And memorize these references:
http://lxr.free-electrons.com/source/Documentation/SubmitChecklist
http://lxr.free-electrons.com/source/Documentation/development-process/

Lidza

Quoted 43 lines · Carlo Caione
Quoted 24 lines · Nick Krause
Quoted 23 lines · On Tue, Sep 16, 2014 at 10:19 AM, <[email protected]> wrote:
Quoted 2 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.

"I am attaching". Fail 3 words in.

That's why you aren't getting a reply from the maintainers. They don't bother reading patches they know will probably *never* be correct.

And yes, at least one of the two patches is incorrect.

Quoted 2 lines
Quoted 2 lines

Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is now to make it right.

You don't make it right by posting more wrong patches. Now do us all a favor and *stop* being either an idiot, or a troll, or whatever your problem is. We have *zero* desire to see *any* more patches from somebody who is either unable or unwilling to post a *single* correct patch after *two months* of trying.

So please do us a favor and go piss off some other open source project.

Quoted 7 lines
Quoted 4 lines

THE KERNEL DOES NOT WANT YOUR BULLSHIT.

I am going to attach it again and I understand Valdis. I am going to talk to Sudip about reading and checking
my patches first.

Rik,
probably it's time to ban Nick also from this ml.

--
Carlo Caione

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

#17 lore raw
Quoted 3 lines · Lidza Louina

Use this guide: http://kernelnewbies.org/OPWfirstpatch

It's a tutorial that shows you how to setup and send patches.

Don't bother.

He's been pointed at that at least once a week for the past two months, and everybody from me to Greg KH to Ted T'so and at least a half dozen other experienced kernel people have told him *repeatedly* what to do and not do, and he has *yet* to post a correct patch - and he keeps making the same mistakes that he was told not to. For instance, I didn't even *bother* looking at his last two patches, because they were attachments, even *after* Robert PJ Day told him *yesterday* to not do that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/35516a94/attachment.bin

#18 lore raw
Quoted 8 lines · Valdis.Kletnieks at vt.edu
Quoted 3 lines · Lidza Louina

Use this guide: http://kernelnewbies.org/OPWfirstpatch

It's a tutorial that shows you how to setup and send patches.

Don't bother.

Quoted 7 lines

He's been pointed at that at least once a week for the past two months, and everybody from me to Greg KH to Ted T'so and at least a half dozen other experienced kernel people have told him *repeatedly* what to do and not do, and he has *yet* to post a correct patch - and he keeps making the same mistakes that he was told not to. For instance, I didn't even *bother* looking at his last two patches, because they were attachments, even *after* Robert PJ Day told him *yesterday* to not do that.

i posted three simple pieces of advice yesterday:

* proper grammar, at the very least in the subject line
* make sure the commit description matches the patch
* no attachments

nick promptly violated all of the above.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#19 lore raw
In reply to Lidza Louina
Quoted 4 lines · Lidza Louina

Nick,

Use this guide: http://kernelnewbies.org/OPWfirstpatch

Quoted 8 lines

It's a tutorial that shows you how to setup and send patches.

And memorize these references:
http://lxr.free-electrons.com/source/Documentation/SubmitChecklist
http://lxr.free-electrons.com/source/Documentation/development-process/

Lidza

i'm going to back up carlo ... time to ban nick as i suggested a
while back. giving nick more references is not going to help -- he is simply unteachable.

in a nutshell, nick brings no value to this mailing list. quite the
opposite -- he devalues it significantly by wasting bandwidth and just plain pissing people off. all by himself, nick makes this mailing list a worse place.

if nick showed any sign of progress whatsoever, that would be
different. but he doesn't. so, please, pull the plug on him.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#20 lore raw
In reply to Nick Krause
Quoted 7 lines · Nick Krause
Quoted 6 lines · On Tue, Sep 16, 2014 at 10:19 AM, <[email protected]> wrote:
Quoted 2 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply from the maintainers. Would someone please send them off for me.

"I am attaching". Fail 3 words in.

[snip]

Quoted 3 lines

I am going to attach it again and I understand Valdis. I am going to talk to Sudip about reading and checking
my patches first.

The email that you are replying to repeats the statement that
attaching the patches is the wrong thing to be doing. And yet, in the reply, you talk about attaching patches.

Can you please explain what's going on here?

Did you forget about it while you were writing the three line
response? Did you simply ignore the words? Did you assume that it didn't apply to you? Did you merely think it wasn't important? Do you have short-term memory problems? Is there something else I don't know about?

I understand that you're a student (or will shortly be one), and so
far you're showing *major* learning difficulties, without any apparent self-identification of the fact. If you do actually have some kind of learning difficulty, you're going to have to take charge of it yourself, seek professional advice, use that to work out how you can learn, and start doing it, because if you behave like this in any institution of higher learning, you're going to have big problems, probably very quickly.

You've spent two months, with *lots* of explicit recommendations on
how you should be modifying your behaviour (i.e. learning), and so far you've utterly failed to do so. It's up to you to seek help in identifying the difficulties you have in learning, and to use the results of that to work out how you can do so. This kernel development environment is *absolutely* the wrong one for you to be doing that exercise in. I doubt that there are many (if any) people on this mailing list who have the knowledge or skills to help you. I am certain that if there are any, none of them would be willing to start the process via email.

Hugo.

Signature · 10 lines
=== Hugo Mills: hugo at ... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
      --- "Big data" doesn't just mean increasing the font size ---      
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/c98cfc1c/attachment.bin
#21 lore raw
In reply to Nick Krause
Quoted 27 lines · Nick Krause
Quoted 26 lines · On Tue, Sep 16, 2014 at 10:19 AM, <[email protected]> wrote:
Quoted 3 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
from the maintainers. Would someone please send them off for me.

"I am attaching". Fail 3 words in.

That's why you aren't getting a reply from the maintainers. They don't bother
reading patches they know will probably *never* be correct.

And yes, at least one of the two patches is incorrect.

Quoted 3 lines
Quoted 3 lines

Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is
now to make it right.

You don't make it right by posting more wrong patches. Now do us all a favor and *stop* being either an idiot, or a troll, or whatever your problem is. We have *zero* desire to see *any* more patches from somebody who is either unable or unwilling to post a *single* correct patch after *two months* of trying.

So please do us a favor and go piss off some other open source project.

Quoted 9 lines
Quoted 4 lines

THE KERNEL DOES NOT WANT YOUR BULLSHIT.

I am going to attach it again and I understand Valdis. I am going to talk to Sudip about reading and checking
my patches first.
Nick

plzzz .. NO ...
today i checked your patches just to take a break from what i was doing.. and besides , i am also a newbie , i also make mistakes when submitting patches, but i try to learn from my mistakes and see to it that they are never repeated.
apart from the numerous advises you got from the LKML , i think just yesterday Robert P. J. Day has pointed out something, day before yesterday Valdis , before that ( sorry i lost track) ... and you have not cared to listen to any of that ..

Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

author
#22 lore raw
Quoted 38 lines · Sudip Mukherjee
Quoted 27 lines · Nick Krause
Quoted 26 lines · On Tue, Sep 16, 2014 at 10:19 AM, <[email protected]> wrote:
Quoted 3 lines · nick

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
from the maintainers. Would someone please send them off for me.

"I am attaching". Fail 3 words in.

That's why you aren't getting a reply from the maintainers. They don't bother
reading patches they know will probably *never* be correct.

And yes, at least one of the two patches is incorrect.

Quoted 3 lines
Quoted 3 lines

Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is
now to make it right.

You don't make it right by posting more wrong patches. Now do us all a favor and *stop* being either an idiot, or a troll, or whatever your problem is. We have *zero* desire to see *any* more patches from somebody who is either unable or unwilling to post a *single* correct patch after *two months* of trying.

So please do us a favor and go piss off some other open source project.

Quoted 9 lines
Quoted 4 lines

THE KERNEL DOES NOT WANT YOUR BULLSHIT.

I am going to attach it again and I understand Valdis. I am going to talk to Sudip about reading and checking
my patches first.
Nick

Quoted 17 lines

plzzz .. NO ...
today i checked your patches just to take a break from what i was doing.. and besides , i am also a newbie , i also make mistakes when submitting patches, but i try to learn from my mistakes and see to it that they are never repeated.
apart from the numerous advises you got from the LKML , i think just yesterday Robert P. J. Day has pointed out something, day before yesterday Valdis , before that ( sorry i lost track) ... and you have not cared to listen to any of that ..

Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I am going to resend my patch and see if it's good and if not I am going to leave for a while.
Nick

#23 lore raw
Quoted 1 line · Nick Krause

I am going to resend my patch and see if it's good ...

because, of course, that's the correct order of events -- send the
patch, *then* validate its correctness.

ban. for the love of mutt, please, ban. there is no excuse for this
anymore.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#24 lore raw
In reply to Nick Krause
Quoted 1 line · Nick Krause

I am going to resend my patch and see if it's good

Why bother? We already *know* it won't be.

You could amaze and astound us all by seeing if it's good *before* you hit send. But I'm not holding my breath.

Quoted 1 line

and if not I am going to leave for a while.

Actions. Not words.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/4649e626/attachment.bin

#25 lore raw
In reply to Nick Krause

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 2 lines · Nick Krause

I am going to resend my patch and see if it's good and if not I am going to leave for a while.

You may want to consider fixing them, by applying the advice provided by many people, before resending them.

- --
All rights reversed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUGHMmAAoJEM553pKExN6Dvw4IAKi2no5OpH9TUgcCd5zRHTsb oqFsZ2xR21bgnIyfM93V+h9QtG+Fuc+WOScCL1Ofk4OWVXWV6gIgHHSGBOb0cEBf zGTxhMyRdPUl7WHAn7KHWAEqhCGQlIp0QyyRiXjnNLmSmGYt/9yv3TrvmZE0xuJw /jrq+H93AxTXXVzIjfpnziXMD5w3/Zt9+FPlyuNjyVh2Hnlf2CbwfSqsgsJETZOx ML+CNsl/2CAXkJ1++CUQ94iC4plAPekVrpXAea4xqWqargD8Hcm0jqWuD9vns0ZA VDJU669ocBlZRVCdZI6axGm4JAdtceQLLMMVZtzre8IAELB9JPiUC/C6g7e60Cg= =oeV3
-----END PGP SIGNATURE-----

#26 lore raw
Quoted 9 lines · Rik van Riel

-----BEGIN PGP SIGNED MESSAGE-----

Quoted 2 lines · Nick Krause

I am going to resend my patch and see if it's good and if not I am going to leave for a while.

You may want to consider fixing them, by applying the advice provided by many people, before resending them.

That's just crazy talk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/88fb3e88/attachment.bin

author
#27 lore raw
Quoted 11 lines · On Tue, Sep 16, 2014 at 1:39 PM, <[email protected]> wrote:
Quoted 9 lines · Rik van Riel

-----BEGIN PGP SIGNED MESSAGE-----

Quoted 2 lines · Nick Krause

I am going to resend my patch and see if it's good and if not I am going to leave for a while.

You may want to consider fixing them, by applying the advice provided by many people, before resending them.

Quoted 7 lines

That's just crazy talk.

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I am fixing them first and them sending them out. I am going to listen now and only do them correctly.
Nick

#28 lore raw
Quoted 14 lines · Nick Krause
Quoted 13 lines · On Tue, Sep 16, 2014 at 1:39 PM, <[email protected]> wrote:
Quoted 9 lines · Rik van Riel

-----BEGIN PGP SIGNED MESSAGE-----

Quoted 2 lines · Nick Krause

I am going to resend my patch and see if it's good and if not I am going to leave for a while.

You may want to consider fixing them, by applying the advice provided by many people, before resending them.

That's just crazy talk.

Quoted 9 lines
Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I am fixing them first and them sending them out. I am going to listen now and only do them correctly.
Nick

No, you won't.

Quoted 4 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

#29 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 15 lines · Kristofer Hallin
Quoted 13 lines · Nick Krause
Quoted 11 lines · On Tue, Sep 16, 2014 at 1:39 PM, <[email protected]> wrote:
Quoted 9 lines · Rik van Riel

-----BEGIN PGP SIGNED MESSAGE-----

Quoted 2 lines · Nick Krause

I am going to resend my patch and see if it's good and if not I am going to leave for a while.

You may want to consider fixing them, by applying the advice provided by many people, before resending them.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

That's just crazy talk.

I am fixing them first and them sending them out. I am going to listen now and only do them correctly. Nick

No, you won't.

Nick,

this is a chance for you to prove the nay-sayers wrong (or right).

When re-posting your patch, you can include information on what tips you got on how to improve the patch, and how you applied that information in the new version of the patch.

This is a good idea for anybody resubmitting a changed patch, because it tells other reviewers what changes were made, why, and who pointed out the idea for the change.

- --
All rights reversed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUGIUeAAoJEM553pKExN6DEt8H/36FILPmG4wOK3TZFpQEVJHv Lxq4DLq7GBUS37PhL/wjdYnLD4RJmOhpGk+FlZBhJ0StnCvS38Su7wwyZTzgCPIS ir3EYOKhiFgEEuoB4iVaDc2FNv9jKKRVy/QK3jwkdt5oTBvr/I6YZzj2XAFJaUp9 0/RvdSNZU6kcvhTkd5xdDaaX1iOpxrggccRl+Pv2GBapeIEKvO6zk9U2GuLw+r6q OLfJ5BElpEReoqFJNUXxzT+UyTmMel21REdfyu9UxAEONrQ2A3UHx/7upy71YpyR a/IADIuBSXTdb31b+uuoFPfSUp4cs7WMyIDK2/tlL8wF28GLoL39X2xhWE3gkUU= =7mL1
-----END PGP SIGNATURE-----

#30 lore raw
Quoted 11 lines · Rik van Riel

Nick,

this is a chance for you to prove the nay-sayers wrong (or right).

When re-posting your patch, you can include information on what tips you got on how to improve the patch, and how you applied that information in the new version of the patch.

This is a good idea for anybody resubmitting a changed patch, because it tells other reviewers what changes were made, why, and who pointed out the idea for the change.

my god, rik, you're adorable. :-) i predict that, despite what i've
posted *twice*, nick will describe as an "error" what is simply a checkpatch coding style *warning*. let's watch ...

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#31 lore raw
In reply to Nick Krause
Quoted 2 lines

I am fixing them first and them sending them out. I am going to listen now and only do them correctly.

Nick, you're very close to being banned from kernelnewbies too, so please give some thought to other people's advise or else this might be your last email to kernelnewbies.

As a first step, DON'T send patches as attachments, send them INLINE in PLAIN TEXT. You need to demonstrate an understanding of this basic instruction or else nobody will be able to help you. And frankly, you need to stop fixing anything in the kernel till you get some level of proficiency in basic programming and working collaboratively in opensource projects.

Quoted 6 lines

Nick

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies