config_distro_bootcmd: Run 'scsi scan' before trying scsi
cover config_distro_bootcmd: Run 'scsi scan' before trying scsi
Hi Tom,
Here is a bug-fix patch for config_distro_bootcmd which I would like to get into v2014.10 .
Stephen, may we have your Acked-by for this one ?
Karsten, may we have your Reported-and-tested-by for this one ?
Thanks & Regards,
Hans
PATCH 1/1 config_distro_bootcmd: Run 'scsi scan' before trying scsi disks
Scsi disks need to be probed before we try to access them, otherwise all accesses fail with: ** Bad device size - scsi 0 **.
--- include/config_distro_bootcmd.h | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
include/config_distro_bootcmd.h +15 -2
@@ -53,10 +53,23 @@#endif #ifdef CONFIG_CMD_SCSI -#define BOOTENV_SHARED_SCSI BOOTENV_SHARED_BLKDEV(scsi) +#define BOOTENV_RUN_SCSI_INIT "run scsi_init; " +#define BOOTENV_SET_SCSI_NEED_INIT "setenv scsi_need_init; " +#define BOOTENV_SHARED_SCSI \ + "scsi_init=" \ + "if ${scsi_need_init}; then " \ + "setenv scsi_need_init false; " \ + "scsi scan; " \ + "fi\0" \ + \ + "scsi_boot=" \ + BOOTENV_RUN_SCSI_INIT \ + BOOTENV_SHARED_BLKDEV_BODY(scsi)#define BOOTENV_DEV_SCSI BOOTENV_DEV_BLKDEV#define BOOTENV_DEV_NAME_SCSI BOOTENV_DEV_NAME_BLKDEV#else +#define BOOTENV_RUN_SCSI_INIT +#define BOOTENV_SET_SCSI_NEED_INIT #define BOOTENV_SHARED_SCSI #define BOOTENV_DEV_SCSI \ BOOT_TARGET_DEVICES_references_SCSI_without_CONFIG_CMD_SCSI
@@ -189,7 +202,7 @@ \ BOOT_TARGET_DEVICES(BOOTENV_DEV) \ \ -"bootcmd=" BOOTENV_SET_USB_NEED_INIT \ +"bootcmd=" BOOTENV_SET_USB_NEED_INIT BOOTENV_SET_SCSI_NEED_INIT \"for target in ${boot_targets}; do " \"run bootcmd_${target}; " \"done\0"
Signature · 1 line
2.1.0
PATCH 1/1 config_distro_bootcmd: Run 'scsi scan' before trying scsi disks
Quoted 2 lines · Hans de Goede
Scsi disks need to be probed before we try to access them, otherwise all accesses fail with: ** Bad device size - scsi 0 **.
[U-Boot] config_distro_bootcmd: Run 'scsi scan' before trying scsi disks
In reply to Hans de GoedeQuoted 7 lines · Hans de Goede
Scsi disks need to be probed before we try to access them, otherwise all accesses fail with: ** Bad device size - scsi 0 **.
Reported-by Karsten Merker <[email protected]>Signed-off-by Hans de Goede <[email protected]>Reviewed-by Stephen Warren <[email protected]>Tested-by Karsten Merker <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140925/44567410/attachment.pgp>