Skip to contentSkip to conversation

extcon: sm5502: Depend on I2C

PATCH MyungJoo Ham 2 participants 2 messages Sep 16, 2014

lore
Share & tools
lore

MyungJoo Ham

author Acked-by
#0 lore raw
Quoted 6 lines

The SM5502 chip is an I2C device so its drivers must depend on I2C. Failing to do so results in build failures on kernels where I2C is not enabled.

Quoted 21 lines
---
 drivers/extcon/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/extcon/Kconfig +1 -0
@@ -72,6 +72,7 @@ config EXTCON_PALMAS
 
 config EXTCON_SM5502
 	tristate "SM5502 EXTCON support"
+	depends on I2C
 	select IRQ_DOMAIN
 	select REGMAP_I2C
 	select REGMAP_IRQ
Signature · 3 lines
-- 
Jean Delvare
SUSE L3 Support

�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

Acked-by
#1 lore raw
Quoted 8 lines · MyungJoo Ham
Quoted 6 lines

The SM5502 chip is an I2C device so its drivers must depend on I2C. Failing to do so results in build failures on kernels where I2C is not enabled.

Geert sent this same patch. I sent this same patch. What happened to those patches?

Quoted 19 lines
Quoted 19 lines
---
 drivers/extcon/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/extcon/Kconfig +1 -0
@@ -72,6 +72,7 @@ config EXTCON_PALMAS
 
 config EXTCON_SM5502
 	tristate "SM5502 EXTCON support"
+	depends on I2C
 	select IRQ_DOMAIN
 	select REGMAP_I2C
 	select REGMAP_IRQ
Signature · 3 lines
-- 
Jean Delvare
SUSE L3 Support
Signature · 1 line
~Randy