mesa3d: Add missing dependencies
PATCH 1/1 mesa3d: Add missing dependencies
Add xcb-dri3, xcb-present and xshmfence to mesa3d's dependencies. Otherwise it will fail during the configure phase.
--- package/mesa3d/Config.in | 3 +++ package/mesa3d/mesa3d.mk | 3 +++ 2 files changed, 6 insertions(+)
package/mesa3d/Config.in +3 -0
@@ -3,11 +3,14 @@ menuconfig BR2_PACKAGE_MESA3D select BR2_PACKAGE_LIBDRM select BR2_PACKAGE_EXPAT select BR2_PACKAGE_XPROTO_DRI2PROTO if BR2_PACKAGE_XORG7 + select BR2_PACKAGE_XPROTO_DRI3PROTO if BR2_PACKAGE_XORG7 + select BR2_PACKAGE_XPROTO_PRESENTPROTO if BR2_PACKAGE_XORG7 select BR2_PACKAGE_XPROTO_XF86DRIPROTO if BR2_PACKAGE_XORG7 select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7 select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7 select BR2_PACKAGE_XLIB_LIBXDAMAGE if BR2_PACKAGE_XORG7 select BR2_PACKAGE_XLIB_LIBXFIXES if BR2_PACKAGE_XORG7 + select BR2_PACKAGE_XLIB_LIBXSHMFENCE if BR2_PACKAGE_XORG7 select BR2_PACKAGE_LIBXCB if BR2_PACKAGE_XORG7 depends on BR2_PACKAGE_HAS_UDEV depends on BR2_INSTALL_LIBSTDCPP
package/mesa3d/mesa3d.mk +3 -0
@@ -28,11 +28,14 @@ ifeq ($(BR2_PACKAGE_XORG7),y) MESA3D_DEPENDENCIES += \ xproto_xf86driproto \ xproto_dri2proto \ + xproto_dri3proto \ + xproto_presentproto \ xproto_glproto \ xlib_libX11 \ xlib_libXext \ xlib_libXdamage \ xlib_libXfixes \ + xlib_libxshmfence \ libxcb MESA3D_CONF_OPT += --enable-glx # quote from mesa3d configure "Building xa requires at least one non swrast gallium driver."
Signature · 1 line
1.9.0
PATCH 1/1 mesa3d: Add missing dependencies
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Vicente" == Vicente Olivert Riera <[email protected]> writes:
Add xcb-dri3, xcb-present and xshmfence to mesa3d's dependencies. Otherwise it will fail during the configure phase.
Signed-off-by Vicente Olivert Riera <[email protected]>
hmm, but we also have optional dri3 support since:
commit 1fcc621f0344c11ebaf7903545cd99d2f5b8ec9b
Author: Bernd Kuhls <[email protected]> Date: Thu Jul 17 07:42:54 2014 +0200
package/mesa3d: Fix optional DRI3 support
Looking at configure.ac, I think we should just disable dri support if no dri drivers are enabled, E.G.:
package/mesa3d/mesa3d.mk +1 -1
@@ -75,7 +75,7 @@ endif ifeq ($(MESA3D_DRI_DRIVERS-y),) MESA3D_CONF_OPT += \ - --without-dri-drivers + --without-dri-drivers --disable-dri else ifeq ($(BR2_PACKAGE_XPROTO_DRI3PROTO),y) MESA3D_DEPENDENCIES += xlib_libxshmfence xproto_dri3proto xproto_presentproto
What do the mesa3d experts say?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 mesa3d: Add missing dependencies
Quoted 32 lines · Peter Korsgaard
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Vicente" == Vicente Olivert Riera <[email protected]> writes:
Add xcb-dri3, xcb-present and xshmfence to mesa3d's dependencies. Otherwise it will fail during the configure phase.
Signed-off-by Vicente Olivert Riera <[email protected]>hmm, but we also have optional dri3 support since:
commit
1fcc621f0344c11ebaf7903545cd99d2f5b8ec9bAuthor: Bernd Kuhls <[email protected]> Date: Thu Jul 17 07:42:54 2014 +0200package/mesa3d: Fix optional DRI3 support
Looking at configure.ac, I think we should just disable dri support if no dri drivers are enabled, E.G.:
package/mesa3d/mesa3d.mk +1
-1@@ -75,7 +75,7 @@ endif ifeq ($(MESA3D_DRI_DRIVERS-y),) MESA3D_CONF_OPT += \ - --without-dri-drivers + --without-dri-drivers --disable-dri else ifeq ($(BR2_PACKAGE_XPROTO_DRI3PROTO),y) MESA3D_DEPENDENCIES += xlib_libxshmfence xproto_dri3proto xproto_presentproto
Quoted 2 lines
What do the mesa3d experts say?
Please use this defconfig if you want to reproduce the failure:
-----------------------------------------
BR2_x86_64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
BR2_PACKAGE_QT5BASE_EXAMPLES=y
BR2_PACKAGE_QT5BASE_SQL=y
BR2_PACKAGE_QT5BASE_MYSQL=y
BR2_PACKAGE_QT5BASE_PSQL=y
BR2_PACKAGE_QT5BASE_TEST=y
BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
BR2_PACKAGE_QT5BASE_LINUXFB=y
BR2_PACKAGE_QT5BASE_DIRECTFB=y
BR2_PACKAGE_QT5BASE_XCB=y
BR2_PACKAGE_QT5BASE_PRINTSUPPORT=y
BR2_PACKAGE_QT5BASE_FONTCONFIG=y
BR2_PACKAGE_QT5BASE_GIF=y
BR2_PACKAGE_QT5BASE_JPEG=y
BR2_PACKAGE_QT5BASE_PNG=y
BR2_PACKAGE_QT5BASE_TSLIB=y
BR2_PACKAGE_QT5CONNECTIVITY=y
BR2_PACKAGE_QT5ENGINIO=y
BR2_PACKAGE_QT5GRAPHICALEFFECTS=y
BR2_PACKAGE_QT5IMAGEFORMATS=y
BR2_PACKAGE_QT5MULTIMEDIA=y
BR2_PACKAGE_QT5QUICK1=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5SENSORS=y
BR2_PACKAGE_QT5SERIALPORT=y
BR2_PACKAGE_QT5SVG=y
BR2_PACKAGE_QT5WEBKIT=y
BR2_PACKAGE_QT5WEBKIT_EXAMPLES=y
BR2_PACKAGE_QT5WEBSOCKETS=y
BR2_PACKAGE_QT5X11EXTRAS=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XSERVER_XORG_SERVER=y
BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR=y
-----------------------------------------
By the way, if you fix mesa3d and keep building the rest of the stuff, you will find a failure of qt5webkit like this one:
platform/graphics/opengl/Extensions3DOpenGLES.cpp:33:21: fatal error:EGL/egl.h: No such file or directory
It tries to include that file when the 3D_GRAPHICS macro is enabled, and that macro is enabled if Qt has opengl support. I don't know if there are more packages providing that file, but the only one I know is this one:
BR2_PACKAGE_MESA3D_OPENGL_EGL
Signature · 1 line
Vincent
PATCH 1/1 mesa3d: Add missing dependencies
In reply to Peter KorsgaardPeter Korsgaard <[email protected]> wrote in
news:87sijr8h2t.fsf at dell.be.48ers.dk:
package/mesa3d/mesa3d.mk endif · line 78
Quoted 3 lines
MESA3D_CONF_OPT+= \package/mesa3d/mesa3d.mk +1
-1- --without-dri-drivers + --without-dri-drivers --disable-dri
Hi,
Please note that enabling dri3 support in mesa3d is currently broken when used together with xdriver_xf86-video-intel:
https://github.com/OpenELEC/OpenELEC.tv/commit/b574ad91fe9c7b9fcf627df0d5e3c7
7e262a1f85#diff-87b6f34fde55cda38c8e119be89a63d4
Regards, Bernd