compulab: eeprom: add default eeprom bus

PATCH New Nikita Kiryanov 3 participants 7 messages Sep 17, 2014 – Oct 9, 2014

Share & tools

Nikita Kiryanov

author

2014-09-17 12:59 UTC #0 lore raw

PATCH 1/1 compulab: eeprom: add default eeprom bus

Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced with the addition of this setting.

Cc Albert ARIBAUD <[email protected]>

Cc Igor Grinberg <[email protected]>

Signed-off-by Nikita Kiryanov <[email protected]>

---
 board/compulab/common/eeprom.c | 4 ++++
 1 file changed, 4 insertions(+)

board/compulab/common/eeprom.c +4 -0

index 85442cd..2df3ada 100644
@@ -15,6 +15,10 @@
 # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
 #endif
 
+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS	0
+#endif
+
 #define EEPROM_LAYOUT_VER_OFFSET	44
 #define BOARD_SERIAL_OFFSET		20
 #define BOARD_SERIAL_OFFSET_LEGACY	8

Signature · 1 line

1.9.1

Igor Grinberg

2014-09-17 14:18 UTC #1 lore raw

PATCH 1/1 compulab: eeprom: add default eeprom bus

Quoted 7 lines · Nikita Kiryanov

Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced with the addition of this setting.
Cc Albert ARIBAUD <[email protected]>
Cc Igor Grinberg <[email protected]>
Signed-off-by Nikita Kiryanov <[email protected]>

Acked-by Igor Grinberg <[email protected]>

Albert, this should be a temporary fix to not break the trimslice support. We intend to rework this while switching Kconfig for all boards.

Thanks!

Quoted 20 lines

---
 board/compulab/common/eeprom.c | 4 ++++
 1 file changed, 4 insertions(+)

board/compulab/common/eeprom.c +4 -0

index 85442cd..2df3ada 100644
@@ -15,6 +15,10 @@
 # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
 #endif
 
+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS	0
+#endif
+
 #define EEPROM_LAYOUT_VER_OFFSET	44
 #define BOARD_SERIAL_OFFSET		20
 #define BOARD_SERIAL_OFFSET_LEGACY	8

Signature · 2 lines

Regards,
Igor.

Albert ARIBAUD

2014-09-18 12:26 UTC #2 lore raw

PATCH 1/1 compulab: eeprom: add default eeprom bus

Hi Igor,

Quoted 28 lines · Igor Grinberg

Quoted 7 lines · Nikita Kiryanov
Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced with the addition of this setting.
Cc Albert ARIBAUD <[email protected]>
Cc Igor Grinberg <[email protected]>
Signed-off-by Nikita Kiryanov <[email protected]>
Acked-by Igor Grinberg <[email protected]>
Albert, this should be a temporary fix to not break the trimslice support. We intend to rework this while switching Kconfig for all boards.
Thanks!
Quoted 12 lines
---
 board/compulab/common/eeprom.c | 4 ++++
 1 file changed, 4 insertions(+)
board/compulab/common/eeprom.c +0 -0
index 85442cd..2df3ada 100644
@@ -15,6 +15,10 @@
 # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
 #endif
 

Quoted 8 lines

board/compulab/common/eeprom.c line 24

Quoted 8 lines

board/compulab/common/eeprom.c +4 -0

+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS	0
+#endif
+
 #define EEPROM_LAYOUT_VER_OFFSET	44
 #define BOARD_SERIAL_OFFSET		20
 #define BOARD_SERIAL_OFFSET_LEGACY	8

a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.

Therefore I would prefer that the temporary fix be in include/configs/trimslice.h header file too.

Amicalement,

Signature · 1 line

Albert.

Nikita Kiryanov

author

2014-09-18 13:21 UTC #3 lore raw

PATCH 1/1 compulab: eeprom: add default eeprom bus

Hi ALbert,

Quoted 45 lines · Albert ARIBAUD

Hi Igor,
Quoted 28 lines · Igor Grinberg
Quoted 7 lines · Nikita Kiryanov
Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced with the addition of this setting.
Cc Albert ARIBAUD <[email protected]>
Cc Igor Grinberg <[email protected]>
Signed-off-by Nikita Kiryanov <[email protected]>
Acked-by Igor Grinberg <[email protected]>
Albert, this should be a temporary fix to not break the trimslice support. We intend to rework this while switching Kconfig for all boards.
Thanks!
Quoted 12 lines
---
  board/compulab/common/eeprom.c | 4 ++++
  1 file changed, 4 insertions(+)
board/compulab/common/eeprom.c +0 -0
index 85442cd..2df3ada 100644
@@ -15,6 +15,10 @@
  # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
  #endif
 
Quoted 8 lines
board/compulab/common/eeprom.c line 24
Quoted 8 lines
board/compulab/common/eeprom.c +4 -0
+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS	0
+#endif
+
  #define EEPROM_LAYOUT_VER_OFFSET	44
  #define BOARD_SERIAL_OFFSET		20
  #define BOARD_SERIAL_OFFSET_LEGACY	8
a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.

Quoted 3 lines

Therefore I would prefer that the temporary fix be in include/configs/trimslice.h header file too.

Given that trimslice does not use the eeprom code, I feel that it's cleaner to not populate its config file with irrelevant defines. It's also consistent with the way CONFIG_SYS_I2C_EEPROM_ADDR and CONFIG_SYS_I2C_EEPROM_ADDR_LEN are handled.

Signature · 2 lines

Regards,
Nikita Kiryanov

Albert ARIBAUD

2014-09-18 20:35 UTC #4 lore raw

PATCH 1/1 compulab: eeprom: add default eeprom bus

Hi Nikita,

Quoted 48 lines · Nikita Kiryanov

Hi ALbert,
Quoted 45 lines · Albert ARIBAUD
Hi Igor,
Quoted 28 lines · Igor Grinberg
Quoted 7 lines · Nikita Kiryanov
Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced with the addition of this setting.
Cc Albert ARIBAUD <[email protected]>
Cc Igor Grinberg <[email protected]>
Signed-off-by Nikita Kiryanov <[email protected]>
Acked-by Igor Grinberg <[email protected]>
Albert, this should be a temporary fix to not break the trimslice support. We intend to rework this while switching Kconfig for all boards.
Thanks!
Quoted 12 lines
---
  board/compulab/common/eeprom.c | 4 ++++
  1 file changed, 4 insertions(+)
board/compulab/common/eeprom.c +0 -0
index 85442cd..2df3ada 100644
@@ -15,6 +15,10 @@
  # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
  #endif
 
Quoted 8 lines
board/compulab/common/eeprom.c line 24
Quoted 8 lines
board/compulab/common/eeprom.c +4 -0
+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS	0
+#endif
+
  #define EEPROM_LAYOUT_VER_OFFSET	44
  #define BOARD_SERIAL_OFFSET		20
  #define BOARD_SERIAL_OFFSET_LEGACY	8
a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.

Quoted 8 lines

Quoted 3 lines
Therefore I would prefer that the temporary fix be in include/configs/trimslice.h header file too.
Given that trimslice does not use the eeprom code, I feel that it's cleaner to not populate its config file with irrelevant defines. It's also consistent with the way CONFIG_SYS_I2C_EEPROM_ADDR and CONFIG_SYS_I2C_EEPROM_ADDR_LEN are handled.

Makes sense enough.

Amicalement,

Signature · 1 line

Albert.

Nikita Kiryanov

author

2014-10-08 12:03 UTC #5 lore raw

PATCH 1/1 compulab: eeprom: add default eeprom bus

Gentle ping.

Quoted 66 lines · Albert ARIBAUD

Hi Nikita,
Quoted 48 lines · Nikita Kiryanov
Hi ALbert,
Quoted 45 lines · Albert ARIBAUD
Hi Igor,
Quoted 28 lines · Igor Grinberg
Quoted 7 lines · Nikita Kiryanov
Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced with the addition of this setting.
Cc Albert ARIBAUD <[email protected]>
Cc Igor Grinberg <[email protected]>
Signed-off-by Nikita Kiryanov <[email protected]>
Acked-by Igor Grinberg <[email protected]>
Albert, this should be a temporary fix to not break the trimslice support. We intend to rework this while switching Kconfig for all boards.
Thanks!
Quoted 12 lines
---
   board/compulab/common/eeprom.c | 4 ++++
   1 file changed, 4 insertions(+)
board/compulab/common/eeprom.c +0 -0
index 85442cd..2df3ada 100644
@@ -15,6 +15,10 @@
   # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
   #endif
 
Quoted 8 lines
board/compulab/common/eeprom.c line 24
Quoted 8 lines
board/compulab/common/eeprom.c +4 -0
+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS	0
+#endif
+
   #define EEPROM_LAYOUT_VER_OFFSET	44
   #define BOARD_SERIAL_OFFSET		20
   #define BOARD_SERIAL_OFFSET_LEGACY	8
a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.
Quoted 8 lines
Quoted 3 lines
Therefore I would prefer that the temporary fix be in include/configs/trimslice.h header file too.
Given that trimslice does not use the eeprom code, I feel that it's cleaner to not populate its config file with irrelevant defines. It's also consistent with the way CONFIG_SYS_I2C_EEPROM_ADDR and CONFIG_SYS_I2C_EEPROM_ADDR_LEN are handled.
Makes sense enough.
Amicalement,

Signature · 2 lines

Regards,
Nikita Kiryanov

Albert ARIBAUD

2014-10-09 08:50 UTC #6 lore raw

PATCH 1/1 compulab: eeprom: add default eeprom bus

In reply to Nikita Kiryanov

Hi Nikita,

Quoted 16 lines · Nikita Kiryanov

Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced with the addition of this setting.
Cc Albert ARIBAUD <[email protected]>
Cc Igor Grinberg <[email protected]>
Signed-off-by Nikita Kiryanov <[email protected]>
---
 board/compulab/common/eeprom.c | 4 ++++
 1 file changed, 4 insertions(+)
board/compulab/common/eeprom.c +0 -0
index 85442cd..2df3ada 100644

board/compulab/common/eeprom.c line 24

Quoted 10 lines

board/compulab/common/eeprom.c +4 -0

@@ -15,6 +15,10 @@
 # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
 #endif
 
+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS	0
+#endif
+
 #define EEPROM_LAYOUT_VER_OFFSET	44
 #define BOARD_SERIAL_OFFSET		20
 #define BOARD_SERIAL_OFFSET_LEGACY	8

Applied to u-boot-arm/master, thanks!

Unclean builds now down from 6 to 5 (openrd_client openrd_ultimate tricorder_flash openrd_base tricorder)

Amicalement,

Signature · 1 line

Albert.