selftests/memfd: Run test on all architectures
PATCH 1/1 selftests/memfd: Run test on all architectures
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.
--- tools/testing/selftests/memfd/Makefile | 21 --------------------- 1 file changed, 21 deletions(-)
tools/testing/selftests/memfd/Makefile +0 -21
@@ -1,38 +1,17 @@ -uname_M := $(shell uname -m 2>/dev/null || echo not) -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) -ifeq ($(ARCH),i386) - ARCH := x86 -endif -ifeq ($(ARCH),x86_64) - ARCH := x86 -endif - CFLAGS += -D_FILE_OFFSET_BITS=64 -CFLAGS += -I../../../../arch/x86/include/generated/uapi/ -CFLAGS += -I../../../../arch/x86/include/uapi/ CFLAGS += -I../../../../include/uapi/ CFLAGS += -I../../../../include/ all: -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_tests: all -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -endif @./memfd_test || echo "memfd_test: [FAIL]" build_fuse: -ifeq ($(ARCH),x86) gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt gcc $(CFLAGS) fuse_test.c -o fuse_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_fuse: build_fuse @./run_fuse_test.sh || echo "fuse_test: [FAIL]"
Signature · 1 line
2.1.0
Hi
Quoted 3 lines · Pranith Kumar
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.
Signed-off-by Pranith Kumar <[email protected]>
Now that most archs have __NR_memfd_create, this is:
Thanks
David
Quoted 50 lines
--- tools/testing/selftests/memfd/Makefile | 21 --------------------- 1 file changed, 21 deletions(-)tools/testing/selftests/memfd/Makefile +0
-22@@ -1,38 +1,17 @@ -uname_M := $(shell uname -m 2>/dev/null || echo not) -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) -ifeq ($(ARCH),i386) - ARCH := x86 -endif -ifeq ($(ARCH),x86_64) - ARCH := x86 -endif - CFLAGS += -D_FILE_OFFSET_BITS=64 -CFLAGS += -I../../../../arch/x86/include/generated/uapi/ -CFLAGS += -I../../../../arch/x86/include/uapi/ CFLAGS += -I../../../../include/uapi/ CFLAGS += -I../../../../include/ all: -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_tests: all -ifeq ($(ARCH),x86) gcc $(CFLAGS) memfd_test.c -o memfd_test -endif @./memfd_test || echo "memfd_test: [FAIL]" build_fuse: -ifeq ($(ARCH),x86) gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt gcc $(CFLAGS) fuse_test.c -o fuse_test -else - echo "Not an x86 target, can't build memfd selftest" -endif run_fuse: build_fuse @./run_fuse_test.sh || echo "fuse_test: [FAIL]" --2.1.0
Quoted 11 lines · David Herrmann
Hi
Quoted 3 lines · Pranith Kumar
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.
Signed-off-by Pranith Kumar <[email protected]>Now that most archs have
__NR_memfd_create, this is:Reviewed-by David Herrmann <[email protected]>
Hmm. I am seeing failures on x86_64 on top of Linus's tree (without this patch)
make -C tools/testing/selftests/memfd/make: Entering directory `/lkml/linus_git_3.14/tools/testing/selftests/memfd'
gcc -D_FILE_OFFSET_BITS=64 -I../../../../arch/x86/include/generated/uapi/ -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ -I../../../../include/ memfd_test.c -o memfd_test memfd_test.c: In function ‘sys_memfd_create’:
memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in this function)
return syscall(__NR_memfd_create, name, flags);
^memfd_test.c:26:17: note: each undeclared identifier is reported only once for each function it appears in
Could you please look into this?? It appears __NR_memfd_create isn't defined on x86_64???
thanks,
-- Shuah
Signature · 4 lines
Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978
Quoted 12 lines · Shuah Khan
Hmm. I am seeing failures on
x86_64on top of Linus's tree (without this patch)make -C
tools/testing/selftests/memfd/make: Entering directory `/lkml/linus_git_3.14/tools/testing/selftests/memfd' gcc -D_FILE_OFFSET_BITS=64(quoted diff) +0
-3-I../../../../arch/x86/include/generated/uapi/ -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ -I../../../../include/ memfd_test.c -o memfd_test
memfd_test.c: In function ‘sys_memfd_create’:
memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in this function)
Quoted 8 lines
return syscall(__NR_memfd_create, name, flags); ^memfd_test.c:26:17: note: each undeclared identifier is reported only once for each function it appears in
Could you please look into this?? It appears
__NR_memfd_createisn't defined onx86_64???
Hi Shuah,
Did you compile the tree before trying to compile this test? Compiling the kernel will generate the required symbols which are used in this test.
Thanks!
Signature · 1 line
Pranith
Hi
Quoted 25 lines · Shuah Khan
Quoted 11 lines · David Herrmann
Hi
Quoted 3 lines · Pranith Kumar
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.
Signed-off-by Pranith Kumar <[email protected]>Now that most archs have
__NR_memfd_create, this is:Reviewed-by David Herrmann <[email protected]>Hmm. I am seeing failures on
x86_64on top of Linus's tree (without this patch)make -C
tools/testing/selftests/memfd/make: Entering directory `/lkml/linus_git_3.14/tools/testing/selftests/memfd' gcc -D_FILE_OFFSET_BITS=64(quoted diff) +0
-3-I../../../../arch/x86/include/generated/uapi/ -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ -I../../../../include/ memfd_test.c -o memfd_test
memfd_test.c: In function ‘sys_memfd_create’:
memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in this function)
Quoted 7 lines
return syscall(__NR_memfd_create, name, flags); ^memfd_test.c:26:17: note: each undeclared identifier is reported only once for each function it appears in
Could you please look into this?? It appears
__NR_memfd_createisn't defined onx86_64???
You need the headers installed in your system. By dropping the arch-includes from the Makefile, we require 3.17 headers in /usr/include.
Thanks
David
Quoted 33 lines · David Herrmann
Hi
Quoted 30 lines · Shuah Khan
Quoted 11 lines · David Herrmann
Hi
Quoted 3 lines · Pranith Kumar
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.
Signed-off-by Pranith Kumar <[email protected]>Now that most archs have
__NR_memfd_create, this is:Reviewed-by David Herrmann <[email protected]>Hmm. I am seeing failures on
x86_64on top of Linus's tree (without this patch)make -C
tools/testing/selftests/memfd/make: Entering directory `/lkml/linus_git_3.14/tools/testing/selftests/memfd' gcc -D_FILE_OFFSET_BITS=64(quoted diff) +0
-3-I../../../../arch/x86/include/generated/uapi/ -I../../../../arch/x86/include/uapi/ -I../../../../include/uapi/ -I../../../../include/ memfd_test.c -o memfd_test
memfd_test.c: In function ‘sys_memfd_create’:
memfd_test.c:26:17: error: ‘__NR_memfd_create’ undeclared (first use in this function)return syscall(__NR_memfd_create, name, flags); ^memfd_test.c:26:17: note: each undeclared identifier is reported only once for each function it appears in
Quoted 7 lines
Quoted 2 lines
Could you please look into this?? It appears
__NR_memfd_createisn't defined onx86_64???You need the headers installed in your system. By dropping the arch-includes from the
Makefile, we require 3.17 headers in/usr/include.
Sorry - wrong system without the headers installed. My bad.
-- Shuah
Signature · 4 lines
Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978