Skip to contentSkip to conversation

ARM: DT: ifc6410: Add board memory range.

PATCH New Srinivas Kandagatla 5 participants 7 messages Sep 17, 2014 – Sep 18, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: DT: ifc6410: Add board memory range.

This patch adds memory details of IFC6410 as this is necessary to fix the in-correct memory start comming from ATAGs.

---
 arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +5 -0
index 90db8af..3287f12 100644
@@ -4,6 +4,11 @@
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
 
+	memory{
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
 	soc {
 		gsbi at 16600000 {
 			status = "ok";
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: DT: ifc6410: Add board memory range.

Hi Srini,

Thanks for the patch.

A minor nit.

Quoted 13 lines · Srinivas Kandagatla

This patch adds memory details of IFC6410 as this is necessary to fix the in-correct memory start comming from ATAGs.

---
 arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -0
index 90db8af..3287f12 100644

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts line 7

Quoted 4 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +1 -0
@@ -4,6 +4,11 @@
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
 
+	memory{

Space before {?

Quoted 8 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +4 -0
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
 	soc {
 		gsbi@16600000 {
 			status = "ok";
#2 lore raw

PATCH 1/1 ARM: DT: ifc6410: Add board memory range.

Quoted 25 lines · Pramod Gurav

Hi Srini,

Thanks for the patch.

A minor nit.

Quoted 13 lines · Srinivas Kandagatla

This patch adds memory details of IFC6410 as this is necessary to fix the in-correct memory start comming from ATAGs.

---
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++

1 file changed, 5 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -0
index 90db8af..3287f12 100644

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts line 7

Quoted 4 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +1 -0
@@ -4,6 +4,11 @@
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
 
+	memory{

Space before {?

Quoted 7 lines

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts

Quoted 7 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +4 -0
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
 	soc {
 		gsbi at 16600000 {
 			status = "ok?;

Hmm, this doesn?t seem to work for me.

- k

Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#3 lore raw

PATCH 1/1 ARM: DT: ifc6410: Add board memory range.

Quoted 20 lines · Kumar Gala
Quoted 19 lines · Pramod Gurav
Quoted 13 lines · Srinivas Kandagatla

This patch adds memory details of IFC6410 as this is necessary to fix the in-correct memory start comming from ATAGs.

---
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++

1 file changed, 5 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -0
index 90db8af..3287f12 100644

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts line 7

Quoted 4 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +1 -0
@@ -4,6 +4,11 @@
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
 
+	memory{

Space before {?

Quoted 9 lines
Quoted 7 lines

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts

Quoted 7 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +4 -0
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
 	soc {
 		gsbi at 16600000 {
 			status = "ok?;

Hmm, this doesn?t seem to work for me.

I don't see how it could with qcom_defconfig, as we set CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
#4 lore raw

PATCH 1/1 ARM: DT: ifc6410: Add board memory range.

Quoted 31 lines · Josh Cartwright
Quoted 20 lines · Kumar Gala
Quoted 19 lines · Pramod Gurav
Quoted 13 lines · Srinivas Kandagatla

This patch adds memory details of IFC6410 as this is necessary to fix the in-correct memory start comming from ATAGs.

---
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++

1 file changed, 5 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -0
index 90db8af..3287f12 100644

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts line 7

Quoted 4 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +1 -0
@@ -4,6 +4,11 @@
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
 
+	memory{

Space before {?

Quoted 9 lines
Quoted 7 lines

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts

Quoted 7 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +4 -0
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
 	soc {
 		gsbi at 16600000 {
 			status = "ok?;

Hmm, this doesn?t seem to work for me.

Quoted 2 lines

I don't see how it could with qcom_defconfig, as we set CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?

No, its not fixing any thing by itself.

However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM" patch atleast I get to boot my IFC6410 with multi_v7_defconfig.

Quoted 1 line
#5 lore raw

PATCH 1/1 ARM: DT: ifc6410: Add board memory range.

Quoted 5 lines · Srinivas Kandagatla
Quoted 2 lines · Josh Cartwright

On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote:

[..]

Quoted 10 lines
Quoted 5 lines
Quoted 1 line

Hmm, this doesn?t seem to work for me.

I don't see how it could with qcom_defconfig, as we set CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?

No, its not fixing any thing by itself.

However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM" patch atleast I get to boot my IFC6410 with multi_v7_defconfig.

But that patch was rejected by various people.
Instead have a look at [1], it solves the problem for you (and have reference to the original source).

[1] https://github.com/andersson/kernel/commit/d4c0061cf7be8a341e6d06a97c85ecb69284e74c

Regards,
Bjorn

#6 lore raw

PATCH 1/1 ARM: DT: ifc6410: Add board memory range.

Quoted 16 lines · Bjorn Andersson
Quoted 5 lines · Srinivas Kandagatla
Quoted 2 lines · Josh Cartwright

On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote:

[..]

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Hmm, this doesn?t seem to work for me.

I don't see how it could with qcom_defconfig, as we set CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?

No, its not fixing any thing by itself.

Quoted 8 lines
Quoted 2 lines

However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM" patch atleast I get to boot my IFC6410 with multi_v7_defconfig.

But that patch was rejected by various people.
Instead have a look at [1], it solves the problem for you (and have reference to the original source).

[1] https://github.com/andersson/kernel/commit/d4c0061cf7be8a341e6d06a97c85ecb69284e74c

Looks cool.. I think we can ignore this patch with this fixup. On IFC6410 now that we have some way to unbrick the board we could even try to fix this at bootloader level.

Thanks to Kumar and You for redirecting me to this link.

--srini

Quoted 4 lines

Regards,
Bjorn