Skip to contentSkip to conversation

compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus")

U-Boot Stephen Warren 2 participants 2 messages Sep 18, 2014 – Sep 19, 2014

lore
Share & tools
lore
#0 lore raw

After commit 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus"), the trimslice board fails to build with:

.../board/compulab/common/eeprom.c: In function ?cl_eeprom_read?:
.../board/compulab/common/eeprom.c:37:24: error:
?CONFIG_SYS_I2C_EEPROM_BUS? undeclared (first use in this function) .../board/compulab/common/eeprom.c:37:24: note: each undeclared identifier is reported only once for each function it appears in

I have no idea if this EEPROM code should even run on TrimSlice or not. Can you take a look at the correct fix?

#1 lore raw

Hi Stephen,

Quoted 7 lines · Stephen Warren

After commit 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus"), the trimslice board fails to build with:

.../board/compulab/common/eeprom.c: In function ?cl_eeprom_read?:
.../board/compulab/common/eeprom.c:37:24: error: ?CONFIG_SYS_I2C_EEPROM_BUS? undeclared (first use in this function) .../board/compulab/common/eeprom.c:37:24: note: each undeclared identifier is reported only once for each function it appears in

I have no idea if this EEPROM code should even run on TrimSlice or not. Can you take a look at the correct fix?

We have already submitted a temporary fix, see [1]. The intend is to switch to Kconfig for all CompuLab boards and that will bring the proper fix for the problem. After this, the temporary fixes can be removed.

[1] https://patchwork.ozlabs.org/patch/390381/

Signature · 2 lines
Regards,
Igor.