cgroup: fix missing unlock in cgroup_release_agent()
PATCH 1/1 cgroup: fix missing unlock in cgroup_release_agent()
The patch 971ff4935538: "cgroup: use a per-cgroup work for release agent" from Sep 18, 2014, leads to the following static checker warning:
kernel/cgroup.c:5310 cgroup_release_agent() warn: 'mutex:&cgroup_mutex' is sometimes locked here and sometimes unlocked.
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Zefan Li <[email protected]>
--- kernel/cgroup.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/cgroup.c +3 -0
@@ -5290,7 +5290,10 @@ static void cgroup_release_agent(struct work_struct *work)mutex_unlock (&cgroup_mutex);call_usermodehelper (argv[0 ], argv, envp,UMH_WAIT_EXEC ); + goto out_free; out: +mutex_unlock (&cgroup_mutex); +out_free:kfree (agentbuf);kfree (pathbuf); }
Signature · 1 line
1.8.0.2
Quoted 9 lines · Zefan Li
The patch
971ff4935538: "cgroup: use a per-cgroup work for release agent" from Sep 18, 2014, leads to the following static checker warning:kernel/cgroup.c:5310 cgroup_release_agent() warn: 'mutex:&cgroup_mutex' is sometimes locked here and sometimes unlocked.Reported-by Dan Carpenter <[email protected]>Signed-off-by Zefan Li <[email protected]>
Applied to cgroup/for-3.18.
Thanks.
Signature · 1 line
tejun