Skip to contentSkip to conversation

stagging : rtl8821ae : Fixed sparse warning

PATCH In review Jerry Stralko 2 participants 4 messages Sep 23, 2014 – Oct 2, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stagging : rtl8821ae : Fixed sparse warning

Symbol was not declared. Should it be static?

Signed-off-by Jerry Stralko
---
 drivers/staging/rtl8821ae/base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8821ae/base.c +2 -2
index 4a36da0..dea3c4b 100644
@@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
 
 /* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
 /* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
-struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
+static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
 				     enum ieee80211_smps_mode smps,
 				     u8 *da, u8 *bssid)
 {
@@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
 	return matched;
 }
 
-bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
+static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
 		unsigned int len)
 {
 	struct ieee80211_mgmt *mgmt = (void *)data;
Signature · 1 line
1.9.3
#1 lore raw
Quoted 21 lines · Jerry Stralko

Symbol was not declared. Should it be static?

Signed-off-by Jerry Stralko
---
 drivers/staging/rtl8821ae/base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8821ae/base.c +1 -1
index 4a36da0..dea3c4b 100644
@@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
 
 /* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
 /* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
-struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
+static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
 				     enum ieee80211_smps_mode smps,
 				     u8 *da, u8 *bssid)
 {

drivers/staging/rtl8821ae/base.c static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw, · line 1546

Quoted 8 lines
drivers/staging/rtl8821ae/base.c +1 -1
@@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
 	return matched;
 }
 
-bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
+static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
 		unsigned int len)
 {
 	struct ieee80211_mgmt *mgmt = (void *)data;

Ping?

maintainer
#2 lore raw
Quoted 25 lines · Jerry Stralko
Quoted 24 lines · Jerry Stralko

Symbol was not declared. Should it be static?

Signed-off-by Jerry Stralko
---
 drivers/staging/rtl8821ae/base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8821ae/base.c +1 -1
index 4a36da0..dea3c4b 100644
@@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
 
 /* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
 /* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
-struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
+static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
 				     enum ieee80211_smps_mode smps,
 				     u8 *da, u8 *bssid)
 {
@@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
 	return matched;
 }
 
Quoted 7 lines

drivers/staging/rtl8821ae/base.c static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw, · line 1546

Quoted 5 lines
drivers/staging/rtl8821ae/base.c +1 -1
-bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
+static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
 		unsigned int len)
 {
 	struct ieee80211_mgmt *mgmt = (void *)data;

Ping?

This fell out of my scripts due to the misspelled subject line, sorry. I'll queue it up when I get a chance to go through the rest of the "staging" patches, after 3.18-rc1 is out.

thanks,

greg k-h

maintainer
#3 lore raw
In reply to Jerry Stralko
Quoted 6 lines · Jerry Stralko

Symbol was not declared. Should it be static?

Signed-off-by Jerry Stralko
---
 drivers/staging/rtl8821ae/base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This driver is no longer in the kernel tree :(