Skip to contentSkip to conversation

drm/i915: intel_backlight scale() math WA

PATCH In review Joe Konno 3 participants 4 messages Sep 23, 2014 – Sep 24, 2014

Subsystems (2)
lore
Share & tools
lore

Joe Konno

author
#0 lore raw

PATCH 1/1 drm/i915: intel_backlight scale() math WA

From: Joe Konno <[email protected]>

Improper integer division-- truncated rather than rounded-- in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

---
 drivers/gpu/drm/i915/intel_panel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +2 -1
index f17ada3..c40f837 100644
@@ -421,7 +421,8 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = (target_val + ((source_max - source_min) / 2)) /
+		(source_max - source_min);
 	target_val += target_min;
 
 	return target_val;
Signature · 1 line
2.1.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper integer division-- truncated rather than rounded-- in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

Quoted 8 lines

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

Quoted 19 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +2 -1
index f17ada3..c40f837 100644
@@ -421,7 +421,8 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = (target_val + ((source_max - source_min) / 2)) /
+		(source_max - source_min);
 	target_val += target_min;
 
 	return target_val;
#2 lore raw
In reply to Joe Konno
Quoted 3 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper integer division-- truncated rather than rounded-- in the

That's confusing. It reads that you are converting to using truncated, rather than to rounding.

Quoted 22 lines

scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

---
 drivers/gpu/drm/i915/intel_panel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..c40f837 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 425

Quoted 6 lines
drivers/gpu/drm/i915/intel_panel.c +2 -1
@@ -421,7 +421,8 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = (target_val + ((source_max - source_min) / 2)) /
+		(source_max - source_min);

target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);

Quoted 3 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	target_val += target_min;
 
 	return target_val;
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
author
#3 lore raw

Many thanks, Chris. I'll incorporate your feedback into v2.

Quoted 40 lines · Chris Wilson
Quoted 3 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper integer division-- truncated rather than rounded-- in the

That's confusing. It reads that you are converting to using truncated, rather than to rounding.

Quoted 22 lines

scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

---
 drivers/gpu/drm/i915/intel_panel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..c40f837 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 425

Quoted 6 lines
drivers/gpu/drm/i915/intel_panel.c +2 -1
@@ -421,7 +421,8 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = (target_val + ((source_max - source_min) / 2)) /
+		(source_max - source_min);

target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);

Quoted 3 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	target_val += target_min;
 
 	return target_val;