Skip to contentSkip to conversation

ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks

PATCH RESEND New Ludovic Desroches 2 participants 2 messages Sep 22, 2014 – Sep 24, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks

When introducing support for sama5d3, the write to PMC_PCDR register has been accidentally removed.

---

Sorry for the noise, typo in the cc list!

Ludovic

 arch/arm/mach-at91/clock.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-at91/clock.c +1 -0
index 034529d..d66f102 100644
@@ -962,6 +962,7 @@ static int __init at91_clock_reset(void)
 	}
 
 	at91_pmc_write(AT91_PMC_SCDR, scdr);
+	at91_pmc_write(AT91_PMC_PCDR, pcdr);
 	if (cpu_is_sama5d3())
 		at91_pmc_write(AT91_PMC_PCDR1, pcdr1);
 
Signature · 1 line
2.0.3
#1 lore raw

PATCH RESEND 1/1 ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks

On 22/09/2014 15:51, Ludovic Desroches :

Quoted 6 lines

When introducing support for sama5d3, the write to PMC_PCDR register has been accidentally removed.

Absolutely: thanks for the fix!

I queue it in at91-3.18-fixes-non-critical branch and it may show-up in 3.18 or 3.19.

Best regards,

Quoted 22 lines

---

Sorry for the noise, typo in the cc list!

Ludovic

 arch/arm/mach-at91/clock.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-at91/clock.c +1 -0
index 034529d..d66f102 100644
@@ -962,6 +962,7 @@ static int __init at91_clock_reset(void)
 	}
 
 	at91_pmc_write(AT91_PMC_SCDR, scdr);
+	at91_pmc_write(AT91_PMC_PCDR, pcdr);
 	if (cpu_is_sama5d3())
 		at91_pmc_write(AT91_PMC_PCDR1, pcdr1);
 
Signature · 1 line
Nicolas Ferre