Adding selftest testdata dynamically into live tree

DISCUSSION Janusz Użycki 4 participants 6 messages Sep 22, 2014 – Sep 26, 2014 3 messages not in the archive Kbuild

Share & tools

Janusz Użycki

author

2014-09-22 18:05 UTC #0 lore raw

Hi.

On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled zImage is recreated every time I call "make" despite I've not done any change in source files and zImage was the same. This is caused by the rm line:

  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  DTC     drivers/of/testcase-data/testcases.dtb
  DTB     drivers/of/testcase-data/testcases.dtb.S
  AS      drivers/of/testcase-data/testcases.dtb.o
  LD      drivers/of/of_selftest.o
  LD      drivers/of/built-in.o
rm drivers/of/testcase-data/testcases.dtb.S drivers/of/testcase-data/testcases.dtb
  LD      drivers/built-in.o
  LINK    vmlinux
  LD      vmlinux.o

best regards
Janusz

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Gaurav Minocha

2014-09-24 18:03 UTC #2 lore raw

Quoted 6 lines · Janusz Użycki

Hi.
On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled zImage is recreated every time I call "make" despite I've not done any change in source files and zImage was the same. This is caused by the rm line:

I believe the make rule compiles test data without checking whether the test data dts files have been changed or not.

I am not sure how to fix it. So, either direct me or feel free to pick it. Thanks!

Quoted 13 lines

  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  DTC     drivers/of/testcase-data/testcases.dtb
  DTB     drivers/of/testcase-data/testcases.dtb.S
  AS      drivers/of/testcase-data/testcases.dtb.o
  LD      drivers/of/of_selftest.o
  LD      drivers/of/built-in.o
rm drivers/of/testcase-data/testcases.dtb.S
drivers/of/testcase-data/testcases.dtb
  LD      drivers/built-in.o
  LINK    vmlinux
  LD      vmlinux.o

Quoted 3 lines

best regards
Janusz

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CA+rpMbKkS1D=QYSMftgZyTMbHS9+O=YjR+OL_RvzjJPjo2Ox6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Janusz Użycki

author

2014-09-24 18:05 UTC #4 lore raw

W dniu 2014-09-24 20:03, Gaurav Minocha pisze:

Quoted 7 lines · Janusz Użycki

Quoted 6 lines
Hi.
On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled zImage is recreated every time I call "make" despite I've not done any change in source files and zImage was the same. This is caused by the rm line:

Quoted 5 lines

I believe the make rule compiles test data without checking whether the test data dts files have been changed or not.
I am not sure how to fix it. So, either direct me or feel free to pick it. Thanks!

I just disabled CONFIG_OF_SELFTEST now and it works for me.

best regards
Janusz

Quoted 14 lines

   CALL    scripts/checksyscalls.sh
   CHK     include/generated/compile.h
   DTC     drivers/of/testcase-data/testcases.dtb
   DTB     drivers/of/testcase-data/testcases.dtb.S
   AS      drivers/of/testcase-data/testcases.dtb.o
   LD      drivers/of/of_selftest.o
   LD      drivers/of/built-in.o
rm drivers/of/testcase-data/testcases.dtb.S
drivers/of/testcase-data/testcases.dtb
   LD      drivers/built-in.o
   LINK    vmlinux
   LD      vmlinux.o

Quoted 3 lines

Quoted 3 lines
best regards
Janusz

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Grant Likely

2014-09-26 12:09 UTC #5 lore raw

In reply to a message not in the archive

Quoted 6 lines · Janusz UÅ¼ycki

Hi.
On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled zImage is recreated every time I call "make" despite I've not done any change in source files and zImage was the same. This is caused by the rm line:

Quoted 12 lines

   CALL    scripts/checksyscalls.sh
   CHK     include/generated/compile.h
   DTC     drivers/of/testcase-data/testcases.dtb
   DTB     drivers/of/testcase-data/testcases.dtb.S
   AS      drivers/of/testcase-data/testcases.dtb.o
   LD      drivers/of/of_selftest.o
   LD      drivers/of/built-in.o
rm drivers/of/testcase-data/testcases.dtb.S 
drivers/of/testcase-data/testcases.dtb
   LD      drivers/built-in.o
   LINK    vmlinux
   LD      vmlinux.o

Try this change:

scripts/Makefile.lib +1 -1

index 260bf8acfce9..4555e2e1b4ed 100644
@@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
 		-d $(depfile).dtc.tmp $(dtc-tmp) ; \
 	cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
 
-$(obj)/%.dtb: $(src)/%.dts FORCE
+$(obj)/%.dtb: $(src)/%.dts
 	$(call if_changed_dep,dtc)
 
 dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20140926120917.B60B4C40FEB-WNowdnHR2B42iJbIjFUEsiwD8/[email protected]

Janusz Użycki

author

2014-09-26 13:36 UTC #7 lore raw

The patch didn't help. Exactly the same.

best regards
Janusz

W dniu 2014-09-26 14:09, Grant Likely pisze:

Quoted 27 lines · Janusz Użycki

Quoted 6 lines
Hi.
On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled zImage is recreated every time I call "make" despite I've not done any change in source files and zImage was the same. This is caused by the rm line:
Quoted 12 lines
    CALL    scripts/checksyscalls.sh
    CHK     include/generated/compile.h
    DTC     drivers/of/testcase-data/testcases.dtb
    DTB     drivers/of/testcase-data/testcases.dtb.S
    AS      drivers/of/testcase-data/testcases.dtb.o
    LD      drivers/of/of_selftest.o
    LD      drivers/of/built-in.o
rm drivers/of/testcase-data/testcases.dtb.S
drivers/of/testcase-data/testcases.dtb
    LD      drivers/built-in.o
    LINK    vmlinux
    LD      vmlinux.o
Try this change:
scripts/Makefile.lib +0 -0
index 260bf8acfce9..4555e2e1b4ed 100644

scripts/Makefile.lib cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \ · line 275

Quoted 8 lines

scripts/Makefile.lib +1 -1

@@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
  		-d $(depfile).dtc.tmp $(dtc-tmp) ; \
  	cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
 
-$(obj)/%.dtb: $(src)/%.dts FORCE
+$(obj)/%.dtb: $(src)/%.dts
  	$(call if_changed_dep,dtc)
 
  dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Grant Likely

2014-09-26 15:07 UTC #8 lore raw

Quoted 1 line · Janusz Użycki

The patch didn't help. Exactly the same.

Odd it worked here. It's moot anyway though because it breaks checking dependencies on .dts files. I need someone stronger on kbuild-foo to figure this out out. I've cc'd Michal and the kbuild mailing list. Hopefully someone there can help figure this out.

Quoted 30 lines

best regards
Janusz
W dniu 2014-09-26 14:09, Grant Likely pisze:
Quoted 24 lines
Quoted 7 lines · Janusz Użycki
Hi.
On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled zImage is recreated every time I call "make" despite I've not done any change in source files and zImage was the same. This is caused by the rm line:
Quoted 12 lines
    CALL    scripts/checksyscalls.sh
    CHK     include/generated/compile.h
    DTC     drivers/of/testcase-data/testcases.dtb
    DTB     drivers/of/testcase-data/testcases.dtb.S
    AS      drivers/of/testcase-data/testcases.dtb.o
    LD      drivers/of/of_selftest.o
    LD      drivers/of/built-in.o
rm drivers/of/testcase-data/testcases.dtb.S
drivers/of/testcase-data/testcases.dtb
    LD      drivers/built-in.o
    LINK    vmlinux
    LD      vmlinux.o
Try this change:

Quoted 14 lines

scripts/Makefile.lib cmd_dtc = $(CPP) $(dtc_cpp_flags) -x · line 275

Quoted 13 lines

scripts/Makefile.lib +1 -0

index 260bf8acfce9..4555e2e1b4ed 100644
@@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x
 assembler-with-cpp -o $(dtc-tmp) $< ; \
                -d $(depfile).dtc.tmp $(dtc-tmp) ; \
        cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
  -$(obj)/%.dtb: $(src)/%.dts FORCE
+$(obj)/%.dtb: $(src)/%.dts
        $(call if_changed_dep,dtc)
    dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html