Skip to contentSkip to conversation

MAINTAINERS: handle buildsystem

PATCH In review Olaf Hering 4 participants 11 messages Sep 25, 2014 – Oct 1, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: handle buildsystem

Tweaking configure and friends is most likely not of much interest for anyone beside the tools maintainers.

Add a new section with files which are currently covered by "THE REST". Also update list of stubdom related files.

Cc Ian Campbell <[email protected]>
Cc Ian Jackson <[email protected]>
Cc Jan Beulich <[email protected]>
Cc Keir Fraser <[email protected]>
Cc Tim Deegan <[email protected]>

---

Please adjust the "M:" list as required if this patch gets applied.

 MAINTAINERS | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
MAINTAINERS +23 -0
index bf6b099..a6f4d35 100644
@@ -138,6 +138,26 @@ F:	xen/drivers/char/omap-uart.c
 F:	xen/drivers/char/pl011.c
 F:	xen/drivers/passthrough/arm/
 
+BUILD SYSTEM
+M:	Ian Campbell <[email protected]>
+M:	Stefano Stabellini <[email protected]>
+M:	Ian Jackson <[email protected]>
+S:	Supported
+L:	[email protected]
+F:	.gitignore
+F:	config/Docs.mk.in
+F:	config/Paths.mk.in
+F:	config/Stubdom.mk.in
+F:	config/Tools.mk.in
+F:	config/Toplevel.mk.in
+F:	m4/
+F:	configure
+F:	configure.ac
+F:	stubdom/configure
+F:	stubdom/configure.ac
+F:	tools/configure
+F:	tools/configure.ac
+
 CPU POOLS
 M:	Juergen Gross <[email protected]>
 S:	Supported
@@ -228,6 +248,7 @@ MINI-OS
 M:	Stefano Stabellini <[email protected]>
 M:	Samuel Thibault <[email protected]>
 S:	Supported
+F:	config/MiniOS.mk
 F:	extras/mini-os/
 
 OCAML TOOLS
@@ -277,6 +298,8 @@ STUB DOMAINS
 M:	Stefano Stabellini <[email protected]>
 M:	Samuel Thibault <[email protected]>
 S:	Supported
+F:	config/Stubdom.mk.in
+F:	m4/stubdom.m4
 F:	stubdom/
 
 TOOLSTACK
#1 lore raw
Quoted 16 lines
Quoted 1 line
Quoted 1 line · On 25.09.14 at 10:59, <[email protected]> wrote:
MAINTAINERS +9 -0
@@ -138,6 +138,26 @@ F:	xen/drivers/char/omap-uart.c
 F:	xen/drivers/char/pl011.c
 F:	xen/drivers/passthrough/arm/
 
+BUILD SYSTEM
+M:	Ian Campbell <[email protected]>
+M:	Stefano Stabellini <[email protected]>
+M:	Ian Jackson <[email protected]>
+S:	Supported
+L:	[email protected] 
+F:	.gitignore
+F:	config/Docs.mk.in
+F:	config/Paths.mk.in

MAINTAINERS F: xen/drivers/char/omap-uart.c · line 159

Quoted 10 lines
MAINTAINERS +10 -0
+F:	config/Stubdom.mk.in
+F:	config/Tools.mk.in
+F:	config/Toplevel.mk.in
+F:	m4/
+F:	configure
+F:	configure.ac
+F:	stubdom/configure
+F:	stubdom/configure.ac
+F:	tools/configure
+F:	tools/configure.ac

With this set of files the title should be something like CONFIGURY, as otherwise people may imply (or be tempted to add) other makefiles here.

Jan

#2 lore raw
In reply to Olaf Hering
Quoted 5 lines · Olaf Hering

Tweaking configure and friends is most likely not of much interest for anyone beside the tools maintainers.

Add a new section with files which are currently covered by "THE REST". Also update list of stubdom related files.

Does anyone have an opinion on adding these new paths to the existing tools section, rather than adding a new section?

#3 lore raw
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 25.09.14 at 11:47, <[email protected]> wrote:
Quoted 5 lines · Olaf Hering

Tweaking configure and friends is most likely not of much interest for anyone beside the tools maintainers.

Add a new section with files which are currently covered by "THE REST". Also update list of stubdom related files.

Does anyone have an opinion on adding these new paths to the existing tools section, rather than adding a new section?

In fact I was considering this too...

Jan

#4 lore raw
In reply to Ian Campbell
Quoted 2 lines · Ian Campbell

Does anyone have an opinion on adding these new paths to the existing tools section, rather than adding a new section?

tools is fine with me. Patch may look like shown below.

Olaf

MAINTAINERS +17 -0
index bf6b099..6b10cad 100644
@@ -228,6 +228,7 @@ MINI-OS
 M:	Stefano Stabellini <[email protected]>
 M:	Samuel Thibault <[email protected]>
 S:	Supported
+F:	config/MiniOS.mk
 F:	extras/mini-os/
 
 OCAML TOOLS
@@ -277,6 +278,8 @@ STUB DOMAINS
 M:	Stefano Stabellini <[email protected]>
 M:	Samuel Thibault <[email protected]>
 S:	Supported
+F:	config/Stubdom.mk.in
+F:	m4/stubdom.m4
 F:	stubdom/
 
 TOOLSTACK
@@ -285,6 +288,20 @@ M:	Stefano Stabellini <[email protected]>
 M:	Ian Campbell <[email protected]>
 M:	Wei Liu <[email protected]>
 S:	Supported
+F:	.gitignore
+F:	config/Docs.mk.in
+F:	config/Paths.mk.in
+F:	config/Stubdom.mk.in
+F:	config/Tools.mk.in
+F:	config/Toplevel.mk.in
+F:	install.sh
+F:	m4/
+F:	configure
+F:	configure.ac
+F:	docs/configure
+F:	docs/configure.ac
+F:	stubdom/configure
+F:	stubdom/configure.ac
 F:	tools/
 
 TRANSCENDENT MEMORY (TMEM)
#5 lore raw

MAINTAINERS M: Stefano Stabellini <[email protected]> · line 291

Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 25.09.14 at 12:38, <[email protected]> wrote:
MAINTAINERS +1 -0
@@ -285,6 +288,20 @@ M:	Stefano Stabellini <[email protected]>
 M:	Ian Campbell <[email protected]>
 M:	Wei Liu <[email protected]>
 S:	Supported
+F:	.gitignore

I don't think .gitignore should have any specific maintainer, but apart from that the suggested change looks mostly okay. These

MAINTAINERS M: Stefano Stabellini <[email protected]> · line 304

Quoted 4 lines
MAINTAINERS +4 -0
+F:	docs/configure
+F:	docs/configure.ac
+F:	stubdom/configure
+F:	stubdom/configure.ac

may be misplaced, but I'm not sure. Apart from that some wildcard use may help keep the lists of files at reasonable sizes.

Jan

#6 lore raw
Quoted 2 lines · Jan Beulich

may be misplaced, but I'm not sure. Apart from that some wildcard use may help keep the lists of files at reasonable sizes.

Wildcards are supported, I noticed that just now.

Olaf

#7 lore raw

PATCH 1/1 MAINTAINERS: handle buildsystem

In reply to Olaf Hering

Tweaking configure and friends is most likely not of much interest for anyone beside the tools maintainers.

List such files, which are currently covered by "THE REST", in the TOOLSTACK section. Also update list of stubdom related files.

Cc Ian Campbell <[email protected]>
Cc Ian Jackson <[email protected]>
Cc Jan Beulich <[email protected]>
Cc Keir Fraser <[email protected]>
Cc Tim Deegan <[email protected]>
---
 MAINTAINERS | 13 +++++++++++++
 1 file changed, 13 insertions(+)
MAINTAINERS +13 -0
index bf6b099..d6ba866 100644
@@ -228,6 +228,7 @@ MINI-OS
 M:	Stefano Stabellini <[email protected]>
 M:	Samuel Thibault <[email protected]>
 S:	Supported
+F:	config/MiniOS.mk
 F:	extras/mini-os/
 
 OCAML TOOLS
@@ -277,6 +278,8 @@ STUB DOMAINS
 M:	Stefano Stabellini <[email protected]>
 M:	Samuel Thibault <[email protected]>
 S:	Supported
+F:	config/Stubdom.mk.in
+F:	m4/stubdom.m4
 F:	stubdom/
 
 TOOLSTACK
@@ -285,6 +288,16 @@ M:	Stefano Stabellini <[email protected]>
 M:	Ian Campbell <[email protected]>
 M:	Wei Liu <[email protected]>
 S:	Supported
+F:	autogen.sh
+F:	config/*.in
+F:	install.sh
+F:	m4/
+F:	configure
+F:	docs/Makefile
+F:	stubdom/Makefile
+F:	*.ac
+F:	*/configure
+F:	*/*.ac
 F:	tools/
 
 TRANSCENDENT MEMORY (TMEM)
#9 lore raw
Quoted 10 lines · Ian Campbell
Quoted 7 lines · Olaf Hering

Tweaking configure and friends is most likely not of much interest for anyone beside the tools maintainers.

List such files, which are currently covered by "THE REST", in the TOOLSTACK section. Also update list of stubdom related files.

Thanks, I ran this via Stefano and Wei verbally and they were ok with it, so I have applied.

Acked-by on v1 1/1
#10 lore raw
In reply to Olaf Hering

Olaf Hering writes ("[PATCH] MAINTAINERS: handle buildsystem"):

Quoted 5 lines

Tweaking configure and friends is most likely not of much interest for anyone beside the tools maintainers.

List such files, which are currently covered by "THE REST", in the TOOLSTACK section. Also update list of stubdom related files.