Skip to contentSkip to conversation

UBIFS: Align the dump messages of SB_NODE

PATCH In review hujianyang 2 participants 3 messages Sep 20, 2014 – Sep 28, 2014

Subsystems (2)
Memory technology devices (MTD) UBI file system (UBIFS)
lore
Share & tools
lore

hujianyang

author
#0 lore raw

PATCH 1/1 UBIFS: Align the dump messages of SB_NODE

I found the dump messages of UBIFS_SB_NODE is not aligned. This patch remove the extra space from the line which is retracted.

Signed-off-by hujianyang <[email protected]>
---
 fs/ubifs/debug.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/ubifs/debug.c +2 -2
index 177b015..d0bcf92 100644
@@ -334,9 +334,9 @@ void ubifs_dump_node(const struct ubifs_info *c, const void *node)
 		pr_err("\tkey_fmt        %d (%s)\n",
 		       (int)sup->key_fmt, get_key_fmt(sup->key_fmt));
 		pr_err("\tflags          %#x\n", sup_flags);
-		pr_err("\t  big_lpt      %u\n",
+		pr_err("\tbig_lpt        %u\n",
 		       !!(sup_flags & UBIFS_FLG_BIGLPT));
-		pr_err("\t  space_fixup  %u\n",
+		pr_err("\tspace_fixup    %u\n",
 		       !!(sup_flags & UBIFS_FLG_SPACE_FIXUP));
 		pr_err("\tmin_io_size    %u\n", le32_to_cpu(sup->min_io_size));
 		pr_err("\tleb_size       %u\n", le32_to_cpu(sup->leb_size));
Signature · 1 line
1.6.0.2
#1 lore raw
Quoted 5 lines · hujianyang

I found the dump messages of UBIFS_SB_NODE is not aligned. This patch remove the extra space from the line which is retracted.

Signed-off-by hujianyang <[email protected]>

This was not a typo, this was intentional. We first print the all flags in a hex format, and then we "decode" it and print the values of the individual flags with an additional indent. The indent is to make it clear that these line belong to the flags, and they are not independent values.

Signature · 2 lines
Best Regards,
Artem Bityutskiy
author
#2 lore raw
Quoted 5 lines · Artem Bityutskiy
Quoted 4 lines · hujianyang

I found the dump messages of UBIFS_SB_NODE is not aligned. This patch remove the extra space from the line which is retracted.

Quoted 8 lines
Quoted 1 line
Signed-off-by hujianyang <[email protected]>

This was not a typo, this was intentional. We first print the all flags in a hex format, and then we "decode" it and print the values of the individual flags with an additional indent. The indent is to make it clear that these line belong to the flags, and they are not independent values.

Oh, thanks for your explanation~!

Hu