Skip to contentSkip to conversation

ARM: DT: apq8064: add CM-QS600 board

PATCH New Mike Rapoport 2 participants 3 messages Sep 26, 2014 – Sep 29, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ARM: DT: apq8064: add CM-QS600 board

CM-QS600 is a APQ8064 based computer on module.
The details are available at
http://compulab.co.il/products/computer-on-modules/cm-qs600/

---
v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested v3 changes: add board details and keep dts Makefile sorted alphabetically

 arch/arm/boot/dts/Makefile                  |  1 +
 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 59 +++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
arch/arm/boot/dts/Makefile +1 -0
index aaa1a68..3243722 100644
@@ -339,6 +339,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-d2-network.dtb \
 	orion5x-rd88f5182-nas.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb
 dtb-$(CONFIG_ARCH_QCOM) += \
+	qcom-apq8064-cm-qs600.dtb \
 	qcom-apq8064-ifc6410.dtb \
 	qcom-apq8074-dragonboard.dtb \
 	qcom-apq8084-ifc6540.dtb \aaaaaa
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file +59 -0

59 lines not on this page · raw message

Signature · 1 line
1.9.1
#1 lore raw

PATCH v3 1/1 ARM: DT: apq8064: add CM-QS600 board

Hi Mike,

Quoted 5 lines · Mike Rapoport

CM-QS600 is a APQ8064 based computer on module.
The details are available at
http://compulab.co.il/products/computer-on-modules/cm-qs600/

Thanks for working on this!
Some minor notes...

Can we have the subject aligned with other submissions, e.g.
ARM: dts: qcom: ...
?

Quoted 3 lines

---
v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested v3 changes: add board details and keep dts Makefile sorted alphabetically

[...]

Quoted 5 lines

new file mode 100644
index 0000000..db7cf03

arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file +0 -0
@@ -0,0 +1,59 @@

[...]

arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts line 28

Quoted 2 lines
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file +2 -0
+				eeprom: eeprom at 52 {
+					compatible = "atmel,24c128";

I believe the above should be 24c02.
And the address is 0x50.

arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts line 30

Quoted 2 lines
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file +2 -0
+					reg = <0x52>;
+					pagesize = <32>;

pagesize is 16.

[...]

Apart from the eeprom stuff above:

Signature · 2 lines
Regards,
Igor.
#2 lore raw

PATCH v3 1/1 ARM: DT: apq8064: add CM-QS600 board

Quoted 30 lines · Igor Grinberg

Hi Mike,

Quoted 5 lines · Mike Rapoport

CM-QS600 is a APQ8064 based computer on module.
The details are available at
http://compulab.co.il/products/computer-on-modules/cm-qs600/

Thanks for working on this!
Some minor notes...

Can we have the subject aligned with other submissions, e.g.
ARM: dts: qcom: ...
?

Quoted 3 lines

---
v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested v3 changes: add board details and keep dts Makefile sorted alphabetically

[...]

Quoted 5 lines

new file mode 100644
index 0000000..db7cf03

arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file +0 -0
@@ -0,0 +1,59 @@

[...]

Quoted 5 lines

arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts line 28

Quoted 2 lines
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file +2 -0
+				eeprom: eeprom at 52 {
+					compatible = "atmel,24c128";

I believe the above should be 24c02.
And the address is 0x50.

Also, atmel is not the only vendor for the eeprom chips we use, so I think at24 instead of atmel will do better here.

Quoted 12 lines

arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts line 30

Quoted 3 lines
arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file +2 -0
+					reg = <0x52>;
+					pagesize = <32>;

pagesize is 16.

[...]

Apart from the eeprom stuff above:

Signature · 2 lines
Regards,
Igor.