Handle reboot for Exynos SoC via reboot_notifier
Subsystems (5)
cover Handle reboot for Exynos SoC via reboot_notifier
This patch removes restart hook from machine_desc of Exynos, and moves respective code into reboot_notifiers.
Exynos5440 handles reboot via clock register so let's register a reboot_notifier in Exynos5440 clock driver.
For reset Exynos SoC, reboot is handled via PMU SWRESET register so let's register a reboot_notifier in PMU driver for handling this.
This patch is inspired and dependent on following patch series[1] from Geunter Roeck.
Also this patch is dependent on PMU platform driver patch [2] by me, and has been prepared on top of it.
[1]: kernel: Add support for kernel restart handler call chain
https://lkml.org/lkml/2014/8/19/652
[2]: ARM: Exynos: Convert PMU implementation into a platform driver
https://lkml.org/lkml/2014/9/30/219
I have tested reboot functionality on Exynos3250 based board, on kgene/for-next as well as linux-next's next-20140925 tag.
Pankaj Dubey (2):
clk: samsung: exynos5440: move restart code into clock driver
ARM: EXYNOS: PMU: move restart code into pmu driver
arch/arm/mach-exynos/common.h | 1 - arch/arm/mach-exynos/exynos.c | 23 --------------------- arch/arm/mach-exynos/pmu.c | 28 +++++++++++++++++++++++++ drivers/clk/samsung/clk-exynos5440.c | 37 ++++++++++++++++++++++++++++++++++ 4 files changed, 65 insertions(+), 24 deletions(-)
Signature · 1 line
1.7.9.5
PATCH 1/2 clk: samsung: exynos5440: move restart code into clock driver
Let's register reboot_notifier for Exynos5440 from it's clock driver for reboot functionality. So that we can cleanup restart hooks from machine specific file.
--- arch/arm/mach-exynos/exynos.c | 13 ------------ drivers/clk/samsung/clk-exynos5440.c | 37 ++++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 13 deletions(-)
arch/arm/mach-exynos/exynos.c +0 -13
@@ -143,19 +143,6 @@ static void exynos_restart(enum reboot_mode mode, const char *cmd)u32 val =0x1 ;void __iomem *addr = pmu_base_addr +EXYNOS_SWRESET ; -if (of_machine_is_compatible ("samsung,exynos5440" )) { -u32 status; - np =of_find_compatible_node (NULL ,NULL ,"samsung,exynos5440-clock" ); - - addr =of_iomap (np,0 ) +0xbc ; - status =__raw_readl (addr); - - addr =of_iomap (np,0 ) +0xcc ; - val =__raw_readl (addr); - - val = (val &0xffff0000 ) | (status &0xffff ); - } -__raw_writel (val, addr); }
drivers/clk/samsung/clk-exynos5440.c +37 -0
@@ -15,6 +15,8 @@#include <linux/clk-provider.h> #include <linux/of.h> #include <linux/of_address.h> +#include <linux/notifier.h> +#include <linux/reboot.h> #include "clk.h" #include "clk-pll.h"
@@ -89,6 +91,38 @@ static const struct of_device_id ext_clk_match[] __initconst = { {}, }; +static int exynos5440_clk_reboot_notify_handler (struct notifier_block *this, +unsigned long code,void *unused) +{ +if (code ==SYS_RESTART ) { +struct device_node *np; +void __iomem *addr; +u32 val, status; + + np =of_find_compatible_node (NULL ,NULL , +"samsung,exynos5440-clock" ); + + addr =of_iomap (np,0 ) +0xbc ; + status =readl_relaxed (addr); + + addr =of_iomap (np,0 ) +0xcc ; + val =readl_relaxed (addr); + + val = (val &0xffff0000 ) | (status &0xffff ); + +writel_relaxed (val, addr); + } +return NOTIFY_DONE ; +} + +/* +* Exynos5440 Clock reboot notifier, handles reboot functionality +*/ +static struct notifier_block exynos5440_clk_reboot_notifier = { + .notifier_call = exynos5440_clk_reboot_notify_handler, + .priority =128 , +}; +/* register exynos5440 clocks */ static void __init exynos5440_clk_init (struct device_node *np) {
@@ -125,6 +159,9 @@ static void __init exynos5440_clk_init(struct device_node *np)samsung_clk_of_add_provider (np, ctx); +if (register_reboot_notifier (&exynos5440_clk_reboot_notifier)) +pr_err ("exynos5440 clock can't register reboot notifier\n" ); +pr_info ("Exynos5440: arm_clk = %ldHz\n" ,_get_rate ("arm_clk" ));pr_info ("exynos5440 clock initialization complete\n" ); }
Signature · 1 line
1.7.9.5
PATCH 1/2 clk: samsung: exynos5440: move restart code into clock driver
Hi Pankaj,
Please see my comments inline.
Quoted 17 lines · Pankaj Dubey
Let's register
reboot_notifierfor Exynos5440 from it's clock driver for reboot functionality. So that we can cleanup restart hooks from machine specific file.CC Sylwester Nawrocki <[email protected]>CC Mike Turquette <[email protected]>Signed-off-by Pankaj Dubey <[email protected]>--- arch/arm/mach-exynos/exynos.c | 13 ------------ drivers/clk/samsung/clk-exynos5440.c | 37 ++++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 13 deletions(-)arch/arm/mach-exynos/exynos.c +0
-0
arch/arm/mach-exynos/exynos.c static void exynos_restart(enum reboot_mode mode, const char *cmd) · line 144
Quoted 2 lines
arch/arm/mach-exynos/exynos.c +0
-0@@ -143,19 +143,6 @@ static void exynos_restart(enum reboot_mode mode, const char *cmd)u32 val =0x1 ;void __iomem *addr = pmu_base_addr +EXYNOS_SWRESET ;
You can remove the variables above as well...
Quoted 5 lines
arch/arm/mach-exynos/exynos.c +0
-4-if (of_machine_is_compatible ("samsung,exynos5440" )) { -u32 status; - np =of_find_compatible_node (NULL ,NULL ,"samsung,exynos5440-clock" ); -
arch/arm/mach-exynos/exynos.c static void exynos_restart(enum reboot_mode mode, const char *cmd) · line 146
Quoted 10 lines
arch/arm/mach-exynos/exynos.c +0
-9- addr =of_iomap (np,0 ) +0xbc ; - status =__raw_readl (addr); - - addr =of_iomap (np,0 ) +0xcc ; - val =__raw_readl (addr); - - val = (val &0xffff0000 ) | (status &0xffff ); - } -__raw_writel (val, addr);
and make this use the constants instead.
Quoted 21 lines
arch/arm/mach-exynos/exynos.c +0
-0}drivers/clk/samsung/clk-exynos5440.c +4
-0@@ -15,6 +15,8 @@#include <linux/clk-provider.h> #include <linux/of.h> #include <linux/of_address.h> +#include <linux/notifier.h> +#include <linux/reboot.h> #include "clk.h" #include "clk-pll.h" @@ -89,6 +91,38 @@ static const struct of_device_id ext_clk_match[] __initconst = { {}, }; +static int exynos5440_clk_reboot_notify_handler (struct notifier_block *this, +unsigned long code,void *unused)
drivers/clk/samsung/clk-exynos5440.c static const struct of_device_id ext_clk_match[] __initconst = { · line 105
Quoted 10 lines
drivers/clk/samsung/clk-exynos5440.c +10
-0+{ +if (code ==SYS_RESTART ) { +struct device_node *np; +void __iomem *addr; +u32 val, status; + + np =of_find_compatible_node (NULL ,NULL , +"samsung,exynos5440-clock" ); + + addr =of_iomap (np,0 ) +0xbc ;
You can just save the address in exynos5440_clk_init() and use it here without the whole dance with DT and ioremap.
Best regards,
Tomasz
PATCH 2/2 ARM: EXYNOS: PMU: move restart code into pmu driver
In reply to Pankaj DubeyLet's register reboot_notifier from PMU driver for reboot functionality. So that we can remove restart hooks from machine specific file, and thus moving ahead when PMU moved to driver folder, this functionality can be reused for ARM64 based Exynos SoC's.
--- arch/arm/mach-exynos/common.h | 1 - arch/arm/mach-exynos/exynos.c | 10 ---------- arch/arm/mach-exynos/pmu.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 28 insertions(+), 11 deletions(-)
arch/arm/mach-exynos/common.h +0 -1
@@ -12,7 +12,6 @@#ifndef __ARCH_ARM_MACH_EXYNOS_COMMON_H#define __ARCH_ARM_MACH_EXYNOS_COMMON_H -#include <linux/reboot.h> #include <linux/of.h> #define EXYNOS3250_SOC_ID 0xE3472000
arch/arm/mach-exynos/exynos.c +0 -10
@@ -137,15 +137,6 @@ static struct map_desc exynos5_iodesc[] __initdata = { }, }; -static void exynos_restart (enum reboot_mode mode,const char *cmd) -{ -struct device_node *np; -u32 val =0x1 ; -void __iomem *addr = pmu_base_addr +EXYNOS_SWRESET ; - -__raw_writel (val, addr); -} -static struct platform_device exynos_cpuidle = { .name ="exynos_cpuidle" , #ifdef CONFIG_ARM_EXYNOS_CPUIDLE
@@ -369,7 +360,6 @@ DT_MACHINE_START(EXYNOS_DT, "SAMSUNG EXYNOS (Flattened Device Tree)") .init_machine = exynos_dt_machine_init, .init_late = exynos_init_late, .dt_compat = exynos_dt_compat, - .restart = exynos_restart, .reserve = exynos_reserve, .dt_fixup = exynos_dt_fixup,MACHINE_END
arch/arm/mach-exynos/pmu.c +28 -0
@@ -11,7 +11,10 @@#include <linux/io.h> #include <linux/of.h> +#include <linux/of_address.h> #include <linux/platform_device.h> +#include <linux/notifier.h> +#include <linux/reboot.h> #include "exynos-pmu.h" #include "regs-pmu.h"
@@ -439,6 +442,18 @@ static void exynos5250_pmu_init(void)pmu_raw_writel (value,EXYNOS5_MASK_WDTRESET_REQUEST ); } +static int pmu_reboot_notify_handler (struct notifier_block *this, +unsigned long code,void *unused) +{ +if (code ==SYS_RESTART ) { +u32 val =0x1 ; + +pmu_raw_writel (val,EXYNOS_SWRESET ); + } + +return NOTIFY_DONE ; +} +static const struct exynos_pmu_data exynos4210_pmu_data = { .pmu_config = exynos4210_pmu_config, };
@@ -478,11 +493,20 @@ static const struct of_device_id exynos_pmu_of_device_ids[] = { { /*sentinel*/ }, }; +/* +* Exynos PMU reboot notifier, handles reboot functionality +*/ +static struct notifier_block pmu_reboot_notifier = { + .notifier_call = pmu_reboot_notify_handler, + .priority =128 , +}; +static int exynos_pmu_probe (struct platform_device *pdev) {const struct of_device_id *match;struct device *dev = &pdev->dev;struct resource *res; +int ret; res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); pmu_base_addr =devm_ioremap_resource (dev, res);
@@ -507,6 +531,10 @@ static int exynos_pmu_probe(struct platform_device *pdev)platform_set_drvdata (pdev, pmu_context); + ret =register_reboot_notifier (&pmu_reboot_notifier); +if (ret) +dev_err (dev,"can't register reboot notifier err=%d\n" , ret); +dev_dbg (dev,"Exynos PMU Driver probe done\n" );return 0 ; }
Signature · 1 line
1.7.9.5
PATCH 2/2 ARM: EXYNOS: PMU: move restart code into pmu driver
Hi Pankaj,
Please see my comments inline.
Quoted 5 lines · Pankaj Dubey
Let's register
reboot_notifierfrom PMU driver for reboot functionality. So that we can remove restart hooks from machine specific file, and thus moving ahead when PMU moved to driver folder, this functionality can be reused for ARM64 based Exynos SoC's.
[snip]
arch/arm/mach-exynos/pmu.c static void exynos5250_pmu_init(void) · line 451
Quoted 7 lines
arch/arm/mach-exynos/pmu.c +7
-0+static int pmu_reboot_notify_handler (struct notifier_block *this, +unsigned long code,void *unused) +{ +if (code ==SYS_RESTART ) { +u32 val =0x1 ; + +pmu_raw_writel (val,EXYNOS_SWRESET );
As already mentioned for patch 1, no need for the variable, because this is just a constant 1.
Best regards,
Tomasz
PATCH 2/2 ARM: EXYNOS: PMU: move restart code into pmu driver
Hi Tomasz,
On Wednesday, October 01, 2014 4:07 PM, Tomasz Figa wrote,
Quoted 19 lines
To: Pankaj Dubey; linux-arm-kernel at lists.infradead.org; linux-samsung- soc at vger.kernel.org
Cc: kgene.kim at samsung.com; linux at arm.linux.org.uk; thomas.ab at samsung.com; vikas.sajjan at samsung.com; linux at roeck-us.net; naushad at samsung.com
Subject: Re: [PATCH 2/2] ARM: EXYNOS: PMU: move restart code into pmu driverHi Pankaj,
Please see my comments inline.
Quoted 4 lines · Pankaj Dubey
Let's register
reboot_notifierfrom PMU driver for reboot functionality. So that we can remove restart hooks from machine specific file, and thus moving ahead when PMU moved to driver folder, this functionality can be reused for ARM64 based Exynos SoC's.[snip]
Quoted 9 lines
arch/arm/mach-exynos/pmu.c static void exynos5250_pmu_init(void) · line 451
Quoted 7 lines
arch/arm/mach-exynos/pmu.c +7
-0+static int pmu_reboot_notify_handler (struct notifier_block *this, +unsigned long code,void *unused) +{ +if (code ==SYS_RESTART ) { +u32 val =0x1 ; + +pmu_raw_writel (val,EXYNOS_SWRESET );As already mentioned for patch 1, no need for the variable, because this
is just a
Quoted 2 lines
constant 1.
Thanks for review.
Addressed all your review comments for this patch series in v2.
Thanks,
Pankaj Dubey
Quoted 2 lines
Best regards,
Tomasz