hwmon: (ab8500) Call kernel_power_off instead of pm_power_off
Guenter Roeck
maintainerPATCH 1/1 hwmon: (ab8500) Call kernel_power_off instead of pm_power_off
Drivers should not call pm_power_off directly; it is not guaranteed to be non-NULL. Call kernel_power_off instead.
--- drivers/hwmon/ab8500.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/hwmon/ab8500.c +3 -2
@@ -6,7 +6,7 @@* * When the AB8500 thermal warning temperature is reached (threshold cannot * be changed by SW), an interrupt is set, and if no further action is taken -* within a certain time frame, pm_power off will be called. +* within a certain time frame, kernel_power_off will be called. * * When AB8500 thermal shutdown temperature is reached a hardware shutdown of * the AB8500 will occur.
@@ -21,6 +21,7 @@#include <linux/module.h> #include <linux/platform_device.h> #include <linux/power/ab8500.h> +#include <linux/reboot.h> #include <linux/slab.h> #include <linux/sysfs.h> #include "abx500.h"
@@ -106,7 +107,7 @@ static void ab8500_thermal_power_off(struct work_struct *work)dev_warn (&abx500_data->pdev->dev,"Power off due to critical temp\n" ); -pm_power_off (); +kernel_power_off (); } static ssize_t ab8500_show_name(struct device *dev,
Signature · 7 lines
1.9.1 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi Guenter,
Quoted 31 lines · Guenter Roeck
Drivers should not call
pm_power_offdirectly; it is not guaranteed to be non-NULL. Callkernel_power_offinstead.Cc Jean Delvare <[email protected]>Signed-off-by Guenter Roeck <[email protected]>--- drivers/hwmon/ab8500.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/hwmon/ab8500.c +2
-1@@ -6,7 +6,7 @@* * When the AB8500 thermal warning temperature is reached (threshold cannot * be changed by SW), an interrupt is set, and if no further action is taken -* within a certain time frame, pm_power off will be called. +* within a certain time frame, kernel_power_off will be called. * * When AB8500 thermal shutdown temperature is reached a hardware shutdown of * the AB8500 will occur. @@ -21,6 +21,7 @@#include <linux/module.h> #include <linux/platform_device.h> #include <linux/power/ab8500.h> +#include <linux/reboot.h> #include <linux/slab.h> #include <linux/sysfs.h> #include "abx500.h"
drivers/hwmon/ab8500.c static void ab8500_thermal_power_off(struct work_struct *work) · line 113
Quoted 8 lines
drivers/hwmon/ab8500.c +1
-1@@ -106,7 +107,7 @@ static void ab8500_thermal_power_off(struct work_struct *work)dev_warn (&abx500_data->pdev->dev,"Power off due to critical temp\n" ); -pm_power_off (); +kernel_power_off (); } static ssize_t ab8500_show_name(struct device *dev,
I am no expert on the matter but this looks like a reasonable change.
Signature · 7 lines
Jean Delvare SUSE L3 Support _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerQuoted 41 lines · Jean Delvare
Hi Guenter,
Quoted 38 lines · Guenter Roeck
Drivers should not call
pm_power_offdirectly; it is not guaranteed to be non-NULL. Callkernel_power_offinstead.Cc Jean Delvare <[email protected]>Signed-off-by Guenter Roeck <[email protected]>--- drivers/hwmon/ab8500.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/hwmon/ab8500.c +3
-2@@ -6,7 +6,7 @@* * When the AB8500 thermal warning temperature is reached (threshold cannot * be changed by SW), an interrupt is set, and if no further action is taken -* within a certain time frame, pm_power off will be called. +* within a certain time frame, kernel_power_off will be called. * * When AB8500 thermal shutdown temperature is reached a hardware shutdown of * the AB8500 will occur. @@ -21,6 +21,7 @@#include <linux/module.h> #include <linux/platform_device.h> #include <linux/power/ab8500.h> +#include <linux/reboot.h> #include <linux/slab.h> #include <linux/sysfs.h> #include "abx500.h" @@ -106,7 +107,7 @@ static void ab8500_thermal_power_off(struct work_struct *work)dev_warn (&abx500_data->pdev->dev,"Power off due to critical temp\n" ); -pm_power_off (); +kernel_power_off (); }
Quoted 6 lines
drivers/hwmon/ab8500.c static void ab8500_thermal_power_off(struct work_struct *work) · line 113
Quoted 1 line
drivers/hwmon/ab8500.c +0
-0static ssize_t ab8500_show_name(struct device *dev,I am no expert on the matter but this looks like a reasonable change.
Reviewed-by Jean Delvare <[email protected]>
Thanks!
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors