Skip to contentSkip to conversation

ARM: dts: keystone: fixes

PATCH New Grygorii Strashko 2 participants 6 messages Oct 1, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: keystone: fixes

Hi Snatosh,

This small set of DTS fixes for Keystone 2 SoCs, which I've done while testing kernel boot on linux-next (3.18).

Grygorii Strashko (4):
ARM: dts: keystone: fix io range for usb_phy
ARM: dts: keystone-k2e: update usb1 node for dma properties
ARM: dts: keystone-k2e: fix mdio io start address
ARM: dts: keystone-k2l: fix mdio io start address

 arch/arm/boot/dts/k2e.dtsi      | 6 ++++++
 arch/arm/boot/dts/k2l.dtsi      | 4 ++++
 arch/arm/boot/dts/keystone.dtsi | 2 +-
 3 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/4 ARM: dts: keystone: fix io range for usb_phy0

The IO range size is set incorrectly for USB PHY0 deivice it should be 24 instead of 32. Otherwise, It causes USB PHY1 probing failure.

---
 arch/arm/boot/dts/keystone.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/keystone.dtsi +1 -1
index 4e53494..d1f03a0 100644
@@ -177,7 +177,7 @@
 			compatible = "ti,keystone-usbphy";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			reg = <0x2620738 32>;
+			reg = <0x2620738 24>;
 			status = "disabled";
 		};
 
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/4 ARM: dts: keystone-k2e: update usb1 node for dma properties

In reply to Grygorii Strashko

Keystone supports dma-coherent on USB master and also needs dma-ranges to specify the hardware alias memory range in which DMA can be operational.
Such configuration applied for USB0 devices, but It's missed for USB1 device which is present only in K2E SoC - hence apply it.

---
 arch/arm/boot/dts/k2e.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/k2e.dtsi +2 -0
index 03d0190..0e25f79 100644
@@ -67,6 +67,8 @@
 			clock-names = "usb";
 			interrupts = <GIC_SPI 414 IRQ_TYPE_EDGE_RISING>;
 			ranges;
+			dma-coherent;
+			dma-ranges;
 			status = "disabled";
 
 			dwc3 at 25010000 {
Signature · 1 line
1.9.1
#3 lore raw

PATCH 3/4 ARM: dts: keystone-k2e: fix mdio io start address

In reply to Grygorii Strashko

The K2E MDIO io space has different start address. Hence, fix it to be 0x24200f00 according to TRM.

---
 arch/arm/boot/dts/k2e.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/k2e.dtsi +4 -0
index 0e25f79..13b0feb 100644
@@ -80,3 +80,7 @@
 		};
 	};
 };
+
+&mdio {
+	reg = <0x24200f00 0x100>;
+};
Signature · 1 line
1.9.1
#4 lore raw

PATCH 4/4 ARM: dts: keystone-k2l: fix mdio io start address

In reply to Grygorii Strashko

The K2L MDIO io space has different start address. Hence, fix it to be 0x26200f00 according to TRM.

---
 arch/arm/boot/dts/k2l.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/k2l.dtsi +4 -0
index 1f7f479..5e44983 100644
@@ -53,3 +53,7 @@
 		};
 	};
 };
+
+&mdio {
+	reg = <0x26200f00 0x100>;
+};
Signature · 1 line
1.9.1
#5 lore raw

cover ARM: dts: keystone: fixes

In reply to Grygorii Strashko
Quoted 11 lines · Grygorii Strashko

Hi Snatosh,

This small set of DTS fixes for Keystone 2 SoCs, which I've done while testing kernel boot on linux-next (3.18).

Grygorii Strashko (4):
ARM: dts: keystone: fix io range for usb_phy
ARM: dts: keystone-k2e: update usb1 node for dma properties
ARM: dts: keystone-k2e: fix mdio io start address
ARM: dts: keystone-k2l: fix mdio io start address

Thanks Grygorii !!
I will queue this up for 3.18