Skip to contentSkip to conversation

odroid: pmic77686: allow bucket voltage settings

PATCH Superseded Suriyan Ramasami 4 participants 8 messages Oct 2, 2014 – Oct 17, 2014

Subsystems (4)
Arm (32-bit) USB Arm Samsung Exynos USB ehci driver

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Suriyan Ramasami

author
#0 lore raw

PATCH 1/2 odroid: pmic77686: allow bucket voltage settings

Allow to set the bucket voltage for the max77686.
This will be used to reset the SMC LAN9730 ethernet on the odroids.

Signed-off-by Suriyan Ramasami <[email protected]>
---
 drivers/power/pmic/pmic_max77686.c | 48 +++++++++++++++++++++++++++++++++++++-
 include/power/max77686_pmic.h      |  3 +++
 2 files changed, 50 insertions(+), 1 deletion(-)
drivers/power/pmic/pmic_max77686.c +47 -1
index df1fd91..1aeadb4 100644
@@ -42,6 +42,25 @@ static unsigned int max77686_ldo_volt2hex(int ldo, ulong uV)
 	return 0;
 }
 
+static unsigned int max77686_buck_volt2hex(int buck, ulong uV)
+{
+	unsigned int hex = 0;
+
+	if (buck < 5 || buck > 9) {
+		debug("%s: buck %d is not supported\n", __func__, buck);
+		return 0;
+	}
+
+	hex = (uV - 750000) / 50000;
+
+	if (hex >= 0 && hex <= MAX77686_BUCK_VOLT_MAX_HEX)
+		return hex;
+
+	debug("%s: %ld is wrong voltage value for BUCK%d\n",
+	      __func__, uV, buck);
+	return MAX77686_BUCK_VOLT_MAX_HEX + 1;
+}
+
 int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
 {
 	unsigned int val, ret, hex, adr;

@@ -68,6 +87,33 @@ int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
 	return ret;
 }
 
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV)
+{
+	unsigned int val, ret, hex, adr;
+
+	if (buck < 5 && buck > 9) {
+		printf("%s: %d is an unsupported bucket number\n",
+		       __func__, buck);
+		return -1;
+	}
+
+	adr = max77686_buck_addr[buck] + 1;
+	hex = max77686_buck_volt2hex(buck, uV);
+
+	if (hex == MAX77686_BUCK_VOLT_MAX_HEX + 1)
+		return -1;
+
+	ret = pmic_reg_read(p, adr, &val);
+	if (ret)
+		return ret;
+
+	val &= ~MAX77686_BUCK_VOLT_MASK;
+	val |= hex;
+	ret |= pmic_reg_write(p, adr, val);
+
+	return ret;
+}
+
 int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode)
 {
 	unsigned int val, ret, adr, mode;

@@ -157,7 +203,7 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode)
 	/* mode */
 	switch (opmode) {
 	case OPMODE_OFF:
-		mode = MAX77686_BUCK_MODE_OFF;
+		mode = MAX77686_BUCK_MODE_OFF << mode_shift;
 		break;
 	case OPMODE_STANDBY:
 		switch (buck) {
include/power/max77686_pmic.h +3 -0
index c2a772a..b0e4255 100644
@@ -150,6 +150,7 @@ enum {
 
 int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV);
 int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode);
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV);
 int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 
 #define MAX77686_LDO_VOLT_MAX_HEX	0x3f

@@ -159,6 +160,8 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 #define MAX77686_LDO_MODE_STANDBY	(0x01 << 0x06)
 #define MAX77686_LDO_MODE_LPM		(0x02 << 0x06)
 #define MAX77686_LDO_MODE_ON		(0x03 << 0x06)
+#define MAX77686_BUCK_VOLT_MAX_HEX	0x3f
+#define MAX77686_BUCK_VOLT_MASK		0x3f
 #define MAX77686_BUCK_MODE_MASK		0x03
 #define MAX77686_BUCK_MODE_SHIFT_1	0x00
 #define MAX77686_BUCK_MODE_SHIFT_2	0x04
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 odroid: usb: add support for usb host including ethernet

This change adds support for enabling the USB host features of the board. This includes the USB3503A hub and the SMC LAN9730 ethernet controller as well.

Credit goes to Tushar Behera (Linaro) for the function set_usb_ethaddr().

Signed-off-by Suriyan Ramasami <[email protected]>
---
 arch/arm/cpu/armv7/exynos/power.c        | 26 +++++++++++++++
 arch/arm/dts/exynos4412-odroid.dts       | 11 +++++++
 arch/arm/include/asm/arch-exynos/cpu.h   |  2 ++
 arch/arm/include/asm/arch-exynos/ehci.h  | 13 ++++++++
 arch/arm/include/asm/arch-exynos/power.h |  7 ++++
 board/samsung/odroid/odroid.c            | 55 ++++++++++++++++++++++++++++++++
 drivers/usb/host/ehci-exynos.c           | 52 +++++++++++++++++++++++++-----
 include/configs/odroid.h                 | 13 ++++++++
 8 files changed, 171 insertions(+), 8 deletions(-)
arch/arm/cpu/armv7/exynos/power.c +26 -0
index e1ab3d6..6578a07 100644
@@ -53,10 +53,36 @@ void exynos5_set_usbhost_phy_ctrl(unsigned int enable)
 	}
 }
 
+void exynos4412_set_usbhost_phy_ctrl(unsigned int enable)
+{
+	struct exynos4412_power *power =
+		(struct exynos4412_power *)samsung_get_base_power();
+
+	if (enable) {
+		/* Enabling USBHOST_PHY */
+		setbits_le32(&power->usbhost_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		setbits_le32(&power->hsic1_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		setbits_le32(&power->hsic2_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+	} else {
+		/* Disabling USBHOST_PHY */
+		clrbits_le32(&power->usbhost_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		clrbits_le32(&power->hsic1_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		clrbits_le32(&power->hsic2_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+	}
+}
+
 void set_usbhost_phy_ctrl(unsigned int enable)
 {
 	if (cpu_is_exynos5())
 		exynos5_set_usbhost_phy_ctrl(enable);
+	else if (proid_is_exynos4412())
+		exynos4412_set_usbhost_phy_ctrl(enable);
 }
 
 static void exynos5_set_usbdrd_phy_ctrl(unsigned int enable)
arch/arm/dts/exynos4412-odroid.dts +11 -0
index 24d0bf1..8da8568 100644
@@ -67,4 +67,15 @@
 		div = <0x3>;
 		index = <4>;
 	};
+
+        ehci at 12580000 {
+                compatible = "samsung,exynos-ehci";
+                reg = <0x12580000 0x100>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+                phy {
+                        compatible = "samsung,exynos-usb-phy";
+                        reg = <0x125B0000 0x100>;
+                };
+        };
 };
arch/arm/include/asm/arch-exynos/cpu.h +2 -0
index ba71714..fda21fb 100644
@@ -18,6 +18,8 @@
 
 #define EXYNOS4_GPIO_PART3_BASE		0x03860000
 #define EXYNOS4_PRO_ID			0x10000000
+#define EXYNOS4_GUID_LOW		0x10000014
+#define EXYNOS4_GUID_HIGH		0x10000018
 #define EXYNOS4_SYSREG_BASE		0x10010000
 #define EXYNOS4_POWER_BASE		0x10020000
 #define EXYNOS4_SWRESET			0x10020400
arch/arm/include/asm/arch-exynos/ehci.h +13 -0
index d2d70bd..3800fa9 100644
@@ -12,6 +12,13 @@
 
 #define CLK_24MHZ		5
 
+#define PHYPWR_NORMAL_MASK_PHY0                 (0x39 << 0)
+#define PHYPWR_NORMAL_MASK_PHY1                 (0x7 << 6)
+#define PHYPWR_NORMAL_MASK_HSIC0                (0x7 << 9)
+#define PHYPWR_NORMAL_MASK_HSIC1                (0x7 << 12)
+#define RSTCON_HOSTPHY_SWRST                    (0xf << 3)
+#define RSTCON_SWRST                            (0x1 << 0)
+
 #define HOST_CTRL0_PHYSWRSTALL			(1 << 31)
 #define HOST_CTRL0_COMMONON_N			(1 << 9)
 #define HOST_CTRL0_SIDDQ			(1 << 6)

@@ -61,6 +68,12 @@ struct exynos_usb_phy {
 	unsigned int usbotgtune;
 };
 
+struct exynos4412_usb_phy {
+	unsigned int usbphyctrl;
+	unsigned int usbphyclk;
+	unsigned int usbphyrstcon;
+};
+
 /* Switch on the VBUS power. */
 int board_usb_vbus_init(void);
arch/arm/include/asm/arch-exynos/power.h +7 -0
index e8a98a5..3f97b31 100644
@@ -210,6 +210,13 @@ struct exynos4_power {
 	unsigned int	gps_alive_option;
 };
 
+struct exynos4412_power {
+	unsigned char	res1[0x0704];
+	unsigned int	usbhost_phy_control;
+	unsigned int	hsic1_phy_control;
+	unsigned int	hsic2_phy_control;
+};
+
 struct exynos5_power {
 	unsigned int	om_stat;
 	unsigned char	res1[0x18];
board/samsung/odroid/odroid.c +55 -0

64 lines not on this page · raw message

drivers/usb/host/ehci-exynos.c +44 -8

79 lines not on this page · raw message

include/configs/odroid.h +13 -0
index b616ac2..3fc0508 100644
@@ -200,6 +200,19 @@
 
 #define CONFIG_CMD_GPIO
 
+/* USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_EXYNOS
+#define CONFIG_USB_STORAGE
+
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS	3
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_DHCP
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_SMSC95XX
+
 /*
  * Supported Odroid boards: X3, U3
  * TODO: Add Odroid X support
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 odroid: usb: add support for usb host including ethernet

Hi, Suriyan.

This patch can be separated.

Quoted 68 lines · Suriyan Ramasami

This change adds support for enabling the USB host features of the board. This includes the USB3503A hub and the SMC LAN9730 ethernet controller as well.

Credit goes to Tushar Behera (Linaro) for the function set_usb_ethaddr().

Signed-off-by Suriyan Ramasami <[email protected]>
---
 arch/arm/cpu/armv7/exynos/power.c        | 26 +++++++++++++++
 arch/arm/dts/exynos4412-odroid.dts       | 11 +++++++
 arch/arm/include/asm/arch-exynos/cpu.h   |  2 ++
 arch/arm/include/asm/arch-exynos/ehci.h  | 13 ++++++++
 arch/arm/include/asm/arch-exynos/power.h |  7 ++++
 board/samsung/odroid/odroid.c            | 55 ++++++++++++++++++++++++++++++++
 drivers/usb/host/ehci-exynos.c           | 52 +++++++++++++++++++++++++-----
 include/configs/odroid.h                 | 13 ++++++++
 8 files changed, 171 insertions(+), 8 deletions(-)
arch/arm/cpu/armv7/exynos/power.c +26 -0
index e1ab3d6..6578a07 100644
@@ -53,10 +53,36 @@ void exynos5_set_usbhost_phy_ctrl(unsigned int enable)
 	}
 }
 
+void exynos4412_set_usbhost_phy_ctrl(unsigned int enable)
+{
+	struct exynos4412_power *power =
+		(struct exynos4412_power *)samsung_get_base_power();
+
+	if (enable) {
+		/* Enabling USBHOST_PHY */
+		setbits_le32(&power->usbhost_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		setbits_le32(&power->hsic1_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		setbits_le32(&power->hsic2_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+	} else {
+		/* Disabling USBHOST_PHY */
+		clrbits_le32(&power->usbhost_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		clrbits_le32(&power->hsic1_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+		clrbits_le32(&power->hsic2_phy_control,
+			     POWER_USB_HOST_PHY_CTRL_EN);
+	}
+}
+
 void set_usbhost_phy_ctrl(unsigned int enable)
 {
 	if (cpu_is_exynos5())
 		exynos5_set_usbhost_phy_ctrl(enable);
+	else if (proid_is_exynos4412())
+		exynos4412_set_usbhost_phy_ctrl(enable);
 }
 
 static void exynos5_set_usbdrd_phy_ctrl(unsigned int enable)
arch/arm/dts/exynos4412-odroid.dts +1 -0
index 24d0bf1..8da8568 100644
@@ -67,4 +67,15 @@
 		div = <0x3>;
 		index = <4>;
 	};
+

arch/arm/dts/exynos4412-odroid.dts line 80

Quoted 10 lines
arch/arm/dts/exynos4412-odroid.dts +10 -0
+        ehci at 12580000 {
+                compatible = "samsung,exynos-ehci";
+                reg = <0x12580000 0x100>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+                phy {
+                        compatible = "samsung,exynos-usb-phy";
+                        reg = <0x125B0000 0x100>;
+                };
+        };

Fix the indentation.

Best Regards,
Jaehoon Chung

Quoted 244 lines
arch/arm/dts/exynos4412-odroid.dts +0 -0
 };
arch/arm/include/asm/arch-exynos/cpu.h +2 -0
index ba71714..fda21fb 100644
@@ -18,6 +18,8 @@
 
 #define EXYNOS4_GPIO_PART3_BASE		0x03860000
 #define EXYNOS4_PRO_ID			0x10000000
+#define EXYNOS4_GUID_LOW		0x10000014
+#define EXYNOS4_GUID_HIGH		0x10000018
 #define EXYNOS4_SYSREG_BASE		0x10010000
 #define EXYNOS4_POWER_BASE		0x10020000
 #define EXYNOS4_SWRESET			0x10020400
arch/arm/include/asm/arch-exynos/ehci.h +13 -0
index d2d70bd..3800fa9 100644
@@ -12,6 +12,13 @@
 
 #define CLK_24MHZ		5
 
+#define PHYPWR_NORMAL_MASK_PHY0                 (0x39 << 0)
+#define PHYPWR_NORMAL_MASK_PHY1                 (0x7 << 6)
+#define PHYPWR_NORMAL_MASK_HSIC0                (0x7 << 9)
+#define PHYPWR_NORMAL_MASK_HSIC1                (0x7 << 12)
+#define RSTCON_HOSTPHY_SWRST                    (0xf << 3)
+#define RSTCON_SWRST                            (0x1 << 0)
+
 #define HOST_CTRL0_PHYSWRSTALL			(1 << 31)
 #define HOST_CTRL0_COMMONON_N			(1 << 9)
 #define HOST_CTRL0_SIDDQ			(1 << 6)

@@ -61,6 +68,12 @@ struct exynos_usb_phy {
 	unsigned int usbotgtune;
 };
 
+struct exynos4412_usb_phy {
+	unsigned int usbphyctrl;
+	unsigned int usbphyclk;
+	unsigned int usbphyrstcon;
+};
+
 /* Switch on the VBUS power. */
 int board_usb_vbus_init(void);
arch/arm/include/asm/arch-exynos/power.h +7 -0
index e8a98a5..3f97b31 100644
@@ -210,6 +210,13 @@ struct exynos4_power {
 	unsigned int	gps_alive_option;
 };
 
+struct exynos4412_power {
+	unsigned char	res1[0x0704];
+	unsigned int	usbhost_phy_control;
+	unsigned int	hsic1_phy_control;
+	unsigned int	hsic2_phy_control;
+};
+
 struct exynos5_power {
 	unsigned int	om_stat;
 	unsigned char	res1[0x18];
board/samsung/odroid/odroid.c +55 -0
index fd5d2d2..4764a71 100644
@@ -453,9 +453,64 @@ struct s3c_plat_otg_data s5pc210_otg_data = {
 	.usb_phy_ctrl	= EXYNOS4X12_USBPHY_CONTROL,
 	.usb_flags	= PHY0_SLEEP,
 };
+#endif
+
+#if defined(CONFIG_USB_GADGET) || defined(CONFIG_CMD_USB)
+
+#ifdef CONFIG_CMD_USB
+static void set_usb_ethaddr(void)
+{
+	int i;
+	uchar mac[6];
+	unsigned int guid_high = readl(EXYNOS4_GUID_HIGH);
+	unsigned int guid_low = readl(EXYNOS4_GUID_LOW);
+
+	for (i = 0; i < 2; i++)
+		mac[i] = (guid_high >> (8 * (1 - i))) & 0xFF;
+
+	for (i = 0; i < 4; i++)
+		mac[i+2] = (guid_low >> (8 * (3 - i))) & 0xFF;
+
+	/* mark it as not multicast and outside official 80211 MAC namespace */
+	mac[0] = (mac[0] & ~0x1) | 0x2;
+
+	eth_setenv_enetaddr("ethaddr", mac);
+	eth_setenv_enetaddr("usbethaddr", mac);
+}
+#endif
 
 int board_usb_init(int index, enum usb_init_type init)
 {
+#ifdef CONFIG_CMD_USB
+	struct pmic *p_pmic;
+
+	/* Set Ref freq 0 => 24MHz, 1 => 26MHz*/
+	/* Odroid Us have it at 24MHz, Odroid Xs at 26MHz */
+	if (gd->board_type == ODROID_TYPE_U3)
+		gpio_direction_output(EXYNOS4X12_GPIO_X30, 0);
+	else
+		gpio_direction_output(EXYNOS4X12_GPIO_X30, 1);
+
+	/* Disconnect, Reset, Connect */
+	gpio_direction_output(EXYNOS4X12_GPIO_X34, 0);
+	gpio_direction_output(EXYNOS4X12_GPIO_X35, 0);
+	gpio_direction_output(EXYNOS4X12_GPIO_X35, 1);
+	gpio_direction_output(EXYNOS4X12_GPIO_X34, 1);
+
+	/* Power off and on BUCK8 for LAN9730 */
+	debug("LAN9730 - Turning power buck 8 OFF and ON.\n");
+
+	p_pmic = pmic_get("MAX77686_PMIC");
+	if (p_pmic && !pmic_probe(p_pmic)) {
+		max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF);
+		max77686_set_buck_voltage(p_pmic, 8, 750000);
+		max77686_set_buck_voltage(p_pmic, 8, 3300000);
+		max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);
+	}
+
+	set_usb_ethaddr();
+#endif
+
 	debug("USB_udc_probe\n");
 	return s3c_udc_probe(&s5pc210_otg_data);
 }
drivers/usb/host/ehci-exynos.c +44 -8
index edd91a8..91f3c72 100644
@@ -19,6 +19,7 @@
 #include <asm/gpio.h>
 #include <asm-generic/errno.h>
 #include <linux/compat.h>
+#include <power/max77686_pmic.h>
 #include "ehci.h"
 
 /* Declare global data pointer */

@@ -85,15 +86,10 @@ static int exynos_usb_parse_dt(const void *blob, struct exynos_ehci *exynos)
 }
 #endif
 
-/* Setup the EHCI host controller. */
-static void setup_usb_phy(struct exynos_usb_phy *usb)
+static void exynos5_setup_usb_phy(struct exynos_usb_phy *usb)
 {
 	u32 hsic_ctrl;
 
-	set_usbhost_mode(USB20_PHY_CFG_HOST_LINK_EN);
-
-	set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_EN);
-
 	clrbits_le32(&usb->usbphyctrl0,
 			HOST_CTRL0_FSEL_MASK |
 			HOST_CTRL0_COMMONON_N |

@@ -150,8 +146,32 @@ static void setup_usb_phy(struct exynos_usb_phy *usb)
 			EHCICTRL_ENAINCR16);
 }
 
-/* Reset the EHCI host controller. */
-static void reset_usb_phy(struct exynos_usb_phy *usb)
+static void exynos4412_setup_usb_phy(struct exynos4412_usb_phy *usb)
+{
+	writel(CLK_24MHZ, &usb->usbphyclk);
+
+	clrbits_le32(&usb->usbphyctrl, (PHYPWR_NORMAL_MASK_HSIC0 |
+		PHYPWR_NORMAL_MASK_HSIC1 | PHYPWR_NORMAL_MASK_PHY1 |
+		PHYPWR_NORMAL_MASK_PHY0));
+
+	setbits_le32(&usb->usbphyrstcon, (RSTCON_HOSTPHY_SWRST | RSTCON_SWRST));
+	udelay(10);
+	clrbits_le32(&usb->usbphyrstcon, (RSTCON_HOSTPHY_SWRST | RSTCON_SWRST));
+}
+
+static void setup_usb_phy(struct exynos_usb_phy *usb)
+{
+	set_usbhost_mode(USB20_PHY_CFG_HOST_LINK_EN);
+
+	set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_EN);
+
+	if (cpu_is_exynos5())
+		exynos5_setup_usb_phy(usb);
+	else if (proid_is_exynos4412())
+		exynos4412_setup_usb_phy((struct exynos4412_usb_phy *)usb);
+}
+
+static void exynos5_reset_usb_phy(struct exynos_usb_phy *usb)
 {
 	u32 hsic_ctrl;
 

@@ -171,6 +191,22 @@ static void reset_usb_phy(struct exynos_usb_phy *usb)
 
 	setbits_le32(&usb->hsicphyctrl1, hsic_ctrl);
 	setbits_le32(&usb->hsicphyctrl2, hsic_ctrl);
+}
+
+static void exynos4412_reset_usb_phy(struct exynos4412_usb_phy *usb)
+{
+	setbits_le32(&usb->usbphyctrl, (PHYPWR_NORMAL_MASK_HSIC0 |
+		PHYPWR_NORMAL_MASK_HSIC1 | PHYPWR_NORMAL_MASK_PHY1 |
+		PHYPWR_NORMAL_MASK_PHY0));
+}
+
+/* Reset the EHCI host controller. */
+static void reset_usb_phy(struct exynos_usb_phy *usb)
+{
+	if (cpu_is_exynos5())
+		exynos5_reset_usb_phy(usb);
+	else if (proid_is_exynos4412())
+		exynos4412_reset_usb_phy((struct exynos4412_usb_phy *)usb);
 
 	set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_DISABLE);
 }
include/configs/odroid.h +13 -0
index b616ac2..3fc0508 100644
@@ -200,6 +200,19 @@
 
 #define CONFIG_CMD_GPIO
 
+/* USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_EXYNOS
+#define CONFIG_USB_STORAGE
+
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS	3
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_DHCP
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_SMSC95XX
+
 /*
  * Supported Odroid boards: X3, U3
  * TODO: Add Odroid X support
author
#3 lore raw

PATCH 2/2 odroid: usb: add support for usb host including ethernet

Hello Jaehoon,

Quoted 4 lines · Jaehoon Chung

Hi, Suriyan.

This patch can be separated.

OK, I shall separate out the power.c/power.h changes for enabling and disabling the usbhost phy.

Quoted 73 lines · Suriyan Ramasami
Quoted 72 lines

This change adds support for enabling the USB host features of the board. This includes the USB3503A hub and the SMC LAN9730 ethernet controller as well.

Credit goes to Tushar Behera (Linaro) for the function set_usb_ethaddr().

Signed-off-by Suriyan Ramasami <[email protected]>
---
 arch/arm/cpu/armv7/exynos/power.c        | 26 +++++++++++++++
 arch/arm/dts/exynos4412-odroid.dts       | 11 +++++++
 arch/arm/include/asm/arch-exynos/cpu.h   |  2 ++
 arch/arm/include/asm/arch-exynos/ehci.h  | 13 ++++++++
 arch/arm/include/asm/arch-exynos/power.h |  7 ++++
 board/samsung/odroid/odroid.c            | 55 ++++++++++++++++++++++++++++++++
 drivers/usb/host/ehci-exynos.c           | 52 +++++++++++++++++++++++++-----
 include/configs/odroid.h                 | 13 ++++++++
 8 files changed, 171 insertions(+), 8 deletions(-)
arch/arm/cpu/armv7/exynos/power.c +26 -0
index e1ab3d6..6578a07 100644
@@ -53,10 +53,36 @@ void exynos5_set_usbhost_phy_ctrl(unsigned int enable)
      }
 }
 
+void exynos4412_set_usbhost_phy_ctrl(unsigned int enable)
+{
+     struct exynos4412_power *power =
+             (struct exynos4412_power *)samsung_get_base_power();
+
+     if (enable) {
+             /* Enabling USBHOST_PHY */
+             setbits_le32(&power->usbhost_phy_control,
+                          POWER_USB_HOST_PHY_CTRL_EN);
+             setbits_le32(&power->hsic1_phy_control,
+                          POWER_USB_HOST_PHY_CTRL_EN);
+             setbits_le32(&power->hsic2_phy_control,
+                          POWER_USB_HOST_PHY_CTRL_EN);
+     } else {
+             /* Disabling USBHOST_PHY */
+             clrbits_le32(&power->usbhost_phy_control,
+                          POWER_USB_HOST_PHY_CTRL_EN);
+             clrbits_le32(&power->hsic1_phy_control,
+                          POWER_USB_HOST_PHY_CTRL_EN);
+             clrbits_le32(&power->hsic2_phy_control,
+                          POWER_USB_HOST_PHY_CTRL_EN);
+     }
+}
+
 void set_usbhost_phy_ctrl(unsigned int enable)
 {
      if (cpu_is_exynos5())
              exynos5_set_usbhost_phy_ctrl(enable);
+     else if (proid_is_exynos4412())
+             exynos4412_set_usbhost_phy_ctrl(enable);
 }
 
 static void exynos5_set_usbdrd_phy_ctrl(unsigned int enable)
arch/arm/dts/exynos4412-odroid.dts +5 -0
index 24d0bf1..8da8568 100644
@@ -67,4 +67,15 @@
              div = <0x3>;
              index = <4>;
      };
+
+        ehci at 12580000 {
+                compatible = "samsung,exynos-ehci";
+                reg = <0x12580000 0x100>;
+             #address-cells = <1>;
Quoted 9 lines

arch/arm/dts/exynos4412-odroid.dts line 80

Quoted 6 lines
arch/arm/dts/exynos4412-odroid.dts +6 -0
+             #size-cells = <1>;
+                phy {
+                        compatible = "samsung,exynos-usb-phy";
+                        reg = <0x125B0000 0x100>;
+                };
+        };

Fix the indentation.

Shall do that.

Thanks
- Suriyan

Quoted 248 lines

Best Regards,
Jaehoon Chung

Quoted 244 lines
arch/arm/dts/exynos4412-odroid.dts +0 -0
 };
arch/arm/include/asm/arch-exynos/cpu.h +2 -0
index ba71714..fda21fb 100644
@@ -18,6 +18,8 @@
 
 #define EXYNOS4_GPIO_PART3_BASE              0x03860000
 #define EXYNOS4_PRO_ID                       0x10000000
+#define EXYNOS4_GUID_LOW             0x10000014
+#define EXYNOS4_GUID_HIGH            0x10000018
 #define EXYNOS4_SYSREG_BASE          0x10010000
 #define EXYNOS4_POWER_BASE           0x10020000
 #define EXYNOS4_SWRESET                      0x10020400
arch/arm/include/asm/arch-exynos/ehci.h +13 -0
index d2d70bd..3800fa9 100644
@@ -12,6 +12,13 @@
 
 #define CLK_24MHZ            5
 
+#define PHYPWR_NORMAL_MASK_PHY0                 (0x39 << 0)
+#define PHYPWR_NORMAL_MASK_PHY1                 (0x7 << 6)
+#define PHYPWR_NORMAL_MASK_HSIC0                (0x7 << 9)
+#define PHYPWR_NORMAL_MASK_HSIC1                (0x7 << 12)
+#define RSTCON_HOSTPHY_SWRST                    (0xf << 3)
+#define RSTCON_SWRST                            (0x1 << 0)
+
 #define HOST_CTRL0_PHYSWRSTALL                       (1 << 31)
 #define HOST_CTRL0_COMMONON_N                        (1 << 9)
 #define HOST_CTRL0_SIDDQ                     (1 << 6)

@@ -61,6 +68,12 @@ struct exynos_usb_phy {
      unsigned int usbotgtune;
 };
 
+struct exynos4412_usb_phy {
+     unsigned int usbphyctrl;
+     unsigned int usbphyclk;
+     unsigned int usbphyrstcon;
+};
+
 /* Switch on the VBUS power. */
 int board_usb_vbus_init(void);
arch/arm/include/asm/arch-exynos/power.h +7 -0
index e8a98a5..3f97b31 100644
@@ -210,6 +210,13 @@ struct exynos4_power {
      unsigned int    gps_alive_option;
 };
 
+struct exynos4412_power {
+     unsigned char   res1[0x0704];
+     unsigned int    usbhost_phy_control;
+     unsigned int    hsic1_phy_control;
+     unsigned int    hsic2_phy_control;
+};
+
 struct exynos5_power {
      unsigned int    om_stat;
      unsigned char   res1[0x18];
board/samsung/odroid/odroid.c +55 -0
index fd5d2d2..4764a71 100644
@@ -453,9 +453,64 @@ struct s3c_plat_otg_data s5pc210_otg_data = {
      .usb_phy_ctrl   = EXYNOS4X12_USBPHY_CONTROL,
      .usb_flags      = PHY0_SLEEP,
 };
+#endif
+
+#if defined(CONFIG_USB_GADGET) || defined(CONFIG_CMD_USB)
+
+#ifdef CONFIG_CMD_USB
+static void set_usb_ethaddr(void)
+{
+     int i;
+     uchar mac[6];
+     unsigned int guid_high = readl(EXYNOS4_GUID_HIGH);
+     unsigned int guid_low = readl(EXYNOS4_GUID_LOW);
+
+     for (i = 0; i < 2; i++)
+             mac[i] = (guid_high >> (8 * (1 - i))) & 0xFF;
+
+     for (i = 0; i < 4; i++)
+             mac[i+2] = (guid_low >> (8 * (3 - i))) & 0xFF;
+
+     /* mark it as not multicast and outside official 80211 MAC namespace */
+     mac[0] = (mac[0] & ~0x1) | 0x2;
+
+     eth_setenv_enetaddr("ethaddr", mac);
+     eth_setenv_enetaddr("usbethaddr", mac);
+}
+#endif
 
 int board_usb_init(int index, enum usb_init_type init)
 {
+#ifdef CONFIG_CMD_USB
+     struct pmic *p_pmic;
+
+     /* Set Ref freq 0 => 24MHz, 1 => 26MHz*/
+     /* Odroid Us have it at 24MHz, Odroid Xs at 26MHz */
+     if (gd->board_type == ODROID_TYPE_U3)
+             gpio_direction_output(EXYNOS4X12_GPIO_X30, 0);
+     else
+             gpio_direction_output(EXYNOS4X12_GPIO_X30, 1);
+
+     /* Disconnect, Reset, Connect */
+     gpio_direction_output(EXYNOS4X12_GPIO_X34, 0);
+     gpio_direction_output(EXYNOS4X12_GPIO_X35, 0);
+     gpio_direction_output(EXYNOS4X12_GPIO_X35, 1);
+     gpio_direction_output(EXYNOS4X12_GPIO_X34, 1);
+
+     /* Power off and on BUCK8 for LAN9730 */
+     debug("LAN9730 - Turning power buck 8 OFF and ON.\n");
+
+     p_pmic = pmic_get("MAX77686_PMIC");
+     if (p_pmic && !pmic_probe(p_pmic)) {
+             max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF);
+             max77686_set_buck_voltage(p_pmic, 8, 750000);
+             max77686_set_buck_voltage(p_pmic, 8, 3300000);
+             max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);
+     }
+
+     set_usb_ethaddr();
+#endif
+
      debug("USB_udc_probe\n");
      return s3c_udc_probe(&s5pc210_otg_data);
 }
drivers/usb/host/ehci-exynos.c +44 -8
index edd91a8..91f3c72 100644
@@ -19,6 +19,7 @@
 #include <asm/gpio.h>
 #include <asm-generic/errno.h>
 #include <linux/compat.h>
+#include <power/max77686_pmic.h>
 #include "ehci.h"
 
 /* Declare global data pointer */

@@ -85,15 +86,10 @@ static int exynos_usb_parse_dt(const void *blob, struct exynos_ehci *exynos)
 }
 #endif
 
-/* Setup the EHCI host controller. */
-static void setup_usb_phy(struct exynos_usb_phy *usb)
+static void exynos5_setup_usb_phy(struct exynos_usb_phy *usb)
 {
      u32 hsic_ctrl;
 
-     set_usbhost_mode(USB20_PHY_CFG_HOST_LINK_EN);
-
-     set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_EN);
-
      clrbits_le32(&usb->usbphyctrl0,
                      HOST_CTRL0_FSEL_MASK |
                      HOST_CTRL0_COMMONON_N |

@@ -150,8 +146,32 @@ static void setup_usb_phy(struct exynos_usb_phy *usb)
                      EHCICTRL_ENAINCR16);
 }
 
-/* Reset the EHCI host controller. */
-static void reset_usb_phy(struct exynos_usb_phy *usb)
+static void exynos4412_setup_usb_phy(struct exynos4412_usb_phy *usb)
+{
+     writel(CLK_24MHZ, &usb->usbphyclk);
+
+     clrbits_le32(&usb->usbphyctrl, (PHYPWR_NORMAL_MASK_HSIC0 |
+             PHYPWR_NORMAL_MASK_HSIC1 | PHYPWR_NORMAL_MASK_PHY1 |
+             PHYPWR_NORMAL_MASK_PHY0));
+
+     setbits_le32(&usb->usbphyrstcon, (RSTCON_HOSTPHY_SWRST | RSTCON_SWRST));
+     udelay(10);
+     clrbits_le32(&usb->usbphyrstcon, (RSTCON_HOSTPHY_SWRST | RSTCON_SWRST));
+}
+
+static void setup_usb_phy(struct exynos_usb_phy *usb)
+{
+     set_usbhost_mode(USB20_PHY_CFG_HOST_LINK_EN);
+
+     set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_EN);
+
+     if (cpu_is_exynos5())
+             exynos5_setup_usb_phy(usb);
+     else if (proid_is_exynos4412())
+             exynos4412_setup_usb_phy((struct exynos4412_usb_phy *)usb);
+}
+
+static void exynos5_reset_usb_phy(struct exynos_usb_phy *usb)
 {
      u32 hsic_ctrl;
 

@@ -171,6 +191,22 @@ static void reset_usb_phy(struct exynos_usb_phy *usb)
 
      setbits_le32(&usb->hsicphyctrl1, hsic_ctrl);
      setbits_le32(&usb->hsicphyctrl2, hsic_ctrl);
+}
+
+static void exynos4412_reset_usb_phy(struct exynos4412_usb_phy *usb)
+{
+     setbits_le32(&usb->usbphyctrl, (PHYPWR_NORMAL_MASK_HSIC0 |
+             PHYPWR_NORMAL_MASK_HSIC1 | PHYPWR_NORMAL_MASK_PHY1 |
+             PHYPWR_NORMAL_MASK_PHY0));
+}
+
+/* Reset the EHCI host controller. */
+static void reset_usb_phy(struct exynos_usb_phy *usb)
+{
+     if (cpu_is_exynos5())
+             exynos5_reset_usb_phy(usb);
+     else if (proid_is_exynos4412())
+             exynos4412_reset_usb_phy((struct exynos4412_usb_phy *)usb);
 
      set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_DISABLE);
 }
include/configs/odroid.h +13 -0
index b616ac2..3fc0508 100644
@@ -200,6 +200,19 @@
 
 #define CONFIG_CMD_GPIO
 
+/* USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_EXYNOS
+#define CONFIG_USB_STORAGE
+
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS   3
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_DHCP
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_SMSC95XX
+
 /*
  * Supported Odroid boards: X3, U3
  * TODO: Add Odroid X support
#4 lore raw

PATCH 1/2 odroid: pmic77686: allow bucket voltage settings

In reply to Suriyan Ramasami

Dear Suriyan,

I will try to test it after the weekend.

I'm working on a PMIC framework V3 with Trats2 as a base and the buck mode/voltage for Max77686 are yet implemented in my code.

But this is okay because the new driver is fully reworked into new file and the support to the old PMIC framework will be still keept before move all the drivers to PMIC v3.

The RFC will send soon.

Quoted 96 lines · Suriyan Ramasami

Allow to set the bucket voltage for the max77686.
This will be used to reset the SMC LAN9730 ethernet on the odroids.

Signed-off-by Suriyan Ramasami <[email protected]>
---
  drivers/power/pmic/pmic_max77686.c | 48 +++++++++++++++++++++++++++++++++++++-
  include/power/max77686_pmic.h      |  3 +++
  2 files changed, 50 insertions(+), 1 deletion(-)
drivers/power/pmic/pmic_max77686.c +47 -1
index df1fd91..1aeadb4 100644
@@ -42,6 +42,25 @@ static unsigned int max77686_ldo_volt2hex(int ldo, ulong uV)
  	return 0;
  }
 
+static unsigned int max77686_buck_volt2hex(int buck, ulong uV)
+{
+	unsigned int hex = 0;
+
+	if (buck < 5 || buck > 9) {
+		debug("%s: buck %d is not supported\n", __func__, buck);
+		return 0;
+	}
+
+	hex = (uV - 750000) / 50000;
+
+	if (hex >= 0 && hex <= MAX77686_BUCK_VOLT_MAX_HEX)
+		return hex;
+
+	debug("%s: %ld is wrong voltage value for BUCK%d\n",
+	      __func__, uV, buck);
+	return MAX77686_BUCK_VOLT_MAX_HEX + 1;
+}
+
  int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
  {
  	unsigned int val, ret, hex, adr;

@@ -68,6 +87,33 @@ int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
  	return ret;
  }
 
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV)
+{
+	unsigned int val, ret, hex, adr;
+
+	if (buck < 5 && buck > 9) {
+		printf("%s: %d is an unsupported bucket number\n",
+		       __func__, buck);
+		return -1;
+	}
+
+	adr = max77686_buck_addr[buck] + 1;
+	hex = max77686_buck_volt2hex(buck, uV);
+
+	if (hex == MAX77686_BUCK_VOLT_MAX_HEX + 1)
+		return -1;
+
+	ret = pmic_reg_read(p, adr, &val);
+	if (ret)
+		return ret;
+
+	val &= ~MAX77686_BUCK_VOLT_MASK;
+	val |= hex;
+	ret |= pmic_reg_write(p, adr, val);
+
+	return ret;
+}
+
  int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode)
  {
  	unsigned int val, ret, adr, mode;

@@ -157,7 +203,7 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode)
  	/* mode */
  	switch (opmode) {
  	case OPMODE_OFF:
-		mode = MAX77686_BUCK_MODE_OFF;
+		mode = MAX77686_BUCK_MODE_OFF << mode_shift;
  		break;
  	case OPMODE_STANDBY:
  		switch (buck) {
include/power/max77686_pmic.h +1 -0
index c2a772a..b0e4255 100644
@@ -150,6 +150,7 @@ enum {
 
  int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV);
  int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode);
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV);
  int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 
  #define MAX77686_LDO_VOLT_MAX_HEX	0x3f

include/power/max77686_pmic.h int max77686_set_buck_mode(struct pmic *p, int buck, char opmode); · line 167

Quoted 8 lines
include/power/max77686_pmic.h +2 -0
@@ -159,6 +160,8 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
  #define MAX77686_LDO_MODE_STANDBY	(0x01 << 0x06)
  #define MAX77686_LDO_MODE_LPM		(0x02 << 0x06)
  #define MAX77686_LDO_MODE_ON		(0x03 << 0x06)
+#define MAX77686_BUCK_VOLT_MAX_HEX	0x3f
+#define MAX77686_BUCK_VOLT_MASK		0x3f
  #define MAX77686_BUCK_MODE_MASK		0x03
  #define MAX77686_BUCK_MODE_SHIFT_1	0x00
  #define MAX77686_BUCK_MODE_SHIFT_2	0x04

Best regards,

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
author
#5 lore raw

PATCH 1/2 odroid: pmic77686: allow bucket voltage settings

Quoted 4 lines · Przemyslaw Marczak

Dear Suriyan,

I will try to test it after the weekend.

Quoted 9 lines

I'm working on a PMIC framework V3 with Trats2 as a base and the buck mode/voltage for Max77686 are yet implemented in my code.

But this is okay because the new driver is fully reworked into new file and the support to the old PMIC framework will be still keept before move all the drivers to PMIC v3.

The RFC will send soon.

Thanks Przemyslaw,
Just FYI, I tested the USB host on the Odroid U2, a U3 and an X2.

Regards
- Suriyan

Quoted 120 lines · Suriyan Ramasami
Quoted 109 lines

Allow to set the bucket voltage for the max77686.
This will be used to reset the SMC LAN9730 ethernet on the odroids.

Signed-off-by Suriyan Ramasami <[email protected]>
---
  drivers/power/pmic/pmic_max77686.c | 48
+++++++++++++++++++++++++++++++++++++-
  include/power/max77686_pmic.h      |  3 +++
  2 files changed, 50 insertions(+), 1 deletion(-)
drivers/power/pmic/pmic_max77686.c +19 -0
index df1fd91..1aeadb4 100644
@@ -42,6 +42,25 @@ static unsigned int max77686_ldo_volt2hex(int ldo,
 ulong uV)
        return 0;
  }
 
+static unsigned int max77686_buck_volt2hex(int buck, ulong uV)
+{
+       unsigned int hex = 0;
+
+       if (buck < 5 || buck > 9) {
+               debug("%s: buck %d is not supported\n", __func__, buck);
+               return 0;
+       }
+
+       hex = (uV - 750000) / 50000;
+
+       if (hex >= 0 && hex <= MAX77686_BUCK_VOLT_MAX_HEX)
+               return hex;
+
+       debug("%s: %ld is wrong voltage value for BUCK%d\n",
+             __func__, uV, buck);
+       return MAX77686_BUCK_VOLT_MAX_HEX + 1;
+}
+
  int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
  {

        unsigned int val, ret, hex, adr;
drivers/power/pmic/pmic_max77686.c +27 -0
@@ -68,6 +87,33 @@ int max77686_set_ldo_voltage(struct pmic *p, int ldo,
 ulong uV)
        return ret;
  }
 
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV)
+{
+       unsigned int val, ret, hex, adr;
+
+       if (buck < 5 && buck > 9) {
+               printf("%s: %d is an unsupported bucket number\n",
+                      __func__, buck);
+               return -1;
+       }
+
+       adr = max77686_buck_addr[buck] + 1;
+       hex = max77686_buck_volt2hex(buck, uV);
+
+       if (hex == MAX77686_BUCK_VOLT_MAX_HEX + 1)
+               return -1;
+
+       ret = pmic_reg_read(p, adr, &val);
+       if (ret)
+               return ret;
+
+       val &= ~MAX77686_BUCK_VOLT_MASK;
+       val |= hex;
+       ret |= pmic_reg_write(p, adr, val);
+
+       return ret;
+}
+
  int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode)
  {

        unsigned int val, ret, adr, mode;
drivers/power/pmic/pmic_max77686.c +1 -1
@@ -157,7 +203,7 @@ int max77686_set_buck_mode(struct pmic *p, int buck,
 char opmode)
        /* mode */
        switch (opmode) {
        case OPMODE_OFF:
-               mode = MAX77686_BUCK_MODE_OFF;
+               mode = MAX77686_BUCK_MODE_OFF << mode_shift;
                break;
        case OPMODE_STANDBY:

                switch (buck) {
include/power/max77686_pmic.h +3 -0
index c2a772a..b0e4255 100644
@@ -150,6 +150,7 @@ enum {
 
  int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV);
  int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode);
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV);
  int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 
  #define MAX77686_LDO_VOLT_MAX_HEX     0x3f

@@ -159,6 +160,8 @@ int max77686_set_buck_mode(struct pmic *p, int buck,
 char opmode);
  #define MAX77686_LDO_MODE_STANDBY     (0x01 << 0x06)
  #define MAX77686_LDO_MODE_LPM         (0x02 << 0x06)
  #define MAX77686_LDO_MODE_ON          (0x03 << 0x06)
+#define MAX77686_BUCK_VOLT_MAX_HEX     0x3f
+#define MAX77686_BUCK_VOLT_MASK                0x3f
  #define MAX77686_BUCK_MODE_MASK               0x03
  #define MAX77686_BUCK_MODE_SHIFT_1    0x00
Quoted 2 lines
  #define MAX77686_BUCK_MODE_SHIFT_2    0x04

Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

#6 lore raw

PATCH 1/2 odroid: pmic77686: allow bucket voltage settings

In reply to Suriyan Ramasami

Hi Suriyan,

Quoted 2 lines · Suriyan Ramasami

Allow to set the bucket voltage for the max77686.
This will be used to reset the SMC LAN9730 ethernet on the odroids.

I believe the correct term is "buck", not "bucket".

Quoted 92 lines
Signed-off-by Suriyan Ramasami <[email protected]>
---
 drivers/power/pmic/pmic_max77686.c | 48 +++++++++++++++++++++++++++++++++++++-
 include/power/max77686_pmic.h      |  3 +++
 2 files changed, 50 insertions(+), 1 deletion(-)
drivers/power/pmic/pmic_max77686.c +47 -1
index df1fd91..1aeadb4 100644
@@ -42,6 +42,25 @@ static unsigned int max77686_ldo_volt2hex(int ldo, ulong uV)
 	return 0;
 }
 
+static unsigned int max77686_buck_volt2hex(int buck, ulong uV)
+{
+	unsigned int hex = 0;
+
+	if (buck < 5 || buck > 9) {
+		debug("%s: buck %d is not supported\n", __func__, buck);
+		return 0;
+	}
+
+	hex = (uV - 750000) / 50000;
+
+	if (hex >= 0 && hex <= MAX77686_BUCK_VOLT_MAX_HEX)
+		return hex;
+
+	debug("%s: %ld is wrong voltage value for BUCK%d\n",
+	      __func__, uV, buck);
+	return MAX77686_BUCK_VOLT_MAX_HEX + 1;
+}
+
 int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
 {
 	unsigned int val, ret, hex, adr;

@@ -68,6 +87,33 @@ int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
 	return ret;
 }
 
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV)
+{
+	unsigned int val, ret, hex, adr;
+
+	if (buck < 5 && buck > 9) {
+		printf("%s: %d is an unsupported bucket number\n",
+		       __func__, buck);
+		return -1;
+	}
+
+	adr = max77686_buck_addr[buck] + 1;
+	hex = max77686_buck_volt2hex(buck, uV);
+
+	if (hex == MAX77686_BUCK_VOLT_MAX_HEX + 1)
+		return -1;
+
+	ret = pmic_reg_read(p, adr, &val);
+	if (ret)
+		return ret;
+
+	val &= ~MAX77686_BUCK_VOLT_MASK;
+	val |= hex;
+	ret |= pmic_reg_write(p, adr, val);
+
+	return ret;
+}
+
 int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode)
 {
 	unsigned int val, ret, adr, mode;

@@ -157,7 +203,7 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode)
 	/* mode */
 	switch (opmode) {
 	case OPMODE_OFF:
-		mode = MAX77686_BUCK_MODE_OFF;
+		mode = MAX77686_BUCK_MODE_OFF << mode_shift;
 		break;
 	case OPMODE_STANDBY:
 		switch (buck) {
include/power/max77686_pmic.h +1 -0
index c2a772a..b0e4255 100644
@@ -150,6 +150,7 @@ enum {
 
 int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV);
 int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode);
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV);
 int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 
 #define MAX77686_LDO_VOLT_MAX_HEX	0x3f

include/power/max77686_pmic.h int max77686_set_buck_mode(struct pmic *p, int buck, char opmode); · line 167

Quoted 8 lines
include/power/max77686_pmic.h +2 -0
@@ -159,6 +160,8 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 #define MAX77686_LDO_MODE_STANDBY	(0x01 << 0x06)
 #define MAX77686_LDO_MODE_LPM		(0x02 << 0x06)
 #define MAX77686_LDO_MODE_ON		(0x03 << 0x06)
+#define MAX77686_BUCK_VOLT_MAX_HEX	0x3f
+#define MAX77686_BUCK_VOLT_MASK		0x3f
 #define MAX77686_BUCK_MODE_MASK		0x03
 #define MAX77686_BUCK_MODE_SHIFT_1	0x00
 #define MAX77686_BUCK_MODE_SHIFT_2	0x04

Amicalement,

Signature · 1 line
Albert.
author
#7 lore raw

PATCH 1/2 odroid: pmic77686: allow bucket voltage settings

Quoted 10 lines · Albert ARIBAUD

Hi Suriyan,

Quoted 2 lines · Suriyan Ramasami

Allow to set the bucket voltage for the max77686.
This will be used to reset the SMC LAN9730 ethernet on the odroids.

I believe the correct term is "buck", not "bucket".

Thanks Albert,
I always thought they stood for bucket! This prompted me to read up
on BUCK regulators. Thank you. I shall correct it in my next version.

- Suriyan

Quoted 105 lines
Quoted 92 lines
Signed-off-by Suriyan Ramasami <[email protected]>
---
 drivers/power/pmic/pmic_max77686.c | 48 +++++++++++++++++++++++++++++++++++++-
 include/power/max77686_pmic.h      |  3 +++
 2 files changed, 50 insertions(+), 1 deletion(-)
drivers/power/pmic/pmic_max77686.c +47 -1
index df1fd91..1aeadb4 100644
@@ -42,6 +42,25 @@ static unsigned int max77686_ldo_volt2hex(int ldo, ulong uV)
      return 0;
 }
 
+static unsigned int max77686_buck_volt2hex(int buck, ulong uV)
+{
+     unsigned int hex = 0;
+
+     if (buck < 5 || buck > 9) {
+             debug("%s: buck %d is not supported\n", __func__, buck);
+             return 0;
+     }
+
+     hex = (uV - 750000) / 50000;
+
+     if (hex >= 0 && hex <= MAX77686_BUCK_VOLT_MAX_HEX)
+             return hex;
+
+     debug("%s: %ld is wrong voltage value for BUCK%d\n",
+           __func__, uV, buck);
+     return MAX77686_BUCK_VOLT_MAX_HEX + 1;
+}
+
 int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
 {
      unsigned int val, ret, hex, adr;

@@ -68,6 +87,33 @@ int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV)
      return ret;
 }
 
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV)
+{
+     unsigned int val, ret, hex, adr;
+
+     if (buck < 5 && buck > 9) {
+             printf("%s: %d is an unsupported bucket number\n",
+                    __func__, buck);
+             return -1;
+     }
+
+     adr = max77686_buck_addr[buck] + 1;
+     hex = max77686_buck_volt2hex(buck, uV);
+
+     if (hex == MAX77686_BUCK_VOLT_MAX_HEX + 1)
+             return -1;
+
+     ret = pmic_reg_read(p, adr, &val);
+     if (ret)
+             return ret;
+
+     val &= ~MAX77686_BUCK_VOLT_MASK;
+     val |= hex;
+     ret |= pmic_reg_write(p, adr, val);
+
+     return ret;
+}
+
 int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode)
 {
      unsigned int val, ret, adr, mode;

@@ -157,7 +203,7 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode)
      /* mode */
      switch (opmode) {
      case OPMODE_OFF:
-             mode = MAX77686_BUCK_MODE_OFF;
+             mode = MAX77686_BUCK_MODE_OFF << mode_shift;
              break;
      case OPMODE_STANDBY:
              switch (buck) {
include/power/max77686_pmic.h +1 -0
index c2a772a..b0e4255 100644
@@ -150,6 +150,7 @@ enum {
 
 int max77686_set_ldo_voltage(struct pmic *p, int ldo, ulong uV);
 int max77686_set_ldo_mode(struct pmic *p, int ldo, char opmode);
+int max77686_set_buck_voltage(struct pmic *p, int buck, ulong uV);
 int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 
 #define MAX77686_LDO_VOLT_MAX_HEX    0x3f

include/power/max77686_pmic.h int max77686_set_buck_mode(struct pmic *p, int buck, char opmode); · line 167

Quoted 8 lines
include/power/max77686_pmic.h +2 -0
@@ -159,6 +160,8 @@ int max77686_set_buck_mode(struct pmic *p, int buck, char opmode);
 #define MAX77686_LDO_MODE_STANDBY    (0x01 << 0x06)
 #define MAX77686_LDO_MODE_LPM                (0x02 << 0x06)
 #define MAX77686_LDO_MODE_ON         (0x03 << 0x06)
+#define MAX77686_BUCK_VOLT_MAX_HEX   0x3f
+#define MAX77686_BUCK_VOLT_MASK              0x3f
 #define MAX77686_BUCK_MODE_MASK              0x03
 #define MAX77686_BUCK_MODE_SHIFT_1   0x00
 #define MAX77686_BUCK_MODE_SHIFT_2   0x04

Amicalement,
--
Albert.