drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM
PATCH 1/1 drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM
COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error ( with allmodconfig under um):
CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o
drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
dev->mmio = ioremap(membase, II20K_SIZE);
^
drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
dev->mmio = ioremap(membase, II20K_SIZE);
^
drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(dev->mmio);
^--- drivers/staging/comedi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/staging/comedi/Kconfig +1 -0
@@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16 config COMEDI_II_PCI20KC tristate "Intelligent Instruments PCI-20001C carrier support" + depends on HAS_IOMEM ---help--- Enable support for Intelligent Instruments PCI-20001C carrier PCI-20001, PCI-20006 and PCI-20341
Signature · 1 line
1.9.3
Quoted 26 lines · Chen Gang
COMEDI_II_PCI20KCneedsHAS_IOMEM, so depend on it. The related error ( with allmodconfig under um):CC [M]
drivers/staging/comedi/drivers/ii_pci20kc.o
drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]dev->mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default] dev->mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’: drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(dev->mmio); ^Signed-off-by Chen Gang <[email protected]>--- drivers/staging/comedi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/staging/comedi/Kconfig +0
-0
drivers/staging/comedi/Kconfig config COMEDI_AIO_IIRO_16 · line 432
Quoted 7 lines
drivers/staging/comedi/Kconfig +1
-0@@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16 config COMEDI_II_PCI20KC tristate "Intelligent Instruments PCI-20001C carrier support" + depends on HAS_IOMEM ---help--- Enable support for Intelligent Instruments PCI-20001C carrier PCI-20001, PCI-20006 and PCI-20341
This seems appropriate.
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay� ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�
Quoted 37 lines · Hartley Sweeten
Quoted 26 lines · Chen Gang
COMEDI_II_PCI20KCneedsHAS_IOMEM, so depend on it. The related error ( with allmodconfig under um):CC [M]
drivers/staging/comedi/drivers/ii_pci20kc.o
drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]dev->mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default] dev->mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’: drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(dev->mmio); ^Signed-off-by Chen Gang <[email protected]>--- drivers/staging/comedi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/staging/comedi/Kconfig +0
-0drivers/staging/comedi/Kconfig config COMEDI_AIO_IIRO_16 · line 432
Quoted 7 lines
drivers/staging/comedi/Kconfig +1
-0@@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16 config COMEDI_II_PCI20KC tristate "Intelligent Instruments PCI-20001C carrier support" + depends on HAS_IOMEM ---help--- Enable support for Intelligent Instruments PCI-20001C carrier PCI-20001, PCI-20006 and PCI-20341This seems appropriate.
Quoted 2 lines
Reviewed-by H Hartley Sweeten <[email protected]>
Since "egrep -irn "ioremap" drivers/staging/comedi/drivers | wc -l" shows "39" does it mean that this should be added to all the other drivers as well?
Rostislav Lisovy
Quoted 4 lines · Rostislav Lisovy
Since "egrep -irn "ioremap"
drivers/staging/comedi/drivers| wc -l" shows "39" does it mean that this should be added to all the other drivers as well?
The others are actually pci_ioremap_bar() and those drivers depend on PCI. I don't _think_ these drivers require the depends on HAS_IOMEM.
The ii_pci20kc driver is goofy in that it's actually an ISA board that uses memory mapped I/O.
Regards,
Hartley
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay� ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�
Quoted 16 lines · Chen Gang
COMEDI_II_PCI20KCneedsHAS_IOMEM, so depend on it. The related error ( with allmodconfig under um):CC [M]
drivers/staging/comedi/drivers/ii_pci20kc.o
drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] dev->mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default] dev->mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’: drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(dev->mmio); ^
Quoted 1 line
Signed-off-by Chen Gang <[email protected]>