drivers: staging: wlan-ng: fix sparse warnings

PATCH In review Cheng-wei Lee 2 participants 2 messages Oct 4, 2014 – Oct 8, 2014 Staging

Share & tools

Cheng-wei Lee

author

2014-10-04 02:24 UTC #0 lore raw

PATCH 1/1 drivers: staging: wlan-ng: fix sparse warnings

This patch fix the sparse warnings in wlan-ng/cfg80211.c The following functions were only used in this file, so done by declaring them into static.

drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static? drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol 'prism2_disconnected' was not declared. Should it be static? drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol 'prism2_roamed' was not declared. Should it be static?

Signed-off-by Quentin Lee <[email protected]>

---
 drivers/staging/wlan-ng/cfg80211.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/wlan-ng/cfg80211.c +3 -3

index 723319e..9e65429 100644
@@ -707,7 +707,7 @@ exit:
 
 
 /* Interface callback functions, passing data back up to the cfg80211 layer */
-void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
+static void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
 {
     u16 status = failed ?
              WLAN_STATUS_UNSPECIFIED_FAILURE : WLAN_STATUS_SUCCESS;

@@ -716,13 +716,13 @@ void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
                 NULL, 0, NULL, 0, status, GFP_KERNEL);
 }
 
-void prism2_disconnected(wlandevice_t *wlandev)
+static void prism2_disconnected(wlandevice_t *wlandev)
 {
     cfg80211_disconnected(wlandev->netdev, 0, NULL,
         0, GFP_KERNEL);
 }
 
-void prism2_roamed(wlandevice_t *wlandev)
+static void prism2_roamed(wlandevice_t *wlandev)
 {
     cfg80211_roamed(wlandev->netdev, NULL, wlandev->bssid,
         NULL, 0, NULL, 0, GFP_KERNEL);

Signature · 1 line

1.7.9.5

Greg Kroah-Hartman

maintainer

2014-10-08 22:57 UTC #1 lore raw

Quoted 11 lines · Cheng-wei Lee

This patch fix the sparse warnings in wlan-ng/cfg80211.c The following functions were only used in this file, so done by declaring them into static.
drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static? drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol 'prism2_disconnected' was not declared. Should it be static? drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol 'prism2_roamed' was not declared. Should it be static?

Quoted 4 lines

Signed-off-by Quentin Lee <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

This patch doesn't apply to my staging-testing branch of staging.git, can you refresh it and resend please?

thanks,

greg k-h