Skip to contentSkip to conversation

drivers/watchdog/Kconfig: Let XILINX_WATCHDOG and TEGRA_WATCHDOG depend on HAS_IOMEM

PATCH Superseded Chen Gang 2 participants 6 messages Oct 4, 2014 – Oct 5, 2014 Watchdog device drivers

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers/watchdog/Kconfig: Let XILINX_WATCHDOG and TEGRA_WATCHDOG depend on HAS_IOMEM

They need HAS_IOMEM, so let them depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] undefined!

Signed-off-by Chen Gang <[email protected]>
---
 drivers/watchdog/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/watchdog/Kconfig +2 -1
index a51ccf3..d0ddf90 100644
@@ -132,6 +132,7 @@ config WM8350_WATCHDOG
 
 config XILINX_WATCHDOG
 	tristate "Xilinx Watchdog timer"
+	depends on HAS_IOMEM
 	select WATCHDOG_CORE
 	help
 	  Watchdog driver for the xps_timebase_wdt ip core.

@@ -472,7 +473,7 @@ config SIRFSOC_WATCHDOG
 
 config TEGRA_WATCHDOG
 	tristate "Tegra watchdog"
-	depends on ARCH_TEGRA || COMPILE_TEST
+	depends on (ARCH_TEGRA || COMPILE_TEST) && HAS_IOMEM
 	select WATCHDOG_CORE
 	help
 	  Say Y here to include support for the watchdog timer
Signature · 1 line
1.9.3
author
#1 lore raw
Quoted 5 lines · Chen Gang

They need HAS_IOMEM, so let them depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!

    ^

Sorry, the line above is useless for this issue, please skip it.

Thanks.

Quoted 31 lines

ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] undefined!

Signed-off-by Chen Gang <[email protected]>
---
 drivers/watchdog/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/watchdog/Kconfig +2 -1
index a51ccf3..d0ddf90 100644
@@ -132,6 +132,7 @@ config WM8350_WATCHDOG
 
 config XILINX_WATCHDOG
 	tristate "Xilinx Watchdog timer"
+	depends on HAS_IOMEM
 	select WATCHDOG_CORE
 	help
 	  Watchdog driver for the xps_timebase_wdt ip core.

@@ -472,7 +473,7 @@ config SIRFSOC_WATCHDOG
 
 config TEGRA_WATCHDOG
 	tristate "Tegra watchdog"
-	depends on ARCH_TEGRA || COMPILE_TEST
+	depends on (ARCH_TEGRA || COMPILE_TEST) && HAS_IOMEM
 	select WATCHDOG_CORE
 	help
 	  Say Y here to include support for the watchdog timer
Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
maintainer
#2 lore raw
In reply to Chen Gang
Quoted 8 lines · Chen Gang

They need HAS_IOMEM, so let them depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] undefined!

Headline is a bit excessive ("watchdog: ..." would have been sufficient, the first error is irrelevant as you found out yourself, and you got an extra empty line here. Otherwise looks good.

Can you resubmit with that fixed ?

On a side note, guess the conclusion was to not provide a dummy for devm_ioremap_resource if HAS_IOMEM is not defined. Too bad.

Guenter

Quoted 28 lines
Signed-off-by Chen Gang <[email protected]>
---
  drivers/watchdog/Kconfig | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/watchdog/Kconfig +2 -1
index a51ccf3..d0ddf90 100644
@@ -132,6 +132,7 @@ config WM8350_WATCHDOG
 
  config XILINX_WATCHDOG
  	tristate "Xilinx Watchdog timer"
+	depends on HAS_IOMEM
  	select WATCHDOG_CORE
  	help
  	  Watchdog driver for the xps_timebase_wdt ip core.

@@ -472,7 +473,7 @@ config SIRFSOC_WATCHDOG
 
  config TEGRA_WATCHDOG
  	tristate "Tegra watchdog"
-	depends on ARCH_TEGRA || COMPILE_TEST
+	depends on (ARCH_TEGRA || COMPILE_TEST) && HAS_IOMEM
  	select WATCHDOG_CORE
  	help
  	  Say Y here to include support for the watchdog timer
author
#3 lore raw
Quoted 9 lines · Guenter Roeck
Quoted 8 lines · Chen Gang

They need HAS_IOMEM, so let them depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] undefined!

Quoted 6 lines

Headline is a bit excessive ("watchdog: ..." would have been sufficient, the first error is irrelevant as you found out yourself, and you got an extra empty line here. Otherwise looks good.

Can you resubmit with that fixed ?

OK, thank, I shall send patch v2 for it.

Quoted 3 lines

On a side note, guess the conclusion was to not provide a dummy for devm_ioremap_resource if HAS_IOMEM is not defined. Too bad.

For me, it is checked during config time, so need report error during compiling or building time instead of dummy.

And I'd like to let devm_ioremap* quoted by "#if HAS_IOMEM", so can find this issue during compiling time, not in linking time (which can save builder's time resource).

Thanks.

Quoted 29 lines
Quoted 28 lines
Signed-off-by Chen Gang <[email protected]>
---
  drivers/watchdog/Kconfig | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/watchdog/Kconfig +2 -1
index a51ccf3..d0ddf90 100644
@@ -132,6 +132,7 @@ config WM8350_WATCHDOG
 
  config XILINX_WATCHDOG
      tristate "Xilinx Watchdog timer"
+    depends on HAS_IOMEM
      select WATCHDOG_CORE
      help
        Watchdog driver for the xps_timebase_wdt ip core.

@@ -472,7 +473,7 @@ config SIRFSOC_WATCHDOG
 
  config TEGRA_WATCHDOG
      tristate "Tegra watchdog"
-    depends on ARCH_TEGRA || COMPILE_TEST
+    depends on (ARCH_TEGRA || COMPILE_TEST) && HAS_IOMEM
      select WATCHDOG_CORE
      help
        Say Y here to include support for the watchdog timer
Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
author
#4 lore raw

PATCH v2 1/1 watchdog: Let XILINX_WATCHDOG and TEGRA_WATCHDOG depend on HAS_IOMEM

In reply to Chen Gang

They need HAS_IOMEM, so let them depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] undefined!

Signed-off-by Chen Gang <[email protected]>
---
 drivers/watchdog/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/watchdog/Kconfig +2 -1
index a51ccf3..d0ddf90 100644
@@ -132,6 +132,7 @@ config WM8350_WATCHDOG
 
 config XILINX_WATCHDOG
 	tristate "Xilinx Watchdog timer"
+	depends on HAS_IOMEM
 	select WATCHDOG_CORE
 	help
 	  Watchdog driver for the xps_timebase_wdt ip core.

@@ -472,7 +473,7 @@ config SIRFSOC_WATCHDOG
 
 config TEGRA_WATCHDOG
 	tristate "Tegra watchdog"
-	depends on ARCH_TEGRA || COMPILE_TEST
+	depends on (ARCH_TEGRA || COMPILE_TEST) && HAS_IOMEM
 	select WATCHDOG_CORE
 	help
 	  Say Y here to include support for the watchdog timer
Signature · 1 line
1.9.3
maintainer Reviewed-by on v2 1/1
#5 lore raw

Re: [PATCH v2] watchdog: Let XILINX_WATCHDOG and TEGRA_WATCHDOG depend on HAS_IOMEM

Quoted 8 lines · Chen Gang

They need HAS_IOMEM, so let them depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] undefined!

Signed-off-by Chen Gang <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 26 lines
---
  drivers/watchdog/Kconfig | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/watchdog/Kconfig +2 -1
index a51ccf3..d0ddf90 100644
@@ -132,6 +132,7 @@ config WM8350_WATCHDOG
 
  config XILINX_WATCHDOG
  	tristate "Xilinx Watchdog timer"
+	depends on HAS_IOMEM
  	select WATCHDOG_CORE
  	help
  	  Watchdog driver for the xps_timebase_wdt ip core.

@@ -472,7 +473,7 @@ config SIRFSOC_WATCHDOG
 
  config TEGRA_WATCHDOG
  	tristate "Tegra watchdog"
-	depends on ARCH_TEGRA || COMPILE_TEST
+	depends on (ARCH_TEGRA || COMPILE_TEST) && HAS_IOMEM
  	select WATCHDOG_CORE
  	help
  	  Say Y here to include support for the watchdog timer