drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM

PATCH In review Chen Gang 2 participants 3 messages Oct 4, 2014

Subsystems (4)

Networking Network drivers CAN network drivers Mcan device driver

lore

Share & tools

lore

Chen Gang

author

2014-10-04 09:55 UTC #0 lore raw

PATCH 1/1 drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM

CAN_M_CAN needs HAS_IOMEM, so depend on it, the related error (with allmodconfig under um):

MODPOST 1205 modules
ERROR: "devm_ioremap" [drivers/net/can/m_can/m_can.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/net/can/m_can/m_can.ko] undefined!

Signed-off-by Chen Gang <[email protected]>

---
 drivers/net/can/m_can/Kconfig | 1 +
 1 file changed, 1 insertion(+)

drivers/net/can/m_can/Kconfig +1 -0

index fca5482..14c9fcf 100644
@@ -1,4 +1,5 @@
 config CAN_M_CAN
 	tristate "Bosch M_CAN devices"
+	depends on HAS_IOMEM
 	---help---
 	  Say Y here if you want to support for Bosch M_CAN controller.

Signature · 1 line

1.9.3

Varka Bhadram

2014-10-04 11:05 UTC #1 lore raw

Hi Chen Gang

I think commit message should be short and proper.

We can remove *drivers/net/can/m_can/Kconfig* in the commit, just give *can: Kconfig: *

commit message like : *can: Kconfig: Fix CAN_M_CAN dependency*

Quoted 22 lines · Chen Gang

CAN_M_CAN needs HAS_IOMEM, so depend on it, the related error (with allmodconfig under um):
MODPOST 1205 modules
ERROR: "devm_ioremap" [drivers/net/can/m_can/m_can.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/net/can/m_can/m_can.ko] undefined!
Signed-off-by Chen Gang <[email protected]>
---
  drivers/net/can/m_can/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/net/can/m_can/Kconfig +1 -0
index fca5482..14c9fcf 100644
@@ -1,4 +1,5 @@
  config CAN_M_CAN
  	tristate "Bosch M_CAN devices"
+	depends on HAS_IOMEM
  	---help---
  	  Say Y here if you want to support for Bosch M_CAN controller.

Signature · 2 lines

Thanks and Regards,
Varka Bhadram.

Chen Gang

author

2014-10-04 11:43 UTC #2 lore raw

Quoted 10 lines · Varka Bhadram

Hi Chen Gang
I think commit message should be short and proper.
We can remove *drivers/net/can/m_can/Kconfig* in the commit, just give *can: Kconfig: *
commit message like : *can: Kconfig: Fix CAN_M_CAN dependency*

OK, thanks, it sounds good to me. If necessary to send patch v2 for it, please let me know.

Thanks.

Quoted 24 lines · Chen Gang

Quoted 22 lines
CAN_M_CAN needs HAS_IOMEM, so depend on it, the related error (with allmodconfig under um):
MODPOST 1205 modules
ERROR: "devm_ioremap" [drivers/net/can/m_can/m_can.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/net/can/m_can/m_can.ko] undefined!
Signed-off-by Chen Gang <[email protected]>
---
  drivers/net/can/m_can/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/net/can/m_can/Kconfig +1 -0
index fca5482..14c9fcf 100644
@@ -1,4 +1,5 @@
  config CAN_M_CAN
      tristate "Bosch M_CAN devices"
+    depends on HAS_IOMEM
      ---help---
        Say Y here if you want to support for Bosch M_CAN controller.

Signature · 3 lines

Chen Gang

Open, share, and attitude like air, water, and life which God blessed