arm64: dts: rockchip: fix dmas dma-names for rk3308 i2s node
Subsystems (2)
RFC PATCH 1/1 arm64: dts: rockchip: fix dmas dma-names for rk3308 i2s node
One of the current rk3308 'i2s' nodes has a different dma layout with only 1 item. Table 9-2 DMAC1 Request Mapping Table shows that there 2 dma sources available, so fix the dmas and dma-names for the rk3308 'i2s' node.
10 I2S/PCM_2CH_1 tx High level
11 I2S/PCM_2CH_1 rx High level
--- arch/arm64/boot/dts/rockchip/rk3308.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3308.dtsi +2 -2
@@ -564,8 +564,8 @@ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cru SCLK_I2S1_2CH>, <&cru HCLK_I2S1_2CH>; clock-names = "i2s_clk", "i2s_hclk"; - dmas = <&dmac1 11>; - dma-names = "rx"; + dmas = <&dmac1 10>, <&dmac1 11>; + dma-names = "tx", "rx"; resets = <&cru SRST_I2S1_2CH_M>, <&cru SRST_I2S1_2CH_H>; reset-names = "reset-m", "reset-h"; status = "disabled";
Signature · 1 line
2.11.0
Quoted 7 lines · Johan Jonker
One of the current rk3308 'i2s' nodes has a different dma layout with only 1 item. Table 9-2 DMAC1 Request Mapping Table shows that there 2 dma sources available, so fix the dmas and dma-names for the rk3308 'i2s' node.
10 I2S/PCM_2CH_1 tx High level
11 I2S/PCM_2CH_1 rx High level
...however table 1-5 in the same manual (at least that I could find) says request 10 is reserved. Does that mean it was intended to be wired up for this, but ended up broken for some reason?
Do you have hardware to confirm whether this works reliably or not?
Robin.
Quoted 21 lines
Signed-off-by Johan Jonker <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3308.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3308.dtsi +2
-2@@ -564,8 +564,8 @@ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cru SCLK_I2S1_2CH>, <&cru HCLK_I2S1_2CH>; clock-names = "i2s_clk", "i2s_hclk"; - dmas = <&dmac1 11>; - dma-names = "rx"; + dmas = <&dmac1 10>, <&dmac1 11>; + dma-names = "tx", "rx"; resets = <&cru SRST_I2S1_2CH_M>, <&cru SRST_I2S1_2CH_H>; reset-names = "reset-m", "reset-h"; status = "disabled";
Hi Robin, Kever, Caesar,
Quoted 6 lines · Robin Murphy
Quoted 5 lines · Johan Jonker
One of the current rk3308 'i2s' nodes has a different dma layout with only 1 item. Table 9-2 DMAC1 Request Mapping Table shows that there 2 dma sources available, so fix the dmas and dma-names for the rk3308 'i2s' node.
Quoted 8 lines
Quoted 2 lines
10 I2S/PCM_2CH_1 tx High level
11 I2S/PCM_2CH_1 rx High level...however table 1-5 in the same manual (at least that I could find) says request 10 is reserved. Does that mean it was intended to be wired up for this, but ended up broken for some reason?
Do you have hardware to confirm whether this works reliably or not?
No, I don't.
A description for 3308 was added to rockchip-i2s.yaml with only rx by myself.
It would be nice if someone could test, confirm or give a hint.
Could someone from Rockchip(Kever, Caesar) explain the 'Reserved' in Table 1-5 ?
Table 1-5 RK3308 DMAC1 hardware request connection list
10 Reserved High level
11 I2S_2CH_1 rx High level
Quoted 25 lines
Robin.
Quoted 22 lines
Signed-off-by Johan Jonker <[email protected]>---
arch/arm64/boot/dts/rockchip/rk3308.dtsi| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3308.dtsi +2
-2@@ -564,8 +564,8 @@ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cru SCLK_I2S1_2CH>, <&cru HCLK_I2S1_2CH>; clock-names = "i2s_clk", "i2s_hclk"; - dmas = <&dmac1 11>; - dma-names = "rx"; + dmas = <&dmac1 10>, <&dmac1 11>; + dma-names = "tx", "rx"; resets = <&cru SRST_I2S1_2CH_M>, <&cru SRST_I2S1_2CH_H>; reset-names = "reset-m", "reset-h"; status = "disabled";