Skip to contentSkip to conversation

serial: mxs-auart: add sysrq support

PATCH New Janusz Uzycki 3 participants 9 messages Sep 26, 2014 – Oct 6, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: mxs-auart: add sysrq support

This is rather obvious patch now.
The patch is resent as cleaned independent from the patchset:
"Re: [PATCH 1/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals (v2.2c)"

Who could apply the patch?

best regards
Janusz

#1 lore raw

PATCH 1/1 serial: mxs-auart: add sysrq support

When using mxs-auart based console, sometime we need the sysrq function to help debugging kernel. The sysrq code is basically there, this patch just simply enable it.

---
 drivers/tty/serial/mxs-auart.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/tty/serial/mxs-auart.c +4 -0
index 9381732..4c998a3 100644
@@ -14,6 +14,10 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
+#if defined(CONFIG_SERIAL_MXS_AUART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
Signature · 1 line
1.7.11.3
#2 lore raw

PATCH 1/1 serial: mxs-auart: add sysrq support

In reply to Janusz Uzycki
Quoted 5 lines · Janusz Uzycki

This is rather obvious patch now.
The patch is resent as cleaned independent from the patchset:
"Re: [PATCH 1/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals (v2.2c)"

Who could apply the patch?

I have so many patches from you for this driver in my inbox, yet almost no idea which to apply. Please always properly label which series obsoletes previous ones, and what order the patches need to be applied in (your latest patches lack this entirely.)

So I'm deleting all of these now, please resend the latest versions you have, with properly versioning and order information.

thanks,

greg k-h

#3 lore raw

PATCH 1/1 serial: mxs-auart: add sysrq support

Quoted 3 lines

So I'm deleting all of these now, please resend the latest versions you have, with properly versioning
and order information.

Sure. If you don't want to comment dirty patches I will not send you them.
I can send you only the final version, commented before.

On the moment this patch is ready to apply.

[PATCH RESEND] serial: mxs-auart: add sysrq support The patch is resent to apply.

reviewer
#4 lore raw

PATCH 1/1 serial: mxs-auart: add sysrq support

Janusz,

Quoted 4 lines · Janusz Uzycki
Quoted 3 lines

So I'm deleting all of these now, please resend the latest versions you have, with properly versioning
and order information.

Quoted 8 lines

Sure. If you don't want to comment dirty patches I will not send you them.
I can send you only the final version, commented before.

On the moment this patch is ready to apply.

[PATCH RESEND] serial: mxs-auart: add sysrq support The patch is resent to apply.

What Greg is asking you to do is to provide a proper version annotation in your patches.

For example: [PATCH v2] serial: mxs-auart: add ...

Then if you need to submit it again you should do:

[PATCH v3] serial: mxs-auart: add ...

Also, always explain below the --- line what changed from one version to another

#5 lore raw

PATCH 1/1 serial: mxs-auart: add sysrq support

Hi,

W dniu 2014-10-04 18:19, Fabio Estevam pisze:

Quoted 14 lines

Janusz,

Quoted 11 lines · Janusz Uzycki
Quoted 3 lines

So I'm deleting all of these now, please resend the latest versions you have, with properly versioning
and order information.

Sure. If you don't want to comment dirty patches I will not send you them.
I can send you only the final version, commented before.

On the moment this patch is ready to apply.

[PATCH RESEND] serial: mxs-auart: add sysrq support The patch is resent to apply.

Quoted 8 lines

What Greg is asking you to do is to provide a proper version annotation in your patches.

For example: [PATCH v2] serial: mxs-auart: add ...

Then if you need to submit it again you should do:

[PATCH v3] serial: mxs-auart: add ...

I will resend the rest of patches (as v4) this week. This simple patch is independent from the previous patchset so I decided to resubmit it alone ([PATCH RESEND] header used) to apply.

I rather shouldn't resend the patch again I guess. I sent the same initial version of the patch twice after Greg's email so I did mess enough I think.

Quoted 1 line

Also, always explain below the --- line what changed from one version to another

I thought composing cover letter is the only solution for resent patch or series.
As I understood this way is appropriate for single patch only (not patch set).
"Below" - it means between the line and diffstat?
Should I add new/second '---' line before diffstat?

best regards
Janusz

reviewer
#6 lore raw

PATCH 1/1 serial: mxs-auart: add sysrq support

Quoted 44 lines · Janusz U?ycki

Hi,

W dniu 2014-10-04 18:19, Fabio Estevam pisze:

Quoted 18 lines

Janusz,

Quoted 5 lines · Janusz Uzycki
Quoted 4 lines

So I'm deleting all of these now, please resend the latest versions you have, with properly versioning
and order information.

Quoted 8 lines

Sure. If you don't want to comment dirty patches I will not send you them.
I can send you only the final version, commented before.

On the moment this patch is ready to apply.

[PATCH RESEND] serial: mxs-auart: add sysrq support The patch is resent to apply.

Quoted 8 lines

What Greg is asking you to do is to provide a proper version annotation in your patches.

For example: [PATCH v2] serial: mxs-auart: add ...

Then if you need to submit it again you should do:

[PATCH v3] serial: mxs-auart: add ...

I will resend the rest of patches (as v4) this week. This simple patch is independent from the previous patchset so I decided to resubmit it alone ([PATCH RESEND] header used) to apply.

I rather shouldn't resend the patch again I guess. I sent the same initial version of the patch twice after Greg's email so I did mess enough I think.

Quoted 2 lines

Also, always explain below the --- line what changed from one version to another

Quoted 6 lines

I thought composing cover letter is the only solution for resent patch or series.
As I understood this way is appropriate for single patch only (not patch set).
"Below" - it means between the line and diffstat?
Should I add new/second '---' line before diffstat?

Just do something like:

When using mxs-auart based console, sometime we need the sysrq function to help debugging kernel. The sysrq code is basically there, this patch just simply enable it.

---
Changes since v3:
- bla bla bla

#7 lore raw

PATCH RESEND 1/1 serial: mxs-auart: add sysrq support

In reply to Greg Kroah-Hartman
Quoted 3 lines

So I'm deleting all of these now, please resend the latest versions you have, with properly versioning
and order information.

Sure. I've just learnt about RFC header.

[PATCH RESEND] serial: mxs-auart: add sysrq support It is extracted from my previous patchset as independent from others.
The patch is resent as ready to apply.

I resend it again because last time
in conver letter I swapped subject with in-reply-to and the patch could be omited.

Janusz Uzycki (1):
serial: mxs-auart: add sysrq support

 drivers/tty/serial/mxs-auart.c | 4 ++++
 1 file changed, 4 insertions(+)
Signature · 1 line
1.7.11.3
#8 lore raw

PATCH RESEND 1/1 serial: mxs-auart: add sysrq support

When using mxs-auart based console, sometime we need the sysrq function to help debugging kernel. The sysrq code is basically there, this patch just simply enable it.

---
 drivers/tty/serial/mxs-auart.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/tty/serial/mxs-auart.c +4 -0
index eafce41..e838e84 100644
@@ -14,6 +14,10 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
+#if defined(CONFIG_SERIAL_MXS_AUART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
Signature · 1 line
1.7.11.3