Skip to contentSkip to conversation

imx6: add Bachmann OT1200 board

PATCH Superseded Christian Gmeiner 3 participants 4 messages Oct 2, 2014 – Oct 6, 2014 Arm (32-bit)

lore
Share & tools
lore

Christian Gmeiner

author
#0 lore raw

PATCH v3 1/1 imx6: add Bachmann OT1200 board

This patch adds support for the OT1200 series of devices.

Following components are used in u-boot:
+ ethernet
+ i2c
+ emmc
+ gpio

For more details see README.

Changes v1 > v2
- make use of enable_cspi_clock(..)
- fix usage of OUTPUT_40OHM define
- added README

Changes v2 > v3
- improve spelling in README
- added own copy of mx6q_4x_mt41j128.cfg

Signed-off-by Christian Gmeiner <[email protected]>
---
 arch/arm/Kconfig                           |   4 +
 board/bachmann/ot1200/Kconfig              |  23 +++
 board/bachmann/ot1200/MAINTAINERS          |   6 +
 board/bachmann/ot1200/Makefile             |   9 ++
 board/bachmann/ot1200/README               |  20 +++
 board/bachmann/ot1200/mx6q_4x_mt41j128.cfg | 169 +++++++++++++++++++
 board/bachmann/ot1200/ot1200.c             | 251 +++++++++++++++++++++++++++++
 configs/ot1200_defconfig                   |   3 +
 include/configs/ot1200.h                   | 197 ++++++++++++++++++++++
 9 files changed, 682 insertions(+)
 create mode 100644 board/bachmann/ot1200/Kconfig
 create mode 100644 board/bachmann/ot1200/MAINTAINERS
 create mode 100644 board/bachmann/ot1200/Makefile
 create mode 100644 board/bachmann/ot1200/README
 create mode 100644 board/bachmann/ot1200/mx6q_4x_mt41j128.cfg
 create mode 100644 board/bachmann/ot1200/ot1200.c
 create mode 100644 configs/ot1200_defconfig
 create mode 100644 include/configs/ot1200.h
arch/arm/Kconfig +4 -0
index 106aed9..8face21 100644
@@ -414,6 +414,9 @@ config TARGET_HUMMINGBOARD
 config TARGET_TQMA6
 	bool "TQ Systems TQMa6 board"
 
+config TARGET_OT1200
+	bool "Bachmann OT1200"
+
 config OMAP34XX
 	bool "OMAP34XX SoC"
 

@@ -577,6 +580,7 @@ source "board/atmel/at91sam9rlek/Kconfig"
 source "board/atmel/at91sam9x5ek/Kconfig"
 source "board/atmel/sama5d3_xplained/Kconfig"
 source "board/atmel/sama5d3xek/Kconfig"
+source "board/bachmann/ot1200/Kconfig"
 source "board/balloon3/Kconfig"
 source "board/barco/titanium/Kconfig"
 source "board/bluegiga/apx4devkit/Kconfig"
board/bachmann/ot1200/Kconfig new file +23 -0
new file mode 100644
index 0000000..55a825d
@@ -0,0 +1,23 @@
+if TARGET_OT1200
+
+config SYS_CPU
+	string
+	default "armv7"
+
+config SYS_BOARD
+	string
+	default "ot1200"
+
+config SYS_VENDOR
+	string
+	default "bachmann"
+
+config SYS_SOC
+	string
+	default "mx6"
+
+config SYS_CONFIG_NAME
+	string
+	default "ot1200"
+
+endif
board/bachmann/ot1200/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000..ad75c24
@@ -0,0 +1,6 @@
+BACHMANN ELECTRONIC OT1200 BOARD
+M:	Christian Gmeiner <[email protected]>
+S:	Maintained
+F:	board/bachmann/ot1200
+F:	include/configs/ot1200.h
+F:	configs/ot1200*_defconfig
board/bachmann/ot1200/Makefile new file +9 -0
new file mode 100644
index 0000000..1bd42e8
@@ -0,0 +1,9 @@
+#
+# Copyright (C) 2012-2013, Guennadi Liakhovetski <[email protected]>
+# (C) Copyright 2012-2013 Freescale Semiconductor, Inc.
+# Copyright (C) 2013, Boundary Devices <[email protected]>
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y  := ot1200.o
board/bachmann/ot1200/README new file +20 -0
new file mode 100644
index 0000000..c03d44e
@@ -0,0 +1,20 @@
+U-Boot for the Bachmann electronic GmbH OT1200 devices
+
+There are two different versions of the base board, which differ
+in the way ethernet is done. The variant detection is done during
+runtime based on the address of the found phy.
+
+- "mr" variant
+FEC is connected directly to an ethernet switch (KSZ8895). The ethernet
+port is always up and auto-negotiation is not possible.
+
+- normal variant
+FEC is connected to a normal phy and auto-negotiation is possible.
+
+
+The variant name is part of the dtb file name loaded by u-boot. This
+make is possible to boot the linux kernel and make use variant specific
+devicetree (fixed-phy link).
+
+In order to support different display resoltuions/sizes the OT1200 devices
+are making use of EDID data stored in an i2c EEPROM.
board/bachmann/ot1200/mx6q_4x_mt41j128.cfg new file +169 -0

169 lines not on this page · raw message

board/bachmann/ot1200/ot1200.c new file +251 -0

251 lines not on this page · raw message

configs/ot1200_defconfig new file +3 -0
new file mode 100644
index 0000000..c516038
@@ -0,0 +1,3 @@
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/bachmann/ot1200/mx6q_4x_mt41j128.cfg,MX6Q"
+CONFIG_ARM=y
+CONFIG_TARGET_OT1200=y
include/configs/ot1200.h new file +197 -0

197 lines not on this page · raw message

Signature · 1 line
1.9.3
#1 lore raw

PATCH v3 1/1 imx6: add Bachmann OT1200 board

Hi Christian,

Quoted 15 lines · On Thu, 2 Oct 2014 13:33:46 +0200 Christian Gmeiner…
board/bachmann/ot1200/Kconfig new file +12 -0
@@ -0,0 +1,23 @@
+if TARGET_OT1200
+
+config SYS_CPU
+	string
+	default "armv7"
+
+config SYS_BOARD
+	string
+	default "ot1200"
+
+config SYS_VENDOR
+	string

board/bachmann/ot1200/Kconfig line 22

Quoted 10 lines
board/bachmann/ot1200/Kconfig new file +10 -0
+	default "bachmann"
+
+config SYS_SOC
+	string
+	default "mx6"
+
+config SYS_CONFIG_NAME
+	string
+	default "ot1200"
+

The type "string" is not mandatory since
commit 461be2f96e4b87e5065208c6659a47dd0ad9e9f8. You can save 5 lines.

Since it is not a big deal,
I don't think you have to resend it just for fixing this. (I am just pointing out a minor thing I found by chance.)

If you like or you have a chance to send v4 for another fix, I recommend you to drop "string".

Best Regards
Masahiro Yamada

author
#2 lore raw

PATCH v3 1/1 imx6: add Bachmann OT1200 board

Hi

Quoted 23 lines
Quoted 23 lines
board/bachmann/ot1200/Kconfig new file +19 -0
@@ -0,0 +1,23 @@
+if TARGET_OT1200
+
+config SYS_CPU
+     string
+     default "armv7"
+
+config SYS_BOARD
+     string
+     default "ot1200"
+
+config SYS_VENDOR
+     string
+     default "bachmann"
+
+config SYS_SOC
+     string
+     default "mx6"
+
+config SYS_CONFIG_NAME
Quoted 8 lines

board/bachmann/ot1200/Kconfig line 10

Quoted 3 lines
board/bachmann/ot1200/Kconfig new file +3 -0
+     string
+     default "ot1200"
+

The type "string" is not mandatory since
commit 461be2f96e4b87e5065208c6659a47dd0ad9e9f8. You can save 5 lines.

Nice to know.

Quoted 7 lines

Since it is not a big deal,
I don't think you have to resend it just for fixing this. (I am just pointing out a minor thing I found by chance.)

If you like or you have a chance to send v4 for another fix, I recommend you to drop "string".

I am not sure if the current patch set gets accepted or not. Either way I will send a v4 or a followup patch to correct this. I have some more patches in my queue but I need to wait until this patch hits u-boot-imx.

greets
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner

#3 lore raw

PATCH v3 1/1 imx6: add Bachmann OT1200 board

In reply to Christian Gmeiner

Hi Christian,

Quoted 15 lines · Christian Gmeiner

This patch adds support for the OT1200 series of devices.

Following components are used in u-boot:
+ ethernet
+ i2c
+ emmc
+ gpio

For more details see README.

Changes v1 > v2
- make use of enable_cspi_clock(..)
- fix usage of OUTPUT_40OHM define
- added README

Quoted 6 lines

Changes v2 > v3
- improve spelling in README
- added own copy of mx6q_4x_mt41j128.cfg

Signed-off-by Christian Gmeiner <[email protected]>

---

I think you can send a follow-up patch according to Masahiro's suggestion for removing the "string" tag from Kconfig. I think we agree that it is better mainlining this one first ;-)

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================