ARM: i.MX: nitrogen6x clean up

PATCH New Eric Nelson 2 participants 71 messages Oct 2, 2014 – Oct 7, 2014

lore

Share & tools

lore

Eric Nelson

author

2014-10-02 19:16 UTC #0 lore raw

cover ARM: i.MX: nitrogen6x clean up

This collection of patches comprises a set of updates that have been lingering in our Github repository.

We're pushing them to main-line in preparation for the addition of a couple of boards that have also been lingering for a while.

Patches 1-9 are tweaks to the mx6qsabrelite/nitrogen6x initialization code.

Patches 10-18 add support for additional displays supported by the board(s) and tweak the HDMI detection.

Patches 19-32 enable and configure various features through changes to include/configs/nitrogen6x.h.

Diego Rondini (1):
nitrogen6x: config: allow boot to USB stick

Eric Nelson (24):
nitrogen6x: implement board_cfb_skip() to disable text output
nitrogen6x: configure SD2 pads for SDIO on USDHC2
nitrogen6x: power-down miscellanous peripherals
nitrogen6x: staticize board file
nitrogen6x: Allow U-Boot to be silent on UART2
nitrogen6x: prevent warnings about board_ehci* callbacks
nitrogen6x: display: add qvga panel
nitrogen6x: display: add support for LG-9.7 LVDS display
nitrogen6x: display: add LDB-WXGA-S for SPWG 1280x800 displays
nitrogen6x: display: add support for fusion 7 display
nitrogen6x: display: add svga display (800x600)
nitrogen6x: display: add Ampire 1024x600 panel
nitrogen6x: display: add wvga-lvds panel
nitrogen6x: display use I2C detect for HDMI
nitrogen6x: config: add USB Mass Storage (ums) support
nitrogen6x: config: add initrd_high
nitrogen6x: config: expose SATA, then MMC over USB
nitrogen6x: config: enable USB keyboard support
nitrogen6x: config: add CONFIG_CMD_MEMTEST
nitrogen6x: config: enable "i2c edid"
nitrogen6x: config: disable logo
nitrogen6x: config: configure usb_ether
nitrogen6x: config: add gpio command
nitrogen6x: config: enable Android fastboot

Kevin Mihelich (2):
nitrogen6x: config: use FS_GENERIC load command
nitrogen6x: config: enable EXT4 filesystem

Robert Winkler (1):
nitrogen6x: display: add support lvds jeida screen

Troy Kisky (4):
nitrogen6x: simplify board_mmc_getcd
nitrogen6x: configure SGTL5000, CSI camera clock outputs
nitrogen6x: phy: add 100 us delay after phy reset
nitrogen6x: config: allow more bootargs parameters

 board/boundary/nitrogen6x/nitrogen6x.c | 298 +++++++++++++++++++++++++++++----
 include/configs/nitrogen6x.h           |  98 +++++++++--
 2 files changed, 347 insertions(+), 49 deletions(-)

Signature · 1 line

1.9.1

Eric Nelson

author

2014-10-02 19:16 UTC #1 lore raw

PATCH 1/32 nitrogen6x: implement board_cfb_skip() to disable text output

Several customers have asked to leave the display quiet during boot, so allow the user to express this request by the presence of environment variable "novideo".

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 5 +++++
 1 file changed, 5 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +5 -0

index 60a09f4..1a6edac 100644
@@ -558,6 +558,11 @@ struct display_info_t const displays[] = {{
 } } };
 size_t display_count = ARRAY_SIZE(displays);
 
+int board_cfb_skip(void)
+{
+	return NULL != getenv("novideo");
+}
+
 static void setup_display(void)
 {
 	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 15:58 UTC #2 lore raw

PATCH 1/32 nitrogen6x: implement board_cfb_skip() to disable text output

Quoted 6 lines · Eric Nelson

Several customers have asked to leave the display quiet during boot, so allow the user to express this request by the presence of environment variable "novideo".
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #3 lore raw

PATCH 2/32 nitrogen6x: simplify board_mmc_getcd

In reply to Eric Nelson

From: Troy Kisky <[email protected]>

The same logic applies to both SD card slots, only with different GPIOs and the code should make that easier to see.

Signed-off-by Troy Kisky <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

board/boundary/nitrogen6x/nitrogen6x.c +4 ~~-10~~

index 1a6edac..e8cc243 100644
@@ -279,17 +279,11 @@ struct fsl_esdhc_cfg usdhc_cfg[2] = {
 int board_mmc_getcd(struct mmc *mmc)
 {
 	struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
-	int ret;
-
-	if (cfg->esdhc_base == USDHC3_BASE_ADDR) {
-		gpio_direction_input(IMX_GPIO_NR(7, 0));
-		ret = !gpio_get_value(IMX_GPIO_NR(7, 0));
-	} else {
-		gpio_direction_input(IMX_GPIO_NR(2, 6));
-		ret = !gpio_get_value(IMX_GPIO_NR(2, 6));
-	}
+	int gp_cd = (cfg->esdhc_base == USDHC3_BASE_ADDR) ? IMX_GPIO_NR(7, 0) :
+			IMX_GPIO_NR(2, 6);
 
-	return ret;
+	gpio_direction_input(gp_cd);
+	return !gpio_get_value(gp_cd);
 }
 
 int board_mmc_init(bd_t *bis)

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 15:58 UTC #4 lore raw

PATCH 2/32 nitrogen6x: simplify board_mmc_getcd

Quoted 7 lines · Eric Nelson

From: Troy Kisky <[email protected]>
The same logic applies to both SD card slots, only with different GPIOs and the code should make that easier to see.
Signed-off-by Troy Kisky <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #5 lore raw

PATCH 3/32 nitrogen6x: configure SD2 pads for SDIO on USDHC2

In reply to Eric Nelson

Pads SD2_CLK/CMD/DAT0-3 are connected to an SDIO WiFi device on Nitrogen and unconnected on BD-SL-i.MX6 (sabre lite).

Configure them as SDIO pins to prevent them from being in a state that confuses the WiFi part.

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +11 -0

index e8cc243..bde299f 100644
@@ -124,6 +124,15 @@ struct i2c_pads_info i2c_pad_info2 = {
 	}
 };
 
+static iomux_v3_cfg_t const usdhc2_pads[] = {
+	MX6_PAD_SD2_CLK__SD2_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_SD2_CMD__SD2_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_SD2_DAT0__SD2_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_SD2_DAT1__SD2_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_SD2_DAT2__SD2_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_SD2_DAT3__SD2_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+};
+
 iomux_v3_cfg_t const usdhc3_pads[] = {
 	MX6_PAD_SD3_CLK__SD3_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 	MX6_PAD_SD3_CMD__SD3_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL),

@@ -657,6 +666,8 @@ int board_init(void)
 #ifdef CONFIG_MXC_SPI
 	setup_spi();
 #endif
+	imx_iomux_v3_setup_multiple_pads(
+		usdhc2_pads, ARRAY_SIZE(usdhc2_pads));
 	setup_i2c(0, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info0);
 	setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1);
 	setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info2);

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:01 UTC #6 lore raw

PATCH 3/32 nitrogen6x: configure SD2 pads for SDIO on USDHC2

Quoted 8 lines · Eric Nelson

Pads SD2_CLK/CMD/DAT0-3 are connected to an SDIO WiFi device on Nitrogen and unconnected on BD-SL-i.MX6 (sabre lite).
Configure them as SDIO pins to prevent them from being in a state that confuses the WiFi part.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #7 lore raw

PATCH 4/32 nitrogen6x: power-down miscellanous peripherals

In reply to Eric Nelson

Ensure that cameras and USB OTG power are in a stable (reset) state at reset by configuring their pads and toggling GPIOs.

Signed-off-by Troy Kisky <[email protected]>

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 47 +++++++++++++++++++++++++++++++---
 1 file changed, 43 insertions(+), 4 deletions(-)

board/boundary/nitrogen6x/nitrogen6x.c +43 -4

index bde299f..38f0df8 100644
@@ -622,17 +622,56 @@ static void setup_display(void)
 }
 #endif
 
+/* wl1271 pads on nitrogen6x */
+static iomux_v3_cfg_t const init_pads[] = {
+	/* WL12XX_WL_IRQ_GP */
+	NEW_PAD_CTRL(MX6_PAD_NANDF_CS1__GPIO6_IO14, WEAK_PULLDOWN),
+	/* WL12XX_WL_ENABLE_GP */
+	NEW_PAD_CTRL(MX6_PAD_NANDF_CS2__GPIO6_IO15, OUTPUT_40OHM),
+	/* WL12XX_BT_ENABLE_GP */
+	NEW_PAD_CTRL(MX6_PAD_NANDF_CS3__GPIO6_IO16, OUTPUT_40OHM),
+	/* USB otg power */
+	NEW_PAD_CTRL(MX6_PAD_EIM_D22__GPIO3_IO22, OUTPUT_40OHM),
+	NEW_PAD_CTRL(MX6_PAD_NANDF_D5__GPIO2_IO05, OUTPUT_40OHM),
+	NEW_PAD_CTRL(MX6_PAD_NANDF_WP_B__GPIO6_IO09, OUTPUT_40OHM),
+	NEW_PAD_CTRL(MX6_PAD_GPIO_8__GPIO1_IO08, OUTPUT_40OHM),
+	NEW_PAD_CTRL(MX6_PAD_GPIO_6__GPIO1_IO06, OUTPUT_40OHM),
+};
+
+#define WL12XX_WL_IRQ_GP	IMX_GPIO_NR(6, 14)
+
+static unsigned gpios_out_low[] = {
+	/* Disable wl1271 */
+	IMX_GPIO_NR(6, 15),	/* disable wireless */
+	IMX_GPIO_NR(6, 16),	/* disable bluetooth */
+	IMX_GPIO_NR(3, 22),	/* disable USB otg power */
+	IMX_GPIO_NR(2, 5),	/* ov5640 mipi camera reset */
+	IMX_GPIO_NR(1, 8),	/* ov5642 reset */
+};
+
+static unsigned gpios_out_high[] = {
+	IMX_GPIO_NR(1, 6),	/* ov5642 powerdown */
+	IMX_GPIO_NR(6, 9),	/* ov5640 mipi camera power down */
+};
+
+static void set_gpios(unsigned *p, int cnt, int val)
+{
+	int i;
+
+	for (i = 0; i < cnt; i++)
+		gpio_direction_output(*p++, val);
+}
+
 int board_early_init_f(void)
 {
 	setup_iomux_uart();
 
-	/* Disable wl1271 For Nitrogen6w */
+	set_gpios(gpios_out_high, ARRAY_SIZE(gpios_out_high), 1);
+	set_gpios(gpios_out_low, ARRAY_SIZE(gpios_out_low), 0);
 	gpio_direction_input(WL12XX_WL_IRQ_GP);
-	gpio_direction_output(WL12XX_WL_ENABLE_GP, 0);
-	gpio_direction_output(WL12XX_BT_ENABLE_GP, 0);
-	gpio_direction_output(GP_USB_OTG_PWR, 0); /* OTG power off */
 
 	imx_iomux_v3_setup_multiple_pads(wl12xx_pads, ARRAY_SIZE(wl12xx_pads));
+	imx_iomux_v3_setup_multiple_pads(init_pads, ARRAY_SIZE(init_pads));
 	setup_buttons();
 
 #if defined(CONFIG_VIDEO_IPUV3)

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:01 UTC #8 lore raw

PATCH 4/32 nitrogen6x: power-down miscellanous peripherals

Quoted 6 lines · Eric Nelson

Ensure that cameras and USB OTG power are in a stable (reset) state at reset by configuring their pads and toggling GPIOs.
Signed-off-by Troy Kisky <[email protected]>
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #9 lore raw

PATCH 5/32 nitrogen6x: configure SGTL5000, CSI camera clock outputs

In reply to Eric Nelson

From: Troy Kisky <[email protected]>

Configure CLKO outputs for SGTL5000, CSI camera.

The sys_mclk output for the SGTL500 in particular prevents Windows CE from properly driving audio.

Signed-off-by Troy Kisky <[email protected]>

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

board/boundary/nitrogen6x/nitrogen6x.c +7 -1

index 38f0df8..96e2b74 100644
@@ -622,8 +622,14 @@ static void setup_display(void)
 }
 #endif
 
-/* wl1271 pads on nitrogen6x */
 static iomux_v3_cfg_t const init_pads[] = {
+	/* SGTL5000 sys_mclk */
+	NEW_PAD_CTRL(MX6_PAD_GPIO_0__CCM_CLKO1, OUTPUT_40OHM),
+
+	/* J5 - Camera MCLK */
+	NEW_PAD_CTRL(MX6_PAD_GPIO_3__CCM_CLKO2, OUTPUT_40OHM),
+
+	/* wl1271 pads on nitrogen6x */
 	/* WL12XX_WL_IRQ_GP */
 	NEW_PAD_CTRL(MX6_PAD_NANDF_CS1__GPIO6_IO14, WEAK_PULLDOWN),
 	/* WL12XX_WL_ENABLE_GP */

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:01 UTC #10 lore raw

PATCH 5/32 nitrogen6x: configure SGTL5000, CSI camera clock outputs

Quoted 10 lines · Eric Nelson

From: Troy Kisky <[email protected]>
Configure CLKO outputs for SGTL5000, CSI camera.
The sys_mclk output for the SGTL500 in particular prevents Windows CE from properly driving audio.
Signed-off-by Troy Kisky <[email protected]>
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #11 lore raw

PATCH 6/32 nitrogen6x: staticize board file

In reply to Eric Nelson

Declare locally-used data structures and functions as static and pull in header files to prevent compiler warnings of "Should it be static?" when building with "make C=1".

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

board/boundary/nitrogen6x/nitrogen6x.c +16 ~~-14~~

index 96e2b74..e795492 100644
@@ -28,6 +28,8 @@
 #include <asm/arch/crm_regs.h>
 #include <asm/arch/mxc_hdmi.h>
 #include <i2c.h>
+#include <input.h>
+#include <netdev.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 #define GP_USB_OTG_PWR	IMX_GPIO_NR(3, 22)

@@ -70,12 +72,12 @@ int dram_init(void)
 	return 0;
 }
 
-iomux_v3_cfg_t const uart1_pads[] = {
+static iomux_v3_cfg_t const uart1_pads[] = {
 	MX6_PAD_SD3_DAT6__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 	MX6_PAD_SD3_DAT7__UART1_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
-iomux_v3_cfg_t const uart2_pads[] = {
+static iomux_v3_cfg_t const uart2_pads[] = {
 	MX6_PAD_EIM_D26__UART2_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 	MX6_PAD_EIM_D27__UART2_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 };

@@ -83,7 +85,7 @@ iomux_v3_cfg_t const uart2_pads[] = {
 #define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
 
 /* I2C1, SGTL5000 */
-struct i2c_pads_info i2c_pad_info0 = {
+static struct i2c_pads_info i2c_pad_info0 = {
 	.scl = {
 		.i2c_mode = MX6_PAD_EIM_D21__I2C1_SCL | PC,
 		.gpio_mode = MX6_PAD_EIM_D21__GPIO3_IO21 | PC,

@@ -97,7 +99,7 @@ struct i2c_pads_info i2c_pad_info0 = {
 };
 
 /* I2C2 Camera, MIPI */
-struct i2c_pads_info i2c_pad_info1 = {
+static struct i2c_pads_info i2c_pad_info1 = {
 	.scl = {
 		.i2c_mode = MX6_PAD_KEY_COL3__I2C2_SCL | PC,
 		.gpio_mode = MX6_PAD_KEY_COL3__GPIO4_IO12 | PC,

@@ -111,7 +113,7 @@ struct i2c_pads_info i2c_pad_info1 = {
 };
 
 /* I2C3, J15 - RGB connector */
-struct i2c_pads_info i2c_pad_info2 = {
+static struct i2c_pads_info i2c_pad_info2 = {
 	.scl = {
 		.i2c_mode = MX6_PAD_GPIO_5__I2C3_SCL | PC,
 		.gpio_mode = MX6_PAD_GPIO_5__GPIO1_IO05 | PC,

@@ -133,7 +135,7 @@ static iomux_v3_cfg_t const usdhc2_pads[] = {
 	MX6_PAD_SD2_DAT3__SD2_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 };
 
-iomux_v3_cfg_t const usdhc3_pads[] = {
+static iomux_v3_cfg_t const usdhc3_pads[] = {
 	MX6_PAD_SD3_CLK__SD3_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 	MX6_PAD_SD3_CMD__SD3_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 	MX6_PAD_SD3_DAT0__SD3_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),

@@ -143,7 +145,7 @@ iomux_v3_cfg_t const usdhc3_pads[] = {
 	MX6_PAD_SD3_DAT5__GPIO7_IO00    | MUX_PAD_CTRL(NO_PAD_CTRL), /* CD */
 };
 
-iomux_v3_cfg_t const usdhc4_pads[] = {
+static iomux_v3_cfg_t const usdhc4_pads[] = {
 	MX6_PAD_SD4_CLK__SD4_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 	MX6_PAD_SD4_CMD__SD4_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 	MX6_PAD_SD4_DAT0__SD4_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),

@@ -153,7 +155,7 @@ iomux_v3_cfg_t const usdhc4_pads[] = {
 	MX6_PAD_NANDF_D6__GPIO2_IO06    | MUX_PAD_CTRL(NO_PAD_CTRL), /* CD */
 };
 
-iomux_v3_cfg_t const enet_pads1[] = {
+static iomux_v3_cfg_t const enet_pads1[] = {
 	MX6_PAD_ENET_MDIO__ENET_MDIO		| MUX_PAD_CTRL(ENET_PAD_CTRL),
 	MX6_PAD_ENET_MDC__ENET_MDC		| MUX_PAD_CTRL(ENET_PAD_CTRL),
 	MX6_PAD_RGMII_TXC__RGMII_TXC	| MUX_PAD_CTRL(ENET_PAD_CTRL),

@@ -180,7 +182,7 @@ iomux_v3_cfg_t const enet_pads1[] = {
 	MX6_PAD_ENET_RXD0__GPIO1_IO27		| MUX_PAD_CTRL(NO_PAD_CTRL),
 };
 
-iomux_v3_cfg_t const enet_pads2[] = {
+static iomux_v3_cfg_t const enet_pads2[] = {
 	MX6_PAD_RGMII_RXC__RGMII_RXC	| MUX_PAD_CTRL(ENET_PAD_CTRL),
 	MX6_PAD_RGMII_RD0__RGMII_RD0	| MUX_PAD_CTRL(ENET_PAD_CTRL),
 	MX6_PAD_RGMII_RD1__RGMII_RD1	| MUX_PAD_CTRL(ENET_PAD_CTRL),

@@ -198,7 +200,7 @@ static iomux_v3_cfg_t const misc_pads[] = {
 };
 
 /* wl1271 pads on nitrogen6x */
-iomux_v3_cfg_t const wl12xx_pads[] = {
+static iomux_v3_cfg_t const wl12xx_pads[] = {
 	(MX6_PAD_NANDF_CS1__GPIO6_IO14 & ~MUX_PAD_CTRL_MASK)
 		| MUX_PAD_CTRL(WEAK_PULLDOWN),
 	(MX6_PAD_NANDF_CS2__GPIO6_IO15 & ~MUX_PAD_CTRL_MASK)

@@ -246,7 +248,7 @@ static void setup_iomux_enet(void)
 	imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
 }
 
-iomux_v3_cfg_t const usb_pads[] = {
+static iomux_v3_cfg_t const usb_pads[] = {
 	MX6_PAD_GPIO_17__GPIO7_IO12 | MUX_PAD_CTRL(NO_PAD_CTRL),
 };

@@ -280,7 +282,7 @@ int board_ehci_power(int port, int on)
 #endif
 
 #ifdef CONFIG_FSL_ESDHC
-struct fsl_esdhc_cfg usdhc_cfg[2] = {
+static struct fsl_esdhc_cfg usdhc_cfg[2] = {
 	{USDHC3_BASE_ADDR},
 	{USDHC4_BASE_ADDR},
 };

@@ -331,7 +333,7 @@ int board_mmc_init(bd_t *bis)
 #endif
 
 #ifdef CONFIG_MXC_SPI
-iomux_v3_cfg_t const ecspi1_pads[] = {
+static iomux_v3_cfg_t const ecspi1_pads[] = {
 	/* SS1 */
 	MX6_PAD_EIM_D19__GPIO3_IO19  | MUX_PAD_CTRL(NO_PAD_CTRL),
 	MX6_PAD_EIM_D17__ECSPI1_MISO | MUX_PAD_CTRL(SPI_PAD_CTRL),

@@ -339,7 +341,7 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
 	MX6_PAD_EIM_D16__ECSPI1_SCLK | MUX_PAD_CTRL(SPI_PAD_CTRL),
 };
 
-void setup_spi(void)
+static void setup_spi(void)
 {
 	imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
 					 ARRAY_SIZE(ecspi1_pads));

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:02 UTC #12 lore raw

PATCH 6/32 nitrogen6x: staticize board file

Quoted 6 lines · Eric Nelson

Declare locally-used data structures and functions as static and pull in header files to prevent compiler warnings of "Should it be static?" when building with "make C=1".
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #13 lore raw

PATCH 7/32 nitrogen6x: Allow U-Boot to be silent on UART2

In reply to Eric Nelson

Several customers are using UART2 (normally the serial console for U-Boot) as connections to printers or other peripherals that are not tolerant of stray inputs during reset.

Provide a simple way to eliminate output on the serial port by conditionally configuring these pads as GPIOs during U-Boot.

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 6 ++++++
 1 file changed, 6 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +6 -0

index e795492..621cdbc 100644
@@ -77,9 +77,15 @@ static iomux_v3_cfg_t const uart1_pads[] = {
 	MX6_PAD_SD3_DAT7__UART1_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
+/* #define CONFIG_SILENT_UART */
 static iomux_v3_cfg_t const uart2_pads[] = {
+#ifndef CONFIG_SILENT_UART
 	MX6_PAD_EIM_D26__UART2_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 	MX6_PAD_EIM_D27__UART2_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
+#else
+	MX6_PAD_EIM_D26__GPIO3_IO26 | MUX_PAD_CTRL(UART_PAD_CTRL),
+	MX6_PAD_EIM_D27__GPIO3_IO27 | MUX_PAD_CTRL(UART_PAD_CTRL),
+#endif
 };
 
 #define PC MUX_PAD_CTRL(I2C_PAD_CTRL)

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 15:42 UTC #14 lore raw

PATCH 7/32 nitrogen6x: Allow U-Boot to be silent on UART2

Hi Eric,

Quoted 18 lines · Eric Nelson

Several customers are using UART2 (normally the serial console for U-Boot) as connections to printers or other peripherals that are not tolerant of stray inputs during reset.
Provide a simple way to eliminate output on the serial port by conditionally configuring these pads as GPIOs during U-Boot.
Signed-off-by Eric Nelson <[email protected]>
---
 board/boundary/nitrogen6x/nitrogen6x.c | 6 ++++++
 1 file changed, 6 insertions(+)
board/boundary/nitrogen6x/nitrogen6x.c +0 -0
index e795492..621cdbc 100644

board/boundary/nitrogen6x/nitrogen6x.c static iomux_v3_cfg_t const uart1_pads[] = { · line 80

Quoted 4 lines

board/boundary/nitrogen6x/nitrogen6x.c +1 -0

@@ -77,9 +77,15 @@ static iomux_v3_cfg_t const uart1_pads[] = {
 	MX6_PAD_SD3_DAT7__UART1_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
+/* #define CONFIG_SILENT_UART */

Theoretically, we have already in U-Boot CONFIG_SILENT_CONSOLE, without the need to introduce a new CONFIG_.

board/boundary/nitrogen6x/nitrogen6x.c static iomux_v3_cfg_t const uart1_pads[] = { · line 88

Quoted 8 lines

board/boundary/nitrogen6x/nitrogen6x.c +5 -0

 static iomux_v3_cfg_t const uart2_pads[] = {
+#ifndef CONFIG_SILENT_UART
 	MX6_PAD_EIM_D26__UART2_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 	MX6_PAD_EIM_D27__UART2_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
+#else
+	MX6_PAD_EIM_D26__GPIO3_IO26 | MUX_PAD_CTRL(UART_PAD_CTRL),
+	MX6_PAD_EIM_D27__GPIO3_IO27 | MUX_PAD_CTRL(UART_PAD_CTRL),
+#endif

I understand the reason, anyway this looks like a hack (uart is still configured while iomux is not correctly set). Can you check if your goal is simply reached with CONFIG_SILENT_CONSOLE ?

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-06 15:51 UTC #15 lore raw

PATCH 7/32 nitrogen6x: Allow U-Boot to be silent on UART2

Thanks Stefano,

Quoted 29 lines · Stefano Babic

Hi Eric,
Quoted 18 lines · Eric Nelson
Several customers are using UART2 (normally the serial console for U-Boot) as connections to printers or other peripherals that are not tolerant of stray inputs during reset.
Provide a simple way to eliminate output on the serial port by conditionally configuring these pads as GPIOs during U-Boot.
Signed-off-by Eric Nelson <[email protected]>
---
 board/boundary/nitrogen6x/nitrogen6x.c | 6 ++++++
 1 file changed, 6 insertions(+)
board/boundary/nitrogen6x/nitrogen6x.c +0 -0
index e795492..621cdbc 100644
board/boundary/nitrogen6x/nitrogen6x.c static iomux_v3_cfg_t const uart1_pads[] = { · line 80
Quoted 4 lines
board/boundary/nitrogen6x/nitrogen6x.c +1 -0
@@ -77,9 +77,15 @@ static iomux_v3_cfg_t const uart1_pads[] = {
 	MX6_PAD_SD3_DAT7__UART1_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
+/* #define CONFIG_SILENT_UART */
Theoretically, we have already in U-Boot CONFIG_SILENT_CONSOLE, without the need to introduce a new CONFIG_.

Quoted 13 lines

board/boundary/nitrogen6x/nitrogen6x.c static iomux_v3_cfg_t const uart1_pads[] = { · line 88
Quoted 8 lines
board/boundary/nitrogen6x/nitrogen6x.c +5 -0
 static iomux_v3_cfg_t const uart2_pads[] = {
+#ifndef CONFIG_SILENT_UART
 	MX6_PAD_EIM_D26__UART2_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
 	MX6_PAD_EIM_D27__UART2_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
+#else
+	MX6_PAD_EIM_D26__GPIO3_IO26 | MUX_PAD_CTRL(UART_PAD_CTRL),
+	MX6_PAD_EIM_D27__GPIO3_IO27 | MUX_PAD_CTRL(UART_PAD_CTRL),
+#endif
I understand the reason, anyway this looks like a hack (uart is still configured while iomux is not correctly set). Can you check if your goal is simply reached with CONFIG_SILENT_CONSOLE ?

Will do. I wasn't aware of that one.

Regards,

Eric

Eric Nelson

author

2014-10-02 19:16 UTC #16 lore raw

PATCH 8/32 nitrogen6x: phy: add 100 us delay after phy reset

In reply to Eric Nelson

From: Troy Kisky <[email protected]>

Testing shows that the Micrel PHY may not be completely out of reset if accessed immediately.

Signed-off-by Troy Kisky <[email protected]>

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 1 +
 1 file changed, 1 insertion(+)

board/boundary/nitrogen6x/nitrogen6x.c +1 -0

index 621cdbc..465f88f 100644
@@ -252,6 +252,7 @@ static void setup_iomux_enet(void)
 	gpio_set_value(IMX_GPIO_NR(1, 27), 1); /* Nitrogen6X PHY reset */
 
 	imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
+	udelay(100);	/* Wait 100 us before using mii interface */
 }
 
 static iomux_v3_cfg_t const usb_pads[] = {

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:02 UTC #17 lore raw

PATCH 8/32 nitrogen6x: phy: add 100 us delay after phy reset

Quoted 8 lines · Eric Nelson

From: Troy Kisky <[email protected]>
Testing shows that the Micrel PHY may not be completely out of reset if accessed immediately.
Signed-off-by Troy Kisky <[email protected]>
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #18 lore raw

PATCH 9/32 nitrogen6x: prevent warnings about board_ehci* callbacks

In reply to Eric Nelson

Include declarations of board_ehci callbacks to prevent compiler warnings and enforce function prototypes.

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 1 +
 1 file changed, 1 insertion(+)

board/boundary/nitrogen6x/nitrogen6x.c +1 -0

index 465f88f..2e945a4 100644
@@ -30,6 +30,7 @@
 #include <i2c.h>
 #include <input.h>
 #include <netdev.h>
+#include <usb/ehci-fsl.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 #define GP_USB_OTG_PWR	IMX_GPIO_NR(3, 22)

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:03 UTC #19 lore raw

PATCH 9/32 nitrogen6x: prevent warnings about board_ehci* callbacks

Quoted 5 lines · Eric Nelson

Include declarations of board_ehci callbacks to prevent compiler warnings and enforce function prototypes.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #20 lore raw

PATCH 10/32 nitrogen6x: display: add support lvds jeida screen

In reply to Eric Nelson

From: Robert Winkler <[email protected]>

Add support for Boundary Devices 7" and 10.1" 1280x800 displays with integrated FocalTech ft5x06 10-point touch controller.

Because they share the touch controller with the 1024x600 displays, auto-detection is disabled and you must explicitly set the 'panel' environment variable:

U-Boot > setenv panel LDB-WXGA
U-Boot > saveenv && reset

Signed-off-by Robert Winkler <[email protected]>

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +31 -0

index 2e945a4..336a6f9 100644
@@ -480,6 +480,17 @@ static void enable_lvds(struct display_info_t const *dev)
 	gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
 }
 
+static void enable_lvds_jeida(struct display_info_t const *dev)
+{
+	struct iomuxc *iomux = (struct iomuxc *)
+				IOMUXC_BASE_ADDR;
+	u32 reg = readl(&iomux->gpr[2]);
+	reg |= IOMUXC_GPR2_DATA_WIDTH_CH0_24BIT
+	     |IOMUXC_GPR2_BIT_MAPPING_CH0_JEIDA;
+	writel(reg, &iomux->gpr[2]);
+	gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
+}
+
 static void enable_rgb(struct display_info_t const *dev)
 {
 	imx_iomux_v3_setup_multiple_pads(

@@ -509,6 +520,26 @@ struct display_info_t const displays[] = {{
 		.sync           = FB_SYNC_EXT,
 		.vmode          = FB_VMODE_NONINTERLACED
 } }, {
+	.bus	= 0,
+	.addr	= 0,
+	.pixfmt	= IPU_PIX_FMT_RGB24,
+	.detect	= NULL,
+	.enable	= enable_lvds_jeida,
+	.mode	= {
+		.name           = "LDB-WXGA",
+		.refresh        = 60,
+		.xres           = 1280,
+		.yres           = 800,
+		.pixclock       = 14065,
+		.left_margin    = 40,
+		.right_margin   = 40,
+		.upper_margin   = 3,
+		.lower_margin   = 80,
+		.hsync_len      = 10,
+		.vsync_len      = 10,
+		.sync           = FB_SYNC_EXT,
+		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
 	.bus	= 2,
 	.addr	= 0x4,
 	.pixfmt	= IPU_PIX_FMT_LVDS666,

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:04 UTC #21 lore raw

PATCH 10/32 nitrogen6x: display: add support lvds jeida screen

Quoted 9 lines · Eric Nelson

From: Robert Winkler <[email protected]>
Add support for Boundary Devices 7" and 10.1" 1280x800 displays with integrated FocalTech ft5x06 10-point touch controller.
Because they share the touch controller with the 1024x600 displays, auto-detection is disabled and you must explicitly set the 'panel' environment variable:

Quoted 6 lines

U-Boot > setenv panel LDB-WXGA
U-Boot > saveenv && reset
Signed-off-by Robert Winkler <[email protected]>
Signed-off-by Eric Nelson <[email protected]>
---

As the rest of the display's series:

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #22 lore raw

PATCH 11/32 nitrogen6x: display: add qvga panel

In reply to Eric Nelson

Add support for a 1/4 VGA panel with a 24-bit RGB interface. No auto-detection is enabled, so you must configure the 'panel' environment variable to use this display:

U-Boot > setenv panel qvga
U-Boot > saveenv && reset

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +20 -0

index 336a6f9..b2218c9f 100644
@@ -599,6 +599,26 @@ struct display_info_t const displays[] = {{
 		.vsync_len      = 10,
 		.sync           = 0,
 		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
+	.bus	= 0,
+	.addr	= 0,
+	.pixfmt	= IPU_PIX_FMT_RGB24,
+	.detect	= NULL,
+	.enable	= enable_rgb,
+	.mode	= {
+		.name           = "qvga",
+		.refresh        = 60,
+		.xres           = 320,
+		.yres           = 240,
+		.pixclock       = 37037,
+		.left_margin    = 38,
+		.right_margin   = 37,
+		.upper_margin   = 16,
+		.lower_margin   = 15,
+		.hsync_len      = 30,
+		.vsync_len      = 3,
+		.sync           = 0,
+		.vmode          = FB_VMODE_NONINTERLACED
 } } };
 size_t display_count = ARRAY_SIZE(displays);

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:04 UTC #23 lore raw

PATCH 11/32 nitrogen6x: display: add qvga panel

Quoted 9 lines · Eric Nelson

Add support for a 1/4 VGA panel with a 24-bit RGB interface. No auto-detection is enabled, so you must configure the 'panel' environment variable to use this display:
U-Boot > setenv panel qvga
U-Boot > saveenv && reset
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #24 lore raw

PATCH 12/32 nitrogen6x: display: add support for LG-9.7 LVDS display

In reply to Eric Nelson

Add support for LG 9.7" LVDS panel (1024x768) with integrated eGalax touch screen.

Note that this panel differs only slightly from the Hannstar XGA panel (margins).

No auto-detection is available because it shares the same touch controller as the Hannstar-XGA display, so you'll need to configure it through the 'panel' environment variable:

U-Boot > setenv panel LG-9.7
U-Boot > saveenv && reset

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +20 -0

index b2218c9f..fd214ca 100644
@@ -560,6 +560,26 @@ struct display_info_t const displays[] = {{
 		.sync           = FB_SYNC_EXT,
 		.vmode          = FB_VMODE_NONINTERLACED
 } }, {
+	.bus	= 0,
+	.addr	= 0,
+	.pixfmt	= IPU_PIX_FMT_LVDS666,
+	.detect	= NULL,
+	.enable	= enable_lvds,
+	.mode	= {
+		.name           = "LG-9.7",
+		.refresh        = 60,
+		.xres           = 1024,
+		.yres           = 768,
+		.pixclock       = 15385, /* ~65MHz */
+		.left_margin    = 480,
+		.right_margin   = 260,
+		.upper_margin   = 16,
+		.lower_margin   = 6,
+		.hsync_len      = 250,
+		.vsync_len      = 10,
+		.sync           = FB_SYNC_EXT,
+		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
 	.bus	= 2,
 	.addr	= 0x38,
 	.pixfmt	= IPU_PIX_FMT_LVDS666,

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:05 UTC #25 lore raw

PATCH 12/32 nitrogen6x: display: add support for LG-9.7 LVDS display

Quoted 10 lines · Eric Nelson

Add support for LG 9.7" LVDS panel (1024x768) with integrated eGalax touch screen.
Note that this panel differs only slightly from the Hannstar XGA panel (margins).
No auto-detection is available because it shares the same touch controller as the Hannstar-XGA display, so you'll need to configure it through the 'panel' environment variable:

Quoted 5 lines

U-Boot > setenv panel LG-9.7
U-Boot > saveenv && reset
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #26 lore raw

PATCH 13/32 nitrogen6x: display: add LDB-WXGA-S for SPWG 1280x800 displays

In reply to Eric Nelson

This patch adds support for LVDS WXGA displays that use the SPWG encoding standard instead of JEIDA.

No auto-detection is enabled and you must explicitly set the 'panel' environment variable:

U-Boot > setenv panel LDB-WXGA-S
U-Boot > saveenv && reset

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +20 -0

index fd214ca..261fa7e 100644
@@ -540,6 +540,26 @@ struct display_info_t const displays[] = {{
 		.sync           = FB_SYNC_EXT,
 		.vmode          = FB_VMODE_NONINTERLACED
 } }, {
+	.bus	= 0,
+	.addr	= 0,
+	.pixfmt	= IPU_PIX_FMT_RGB24,
+	.detect	= NULL,
+	.enable	= enable_lvds,
+	.mode	= {
+		.name           = "LDB-WXGA-S",
+		.refresh        = 60,
+		.xres           = 1280,
+		.yres           = 800,
+		.pixclock       = 14065,
+		.left_margin    = 40,
+		.right_margin   = 40,
+		.upper_margin   = 3,
+		.lower_margin   = 80,
+		.hsync_len      = 10,
+		.vsync_len      = 10,
+		.sync           = FB_SYNC_EXT,
+		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
 	.bus	= 2,
 	.addr	= 0x4,
 	.pixfmt	= IPU_PIX_FMT_LVDS666,

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:05 UTC #27 lore raw

PATCH 13/32 nitrogen6x: display: add LDB-WXGA-S for SPWG 1280x800 displays

Quoted 11 lines · Eric Nelson

This patch adds support for LVDS WXGA displays that use the SPWG encoding standard instead of JEIDA.
No auto-detection is enabled and you must explicitly set the 'panel' environment variable:
U-Boot > setenv panel LDB-WXGA-S
U-Boot > saveenv && reset
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #28 lore raw

PATCH 14/32 nitrogen6x: display: add support for fusion 7 display

In reply to Eric Nelson

Add support for the Touch Revolution Fusion7 display: 800x480 RGB with a custom F0710A resistive touch controller.

Auto-detection of this panel is supported so no configuration is required.

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +20 -0

index 261fa7e..b1d85da 100644
@@ -621,6 +621,26 @@ struct display_info_t const displays[] = {{
 		.vmode          = FB_VMODE_NONINTERLACED
 } }, {
 	.bus	= 2,
+	.addr	= 0x10,
+	.pixfmt	= IPU_PIX_FMT_RGB666,
+	.detect	= detect_i2c,
+	.enable	= enable_rgb,
+	.mode	= {
+		.name           = "fusion7",
+		.refresh        = 60,
+		.xres           = 800,
+		.yres           = 480,
+		.pixclock       = 33898,
+		.left_margin    = 96,
+		.right_margin   = 24,
+		.upper_margin   = 3,
+		.lower_margin   = 10,
+		.hsync_len      = 72,
+		.vsync_len      = 7,
+		.sync           = 0x40000002,
+		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
+	.bus	= 2,
 	.addr	= 0x48,
 	.pixfmt	= IPU_PIX_FMT_RGB666,
 	.detect	= detect_i2c,

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:05 UTC #29 lore raw

PATCH 14/32 nitrogen6x: display: add support for fusion 7 display

Quoted 8 lines · Eric Nelson

Add support for the Touch Revolution Fusion7 display: 800x480 RGB with a custom F0710A resistive touch controller.
Auto-detection of this panel is supported so no configuration is required.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #30 lore raw

PATCH 15/32 nitrogen6x: display: add svga display (800x600)

In reply to Eric Nelson

Add support for 800x600 18-bit RGB displays using VESA GTF timings.

No auto-detection is supported, so you must configure this panel manually through the 'panel' environment variable:

U-Boot > setenv panel svga
U-Boot > saveenv && reset

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +20 -0

index b1d85da..6695f87 100644
@@ -640,6 +640,26 @@ struct display_info_t const displays[] = {{
 		.sync           = 0x40000002,
 		.vmode          = FB_VMODE_NONINTERLACED
 } }, {
+	.bus	= 0,
+	.addr	= 0,
+	.pixfmt	= IPU_PIX_FMT_RGB666,
+	.detect	= NULL,
+	.enable	= enable_rgb,
+	.mode	= {
+		.name           = "svga",
+		.refresh        = 60,
+		.xres           = 800,
+		.yres           = 600,
+		.pixclock       = 15385,
+		.left_margin    = 220,
+		.right_margin   = 40,
+		.upper_margin   = 21,
+		.lower_margin   = 7,
+		.hsync_len      = 60,
+		.vsync_len      = 10,
+		.sync           = 0,
+		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
 	.bus	= 2,
 	.addr	= 0x48,
 	.pixfmt	= IPU_PIX_FMT_RGB666,

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:06 UTC #31 lore raw

PATCH 15/32 nitrogen6x: display: add svga display (800x600)

Quoted 10 lines · Eric Nelson

Add support for 800x600 18-bit RGB displays using VESA GTF timings.
No auto-detection is supported, so you must configure this panel manually through the 'panel' environment variable:
U-Boot > setenv panel svga
U-Boot > saveenv && reset
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #32 lore raw

PATCH 16/32 nitrogen6x: display: add Ampire 1024x600 panel

In reply to Eric Nelson

Add support for an Ampire 1024x600 LVDS panel with integrated Ilitek capacitive touch screen.

Auto-detection is enabled, so no explicit configuration is needed.

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +20 -0

index 6695f87..c91e0c4 100644
@@ -661,6 +661,26 @@ struct display_info_t const displays[] = {{
 		.vmode          = FB_VMODE_NONINTERLACED
 } }, {
 	.bus	= 2,
+	.addr	= 0x41,
+	.pixfmt	= IPU_PIX_FMT_LVDS666,
+	.detect	= detect_i2c,
+	.enable	= enable_lvds,
+	.mode	= {
+		.name           = "amp1024x600",
+		.refresh        = 60,
+		.xres           = 1024,
+		.yres           = 600,
+		.pixclock       = 15385,
+		.left_margin    = 220,
+		.right_margin   = 40,
+		.upper_margin   = 21,
+		.lower_margin   = 7,
+		.hsync_len      = 60,
+		.vsync_len      = 10,
+		.sync           = FB_SYNC_EXT,
+		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
+	.bus	= 2,
 	.addr	= 0x48,
 	.pixfmt	= IPU_PIX_FMT_RGB666,
 	.detect	= detect_i2c,

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:06 UTC #33 lore raw

PATCH 16/32 nitrogen6x: display: add Ampire 1024x600 panel

Quoted 7 lines · Eric Nelson

Add support for an Ampire 1024x600 LVDS panel with integrated Ilitek capacitive touch screen.
Auto-detection is enabled, so no explicit configuration is needed.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #34 lore raw

PATCH 17/32 nitrogen6x: display: add wvga-lvds panel

In reply to Eric Nelson

Add support for WVGA (800x480) panels using VESA GTF timings over LVDS.

No auto-detection is supported, so you must configure this panel manually through the 'panel' environment variable:

U-Boot > setenv panel svga
U-Boot > saveenv && reset

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

board/boundary/nitrogen6x/nitrogen6x.c +20 -0

index c91e0c4..115ee81 100644
@@ -680,6 +680,26 @@ struct display_info_t const displays[] = {{
 		.sync           = FB_SYNC_EXT,
 		.vmode          = FB_VMODE_NONINTERLACED
 } }, {
+	.bus	= 0,
+	.addr	= 0,
+	.pixfmt	= IPU_PIX_FMT_LVDS666,
+	.detect	= 0,
+	.enable	= enable_lvds,
+	.mode	= {
+		.name           = "wvga-lvds",
+		.refresh        = 57,
+		.xres           = 800,
+		.yres           = 480,
+		.pixclock       = 15385,
+		.left_margin    = 220,
+		.right_margin   = 40,
+		.upper_margin   = 21,
+		.lower_margin   = 7,
+		.hsync_len      = 60,
+		.vsync_len      = 10,
+		.sync           = FB_SYNC_EXT,
+		.vmode          = FB_VMODE_NONINTERLACED
+} }, {
 	.bus	= 2,
 	.addr	= 0x48,
 	.pixfmt	= IPU_PIX_FMT_RGB666,

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:06 UTC #35 lore raw

PATCH 17/32 nitrogen6x: display: add wvga-lvds panel

Quoted 11 lines · Eric Nelson

Add support for WVGA (800x480) panels using VESA GTF timings over LVDS.
No auto-detection is supported, so you must configure this panel manually through the 'panel' environment variable:
U-Boot > setenv panel svga
U-Boot > saveenv && reset
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #36 lore raw

PATCH 18/32 nitrogen6x: display use I2C detect for HDMI

In reply to Eric Nelson

The HPD pin and RX_SENSE registers have proven to be less reliable than using I2C on the EDID pins for detection of an HDMI monitor. In particular, when the HDMI output is reset through a "reboot" cycle, the detect_hdmi() routine often bounces, resulting in a failure to detect a connected monitor.

Signed-off-by Eric Nelson <[email protected]>

---
 board/boundary/nitrogen6x/nitrogen6x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

board/boundary/nitrogen6x/nitrogen6x.c +3 -3

index 115ee81..269d62e 100644
@@ -500,10 +500,10 @@ static void enable_rgb(struct display_info_t const *dev)
 }
 
 struct display_info_t const displays[] = {{
-	.bus	= -1,
-	.addr	= 0,
+	.bus	= 1,
+	.addr	= 0x50,
 	.pixfmt	= IPU_PIX_FMT_RGB24,
-	.detect	= detect_hdmi,
+	.detect	= detect_i2c,
 	.enable	= do_enable_hdmi,
 	.mode	= {
 		.name           = "HDMI",

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:07 UTC #37 lore raw

PATCH 18/32 nitrogen6x: display use I2C detect for HDMI

Quoted 8 lines · Eric Nelson

The HPD pin and RX_SENSE registers have proven to be less reliable than using I2C on the EDID pins for detection of an HDMI monitor. In particular, when the HDMI output is reset through a "reboot" cycle, the detect_hdmi() routine often bounces, resulting in a failure to detect a connected monitor.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #38 lore raw

PATCH 19/32 nitrogen6x: config: add USB Mass Storage (ums) support

In reply to Eric Nelson

Add support for the USB mass storage to enable access to on-board storage (especially eMMC and SATA).

Details at:
http://boundarydevices.com/u-boot-usb-mass-storage-gadget/

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

include/configs/nitrogen6x.h +13 -0

index 2a1eb3b..5e9b743 100644
@@ -368,4 +368,17 @@
 #define CONFIG_PCIE_IMX
 #endif
 
+#define CONFIG_CMD_ELF
+
+#define CONFIG_USB_GADGET
+#define CONFIG_CMD_USB_MASS_STORAGE
+#define CONFIG_USB_GADGET_MASS_STORAGE
+#define CONFIG_USBDOWNLOAD_GADGET
+#define CONFIG_USB_GADGET_VBUS_DRAW	2
+
+/* Netchip IDs */
+#define CONFIG_G_DNL_VENDOR_NUM 0x0525
+#define CONFIG_G_DNL_PRODUCT_NUM 0xa4a5
+#define CONFIG_G_DNL_MANUFACTURER "Boundary"
+
 #endif	       /* __CONFIG_H */

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:07 UTC #39 lore raw

PATCH 19/32 nitrogen6x: config: add USB Mass Storage (ums) support

Quoted 8 lines · Eric Nelson

Add support for the USB mass storage to enable access to on-board storage (especially eMMC and SATA).
Details at:
http://boundarydevices.com/u-boot-usb-mass-storage-gadget/
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #40 lore raw

PATCH 20/32 nitrogen6x: config: allow boot to USB stick

In reply to Eric Nelson

From: Diego Rondini <[email protected]>

This patch enables boot to USB storage devices by expanding on the list of boot devices.

Because the USB startup currently takes a long time, it places USB at the end of the list of supported devices.

You can over-ride the boot order using the bootdevs environment variable. For instance, this will make USB the first (highest priority) device:

U-Boot > setenv bootdevs usb mmc sata
U-Boot > saveenv

Signed-off-by Diego Rondini <[email protected]>

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

include/configs/nitrogen6x.h +13 -3

index 5e9b743..21a25e0 100644
@@ -173,7 +173,13 @@
 #define CONFIG_DRIVE_MMC
 #endif
 
-#define CONFIG_DRIVE_TYPES CONFIG_DRIVE_SATA CONFIG_DRIVE_MMC
+#ifdef CONFIG_USB_STORAGE
+#define CONFIG_DRIVE_USB "usb "
+#else
+#define CONFIG_DRIVE_USB
+#endif
+
+#define CONFIG_DRIVE_TYPES CONFIG_DRIVE_SATA CONFIG_DRIVE_MMC CONFIG_DRIVE_USB
 
 #if defined(CONFIG_SABRELITE)
 #define CONFIG_EXTRA_ENV_SETTINGS \

@@ -253,12 +259,16 @@
 	"run netboot; "
 #else
 #define CONFIG_EXTRA_ENV_SETTINGS \
+	"bootdevs=" CONFIG_DRIVE_TYPES "\0" \
 	"console=ttymxc1\0" \
 	"clearenv=if sf probe || sf probe || sf probe 1 ; then " \
 		"sf erase 0xc0000 0x2000 && " \
 		"echo restored environment to factory default ; fi\0" \
-	"bootcmd=for dtype in " CONFIG_DRIVE_TYPES \
+	"bootcmd=for dtype in ${bootdevs}" \
 		"; do " \
+			"if itest.s \"xusb\" == \"x${dtype}\" ; then " \
+				"usb start ;" \
+			"fi; " \
 			"for disk in 0 1 ; do ${dtype} dev ${disk} ;" \
 				"for fs in fat ext2 ; do " \
 					"${fs}load " \

@@ -274,7 +284,7 @@
 		"echo ; echo serial console at 115200, 8N1 ; echo ; " \
 		"echo details at http://boundarydevices.com/6q_bootscript ; " \
 		"setenv stdout serial\0" \
-	"upgradeu=for dtype in " CONFIG_DRIVE_TYPES \
+	"upgradeu=for dtype in ${bootdevs}" \
 		"; do " \
 		"for disk in 0 1 ; do ${dtype} dev ${disk} ;" \
 		     "for fs in fat ext2 ; do " \

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:07 UTC #41 lore raw

PATCH 20/32 nitrogen6x: config: allow boot to USB stick

Quoted 11 lines · Eric Nelson

From: Diego Rondini <[email protected]>
This patch enables boot to USB storage devices by expanding on the list of boot devices.
Because the USB startup currently takes a long time, it places USB at the end of the list of supported devices.
You can over-ride the boot order using the bootdevs environment variable. For instance, this will make USB the first (highest priority) device:

Quoted 6 lines

U-Boot > setenv bootdevs usb mmc sata
U-Boot > saveenv
Signed-off-by Diego Rondini <[email protected]>
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #42 lore raw

PATCH 21/32 nitrogen6x: config: use FS_GENERIC load command

In reply to Eric Nelson

From: Kevin Mihelich <[email protected]>

Remove the individual attempts to load using ext2 and fat, replace with the generic load command supporting available filesystem types.

Signed-off-by Kevin Mihelich <[email protected]>

---
 include/configs/nitrogen6x.h | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

include/configs/nitrogen6x.h +8 ~~-12~~

index 21a25e0..2167d77 100644
@@ -270,13 +270,11 @@
 				"usb start ;" \
 			"fi; " \
 			"for disk in 0 1 ; do ${dtype} dev ${disk} ;" \
-				"for fs in fat ext2 ; do " \
-					"${fs}load " \
-						"${dtype} ${disk}:1 " \
-						"10008000 " \
-						"/6x_bootscript" \
-						"&& source 10008000 ; " \
-				"done ; " \
+				"load " \
+					"${dtype} ${disk}:1 " \
+					"10008000 " \
+					"/6x_bootscript" \
+					"&& source 10008000 ; " \
 			"done ; " \
 		"done; " \
 		"setenv stdout serial,vga ; " \

@@ -287,11 +285,9 @@
 	"upgradeu=for dtype in ${bootdevs}" \
 		"; do " \
 		"for disk in 0 1 ; do ${dtype} dev ${disk} ;" \
-		     "for fs in fat ext2 ; do " \
-				"${fs}load ${dtype} ${disk}:1 10008000 " \
-					"/6x_upgrade " \
-					"&& source 10008000 ; " \
-			"done ; " \
+			"load ${dtype} ${disk}:1 10008000 " \
+				"/6x_upgrade " \
+				"&& source 10008000 ; " \
 		"done ; " \
 	"done\0" \

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:07 UTC #43 lore raw

PATCH 21/32 nitrogen6x: config: use FS_GENERIC load command

Quoted 7 lines · Eric Nelson

From: Kevin Mihelich <[email protected]>
Remove the individual attempts to load using ext2 and fat, replace with the generic load command supporting available filesystem types.
Signed-off-by Kevin Mihelich <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #44 lore raw

PATCH 22/32 nitrogen6x: config: add initrd_high

In reply to Eric Nelson

Support RAM disks by setting initrd_high. See commit 7e9603e

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 1 +
 1 file changed, 1 insertion(+)

include/configs/nitrogen6x.h +1 -0

index 2167d77..3c24443 100644
@@ -282,6 +282,7 @@
 		"echo ; echo serial console at 115200, 8N1 ; echo ; " \
 		"echo details at http://boundarydevices.com/6q_bootscript ; " \
 		"setenv stdout serial\0" \
+	"initrd_high=0xffffffff\0" \
 	"upgradeu=for dtype in ${bootdevs}" \
 		"; do " \
 		"for disk in 0 1 ; do ${dtype} dev ${disk} ;" \

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:08 UTC #45 lore raw

PATCH 22/32 nitrogen6x: config: add initrd_high

Quoted 4 lines · Eric Nelson

Support RAM disks by setting initrd_high. See commit 7e9603e
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #46 lore raw

PATCH 23/32 nitrogen6x: config: expose SATA, then MMC over USB

In reply to Eric Nelson

If no boot script was found, expose internal storage over the USB mass storage gadget to allow easy programming.

This is especially useful when SD cards are inaccessible or when loading SATA drives.

More details are available in this blog post:
http://boundarydevices.com/u-boot-usb-mass-storage-gadget/

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

include/configs/nitrogen6x.h +22 -1

index 3c24443..b31b922 100644
@@ -180,6 +180,7 @@
 #endif
 
 #define CONFIG_DRIVE_TYPES CONFIG_DRIVE_SATA CONFIG_DRIVE_MMC CONFIG_DRIVE_USB
+#define CONFIG_UMSDEVS CONFIG_DRIVE_SATA CONFIG_DRIVE_MMC
 
 #if defined(CONFIG_SABRELITE)
 #define CONFIG_EXTRA_ENV_SETTINGS \

@@ -260,6 +261,7 @@
 #else
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootdevs=" CONFIG_DRIVE_TYPES "\0" \
+	"umsdevs=" CONFIG_UMSDEVS "\0" \
 	"console=ttymxc1\0" \
 	"clearenv=if sf probe || sf probe || sf probe 1 ; then " \
 		"sf erase 0xc0000 0x2000 && " \

@@ -281,7 +283,26 @@
 		"echo ; echo 6x_bootscript not found ; " \
 		"echo ; echo serial console at 115200, 8N1 ; echo ; " \
 		"echo details at http://boundarydevices.com/6q_bootscript ; " \
-		"setenv stdout serial\0" \
+		"setenv stdout serial;" \
+		"setenv stdin serial,usbkbd;" \
+		"for dtype in ${umsdevs} ; do " \
+			"if itest.s sata == ${dtype}; then " \
+				"initcmd='sata init' ;" \
+			"else " \
+				"initcmd='mmc rescan' ;" \
+			"fi; " \
+			"for disk in 0 1 ; do " \
+				"if $initcmd && $dtype dev $disk ; then " \
+					"setenv stdout serial,vga; " \
+					"echo expose ${dtype} ${disk} " \
+						"over USB; " \
+					"ums 0 $dtype $disk ;" \
+				"fi; " \
+		"	done; " \
+		"done ;" \
+		"setenv stdout serial,vga; " \
+		"echo no block devices found;" \
+		"\0" \
 	"initrd_high=0xffffffff\0" \
 	"upgradeu=for dtype in ${bootdevs}" \
 		"; do " \

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:08 UTC #47 lore raw

PATCH 23/32 nitrogen6x: config: expose SATA, then MMC over USB

Quoted 11 lines · Eric Nelson

If no boot script was found, expose internal storage over the USB mass storage gadget to allow easy programming.
This is especially useful when SD cards are inaccessible or when loading SATA drives.
More details are available in this blog post:
http://boundarydevices.com/u-boot-usb-mass-storage-gadget/
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #48 lore raw

PATCH 24/32 nitrogen6x: config: enable USB keyboard support

In reply to Eric Nelson

Enable the use of USB keyboards on SABRE Lite and Nitrogen6x boards.

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 2 ++
 1 file changed, 2 insertions(+)

include/configs/nitrogen6x.h +2 -0

index b31b922..d505191 100644
@@ -122,6 +122,8 @@
 #define CONFIG_EHCI_HCD_INIT_AFTER_RESET	/* For OTG port */
 #define CONFIG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS	0
+#define CONFIG_USB_KEYBOARD
+#define CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP
 
 /* Miscellaneous commands */
 #define CONFIG_CMD_BMODE

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:08 UTC #49 lore raw

PATCH 24/32 nitrogen6x: config: enable USB keyboard support

Quoted 4 lines · Eric Nelson

Enable the use of USB keyboards on SABRE Lite and Nitrogen6x boards.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #50 lore raw

PATCH 25/32 nitrogen6x: config: add CONFIG_CMD_MEMTEST

In reply to Eric Nelson

Enable the 'mtest' command on Nitrogen6x and SABRE Lite boards.

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 1 +
 1 file changed, 1 insertion(+)

include/configs/nitrogen6x.h +1 -0

index d505191..82dc0fc 100644
@@ -382,6 +382,7 @@
 #define CONFIG_CMD_BMP
 
 #define CONFIG_CMD_TIME
+#define CONFIG_CMD_MEMTEST
 #define CONFIG_SYS_ALT_MEMTEST
 
 #define CONFIG_CMD_BOOTZ

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:08 UTC #51 lore raw

PATCH 25/32 nitrogen6x: config: add CONFIG_CMD_MEMTEST

Quoted 4 lines · Eric Nelson

Enable the 'mtest' command on Nitrogen6x and SABRE Lite boards.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #52 lore raw

PATCH 26/32 nitrogen6x: config: enable "i2c edid"

In reply to Eric Nelson

Enable the "i2c edid" command to query data from an attached HDMI monitor.

Usage is typically this:

        U-Boot > i2c dev 1
        U-Boot > i2c edid 0x50
        ...

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 1 +
 1 file changed, 1 insertion(+)

include/configs/nitrogen6x.h +1 -0

index 82dc0fc..b911d06 100644
@@ -63,6 +63,7 @@
 #define CONFIG_SYS_I2C
 #define CONFIG_SYS_I2C_MXC
 #define CONFIG_SYS_I2C_SPEED		100000
+#define CONFIG_I2C_EDID
 
 /* MMC Configs */
 #define CONFIG_FSL_ESDHC

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:08 UTC #53 lore raw

PATCH 26/32 nitrogen6x: config: enable "i2c edid"

Quoted 11 lines · Eric Nelson

Enable the "i2c edid" command to query data from an attached HDMI monitor.
Usage is typically this:
        U-Boot > i2c dev 1
        U-Boot > i2c edid 0x50
        ...
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #54 lore raw

PATCH 27/32 nitrogen6x: config: allow more bootargs parameters

In reply to Eric Nelson

From: Troy Kisky <[email protected]>

Increase the maximum number of arguments allowed by the Hush parser. This prevents errors when users or scripts aren't quoting parameters when setting the "bootargs" variable et al.

Signed-off-by Troy Kisky <[email protected]>

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/nitrogen6x.h +1 -1

index b911d06..50b6c5a 100644
@@ -326,7 +326,7 @@
 
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
-#define CONFIG_SYS_MAXARGS	       16
+#define CONFIG_SYS_MAXARGS	       48
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
 
 #define CONFIG_SYS_MEMTEST_START       0x10000000

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:09 UTC #55 lore raw

PATCH 27/32 nitrogen6x: config: allow more bootargs parameters

Quoted 9 lines · Eric Nelson

From: Troy Kisky <[email protected]>
Increase the maximum number of arguments allowed by the Hush parser. This prevents errors when users or scripts aren't quoting parameters when setting the "bootargs" variable et al.
Signed-off-by Troy Kisky <[email protected]>
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #56 lore raw

PATCH 28/32 nitrogen6x: config: disable logo

In reply to Eric Nelson

Some users (QNX and Windows CE users in particular) have asked to disable the Penguin shown on the display at boot time.

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 1 -
 1 file changed, 1 deletion(-)

include/configs/nitrogen6x.h +0 -1

index 50b6c5a..60c942f 100644
@@ -140,7 +140,6 @@
 #define CONFIG_VIDEO_BMP_RLE8
 #define CONFIG_SPLASH_SCREEN
 #define CONFIG_BMP_16BPP
-#define CONFIG_VIDEO_LOGO
 #define CONFIG_IPUV3_CLK 260000000
 #define CONFIG_CMD_HDMIDETECT
 #define CONFIG_CONSOLE_MUX

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 15:51 UTC #57 lore raw

PATCH 28/32 nitrogen6x: config: disable logo

Quoted 3 lines · Eric Nelson

Some users (QNX and Windows CE users in particular) have asked to disable the Penguin shown on the display at boot time.

This is really pity, but I understand :-).

Acked-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Stefano Babic

2014-10-06 16:09 UTC #58 lore raw

PATCH 28/32 nitrogen6x: config: disable logo

In reply to Eric Nelson

Quoted 5 lines · Eric Nelson

Some users (QNX and Windows CE users in particular) have asked to disable the Penguin shown on the display at boot time.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #59 lore raw

PATCH 29/32 nitrogen6x: config: configure usb_ether

In reply to Eric Nelson

Provide fixed USB networking mac addresses for host and client to enable static configuration of host network stacks.

Include a command 'usbrecover' both to illustrate the use of the USB ethernet gadget and also to allow quick booting of a kernel (uImage) and ram disk (uramdisk).

Details and commentary are available here:

        http://boundarydevices.com/u-boot-2014-01/#usbrecover

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

include/configs/nitrogen6x.h +10 -0

index 60c942f..8afbded 100644
@@ -314,6 +314,16 @@
 				"&& source 10008000 ; " \
 		"done ; " \
 	"done\0" \
+	"usbnet_devaddr=00:19:b8:00:00:02\0" \
+	"usbnet_hostaddr=00:19:b8:00:00:01\0" \
+	"usbrecover=setenv ethact usb_ether; " \
+		"setenv ipaddr 10.0.0.2; " \
+		"setenv netmask 255.255.255.0; " \
+		"setenv serverip 10.0.0.1; " \
+		"setenv bootargs console=ttymxc1,115200; " \
+		"tftpboot 10800000 10.0.0.1:uImage-${board}-recovery && " \
+		"tftpboot 12800000 10.0.0.1:uramdisk-${board}-recovery.img " \
+		"&& bootm 10800000 12800000\0" \
 
 #endif
 /* Miscellaneous configurable options */

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 15:54 UTC #60 lore raw

PATCH 29/32 nitrogen6x: config: configure usb_ether

Hi Eric,

Quoted 23 lines · Eric Nelson

Provide fixed USB networking mac addresses for host and client to enable static configuration of host network stacks.
Include a command 'usbrecover' both to illustrate the use of the USB ethernet gadget and also to allow quick booting of a kernel (uImage) and ram disk (uramdisk).
Details and commentary are available here:
        http://boundarydevices.com/u-boot-2014-01/#usbrecover
Signed-off-by Eric Nelson <[email protected]>
---
 include/configs/nitrogen6x.h | 10 ++++++++++
 1 file changed, 10 insertions(+)
include/configs/nitrogen6x.h +0 -0
index 60c942f..8afbded 100644
@@ -314,6 +314,16 @@
 				"&& source 10008000 ; " \
 		"done ; " \
 	"done\0" \

include/configs/nitrogen6x.h line 326

Quoted 10 lines

include/configs/nitrogen6x.h +10 -0

+	"usbnet_devaddr=00:19:b8:00:00:02\0" \
+	"usbnet_hostaddr=00:19:b8:00:00:01\0" \
+	"usbrecover=setenv ethact usb_ether; " \
+		"setenv ipaddr 10.0.0.2; " \
+		"setenv netmask 255.255.255.0; " \
+		"setenv serverip 10.0.0.1; " \
+		"setenv bootargs console=ttymxc1,115200; " \
+		"tftpboot 10800000 10.0.0.1:uImage-${board}-recovery && " \
+		"tftpboot 12800000 10.0.0.1:uramdisk-${board}-recovery.img " \
+		"&& bootm 10800000 12800000\0" \

I understand the use case, but it does not always work (I mean, in all network configurations) and we regret generally having IP addresses hard coded in the default configuration.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-06 16:41 UTC #61 lore raw

PATCH 29/32 nitrogen6x: config: configure usb_ether

Hi Stefano,

Quoted 32 lines · Stefano Babic

Hi Eric,
Quoted 29 lines · Eric Nelson
Provide fixed USB networking mac addresses for host and client to enable static configuration of host network stacks.
Include a command 'usbrecover' both to illustrate the use of the USB ethernet gadget and also to allow quick booting of a kernel (uImage) and ram disk (uramdisk).
Details and commentary are available here:
        http://boundarydevices.com/u-boot-2014-01/#usbrecover
Signed-off-by Eric Nelson <[email protected]>
---
 include/configs/nitrogen6x.h | 10 ++++++++++
 1 file changed, 10 insertions(+)
include/configs/nitrogen6x.h +6 -0
index 60c942f..8afbded 100644
@@ -314,6 +314,16 @@
 				"&& source 10008000 ; " \
 		"done ; " \
 	"done\0" \
+	"usbnet_devaddr=00:19:b8:00:00:02\0" \
+	"usbnet_hostaddr=00:19:b8:00:00:01\0" \
+	"usbrecover=setenv ethact usb_ether; " \
+		"setenv ipaddr 10.0.0.2; " \
+		"setenv netmask 255.255.255.0; " \
+		"setenv serverip 10.0.0.1; " \

Quoted 9 lines

include/configs/nitrogen6x.h line 326
Quoted 4 lines
include/configs/nitrogen6x.h +4 -0
+		"setenv bootargs console=ttymxc1,115200; " \
+		"tftpboot 10800000 10.0.0.1:uImage-${board}-recovery && " \
+		"tftpboot 12800000 10.0.0.1:uramdisk-${board}-recovery.img " \
+		"&& bootm 10800000 12800000\0" \
I understand the use case, but it does not always work (I mean, in all network configurations) and we regret generally having IP addresses hard coded in the default configuration.

Can you clarify which parts (mac/IP address/both) are a problem?

The 'usb_ether' is kind of an odd beast, in that it's a link-local protocol, which is why the the IP addresses aren't read from or written to a persistent environment.

Our goal was to only require configuration of one side of the link (the USB Host). It seems that without implementing a DHCP **server**, this is the most convenient.

The mac addresses above are ours, and we can confirm that they are not in use on any other hardware, so they're guaranteed to be unique unless you happen to hook up multiple of our boards to a Host at the same time.

Since the configuration of network adapters on most hosts is based on mac addresses, hard-coding these prevents the need to re-configure each time a new board is connected to a host.

Please advise,

Eric

Stefano Babic

2014-10-07 14:36 UTC #62 lore raw

PATCH 29/32 nitrogen6x: config: configure usb_ether

Hi Eric,

Quoted 10 lines · Eric Nelson

Quoted 4 lines
I understand the use case, but it does not always work (I mean, in all network configurations) and we regret generally having IP addresses hard coded in the default configuration.
Can you clarify which parts (mac/IP address/both) are a problem?
The 'usb_ether' is kind of an odd beast, in that it's a link-local protocol, which is why the the IP addresses aren't read from or written to a persistent environment.

This is not completely true. I mean, I understand that you want to have such as situation, with addresses valid only in the link host / target.

However, if a customer / user has a PC belonging to the 10.0.0.0/24 network, there is a conflict. And this is not a rare case, because as I have seen in companies 10.0.0.0/8 are used more often as 192.168.0.0/16.

You can have two interface (ethernet and USB) acting on the same address range and packets originally sent to network are readdressed to the target, letting the customer without network.

I understand that you want to provide is a special case - but as you can see, you cannot cover all cases by setting a hard coded address.

Quoted 4 lines

Our goal was to only require configuration of one side of the link (the USB Host). It seems that without implementing a DHCP **server**, this is the most convenient.

If you really want, why don't you use a script as a 6x_ ? usbrecover can load initially a script setting the network addresses, without hardcoding to the u-boot image.

Quoted 3 lines

The mac addresses above are ours, and we can confirm that they are not in use on any other hardware,

I know that and it is exactly the same we had in the past with other boards. Customers can buy more as one instance of the boards, having then multiple boards with the same MAC address - and very bad case.

Quoted 3 lines

so they're guaranteed to be unique
unless you happen to hook up multiple of our boards to a Host at the same time.

Yes, exactly. Why do you want to restrict your sales chances ? :-D

Seriously, hard coding mac and network addresses was strictly rejected - even if after your patch I have found a couple of boards doing that (maybe it was not seen during review, see for example v38b.h).

Quoted 4 lines

Since the configuration of network adapters on most hosts is based on mac addresses, hard-coding these prevents the need to re-configure each time a new board is connected to a host.

I understand that hard coding makes life easier, but I am not convinced it is the correct way to do, specially with IP addresses.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-07 15:08 UTC #63 lore raw

PATCH 29/32 nitrogen6x: config: configure usb_ether

Thanks Stefano,

Quoted 22 lines · Stefano Babic

Hi Eric,
Quoted 10 lines · Eric Nelson
Quoted 4 lines
I understand the use case, but it does not always work (I mean, in all network configurations) and we regret generally having IP addresses hard coded in the default configuration.
Can you clarify which parts (mac/IP address/both) are a problem?
The 'usb_ether' is kind of an odd beast, in that it's a link-local protocol, which is why the the IP addresses aren't read from or written to a persistent environment.
This is not completely true. I mean, I understand that you want to have such as situation, with addresses valid only in the link host / target.
However, if a customer / user has a PC belonging to the 10.0.0.0/24 network, there is a conflict. And this is not a rare case, because as I have seen in companies 10.0.0.0/8 are used more often as 192.168.0.0/16.

Quoted 7 lines

You can have two interface (ethernet and USB) acting on the same address range and packets originally sent to network are readdressed to the target, letting the customer without network.
I understand that you want to provide is a special case - but as you can see, you cannot cover all cases by setting a hard coded address.

Right. I've also seen that.

It seems that 169.254.x.x is more appropriate.

	http://tools.ietf.org/html/rfc3927

Quoted 9 lines

Quoted 4 lines
Our goal was to only require configuration of one side of the link (the USB Host). It seems that without implementing a DHCP **server**, this is the most convenient.
If you really want, why don't you use a script as a 6x_ ? usbrecover can load initially a script setting the network addresses, without hardcoding to the u-boot image.

Chicken and egg.... The goal for usbrecover was/is to allow access to on-board storage (SATA on Nitrogen6x, eMMC on Nitrogen6_Max)

Thankfully, the "ums" utility now functions nicely for that purpose without using IP.

A kernel gadget still performs much better though (~2x), since you can interleave writes to storage with USB I/O.

Quoted 8 lines

Quoted 3 lines
The mac addresses above are ours, and we can confirm that they are not in use on any other hardware,
I know that and it is exactly the same we had in the past with other boards. Customers can buy more as one instance of the boards, having then multiple boards with the same MAC address - and very bad case.

Quoted 6 lines

Quoted 3 lines
so they're guaranteed to be unique
unless you happen to hook up multiple of our boards to a Host at the same time.
Yes, exactly. Why do you want to restrict your sales chances ? :-D

This (and all of our patches) is an attempt to increase sales by making life easier on users.

Quoted 4 lines

Seriously, hard coding mac and network addresses was strictly rejected - even if after your patch I have found a couple of boards doing that (maybe it was not seen during review, see for example v38b.h).

Understood.

Quoted 8 lines

Quoted 4 lines
Since the configuration of network adapters on most hosts is based on mac addresses, hard-coding these prevents the need to re-configure each time a new board is connected to a host.
I understand that hard coding makes life easier, but I am not convinced it is the correct way to do, specially with IP addresses.

Right.

Perhaps when we have some spare time we could write a DHCP server component to get closer to auto-configuration, although it's not clear how that would interact with other commands.

I appreciate your time in review and commenting.

Regards,

Eric

Eric Nelson

author

2014-10-02 19:16 UTC #64 lore raw

PATCH 30/32 nitrogen6x: config: add gpio command

In reply to Eric Nelson

Enable the 'gpio' command to allow reading and toggling of GPIO pins.

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 1 +
 1 file changed, 1 insertion(+)

include/configs/nitrogen6x.h +1 -0

index 8afbded..df3e2bb 100644
@@ -32,6 +32,7 @@
 #define CONFIG_BOARD_EARLY_INIT_F
 #define CONFIG_MISC_INIT_R
 #define CONFIG_MXC_GPIO
+#define CONFIG_CMD_GPIO
 #define CONFIG_CI_UDC
 #define CONFIG_USBD_HS
 #define CONFIG_USB_GADGET_DUALSPEED

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:09 UTC #65 lore raw

PATCH 30/32 nitrogen6x: config: add gpio command

Quoted 5 lines · Eric Nelson

Enable the 'gpio' command to allow reading and toggling of GPIO pins.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #66 lore raw

PATCH 31/32 nitrogen6x: config: enable Android fastboot

In reply to Eric Nelson

Enable 'fastboot' command.

This is currently enabled but not yet functional. Including it in the configuration will ease further testing and development as discussed on the mailing list.

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 5 +++++
 1 file changed, 5 insertions(+)

include/configs/nitrogen6x.h +5 -0

index df3e2bb..f465d9e 100644
@@ -423,4 +423,9 @@
 #define CONFIG_G_DNL_PRODUCT_NUM 0xa4a5
 #define CONFIG_G_DNL_MANUFACTURER "Boundary"
 
+#define CONFIG_CMD_FASTBOOT
+#define CONFIG_ANDROID_BOOT_IMAGE
+#define CONFIG_USB_FASTBOOT_BUF_ADDR   CONFIG_SYS_LOAD_ADDR
+#define CONFIG_USB_FASTBOOT_BUF_SIZE   0x07000000
+
 #endif	       /* __CONFIG_H */

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:09 UTC #67 lore raw

PATCH 31/32 nitrogen6x: config: enable Android fastboot

Quoted 8 lines · Eric Nelson

Enable 'fastboot' command.
This is currently enabled but not yet functional. Including it in the configuration will ease further testing and development as discussed on the mailing list.
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Eric Nelson

author

2014-10-02 19:16 UTC #68 lore raw

PATCH 32/32 nitrogen6x: config: enable EXT4 filesystem

In reply to Eric Nelson

From: Kevin Mihelich <[email protected]>

Support reading/writing ext4 partitions.

Signed-off-by Kevin Mihelich <[email protected]>

Signed-off-by Eric Nelson <[email protected]>

---
 include/configs/nitrogen6x.h | 2 ++
 1 file changed, 2 insertions(+)

include/configs/nitrogen6x.h +2 -0

index f465d9e..d08e333 100644
@@ -77,6 +77,8 @@
 #define CONFIG_GENERIC_MMC
 #define CONFIG_BOUNCE_BUFFER
 #define CONFIG_CMD_EXT2
+#define CONFIG_CMD_EXT4
+#define CONFIG_CMD_EXT4_WRITE
 #define CONFIG_CMD_FAT
 #define CONFIG_DOS_PARTITION

Signature · 1 line

1.9.1

Stefano Babic

2014-10-06 16:10 UTC #69 lore raw

PATCH 32/32 nitrogen6x: config: enable EXT4 filesystem

Quoted 7 lines · Eric Nelson

From: Kevin Mihelich <[email protected]>
Support reading/writing ext4 partitions.
Signed-off-by Kevin Mihelich <[email protected]>
Signed-off-by Eric Nelson <[email protected]>
---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Stefano Babic

2014-10-06 15:35 UTC #70 lore raw

cover ARM: i.MX: nitrogen6x clean up

In reply to Eric Nelson

Hi Eric,

Quoted 6 lines · Eric Nelson

This collection of patches comprises a set of updates that have been lingering in our Github repository.
We're pushing them to main-line in preparation for the addition of a couple of boards that have also been lingering for a while.

Quoted 9 lines

Patches 1-9 are tweaks to the mx6qsabrelite/nitrogen6x initialization code.
Patches 10-18 add support for additional displays supported by the board(s) and tweak the HDMI detection.
Patches 19-32 enable and configure various features through changes to include/configs/nitrogen6x.h.

Patches are orthogonal and can be applied separetely. I have not seen any comments and I have not comments for most of them. I will start to apply the ones (most of them) are straightforward. Please wait until I end up with first pass - your next version will be much shorter !

Quoted 18 lines

Diego Rondini (1):
nitrogen6x: config: allow boot to USB stick
Eric Nelson (24):
nitrogen6x: implement board_cfb_skip() to disable text output
nitrogen6x: configure SD2 pads for SDIO on USDHC2
nitrogen6x: power-down miscellanous peripherals
nitrogen6x: staticize board file
nitrogen6x: Allow U-Boot to be silent on UART2
nitrogen6x: prevent warnings about board_ehci* callbacks
nitrogen6x: display: add qvga panel
nitrogen6x: display: add support for LG-9.7 LVDS display
nitrogen6x: display: add LDB-WXGA-S for SPWG 1280x800 displays
nitrogen6x: display: add support for fusion 7 display
nitrogen6x: display: add svga display (800x600)
nitrogen6x: display: add Ampire 1024x600 panel
nitrogen6x: display: add wvga-lvds panel
nitrogen6x: display use I2C detect for HDMI

Quoted 8 lines

nitrogen6x: config: add USB Mass Storage (ums) support
nitrogen6x: config: add initrd_high
nitrogen6x: config: expose SATA, then MMC over USB
nitrogen6x: config: enable USB keyboard support
nitrogen6x: config: add CONFIG_CMD_MEMTEST
nitrogen6x: config: enable "i2c edid"
nitrogen6x: config: disable logo
nitrogen6x: config: configure usb_ether

Mainly I have problems with fixed addresses - my comments to the related patch.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================