Skip to contentSkip to conversation

package/trinity: New package

PATCH Superseded Vicente Olivert Riera 3 participants 6 messages Oct 8, 2014

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH v2 1/1 package/trinity: New package

Adding the Trinity Linux System call fuzz tester.

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/Config.in          |    1 +
 package/trinity/Config.in  |   10 ++++++++++
 package/trinity/trinity.mk |   31 +++++++++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100644 package/trinity/Config.in
 create mode 100644 package/trinity/trinity.mk
package/Config.in +1 -0
index ea89c96..3b570ee 100644
@@ -89,6 +89,7 @@ endif
 	source "package/sysprof/Config.in"
 	source "package/tinymembench/Config.in"
 	source "package/trace-cmd/Config.in"
+	source "package/trinity/Config.in"
 	source "package/valgrind/Config.in"
 	source "package/whetstone/Config.in"
 endmenu
package/trinity/Config.in new file +10 -0
new file mode 100644
index 0000000..c648694
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_TRINITY
+	bool "trinity"
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC
+	help
+	  A Linux System call fuzz tester
+
+	  http://codemonkey.org.uk/projects/trinity/
+
+comment "trinity is not supported for uClibc"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC
package/trinity/trinity.mk new file +31 -0
new file mode 100644
index 0000000..1e6c54a
@@ -0,0 +1,31 @@
+################################################################################
+#
+# trinity
+#
+################################################################################
+
+TRINITY_VERSION = c02034ec08d951cde3429905e64afe450cbc47db
+TRINITY_SITE = $(call github,kernelslacker,trinity,$(TRINITY_VERSION))
+TRINITY_LICENSE = GPLv2
+TRINITY_LICENSE_FILES = COPYING
+
+define TRINITY_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.sh)
+endef
+
+define TRINITY_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define TRINITY_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR)/usr install
+endef
+
+# Install helper scripts
+define TRINITY_INSTALL_HELPER_SCRIPTS
+	mkdir -p $(TARGET_DIR)/usr/libexec/trinity
+	cp -p $(@D)/scripts/* $(TARGET_DIR)/usr/libexec/trinity/
+endef
+TRINITY_POST_INSTALL_TARGET_HOOKS += TRINITY_INSTALL_HELPER_SCRIPTS
+
+$(eval $(generic-package))
Signature · 1 line
1.7.1
#1 lore raw

PATCH v2 1/1 package/trinity: New package

Hi,

may be I missed it in v1, is there a reason for
depends on !BR2_TOOLCHAIN_USES_UCLIBC ?
May be you can add a comment about it.

best regards
Waldemar

Vicente Olivert Riera wrote,

Quoted 84 lines

Adding the Trinity Linux System call fuzz tester.

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/Config.in          |    1 +
 package/trinity/Config.in  |   10 ++++++++++
 package/trinity/trinity.mk |   31 +++++++++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100644 package/trinity/Config.in
 create mode 100644 package/trinity/trinity.mk
package/Config.in +1 -0
index ea89c96..3b570ee 100644
@@ -89,6 +89,7 @@ endif
 	source "package/sysprof/Config.in"
 	source "package/tinymembench/Config.in"
 	source "package/trace-cmd/Config.in"
+	source "package/trinity/Config.in"
 	source "package/valgrind/Config.in"
 	source "package/whetstone/Config.in"
 endmenu
package/trinity/Config.in new file +10 -0
new file mode 100644
index 0000000..c648694
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_TRINITY
+	bool "trinity"
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC
+	help
+	  A Linux System call fuzz tester
+
+	  http://codemonkey.org.uk/projects/trinity/
+
+comment "trinity is not supported for uClibc"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC
package/trinity/trinity.mk new file +31 -0
new file mode 100644
index 0000000..1e6c54a
@@ -0,0 +1,31 @@
+################################################################################
+#
+# trinity
+#
+################################################################################
+
+TRINITY_VERSION = c02034ec08d951cde3429905e64afe450cbc47db
+TRINITY_SITE = $(call github,kernelslacker,trinity,$(TRINITY_VERSION))
+TRINITY_LICENSE = GPLv2
+TRINITY_LICENSE_FILES = COPYING
+
+define TRINITY_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.sh)
+endef
+
+define TRINITY_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define TRINITY_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR)/usr install
+endef
+
+# Install helper scripts
+define TRINITY_INSTALL_HELPER_SCRIPTS
+	mkdir -p $(TARGET_DIR)/usr/libexec/trinity
+	cp -p $(@D)/scripts/* $(TARGET_DIR)/usr/libexec/trinity/
+endef
+TRINITY_POST_INSTALL_TARGET_HOOKS += TRINITY_INSTALL_HELPER_SCRIPTS
+
+$(eval $(generic-package))
Signature · 6 lines
1.7.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
author
#2 lore raw

PATCH v2 1/1 package/trinity: New package

Dear Waldemar Brodkorb,

Quoted 4 lines · Waldemar Brodkorb

Hi,

may be I missed it in v1, is there a reason for
depends on !BR2_TOOLCHAIN_USES_UCLIBC ?

This is the v1 patch. You can see the reason there.

Regards,

--
Vincent

Quoted 92 lines

May be you can add a comment about it.

best regards
Waldemar

Vicente Olivert Riera wrote,

Quoted 84 lines

Adding the Trinity Linux System call fuzz tester.

Signed-off-by Vicente Olivert Riera <[email protected]>
---
  package/Config.in          |    1 +
  package/trinity/Config.in  |   10 ++++++++++
  package/trinity/trinity.mk |   31 +++++++++++++++++++++++++++++++
  3 files changed, 42 insertions(+), 0 deletions(-)

create mode 100644 package/trinity/Config.in
create mode 100644 package/trinity/trinity.mk

package/Config.in +1 -0
index ea89c96..3b570ee 100644
@@ -89,6 +89,7 @@ endif
  	source "package/sysprof/Config.in"
  	source "package/tinymembench/Config.in"
  	source "package/trace-cmd/Config.in"
+	source "package/trinity/Config.in"
  	source "package/valgrind/Config.in"
  	source "package/whetstone/Config.in"
  endmenu
package/trinity/Config.in new file +10 -0
new file mode 100644
index 0000000..c648694
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_TRINITY
+	bool "trinity"
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC
+	help
+	  A Linux System call fuzz tester
+
+	  http://codemonkey.org.uk/projects/trinity/
+
+comment "trinity is not supported for uClibc"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC
package/trinity/trinity.mk new file +31 -1
new file mode 100644
index 0000000..1e6c54a
@@ -0,0 +1,31 @@
+################################################################################
+#
+# trinity
+#
+################################################################################
+
+TRINITY_VERSION = c02034ec08d951cde3429905e64afe450cbc47db
+TRINITY_SITE = $(call github,kernelslacker,trinity,$(TRINITY_VERSION))
+TRINITY_LICENSE = GPLv2
+TRINITY_LICENSE_FILES = COPYING
+
+define TRINITY_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.sh)
+endef
+
+define TRINITY_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define TRINITY_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR)/usr install
+endef
+
+# Install helper scripts
+define TRINITY_INSTALL_HELPER_SCRIPTS
+	mkdir -p $(TARGET_DIR)/usr/libexec/trinity
+	cp -p $(@D)/scripts/* $(TARGET_DIR)/usr/libexec/trinity/
+endef
+TRINITY_POST_INSTALL_TARGET_HOOKS += TRINITY_INSTALL_HELPER_SCRIPTS
+
+$(eval $(generic-package))
--

1.7.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#3 lore raw

PATCH v2 1/1 package/trinity: New package

Sorry, I forgot to add the URL:

http://patchwork.ozlabs.org/patch/396775/

Quoted 114 lines · Vicente Olivert Riera

Dear Waldemar Brodkorb,

Quoted 4 lines · Waldemar Brodkorb

Hi,

may be I missed it in v1, is there a reason for
depends on !BR2_TOOLCHAIN_USES_UCLIBC ?

This is the v1 patch. You can see the reason there.

Regards,

--
Vincent

Quoted 90 lines

May be you can add a comment about it.

best regards
Waldemar

Vicente Olivert Riera wrote,

Quoted 82 lines

Adding the Trinity Linux System call fuzz tester.

Signed-off-by Vicente Olivert Riera <[email protected]>
---
  package/Config.in          |    1 +
  package/trinity/Config.in  |   10 ++++++++++
  package/trinity/trinity.mk |   31 +++++++++++++++++++++++++++++++
  3 files changed, 42 insertions(+), 0 deletions(-)

create mode 100644 package/trinity/Config.in
create mode 100644 package/trinity/trinity.mk

package/Config.in +1 -0
index ea89c96..3b570ee 100644
@@ -89,6 +89,7 @@ endif
      source "package/sysprof/Config.in"
      source "package/tinymembench/Config.in"
      source "package/trace-cmd/Config.in"
+    source "package/trinity/Config.in"
      source "package/valgrind/Config.in"
      source "package/whetstone/Config.in"
  endmenu
package/trinity/Config.in new file +10 -0
new file mode 100644
index 0000000..c648694
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_TRINITY
+    bool "trinity"
+    depends on !BR2_TOOLCHAIN_USES_UCLIBC
+    help
+      A Linux System call fuzz tester
+
+      http://codemonkey.org.uk/projects/trinity/
+
+comment "trinity is not supported for uClibc"
+    depends on BR2_TOOLCHAIN_USES_UCLIBC
package/trinity/trinity.mk new file +21 -0
new file mode 100644
index 0000000..1e6c54a
@@ -0,0 +1,31 @@
+################################################################################
 
+#
+# trinity
+#
+################################################################################
 
+
+TRINITY_VERSION = c02034ec08d951cde3429905e64afe450cbc47db
+TRINITY_SITE = $(call github,kernelslacker,trinity,$(TRINITY_VERSION))
+TRINITY_LICENSE = GPLv2
+TRINITY_LICENSE_FILES = COPYING
+
+define TRINITY_CONFIGURE_CMDS
+    (cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.sh)
+endef
+
+define TRINITY_BUILD_CMDS
+    $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define TRINITY_INSTALL_TARGET_CMDS
+    $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)

DESTDIR=$(TARGET_DIR)/usr install

package/trinity/trinity.mk new file +10 -1
+endef
+
+# Install helper scripts
+define TRINITY_INSTALL_HELPER_SCRIPTS
+    mkdir -p $(TARGET_DIR)/usr/libexec/trinity
+    cp -p $(@D)/scripts/* $(TARGET_DIR)/usr/libexec/trinity/
+endef
+TRINITY_POST_INSTALL_TARGET_HOOKS += TRINITY_INSTALL_HELPER_SCRIPTS
+
+$(eval $(generic-package))
--

1.7.1

Quoted 5 lines
Quoted 5 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 1 line
Vincent
#4 lore raw

PATCH v2 1/1 package/trinity: New package

In reply to Vicente Olivert Riera
Quoted 10 lines · Vicente Olivert Riera

Dear Waldemar Brodkorb,

Quoted 4 lines · Waldemar Brodkorb

Hi,

may be I missed it in v1, is there a reason for
depends on !BR2_TOOLCHAIN_USES_UCLIBC ?

This is the v1 patch. You can see the reason there.

Still it's probably a good idea to have a comment in Config.in since neither Config.in nor commit message explain the reason so one may forget and remove the restriction in the future.

Signature · 1 line
markos
author
#5 lore raw

PATCH v2 1/1 package/trinity: New package

Dear Markos Chandras,

Quoted 9 lines · Markos Chandras
Quoted 8 lines · Vicente Olivert Riera

Dear Waldemar Brodkorb,

Quoted 4 lines · Waldemar Brodkorb

Hi,

may be I missed it in v1, is there a reason for
depends on !BR2_TOOLCHAIN_USES_UCLIBC ?

Quoted 7 lines
Quoted 2 lines

This is the v1 patch. You can see the reason there.

Still it's probably a good idea to have a comment in Config.in since neither Config.in nor commit message explain the reason so one may forget and remove the restriction in the future.

Patch resent including the information about why we disable this package for uClibc:

http://patchwork.ozlabs.org/patch/397661/

Regards,

Signature · 1 line
Vincent