package/sysvinit: don't start logging
PATCH 1/2 package/sysvinit: don't start logging
Don't try to start logging from /etc/inittab because busybox installs a S01logging script that handles that and can lead to duplicate logging processes.
Let's handle the logging in each package that provides it since we can get multiple variants in the future like syslog-ng that have different initialization routines.
--- package/sysvinit/inittab | 7 ------- 1 file changed, 7 deletions(-)
package/sysvinit/inittab +0 -7
@@ -17,16 +17,9 @@ init::sysinit:/etc/init.d/rcS # S0:1:respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL -# Logging junk -mess::sysinit:/bin/touch /var/log/messages -sysl:1:respawn:/sbin/syslogd -n -m 0 -klog:1:respawn:/sbin/klogd -n - # Stuff to do for the 3-finger salute rebo::ctrlaltdel:/sbin/reboot # Stuff to do before rebooting -sklo:6:wait:/usr/bin/killall klogd -ssys:6:wait:/usr/bin/killall syslogd umou:6:wait:/bin/umount -a -r swap:6:wait:/sbin/swapoff -a
Signature · 1 line
2.0.4
PATCH 2/2 sysklogd: add initscript
Since we don't handle it in sysvinit inittab any longer let's add an initscript to get things back into plug-and-play shape.
--- package/sysklogd/S01logging | 25 +++++++++++++++++++++++++ package/sysklogd/sysklogd.mk | 5 +++++ 2 files changed, 30 insertions(+) create mode 100644 package/sysklogd/S01logging
package/sysklogd/S01logging new file +25 -0
@@ -0,0 +1,25 @@ +#!/bin/sh + +case "$1" in + start) + echo -n "Starting logging: " + /sbin/syslogd -m 0 + /sbin/klogd + echo "OK" + ;; + stop) + echo -n "Stopping logging: " + [ -f /var/run/klogd.pid ] && kill `cat /var/run/klogd.pid` + [ -f /var/run/syslogd.pid ] && kill `cat /var/run/syslogd.pid` + echo "OK" + ;; + restart|reload) + $0 stop + $0 start + ;; + *) + echo "Usage: $0 {start|stop|restart}" + exit 1 +esac + +exit $?
package/sysklogd/sysklogd.mk +5 -0
@@ -27,4 +27,9 @@ define SYSKLOGD_INSTALL_TARGET_CMDS fi endef +define SYSKLOGD_INSTALL_INIT_SYSV + $(INSTALL) -m 755 -D package/sysklogd/S01logging \ + $(TARGET_DIR)/etc/init.d/S01logging +endef + $(eval $(generic-package))
Signature · 1 line
2.0.4
PATCH 2/2 sysklogd: add initscript
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
Since we don't handle it in sysvinit inittab any longer let's add an initscript to get things back into plug-and-play shape.
Signed-off-by Gustavo Zacarias <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/2 package/sysvinit: don't start logging
In reply to Gustavo ZacariasQuoted 9 lines · Gustavo Zacarias
Don't try to start logging from
/etc/inittabbecause busybox installs a S01logging script that handles that and can lead to duplicate logging processes.
Let's handle the logging in each package that provides it since we can get multiple variants in the future like syslog-ng that have different initialization routines.Signed-off-by Gustavo Zacarias <[email protected]>---
Thanks. That has always been bugging me but never got around to fix it myself
Signature · 1 line
markos
PATCH 1/2 package/sysvinit: don't start logging
In reply to Gustavo ZacariasQuoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
Don't try to start logging from
/etc/inittabbecause busybox installs a S01logging script that handles that and can lead to duplicate logging processes.
Let's handle the logging in each package that provides it since we can get multiple variants in the future like syslog-ng that have different initialization routines.Signed-off-by Gustavo Zacarias <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard