Skip to contentSkip to conversation

vlc: fix build when Qt4 development files are installed on the host

PATCH New Thomas Petazzoni 4 participants 4 messages Oct 8, 2014 – Oct 10, 2014

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 vlc: fix build when Qt4 development files are installed on the host

When Qt4 development files are installed on the host, VLC uses /usr/bin/moc, /usr/bin/uic and /usr/bin/rcc when Qt support is enabled. However, those host installed versions are not necessarily compatible with the Qt version used in Buildroot, causes some build failures.

This commit therefore passes explicit ac_cv_path_MOC, ac_cv_path_RCC and ac_cv_path_UIC variables to make sure the Qt host tools built by Buildroot are used.

Note that the VLC configure.ac script uses 'pkg-config --variable=exec_prefix QtCore' to find the location of such tools, but this invocation returns /usr. One solution would have been to extend the pkgconf-01-fix-variable.patch we have against pkgconf to also cover exec_prefix, but this has more uncertain consequences than just fixing VLC.

Fixes:

http://autobuild.buildroot.org/results/061/06174eaeb7f2b8a591395e607912ad72623b79e3/

Signed-off-by Thomas Petazzoni <[email protected]>
Cc Bernd Kuhls <[email protected]>
---
 package/vlc/vlc.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/vlc/vlc.mk +4 -0
index 0b275f2..13c72ce 100644
@@ -251,6 +251,10 @@ endif
 
 ifeq ($(BR2_PACKAGE_QT_GUI_MODULE),y)
 VLC_CONF_OPTS += --enable-qt
+VLC_CONF_ENV += \
+       ac_cv_path_MOC=$(HOST_DIR)/usr/bin/moc \
+       ac_cv_path_RCC=$(HOST_DIR)/usr/bin/rcc \
+       ac_cv_path_UIC=$(HOST_DIR)/usr/bin/uic
 VLC_DEPENDENCIES += qt
 else
 VLC_CONF_OPTS += --disable-qt
Signature · 1 line
2.0.0
#1 lore raw

PATCH 1/1 vlc: fix build when Qt4 development files are installed on the host

Thomas, All,

On 2014-10-08 23:11 +0200, Thomas Petazzoni spake thusly:

Quoted 17 lines

When Qt4 development files are installed on the host, VLC uses /usr/bin/moc, /usr/bin/uic and /usr/bin/rcc when Qt support is enabled. However, those host installed versions are not necessarily compatible with the Qt version used in Buildroot, causes some build failures.

This commit therefore passes explicit ac_cv_path_MOC, ac_cv_path_RCC and ac_cv_path_UIC variables to make sure the Qt host tools built by Buildroot are used.

Note that the VLC configure.ac script uses 'pkg-config --variable=exec_prefix QtCore' to find the location of such tools, but this invocation returns /usr. One solution would have been to extend the pkgconf-01-fix-variable.patch we have against pkgconf to also cover exec_prefix, but this has more uncertain consequences than just fixing VLC.

Quoted 6 lines

Fixes:

http://autobuild.buildroot.org/results/061/06174eaeb7f2b8a591395e607912ad72623b79e3/

Signed-off-by Thomas Petazzoni <[email protected]>
Cc Bernd Kuhls <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/vlc/vlc.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/vlc/vlc.mk +4 -0
index 0b275f2..13c72ce 100644
@@ -251,6 +251,10 @@ endif
 
 ifeq ($(BR2_PACKAGE_QT_GUI_MODULE),y)
 VLC_CONF_OPTS += --enable-qt
+VLC_CONF_ENV += \
+       ac_cv_path_MOC=$(HOST_DIR)/usr/bin/moc \
+       ac_cv_path_RCC=$(HOST_DIR)/usr/bin/rcc \
+       ac_cv_path_UIC=$(HOST_DIR)/usr/bin/uic
 VLC_DEPENDENCIES += qt
 else
 VLC_CONF_OPTS += --disable-qt
Signature · 6 lines
2.0.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 vlc: fix build when Qt4 development files are installed on the host

In reply to Thomas Petazzoni

Dear Thomas Petazzoni,

Quoted 33 lines · Thomas Petazzoni

When Qt4 development files are installed on the host, VLC uses /usr/bin/moc, /usr/bin/uic and /usr/bin/rcc when Qt support is enabled. However, those host installed versions are not necessarily compatible with the Qt version used in Buildroot, causes some build failures.

This commit therefore passes explicit ac_cv_path_MOC, ac_cv_path_RCC and ac_cv_path_UIC variables to make sure the Qt host tools built by Buildroot are used.

Note that the VLC configure.ac script uses 'pkg-config --variable=exec_prefix QtCore' to find the location of such tools, but this invocation returns /usr. One solution would have been to extend the pkgconf-01-fix-variable.patch we have against pkgconf to also cover exec_prefix, but this has more uncertain consequences than just fixing VLC.

Fixes:

   http://autobuild.buildroot.org/results/061/06174eaeb7f2b8a591395e607912ad72623b79e3/
Signed-off-by Thomas Petazzoni <[email protected]>
Cc Bernd Kuhls <[email protected]>
---
  package/vlc/vlc.mk | 4 ++++
  1 file changed, 4 insertions(+)
package/vlc/vlc.mk +0 -0
index 0b275f2..13c72ce 100644

package/vlc/vlc.mk endif · line 260

Quoted 10 lines
package/vlc/vlc.mk +4 -0
@@ -251,6 +251,10 @@ endif
 
  ifeq ($(BR2_PACKAGE_QT_GUI_MODULE),y)
  VLC_CONF_OPTS += --enable-qt
+VLC_CONF_ENV += \
+       ac_cv_path_MOC=$(HOST_DIR)/usr/bin/moc \
+       ac_cv_path_RCC=$(HOST_DIR)/usr/bin/rcc \
+       ac_cv_path_UIC=$(HOST_DIR)/usr/bin/uic
  VLC_DEPENDENCIES += qt
  else
  VLC_CONF_OPTS += --disable-qt
Tested-by Vicente Olivert Riera <[email protected]>

It also fixes the autobuild failure on MIPS:

http://autobuild.buildroot.net/results/06174eaeb7f2b8a591395e607912ad72623b79e3/

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
#3 lore raw

PATCH 1/1 vlc: fix build when Qt4 development files are installed on the host

In reply to Thomas Petazzoni
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

When Qt4 development files are installed on the host, VLC uses /usr/bin/moc, /usr/bin/uic and /usr/bin/rcc when Qt support is enabled. However, those host installed versions are not necessarily compatible with the Qt version used in Buildroot, causes some build failures.

This commit therefore passes explicit ac_cv_path_MOC, ac_cv_path_RCC and ac_cv_path_UIC variables to make sure the Qt host tools built by Buildroot are used.

Note that the VLC configure.ac script uses 'pkg-config --variable=exec_prefix QtCore' to find the location of such tools, but this invocation returns /usr. One solution would have been to extend the pkgconf-01-fix-variable.patch we have against pkgconf to also cover exec_prefix, but this has more uncertain consequences than just fixing VLC.

Quoted 6 lines

Fixes:

http://autobuild.buildroot.org/results/061/06174eaeb7f2b8a591395e607912ad72623b79e3/

Signed-off-by Thomas Petazzoni <[email protected]>
Cc Bernd Kuhls <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard