Skip to contentSkip to conversation

rockchip: dts: rk3399: Add spl-boot-order for Rock PI 4

PATCH New Andy Yan 4 participants 4 messages Jul 4, 2019 – Jul 15, 2019 Arm (32-bit)

lore
Share & tools
lore

Andy Yan

author
#0 lore raw

PATCH 1/1 rockchip: dts: rk3399: Add spl-boot-order for Rock PI 4

RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.

---

 arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +5 -0
index 7bddc3acdb..30f2b5f479 100644
@@ -4,3 +4,8 @@
  */
 
 #include "rk3399-u-boot.dtsi"
+/ {
+	chosen {
+		u-boot,spl-boot-order = &sdhci, &sdmmc;
+	};
+};
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 rockchip: dts: rk3399: Add spl-boot-order for Rock PI 4

Quoted 7 lines

From: Andy Yan <[email protected]>
Date: Thu, 4 Jul 2019 14:52:47 +0800

RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.

Do you really not want "same-as-spl" in there as well?

Quoted 28 lines

---

 arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +5 -0
index 7bddc3acdb..30f2b5f479 100644
@@ -4,3 +4,8 @@
  */
 
 #include "rk3399-u-boot.dtsi"
+/ {
+	chosen {
+		u-boot,spl-boot-order = &sdhci, &sdmmc;
+	};
+};
Signature · 8 lines
2.17.1



_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
#2 lore raw

PATCH 1/1 rockchip: dts: rk3399: Add spl-boot-order for Rock PI 4

Hi Mark:

Quoted 11 lines · Mark Kettenis <[email protected]> 于2019年7月4日周四 下午3:16写道:
Quoted 7 lines

From: Andy Yan <[email protected]>
Date: Thu, 4 Jul 2019 14:52:47 +0800

RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.

Do you really not want "same-as-spl" in there as well?

same-as-spl can be added as a feather with another patch.
But this patch should be applied first as a fix, or the board can't bootup when there is no sdcard on board.

Quoted 34 lines

Review

Quoted 7 lines

---

 arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi

Quoted 17 lines

index 7bddc3acdb..30f2b5f479 100644

arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +5 -1
@@ -4,3 +4,8 @@
  */
 
 #include "rk3399-u-boot.dtsi"
+/ {
+     chosen {
+             u-boot,spl-boot-order = &sdhci, &sdmmc;
+     };
+};
--

2.17.1

Quoted 4 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#3 lore raw

PATCH 1/1 rockchip: dts: rk3399: Add spl-boot-order for Rock PI 4

In reply to Andy Yan

Hi Andy,

Quoted 6 lines · Andy Yan

RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.

Thanks,

- Kever

Quoted 18 lines

---

  arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++
  1 file changed, 5 insertions(+)
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +5 -0
index 7bddc3acdb..30f2b5f479 100644
@@ -4,3 +4,8 @@
   */
 
  #include "rk3399-u-boot.dtsi"
+/ {
+	chosen {
+		u-boot,spl-boot-order = &sdhci, &sdmmc;
+	};
+};