Skip to contentSkip to conversation

Documentation: virtual: kvm: correct one bit description in APF case

PATCH In review Tiejun Chen 2 participants 2 messages Oct 11, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: virtual: kvm: correct one bit description in APF case

When commit 6adba5274206 (KVM: Let host know whether the guest can handle async PF in non-userspace context.) is introduced, actually bit 2 still is reserved and should be zero. Instead, bit 1 is 1 to indicate if asynchronous page faults can be injected when vcpu is in cpl == 0, and also please see this,

in the file kvm_para.h, #define KVM_ASYNC_PF_SEND_ALWAYS (1 << 1).

---
 Documentation/virtual/kvm/msr.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virtual/kvm/msr.txt +1 -1
index 6d470ae..2a71c8f 100644
@@ -168,7 +168,7 @@ MSR_KVM_ASYNC_PF_EN: 0x4b564d02
 	64 byte memory area which must be in guest RAM and must be
 	zeroed. Bits 5-2 are reserved and should be zero. Bit 0 is 1
 	when asynchronous page faults are enabled on the vcpu 0 when
-	disabled. Bit 2 is 1 if asynchronous page faults can be injected
+	disabled. Bit 1 is 1 if asynchronous page faults can be injected
 	when vcpu is in cpl == 0.
 
 	First 4 byte of 64 byte memory location will be written to by
Signature · 1 line
1.9.1
maintainer
#1 lore raw

Il 11/10/2014 03:19, Tiejun Chen ha scritto:

Quoted 19 lines

When commit 6adba5274206 (KVM: Let host know whether the guest can handle async PF in non-userspace context.) is introduced, actually bit 2 still is reserved and should be zero. Instead, bit 1 is 1 to indicate if asynchronous page faults can be injected when vcpu is in cpl == 0, and also please see this,

in the file kvm_para.h, #define KVM_ASYNC_PF_SEND_ALWAYS (1 << 1).

---
 Documentation/virtual/kvm/msr.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virtual/kvm/msr.txt +0 -0
index 6d470ae..2a71c8f 100644

Documentation/virtual/kvm/msr.txt MSR_KVM_ASYNC_PF_EN: 0x4b564d02 · line 174

Quoted 8 lines
Documentation/virtual/kvm/msr.txt +1 -1
@@ -168,7 +168,7 @@ MSR_KVM_ASYNC_PF_EN: 0x4b564d02
 	64 byte memory area which must be in guest RAM and must be
 	zeroed. Bits 5-2 are reserved and should be zero. Bit 0 is 1
 	when asynchronous page faults are enabled on the vcpu 0 when
-	disabled. Bit 2 is 1 if asynchronous page faults can be injected
+	disabled. Bit 1 is 1 if asynchronous page faults can be injected
 	when vcpu is in cpl == 0.
 
 	First 4 byte of 64 byte memory location will be written to by

Thanks, applying locally.

Paolo