powerpc/85xx: enable some P1/P2 boards mtdparts for nor flash

PATCH Superseded Yangbo Lu 2 participants 3 messages Aug 18, 2014 – Oct 14, 2014

lore

Share & tools

lore

Yangbo Lu

author

2014-08-18 02:03 UTC #0 lore raw

PATCH v3 1/1 powerpc/85xx: enable some P1/P2 boards mtdparts for nor flash

Enable these boards mtdparts for nor flash:
p1020rdb-pd, p1021rdb-pc, p1022ds, p1025twr, and p2020rdb-pc.

Signed-off-by Xie Xiaobo <[email protected]>

Signed-off-by Yangbo Lu <[email protected]>

Cc York Sun <[email protected]>

Cc Scott Wood <[email protected]>

---
Changes for v2:
- changed commit message
- fixed max line length problem in code
Changes for v3:
- added a Cc to York Sun

---
 include/configs/P1022DS.h      | 12 ++++++++++++
 include/configs/p1_p2_rdb_pc.h | 31 +++++++++++++++++++++++++++++++
 include/configs/p1_twr.h       | 12 ++++++++++++
 3 files changed, 55 insertions(+)

include/configs/P1022DS.h +12 -0

index 139d4fe..4480270 100644
@@ -620,6 +620,18 @@
 #endif
 
 /*
+ * Dynamic MTD Partition support with mtdparts
+ */
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#define CONFIG_FLASH_CFI_MTD
+#define MTDIDS_DEFAULT "nor0=e8000000.nor"
+#define MTDPARTS_DEFAULT "mtdparts=e8000000.nor:48m(ramdisk)," \
+			"14m(diagnostic),2m(dink),6m(kernel),58112k(fs)," \
+			"512k(dtb),768k(u-boot)"
+
+/*
  * Environment
  */
 #ifdef CONFIG_SPIFLASH

include/configs/p1_p2_rdb_pc.h +31 -0

index 07b6179..1ed8838 100644
@@ -77,6 +77,16 @@
 #define __SW_BOOT_NAND		0x44
 #define __SW_BOOT_PCIE		0x74
 #define CONFIG_SYS_L2_SIZE	(256 << 10)
+/*
+ * Dynamic MTD Partition support with mtdparts
+ */
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#define CONFIG_FLASH_CFI_MTD
+#define MTDIDS_DEFAULT "nor0=ec000000.nor"
+#define MTDPARTS_DEFAULT "mtdparts=ec000000.nor:128k(dtb),6016k(kernel)," \
+			"57088k(fs),1m(vsc7385-firmware),1280k(u-boot)"
 #endif
 
 #if defined(CONFIG_P1021RDB)

@@ -95,6 +105,17 @@
 #define __SW_BOOT_NAND		0xec
 #define __SW_BOOT_PCIE		0x6c
 #define CONFIG_SYS_L2_SIZE	(256 << 10)
+/*
+ * Dynamic MTD Partition support with mtdparts
+ */
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#define CONFIG_FLASH_CFI_MTD
+#define MTDIDS_DEFAULT "nor0=ef000000.nor"
+#define MTDPARTS_DEFAULT "mtdparts=ef000000.nor:256k(vsc7385-firmware)," \
+			"256k(dtb),4608k(kernel),9728k(fs)," \
+			"256k(qe-ucode-firmware),1280k(u-boot)"
 #endif
 
 #if defined(CONFIG_P1024RDB)

@@ -142,6 +163,16 @@
 #define __SW_BOOT_NAND		0xe8
 #define __SW_BOOT_PCIE		0xa8
 #define CONFIG_SYS_L2_SIZE	(512 << 10)
+/*
+ * Dynamic MTD Partition support with mtdparts
+ */
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#define CONFIG_FLASH_CFI_MTD
+#define MTDIDS_DEFAULT "nor0=ef000000.nor"
+#define MTDPARTS_DEFAULT "mtdparts=ef000000.nor:256k(vsc7385-firmware)," \
+			"256k(dtb),4608k(kernel),9984k(fs),1280k(u-boot)"
 #endif
 
 #ifdef CONFIG_SDCARD

include/configs/p1_twr.h +12 -0

index c296a07..d3093f5 100644
@@ -389,6 +389,18 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
 #endif /* CONFIG_TWR-P1025 */
 
 /*
+ * Dynamic MTD Partition support with mtdparts
+ */
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#define CONFIG_FLASH_CFI_MTD
+#define MTDIDS_DEFAULT "nor0=ec000000.nor"
+#define MTDPARTS_DEFAULT "mtdparts=ec000000.nor:256k(vsc7385-firmware)," \
+			"256k(dtb),5632k(kernel),57856k(fs)," \
+			"256k(qe-ucode-firmware),1280k(u-boot)"
+
+/*
  * Environment
  */
 #ifdef CONFIG_SYS_RAMBOOT

Signature · 1 line

1.8.5

York Sun

2014-08-18 02:43 UTC #1 lore raw

PATCH v3 1/1 powerpc/85xx: enable some P1/P2 boards mtdparts for nor flash

Yangbo,

Quoted 28 lines · Yangbo Lu

Enable these boards mtdparts for nor flash:
p1020rdb-pd, p1021rdb-pc, p1022ds, p1025twr, and p2020rdb-pc.
Signed-off-by Xie Xiaobo <[email protected]>
Signed-off-by Yangbo Lu <[email protected]>
Cc York Sun <[email protected]>
Cc Scott Wood <[email protected]>
---
Changes for v2:
- changed commit message
- fixed max line length problem in code
Changes for v3:
- added a Cc to York Sun
---
include/configs/P1022DS.h      | 12 ++++++++++++
include/configs/p1_p2_rdb_pc.h | 31 +++++++++++++++++++++++++++++++
include/configs/p1_twr.h       | 12 ++++++++++++
3 files changed, 55 insertions(+)
include/configs/P1022DS.h +1 -0
index 139d4fe..4480270 100644
@@ -620,6 +620,18 @@
 #endif
 
 /*
+ * Dynamic MTD Partition support with mtdparts

include/configs/P1022DS.h line 633

Quoted 10 lines

include/configs/P1022DS.h +10 -0

+ */
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#define CONFIG_FLASH_CFI_MTD
+#define MTDIDS_DEFAULT "nor0=e8000000.nor"
+#define MTDPARTS_DEFAULT "mtdparts=e8000000.nor:48m(ramdisk)," \
+			"14m(diagnostic),2m(dink),6m(kernel),58112k(fs)," \
+			"512k(dtb),768k(u-boot)"
+

Don't you need to consider both 32- and 36-bit physical address for the flash base here? The same comment applies to p1_p2_rdb_pc.h as well.

York

Quoted 1 line

York Sun

2014-10-14 18:31 UTC #2 lore raw

PATCH v3 1/1 powerpc/85xx: enable some P1/P2 boards mtdparts for nor flash

Quoted 30 lines · York Sun

Yangbo,
Quoted 26 lines · Yangbo Lu
Enable these boards mtdparts for nor flash:
p1020rdb-pd, p1021rdb-pc, p1022ds, p1025twr, and p2020rdb-pc.
Signed-off-by Xie Xiaobo <[email protected]>
Signed-off-by Yangbo Lu <[email protected]>
Cc York Sun <[email protected]>
Cc Scott Wood <[email protected]>
---
Changes for v2:
- changed commit message
- fixed max line length problem in code
Changes for v3:
- added a Cc to York Sun
---
include/configs/P1022DS.h      | 12 ++++++++++++
include/configs/p1_p2_rdb_pc.h | 31 +++++++++++++++++++++++++++++++
include/configs/p1_twr.h       | 12 ++++++++++++
3 files changed, 55 insertions(+)
include/configs/P1022DS.h +0 -0
index 139d4fe..4480270 100644
@@ -620,6 +620,18 @@
 #endif
 

Quoted 16 lines

include/configs/P1022DS.h line 633
Quoted 12 lines
include/configs/P1022DS.h +11 -0
 /*
+ * Dynamic MTD Partition support with mtdparts
+ */
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#define CONFIG_FLASH_CFI_MTD
+#define MTDIDS_DEFAULT "nor0=e8000000.nor"
+#define MTDPARTS_DEFAULT "mtdparts=e8000000.nor:48m(ramdisk)," \
+			"14m(diagnostic),2m(dink),6m(kernel),58112k(fs)," \
+			"512k(dtb),768k(u-boot)"
+
Don't you need to consider both 32- and 36-bit physical address for the flash base here? The same comment applies to p1_p2_rdb_pc.h as well.

Please respond.

York