cppunit: Added package
PATCH v2 1/1 cppunit: Added package
CppUnit is the C++ port of the famous JUnit framework for unit testing. Test output is in XML or text format for automatic testing and GUI based for supervised tests.
http://www.freedesktop.org/wiki/Software/cppunit/
---
Changes v1 -> v2:
- used AUTORECONF option (suggested by romain.naour at openwide.fr)
- removed useless CONFIGURE_CMDS (suggested by romain.naour at openwide.fr)
--- package/Config.in | 1 + package/cppunit/Config.in | 12 ++++++++++++ package/cppunit/cppunit.mk | 14 ++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 package/cppunit/Config.in create mode 100644 package/cppunit/cppunit.mk
package/Config.in +1 -0
@@ -838,6 +838,7 @@ menu "Other" source "package/clapack/Config.in" source "package/classpath/Config.in" source "package/cppcms/Config.in" + source "package/cppunit/Config.in" source "package/eigen/Config.in" source "package/elfutils/Config.in" source "package/fftw/Config.in"
package/cppunit/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_CPPUNIT + bool "cppunit" + depends on BR2_INSTALL_LIBSTDCPP + help + CppUnit is the C++ port of the famous JUnit framework for unit testing. + Test output is in XML or text format for automatic testing and GUI + based for supervised tests. + + http://www.freedesktop.org/wiki/Software/cppunit/ + +comment "cppunit needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP
package/cppunit/cppunit.mk new file +14 -0
@@ -0,0 +1,14 @@ +################################################################################ +# +# cppunit +# +################################################################################ + +CPPUNIT_VERSION = cppunit-1.13.2 +CPPUNIT_SITE = git://anongit.freedesktop.org/git/libreoffice/cppunit/ +CPPUNIT_INSTALL_STAGING = YES +CPPUNIT_LICENSE = GPLv2 +CPPUNIT_LICENSE_FILES = COPYING +CPPUNIT_AUTORECONF = YES + +$(eval $(autotools-package))
Signature · 1 line
1.8.3.4
PATCH v2 1/1 cppunit: Added package
Hi Sebastien,
Thank you for your contribution. I still have a few more comments.
Quoted 6 lines · Sebastien Bourdelin
CppUnit is the C++ port of the famous JUnit framework for unit testing. Test output is in XML or text format for automatic testing and GUI based for supervised tests.
http://www.freedesktop.org/wiki/Software/cppunit/
Signed-off-by Sebastien Bourdelin <[email protected]>
We normally leave an empty line between the commit message itself and the SOB.
Quoted 48 lines
---
Changes v1 -> v2:
- used AUTORECONF option (suggested by romain.naour at openwide.fr)
- removed uselessCONFIGURE_CMDS(suggested by romain.naour at openwide.fr)--- package/Config.in | 1 + package/cppunit/Config.in | 12 ++++++++++++ package/cppunit/cppunit.mk | 14 ++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 package/cppunit/Config.in create mode 100644 package/cppunit/cppunit.mkpackage/Config.in +1
-0@@ -838,6 +838,7 @@ menu "Other" source "package/clapack/Config.in" source "package/classpath/Config.in" source "package/cppcms/Config.in" + source "package/cppunit/Config.in" source "package/eigen/Config.in" source "package/elfutils/Config.in" source "package/fftw/Config.in"package/cppunit/Config.in new file +12
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_CPPUNIT + bool "cppunit" + depends on BR2_INSTALL_LIBSTDCPP + help + CppUnit is the C++ port of the famous JUnit framework for unit testing. + Test output is in XML or text format for automatic testing and GUI + based for supervised tests. + + http://www.freedesktop.org/wiki/Software/cppunit/ + +comment "cppunit needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPPpackage/cppunit/cppunit.mk new file +0
-0
package/cppunit/cppunit.mk line 8
Quoted 8 lines
package/cppunit/cppunit.mk new file +8
-0@@ -0,0 +1,14 @@ +################################################################################ +# +# cppunit +# +################################################################################ + +CPPUNIT_VERSION = cppunit-1.13.2 +CPPUNIT_SITE = git://anongit.freedesktop.org/git/libreoffice/cppunit/
We prefer to use the release tarball:
CPPUNIT_VERSION = 1.13.2CPPUNIT_SITE = http://dev-www.libreoffice.org/src
If that doesn't work for some reason, please add a comment why not.
Also, it would be nice if you could add a hash file with the upstream md5 and
with a locally calculated sha256 or sha512. The hash file is optional, but if upstream provides an md5 it's nice to have it.
package/cppunit/cppunit.mk line 9
Quoted 1 line
package/cppunit/cppunit.mk new file +1
-0+CPPUNIT_INSTALL_STAGING = YES
I'm writing this mail while offline so I can't check myself, but IIRC cppunit
only installs a static library (.a). Therefore, there is nothing to install in the target directory so you could add
# Static library onlyCPPUNIT_INSTALL_TARGET = NO
Note that this is completely optional, though, because we anyway remove all .a
files in the finalize step.
package/cppunit/cppunit.mk line 10
Quoted 1 line
package/cppunit/cppunit.mk new file +1
-0+CPPUNIT_LICENSE = GPLv2
Is it really v2 only and not v2+? To check that, look at the source files, in
the header they usually have something like "blah blah version 2 (or later)".
package/cppunit/cppunit.mk line 12
Quoted 2 lines
package/cppunit/cppunit.mk new file +2
-0+CPPUNIT_LICENSE_FILES = COPYING +CPPUNIT_AUTORECONF = YES
With the release tarball, you probably don't need that.
Regards,
Arnout
Quoted 3 lines
package/cppunit/cppunit.mk new file +2
-0+ +$(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH v2 1/1 cppunit: Added package
Hi Arnout,
Thank you for your review.
Quoted 4 lines · Arnout Vandecappelle
Hi Sebastien,
Thank you for your contribution. I still have a few more comments.
Quoted 8 lines
Quoted 6 lines · Sebastien Bourdelin
CppUnit is the C++ port of the famous JUnit framework for unit testing. Test output is in XML or text format for automatic testing and GUI based for supervised tests.
http://www.freedesktop.org/wiki/Software/cppunit/
Signed-off-by Sebastien Bourdelin <[email protected]>We normally leave an empty line between the commit message itself and the SOB.
My bad.
Quoted 59 lines
Quoted 49 lines
---
Changes v1 -> v2:
- used AUTORECONF option (suggested by romain.naour at openwide.fr)
- removed uselessCONFIGURE_CMDS(suggested by romain.naour at openwide.fr)--- package/Config.in | 1 + package/cppunit/Config.in | 12 ++++++++++++ package/cppunit/cppunit.mk | 14 ++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 package/cppunit/Config.in create mode 100644 package/cppunit/cppunit.mkpackage/Config.in +1
-0@@ -838,6 +838,7 @@ menu "Other" source "package/clapack/Config.in" source "package/classpath/Config.in" source "package/cppcms/Config.in" + source "package/cppunit/Config.in" source "package/eigen/Config.in" source "package/elfutils/Config.in" source "package/fftw/Config.in"package/cppunit/Config.in new file +12
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_CPPUNIT + bool "cppunit" + depends on BR2_INSTALL_LIBSTDCPP + help + CppUnit is the C++ port of the famous JUnit framework for unit testing. + Test output is in XML or text format for automatic testing and GUI + based for supervised tests. + + http://www.freedesktop.org/wiki/Software/cppunit/ + +comment "cppunit needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPPpackage/cppunit/cppunit.mk new file +0
-0package/cppunit/cppunit.mk line 8
Quoted 8 lines
package/cppunit/cppunit.mk new file +8
-0@@ -0,0 +1,14 @@ +################################################################################ +# +# cppunit +# +################################################################################ + +CPPUNIT_VERSION = cppunit-1.13.2 +CPPUNIT_SITE = git://anongit.freedesktop.org/git/libreoffice/cppunit/We prefer to use the release tarball:
Quoted 8 lines
CPPUNIT_VERSION= 1.13.2CPPUNIT_SITE= http://dev-www.libreoffice.org/srcIf that doesn't work for some reason, please add a comment why not.
Also, it would be nice if you could add a hash file with the upstream md5 and
with a locally calculated sha256 or sha512. The hash file is optional, but if upstream provides an md5 it's nice to have it.
Ok, i will do that.
Quoted 11 lines
package/cppunit/cppunit.mk line 9
Quoted 2 lines
package/cppunit/cppunit.mk new file +1
-0+CPPUNIT_INSTALL_STAGING = YESI'm writing this mail while offline so I can't check myself, but IIRC cppunit
only installs a static library (.a). Therefore, there is nothing to install in the target directory so you could add# Static library only
CPPUNIT_INSTALL_TARGET= NONote that this is completely optional, though, because we anyway remove all .a
files in the finalize step.
cppunit also install shared library (.so)
Quoted 4 lines
package/cppunit/cppunit.mk line 10
Quoted 2 lines
package/cppunit/cppunit.mk new file +1
-0+CPPUNIT_LICENSE = GPLv2Is it really v2 only and not v2+? To check that, look at the source files, in
the header they usually have something like "blah blah version 2 (or later)".
You are right, the correct licence is LGPLv2.1+
Quoted 3 lines
package/cppunit/cppunit.mk line 12
Quoted 2 lines
package/cppunit/cppunit.mk new file +2
-0+CPPUNIT_LICENSE_FILES = COPYING +CPPUNIT_AUTORECONF = YESWith the release tarball, you probably don't need that.
Right.
Quoted 4 lines
Regards,
Arnout
Thanks Arnout, i will send a v3.
Regards.
Sebastien Bourdelin.
Quoted 4 lines
Quoted 3 lines
package/cppunit/cppunit.mk new file +2
-0+ +$(eval $(autotools-package))