Skip to contentSkip to conversation

Btrfs corruption fix

GIT PULL Chris Mason 1 participant 2 messages Oct 16, 2014 – Oct 17, 2014 Btrfs file system

lore
Share & tools
lore
#0 lore raw

Hi Linus,

I'm testing a pull with more fixes, but wanted to get this one out so Greg can pick it up. The corruption isn't easy to hit, you have to do a readonly snapshot and have orphans in the snapshot. But my review and testing missed the bug. Filipe has added a better xfstest to cover it.

Please pull:

git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus

Chris Mason (1) commits (+33/-36):
Revert "Btrfs: race free update of commit root for ro snapshots"

Total: (1) commits (+33/-36)

 fs/btrfs/inode.c | 36 ------------------------------------
 fs/btrfs/ioctl.c | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+), 36 deletions(-)
#1 lore raw
Quoted 10 lines · Chris Mason

Hi Linus,

I'm testing a pull with more fixes, but wanted to get this one out so Greg can pick it up. The corruption isn't easy to hit, you have to do a readonly snapshot and have orphans in the snapshot. But my review and testing missed the bug. Filipe has added a better xfstest to cover it.

Please pull:

git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus

Sorry Linus, I realized this morning I forgot my sob. I've pushed out an updated commit to a new for-linus-update branch. The code and diffstat are exactly the same:

git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-update

Quoted 10 lines

Chris Mason (1) commits (+33/-36):
Revert "Btrfs: race free update of commit root for ro snapshots"

Total: (1) commits (+33/-36)

 fs/btrfs/inode.c | 36 ------------------------------------
 fs/btrfs/ioctl.c | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+), 36 deletions(-)

-chris