Skip to contentSkip to conversation

Implement copy offload support

PATCH Christoph Hellwig 3 participants 4 messages Jun 4, 2024 – Jun 5, 2024

Subsystems (5)
lore
Share & tools
lore

Christoph Hellwig

author maintainer
#0 lore raw
Quoted 9 lines · Nitesh Shetty

The major benefit of this copy-offload/emulation framework is observed in fabrics setup, for copy workloads across the network. The host will send offload command over the network and actual copy can be achieved using emulation on the target (hence patch 4). This results in higher performance and lower network consumption, as compared to read and write travelling across the network. With this design of copy-offload/emulation we are able to see the following improvements as compared to userspace read + write on a NVMeOF TCP setup:

What is the use case of this? What workloads does raw copies a lot
of data inside a single block device?

#1 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 9 lines · Nitesh Shetty

The major benefit of this copy-offload/emulation framework is observed in fabrics setup, for copy workloads across the network. The host will send offload command over the network and actual copy can be achieved using emulation on the target (hence patch 4). This results in higher performance and lower network consumption, as compared to read and write travelling across the network. With this design of copy-offload/emulation we are able to see the following improvements as compared to userspace read + write on a NVMeOF TCP setup:

Quoted 3 lines

What is the use case of this? What workloads does raw copies a lot
of data inside a single block device?

The canonical example would be VM provisioning from a master copy.
That's not within a single block device, mind; that's more for copying the contents of one device to another. But I wasn't aware that this approach is limited to copying within a single block devices; that would be quite pointless indeed.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
#2 lore raw
Quoted 12 lines · Hannes Reinecke
Quoted 11 lines · Christoph Hellwig
Quoted 9 lines · Nitesh Shetty

The major benefit of this copy-offload/emulation framework is observed in fabrics setup, for copy workloads across the network. The host will send offload command over the network and actual copy can be achieved using emulation on the target (hence patch 4). This results in higher performance and lower network consumption, as compared to read and write travelling across the network. With this design of copy-offload/emulation we are able to see the following improvements as compared to userspace read + write on a NVMeOF TCP setup:

Quoted 7 lines
Quoted 3 lines

What is the use case of this? What workloads does raw copies a lot
of data inside a single block device?

The canonical example would be VM provisioning from a master copy. That's not within a single block device, mind; that's more for copying the contents of one device to another.

Wouldn't such use case more likely to use file copy ?
I have not heard a lot of cases where VM images occupy an entire block device, but I may be mistaken here...

Quoted 2 lines

But I wasn't aware that this approach is limited to copying within a single block devices; that would be quite pointless indeed.

Not pointless for any FS doing CoW+Rebalancing of block groups (e.g. btrfs) and of course GC for FSes on zoned devices. But for this use case, an API allowing multiple sources and one destination would be better.

Signature · 2 lines
Damien Le Moal
Western Digital Research
author maintainer
#3 lore raw
Quoted 6 lines · Damien Le Moal
Quoted 2 lines

But I wasn't aware that this approach is limited to copying within a single block devices; that would be quite pointless indeed.

Not pointless for any FS doing CoW+Rebalancing of block groups (e.g. btrfs) and of course GC for FSes on zoned devices. But for this use case, an API allowing multiple sources and one destination would be better.

Yes.