Skip to contentSkip to conversation

mp4v2: new package

PATCH Superseded Jörg Krause 2 participants 3 messages Oct 16, 2014 – Oct 20, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 mp4v2: new package

Signed-off-by J?rg Krause <[email protected]>
---
 package/Config.in        |  1 +
 package/mp4v2/Config.in  | 20 ++++++++++++++++++++
 package/mp4v2/mp4v2.hash |  2 ++
 package/mp4v2/mp4v2.mk   | 19 +++++++++++++++++++
 4 files changed, 42 insertions(+)
 create mode 100644 package/mp4v2/Config.in
 create mode 100644 package/mp4v2/mp4v2.hash
 create mode 100644 package/mp4v2/mp4v2.mk
package/Config.in +1 -0
index 19bb9bf..819eaad 100644
@@ -553,6 +553,7 @@ menu "Audio/Sound"
 	source "package/libsndfile/Config.in"
 	source "package/libsoxr/Config.in"
 	source "package/libvorbis/Config.in"
+	source "package/mp4v2/Config.in"
 	source "package/opencore-amr/Config.in"
 	source "package/opus/Config.in"
 	source "package/portaudio/Config.in"
package/mp4v2/Config.in new file +20 -0
new file mode 100644
index 0000000..bd0ddda
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_MP4V2
+	bool "mp4v2"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  The MP4v2 library provides functions to read, create, and modify mp4 files.
+
+	  https://code.google.com/p/mp4v2/
+
+if BR2_PACKAGE_MP4V2
+
+config BR2_PACKAGE_MP4V2_UTIL
+	bool "Install mp4 command line tools"
+	help
+	  Enable to install the mp4 command line tools mp4art, mp4chaps, mp4extract,
+	  mp4info, mp4subtitle, mp4tags, and mp4trackdump.
+
+endif
+
+comment "mp4v2 needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/mp4v2/mp4v2.hash new file +2 -0
new file mode 100644
index 0000000..d5a49c4
@@ -0,0 +1,2 @@
+# From https://code.google.com/p/mp4v2/downloads/detail?name=mp4v2-2.0.0.tar.bz2
+sha1 193260cfb7201e6ec250137bcca1468d4d20e2f0 mp4v2-2.0.0.tar.bz2
package/mp4v2/mp4v2.mk new file +19 -0
new file mode 100644
index 0000000..b1f1740
@@ -0,0 +1,19 @@
+################################################################################
+#
+# mp4v2
+#
+################################################################################
+
+MP4V2_VERSION = 2.0.0
+MP4V2_SOURCE = mp4v2-$(MP4V2_VERSION).tar.bz2
+MP4V2_SITE = https://mp4v2.googlecode.com/files
+MP4V2_INSTALL_STAGING = YES
+MP4V2_LICENSE = MPLv1.1
+MP4V2_LICENSE_FILES = COPYING
+MP4V2_CONF_OPTS = --disable-debug
+
+ifneq ($(BR2_PACKAGE_MP4V2_UTIL),y)
+MP4V2_CONF_OPTS += --disable-util
+endif
+
+$(eval $(autotools-package))
Signature · 1 line
2.1.2
#1 lore raw

PATCH 1/1 mp4v2: new package

J?rg, All,

On 2014-10-16 09:43 +0200, J?rg Krause spake thusly:

package/mp4v2/Config.in line 5

Quoted 12 lines
Signed-off-by J?rg Krause <[email protected]>
package/mp4v2/Config.in new file +5 -0
new file mode 100644
index 0000000..bd0ddda
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_MP4V2
+	bool "mp4v2"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  The MP4v2 library provides functions to read, create, and modify mp4 files.

Keep the line below the 80-char limit, please.

package/mp4v2/Config.in line 14

Quoted 9 lines
package/mp4v2/Config.in new file +9 -0
+
+	  https://code.google.com/p/mp4v2/
+
+if BR2_PACKAGE_MP4V2
+
+config BR2_PACKAGE_MP4V2_UTIL
+	bool "Install mp4 command line tools"
+	help
+	  Enable to install the mp4 command line tools mp4art, mp4chaps, mp4extract,

Ditto.

Quoted 23 lines
package/mp4v2/Config.in new file +6 -0
+	  mp4info, mp4subtitle, mp4tags, and mp4trackdump.
+
+endif
+
+comment "mp4v2 needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/mp4v2/mp4v2.hash new file +2 -0
new file mode 100644
index 0000000..d5a49c4
@@ -0,0 +1,2 @@
+# From https://code.google.com/p/mp4v2/downloads/detail?name=mp4v2-2.0.0.tar.bz2
+sha1 193260cfb7201e6ec250137bcca1468d4d20e2f0 mp4v2-2.0.0.tar.bz2
package/mp4v2/mp4v2.mk new file +3 -0
new file mode 100644
index 0000000..b1f1740
@@ -0,0 +1,19 @@
+################################################################################
+#
+# mp4v2

package/mp4v2/mp4v2.mk line 13

Quoted 10 lines
package/mp4v2/mp4v2.mk new file +10 -0
+#
+################################################################################
+
+MP4V2_VERSION = 2.0.0
+MP4V2_SOURCE = mp4v2-$(MP4V2_VERSION).tar.bz2
+MP4V2_SITE = https://mp4v2.googlecode.com/files
+MP4V2_INSTALL_STAGING = YES
+MP4V2_LICENSE = MPLv1.1
+MP4V2_LICENSE_FILES = COPYING
+MP4V2_CONF_OPTS = --disable-debug

This will soone to be removed, as the pkg-autotools infrastructure will soon be responsible for providing this.

package/mp4v2/mp4v2.mk line 17

Quoted 4 lines
package/mp4v2/mp4v2.mk new file +4 -0
+
+ifneq ($(BR2_PACKAGE_MP4V2_UTIL),y)
+MP4V2_CONF_OPTS += --disable-util
+endif

We prefer using positive logic, and have the pending enable/disable flags passed:

    ifeq ($(BR2_PACKAGE_MP4V2_UTIL),y)
    MP4V2_CONF_OPTS += --enable-util
    else
    MP4V2_CONF_OPTS += --disable-util
    endif

Regards,
Yann E. MORIN.

Quoted 8 lines
package/mp4v2/mp4v2.mk new file +1 -0
+$(eval $(autotools-package))
Signature · 6 lines
2.1.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#2 lore raw

PATCH 1/1 mp4v2: new package

Hi Yann,

Quoted 17 lines · Yann E. MORIN

J?rg, All,

On 2014-10-16 09:43 +0200, J?rg Krause spake thusly:

package/mp4v2/Config.in line 5

Quoted 12 lines
Signed-off-by J?rg Krause <[email protected]>
package/mp4v2/Config.in new file +5 -0
new file mode 100644
index 0000000..bd0ddda
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_MP4V2
+	bool "mp4v2"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  The MP4v2 library provides functions to read, create, and modify mp4 files.

Keep the line below the 80-char limit, please.

I see! I guess the (default?) tab width for KConfig is 8 chars. I didn't find a definition for it. My editors tab width is 2 chars by default...

Quoted 27 lines
Quoted 27 lines
package/mp4v2/Config.in new file +6 -0
+	  mp4info, mp4subtitle, mp4tags, and mp4trackdump.
+
+endif
+
+comment "mp4v2 needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/mp4v2/mp4v2.hash new file +2 -0
new file mode 100644
index 0000000..d5a49c4
@@ -0,0 +1,2 @@
+# From https://code.google.com/p/mp4v2/downloads/detail?name=mp4v2-2.0.0.tar.bz2
+sha1 193260cfb7201e6ec250137bcca1468d4d20e2f0 mp4v2-2.0.0.tar.bz2
package/mp4v2/mp4v2.mk new file +7 -0
new file mode 100644
index 0000000..b1f1740
@@ -0,0 +1,19 @@
+################################################################################
+#
+# mp4v2
+#
+################################################################################
+
+MP4V2_VERSION = 2.0.0
Quoted 8 lines

package/mp4v2/mp4v2.mk line 13

Quoted 6 lines
package/mp4v2/mp4v2.mk new file +6 -0
+MP4V2_SOURCE = mp4v2-$(MP4V2_VERSION).tar.bz2
+MP4V2_SITE = https://mp4v2.googlecode.com/files
+MP4V2_INSTALL_STAGING = YES
+MP4V2_LICENSE = MPLv1.1
+MP4V2_LICENSE_FILES = COPYING
+MP4V2_CONF_OPTS = --disable-debug

This will soone to be removed, as the pkg-autotools infrastructure will soon be responsible for providing this.

I see! So I can remove this here.

Quoted 8 lines

package/mp4v2/mp4v2.mk line 17

Quoted 5 lines
package/mp4v2/mp4v2.mk new file +4 -0
+
+ifneq ($(BR2_PACKAGE_MP4V2_UTIL),y)
+MP4V2_CONF_OPTS += --disable-util
+endif

We prefer using positive logic, and have the pending enable/disable flags passed:

Quoted 5 lines
     ifeq ($(BR2_PACKAGE_MP4V2_UTIL),y)
     MP4V2_CONF_OPTS += --enable-util
     else
     MP4V2_CONF_OPTS += --disable-util
     endif

Looks good!

Many thanks for the review!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141020/60ee7ae6/attachment.html>